Page MenuHomeFreeBSD

dev/mfi: Make a seemingly bogus conditional unconditional

Authored by jhibbits on Dec 8 2020, 6:29 PM.



r358689 attempted to fix a clang warning/error by inferring the intent
of the condition "(cdb[0] != 0x28 || cdb[0] != 0x2A)". Unfortunately, it looks
like this broke things. Instead, fix this by making this path unconditional,
effectively reverting to the previous state.

Diff Detail

rS FreeBSD src repository - subversion
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Looks good to me :-) We should never hit this code and I had never hit it before. Per the bug report this came from LSI/Avago/Broadcom via their Thunderbolt driver update before mrsas. I never understood what the issue was and never implemented the else part. This is to deal with physical disks attached to the RAID versus a volume. I put the DJA XXX so if we ever hit it we might be able to figure it out. Never hit it in real use but rarely used syspd mode.

This revision is now accepted and ready to land.Dec 8 2020, 7:17 PM