Page MenuHomeFreeBSD

dev/mfi: Make a seemingly bogus conditional unconditional
ClosedPublic

Authored by jhibbits on Dec 8 2020, 6:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Aug 21 2023, 9:50 PM
Unknown Object (File)
Aug 17 2023, 5:53 PM
Unknown Object (File)
Aug 10 2023, 12:11 PM
Unknown Object (File)
Aug 7 2023, 10:03 AM
Unknown Object (File)
Aug 7 2023, 9:57 AM
Unknown Object (File)
Aug 7 2023, 9:55 AM
Unknown Object (File)
Jun 24 2023, 6:38 AM
Unknown Object (File)
Jun 12 2023, 12:40 PM
Subscribers

Details

Summary

r358689 attempted to fix a clang warning/error by inferring the intent
of the condition "(cdb[0] != 0x28 || cdb[0] != 0x2A)". Unfortunately, it looks
like this broke things. Instead, fix this by making this path unconditional,
effectively reverting to the previous state.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35261
Build 32199: arc lint + arc unit

Event Timeline

Looks good to me :-) We should never hit this code and I had never hit it before. Per the bug report this came from LSI/Avago/Broadcom via their Thunderbolt driver update before mrsas. I never understood what the issue was and never implemented the else part. This is to deal with physical disks attached to the RAID versus a volume. I put the DJA XXX so if we ever hit it we might be able to figure it out. Never hit it in real use but rarely used syspd mode.

This revision is now accepted and ready to land.Dec 8 2020, 7:17 PM