misc minor fixes in mpr(4)
ClosedPublic
Actions

Authored by asomers on Dec 21 2016, 10:57 PM.

Details

Reviewers

ken
slm

Commits

rS311160: misc minor fixes in mpr(4)

Summary

misc minor fixes in mpr(4)

sys/dev/mpr/mpr_sas.c

Fix a potential null pointer dereference (CID 1305731)
Check for overrun of the ccb_scsiio.cdb_io.cdb_bytes buffer (CID 1211934)

sys/dev/mpr/mpr_sas_lsi.c

Nullify a dangling pointer in mprsas_get_sata_identify
Fix a memory leak in mprsas_SSU_to_SATA_devices (CID 1211935)

Test Plan

Run ZFS I/O to SATA devices connected to an mpr(4) controller

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers updated this revision to Diff 23184.Dec 21 2016, 10:57 PM

asomers retitled this revision from to misc minor fixes in mpr(4).

asomers updated this object.

asomers edited the test plan for this revision. (Show Details)

asomers added reviewers: slm, ken.

Herald edited edge metadata. · View Herald TranscriptDec 21 2016, 10:57 PM

Herald added a subscriber: imp. · View Herald Transcript

Looks good to me. Thanks!

This revision is now accepted and ready to land.Jan 3 2017, 5:28 PM

Closed by commit rS311160: misc minor fixes in mpr(4) (authored by asomers). · Explain WhyJan 3 2017, 5:35 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

mpr/

mpr_sas.c

7 lines

mpr_sas_lsi.c

15 lines

Diff 23579

View Options

head/sys/dev/mpr/mpr_sas.c