Page MenuHomeFreeBSD
Differential D8880

misc minor fixes in mpr(4)
ClosedPublic
Actions

Authored by asomers on Dec 21 2016, 10:57 PM.
Tags
None
Referenced Files
F161134031: D8880.diff
Tue, Jun 30, 8:37 PM
Unknown Object (File)
Mon, Jun 29, 10:44 AM
Unknown Object (File)
Sat, Jun 27, 12:15 PM
Unknown Object (File)
Wed, Jun 17, 11:12 PM
Unknown Object (File)
Sun, Jun 7, 6:10 AM
Unknown Object (File)
May 31 2026, 6:35 AM
Unknown Object (File)
May 26 2026, 8:44 PM
Unknown Object (File)
May 17 2026, 1:21 PM
View All Files
Subscribers
imp

Details

Reviewers
ken
slm
Commits
rS311160: misc minor fixes in mpr(4)
Summary

misc minor fixes in mpr(4)

sys/dev/mpr/mpr_sas.c

  • Fix a potential null pointer dereference (CID 1305731)
  • Check for overrun of the ccb_scsiio.cdb_io.cdb_bytes buffer (CID 1211934)

sys/dev/mpr/mpr_sas_lsi.c

  • Nullify a dangling pointer in mprsas_get_sata_identify
  • Fix a memory leak in mprsas_SSU_to_SATA_devices (CID 1211935)
Test Plan

Run ZFS I/O to SATA devices connected to an mpr(4) controller

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6347
Build 6586: arc lint + arc unit

Event Timeline

asomers updated this revision to Diff 23184.Dec 21 2016, 10:57 PM
asomers retitled this revision from to misc minor fixes in mpr(4).
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added reviewers: slm, ken.
Herald edited edge metadata. · View Herald TranscriptDec 21 2016, 10:57 PM
Herald added a subscriber: imp. · View Herald Transcript
slm accepted this revision.Jan 3 2017, 5:28 PM
slm edited edge metadata.

Looks good to me. Thanks!

This revision is now accepted and ready to land.Jan 3 2017, 5:28 PM
Closed by commit rS311160: misc minor fixes in mpr(4) (authored by asomers). · Explain WhyJan 3 2017, 5:35 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
dev/
mpr/
7 lines
15 lines

Diff 23184

View Options

sys/dev/mpr/mpr_sas.c

Loading...
View Options

sys/dev/mpr/mpr_sas_lsi.c

Loading...