Several style changes and add copyrights for 2016.
Details
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
sys/dev/mpr/mpr.c | ||
---|---|---|
4 ↗ | (On Diff #15607) | Is this technically now Broadcom? |
All of these changes look good to me. However, there are many other style bugs that aren't fixed by this CR (and needn't necessarily be). For example, there are 250 lines with trailing whitespace in sys/dev/mpr. I wrote a tool that can find many style(9) violations. I've also heard that uncrustify does well using this freebsd.cfg file. But I haven't tried it myself.
https://people.freebsd.org/~asomers/style9/
https://github.com/freebsd/pkg/blob/master/freebsd.cfg
sys/dev/mpr/mpr_user.c | ||
---|---|---|
227 ↗ | (On Diff #15607) | You should probably leave the blank line here and at lines 236 and 243. style(9) is to leave an empty line at the top of a function with no local variables. |
sys/dev/mpr/mpr.c | ||
---|---|---|
4 ↗ | (On Diff #15607) | We've been told not to change our copyrights to Broadcom yet, even though I do use 'Broadcom' in the man page change, but I don't think that's a big deal. |
sys/dev/mpr/mpr_user.c | ||
227 ↗ | (On Diff #15607) | OK. I don't like that space as the first line. It looks bad to my eye, but if it's in the rules, that what I should do. I'll change it back. Yes, I'm sure there are still lots of style changes to make. I'll keep working on them as changes are made. Thanks for the pointers. |