Page MenuHomeFreeBSD

Fix mpr(4) panics caused by bad drive mapping tables
ClosedPublic

Authored by asomers on Nov 1 2017, 10:00 PM.

Details

Summary

Fix mpr(4) panics caused by bad drive mapping tables

sys/dev/mpr/mpr_mapping.c
If _mapping_process_dpm_pg0 detects inconsistencies in the drive
mapping table (stored in the HBA's NVRAM), abort reading it and
continue to boot as if the mapping table were blank.

Test Plan

Try booting with an mpr card that contains a known-bad mapping table

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

asomers created this revision.Nov 1 2017, 10:00 PM
slm requested changes to this revision.Nov 1 2017, 10:26 PM
slm added inline comments.
sys/dev/mpr/mpr_mapping.c
2382 ↗(On Diff #34643)

Doesn't look like you need 'dpm_entry' here.

This revision now requires changes to proceed.Nov 1 2017, 10:26 PM
asomers updated this revision to Diff 34647.Nov 1 2017, 11:05 PM

Fix copypaste error found by slm

slm accepted this revision.Nov 2 2017, 2:55 PM
This revision is now accepted and ready to land.Nov 2 2017, 2:55 PM
This revision was automatically updated to reflect the committed changes.