In D21473#475370, @emaste wrote:

In D21473#473720, @grembo wrote:

That was actually what I called it at first (showconfig or dumpconfig), but then I realized that commands provided by freebsd-update prefer brevity over clarity (e.g. cron actually fetches updates from cron, upgrade fetches upgrades, but doesn't install them, IDS has no verb at all).

Ah, fair enough. Was going to say I'm fine with leaving at as config then, but since you've already changed it let's go with showconfig.

Rebase to rS352542, rename config' to showconfig', update man page date.

In D21473#473711, @emaste wrote:

I'm happy with the config part so far, but probably use showconfig.
I haven't yet reviewed the updatesready.

Change function name to make more sense.

In D21579#473694, @emaste wrote:

Fine with me, although I'd prefer a different name for config_Components_src. This is not directly used for the config file as other config_-prefixed functions are. Maybe something like filter_components?

Remove "Fix src component detection" part from this review, as it moved to a separate one (D21579)

Fix style issues.

Assuming this builds correctly in poudriere (didn't test myself). Thanks!

In D19920#432741, @mat wrote:

In D19920#432640, @mat wrote:

Could you please not rename the port so that pkg upgrade keeps on working.

Mmm, I just saw that the SLAVE_PKGNAMESUFFIX was only set in the "lib" case.

In D14103#431924, @seanc wrote:

Can someone summarize what's preventing this patch from being committed?

In D19920#428152, @crees wrote:

Yeah, I wondered what would happen about the php flavours :(
I'll look into the meta port idea, seems a good one! Or perhaps just a slave? They'll have the same effect.

I like the idea of this - unfortunately this approach kills the existing flavours:

Tested again, new version also works as expected, mptramp_pagetables is 0x7bf77000 on c720

Accepting to confirm that I tested this patch one more time against r338318 on the Acer Chromebook c720 (previous test was against an older version of the kernel). Obviously my feedback isn't sufficient and this still requires review by the original reviewers (aka experts).

@kib Updated by tree to r334733 and applied the patch, it's working as expected, thanks!

Fix typo and extra whitespace

In D14103#300013, @emaste wrote:

Testing with this change on X260 (LEN0068, MHKV 0x0200 AFAICT) I see warnings like:

# sysctl dev.acpi_ibm.0.kbd_backlight=0
ACPI Warning: \_SB.PCI0.LPC.EC.HKEY.MLCG: Insufficient arguments - Caller passed 0, method requires 1 (20180209/nsarguments-383)
ACPI Warning: \_SB.PCI0.LPC.EC.HKEY.MLCG: Insufficient arguments - Caller passed 0, method requires 1 (20180209/nsarguments-383)
dev.acpi_ibm.0.kbd_backlight: 1ACPI Warning: \_SB.PCI0.LPC.EC.HKEY.MLCG: Insufficient arguments - Caller passed 0, method requires 1 (20180209/nsarguments-383)
 -> ACPI Warning: \_SB.PCI0.LPC.EC.HKEY.MLCG: Insufficient arguments - Caller passed 0, method requires 1 (20180209/nsarguments-383)
ACPI Warning: \_SB.PCI0.LPC.EC.HKEY.MLCG: Insufficient arguments - Caller passed 0, method requires 1 (20180209/nsarguments-383)
0
#

Keyboard backlight control works despite the warnings. I haven't tested this machine on an unpatched kernel. echo 1 > /dev/led/micmute has no effect.