grembo (Michael Gmelin)
User

Projects

User Details

User Since
May 16 2014, 11:25 AM (213 w, 6 d)

Recent Activity

Wed, Jun 6

grembo accepted D15675: Account for dmap limit when selecting the pages for the bootstrap pagetables..
Wed, Jun 6, 11:10 PM
grembo added a comment to D15675: Account for dmap limit when selecting the pages for the bootstrap pagetables..

@kib Updated by tree to r334733 and applied the patch, it's working as expected, thanks!

Wed, Jun 6, 11:09 PM

Apr 20 2018

grembo committed rP467838: Upgrade devel/libphutil, devel/arcanist and devel/phabricator to 20180420.
Upgrade devel/libphutil, devel/arcanist and devel/phabricator to 20180420
Apr 20 2018, 8:06 PM

Feb 11 2018

grembo updated the diff for D14103: Support post-2015 Lenovo models in acpi_ibm / support keyboard backlight (also led(4)) / support micmute led(4).

Fix typo and extra whitespace

Feb 11 2018, 11:35 AM
grembo added a comment to D14103: Support post-2015 Lenovo models in acpi_ibm / support keyboard backlight (also led(4)) / support micmute led(4).

Testing with this change on X260 (LEN0068, MHKV 0x0200 AFAICT) I see warnings like:

# sysctl dev.acpi_ibm.0.kbd_backlight=0
ACPI Warning: \_SB.PCI0.LPC.EC.HKEY.MLCG: Insufficient arguments - Caller passed 0, method requires 1 (20180209/nsarguments-383)
ACPI Warning: \_SB.PCI0.LPC.EC.HKEY.MLCG: Insufficient arguments - Caller passed 0, method requires 1 (20180209/nsarguments-383)
dev.acpi_ibm.0.kbd_backlight: 1ACPI Warning: \_SB.PCI0.LPC.EC.HKEY.MLCG: Insufficient arguments - Caller passed 0, method requires 1 (20180209/nsarguments-383)
 -> ACPI Warning: \_SB.PCI0.LPC.EC.HKEY.MLCG: Insufficient arguments - Caller passed 0, method requires 1 (20180209/nsarguments-383)
ACPI Warning: \_SB.PCI0.LPC.EC.HKEY.MLCG: Insufficient arguments - Caller passed 0, method requires 1 (20180209/nsarguments-383)
0
#

Keyboard backlight control works despite the warnings. I haven't tested this machine on an unpatched kernel. echo 1 > /dev/led/micmute has no effect.

Feb 11 2018, 11:31 AM

Feb 9 2018

grembo updated the test plan for D14103: Support post-2015 Lenovo models in acpi_ibm / support keyboard backlight (also led(4)) / support micmute led(4).
Feb 9 2018, 11:23 AM
grembo retitled D14103: Support post-2015 Lenovo models in acpi_ibm / support keyboard backlight (also led(4)) / support micmute led(4) from Support post-2015 Lenovo models in acpi_ibm / support keyboard backlight (also led(4)) to Support post-2015 Lenovo models in acpi_ibm / support keyboard backlight (also led(4)) / support micmute led(4).
Feb 9 2018, 11:23 AM
grembo updated the diff for D14103: Support post-2015 Lenovo models in acpi_ibm / support keyboard backlight (also led(4)) / support micmute led(4).

Add support for controlling micmute LED

Feb 9 2018, 11:21 AM

Feb 2 2018

grembo added a reviewer for D14103: Support post-2015 Lenovo models in acpi_ibm / support keyboard backlight (also led(4)) / support micmute led(4): junchoon_dec.sakura.ne.jp.
Feb 2 2018, 11:41 AM
grembo added a comment to D14103: Support post-2015 Lenovo models in acpi_ibm / support keyboard backlight (also led(4)) / support micmute led(4).

Please note that man page changes are pending, but will be added to the review before committing any changes.

Feb 2 2018, 11:40 AM

Jan 30 2018

grembo retitled D14103: Support post-2015 Lenovo models in acpi_ibm / support keyboard backlight (also led(4)) / support micmute led(4) from Support post-2015 Lenovo models in acpi_ibm to Support post-2015 Lenovo models in acpi_ibm / support keyboard backlight (also led(4)).
Jan 30 2018, 1:25 AM
grembo updated the diff for D14103: Support post-2015 Lenovo models in acpi_ibm / support keyboard backlight (also led(4)) / support micmute led(4).

Add support for controlling the keyboard backlight found in newer lenovo models.

Jan 30 2018, 1:22 AM

Jan 29 2018

grembo accepted D13745: Update to buildbot 0.9.15.
Jan 29 2018, 11:52 AM
grembo added a comment to D13745: Update to buildbot 0.9.15.

@rodrigc I think this can be closed.

Jan 29 2018, 11:52 AM
grembo created D14103: Support post-2015 Lenovo models in acpi_ibm / support keyboard backlight (also led(4)) / support micmute led(4).
Jan 29 2018, 2:22 AM

Jan 25 2018

grembo committed rP459949: MFH: r459808.
MFH: r459808
Jan 25 2018, 3:47 PM

Jan 24 2018

grembo committed rP459808: Fix databases/mariadb* hostname verification when building against LibreSSL.
Fix databases/mariadb* hostname verification when building against LibreSSL
Jan 24 2018, 1:03 AM

Jan 22 2018

grembo committed rP459707: Update devel/ice, devel/py-ice, devel/php5-ice to version 3.6.4.
Update devel/ice, devel/py-ice, devel/php5-ice to version 3.6.4
Jan 22 2018, 11:06 PM

Sep 24 2017

grembo accepted D12479: devel/buildbot*: Update to 0.9.11, Add.

@koobs Just glanced at it, trusting your judgement.

Sep 24 2017, 11:28 AM

Sep 7 2017

grembo committed rP449413: Fixed IceGrid node bug where a replica might not get up-to-date object.
Fixed IceGrid node bug where a replica might not get up-to-date object
Sep 7 2017, 6:28 PM

Sep 4 2017

grembo committed rP449242: - Remove pkg-install.in which stopped heartbeat on.
- Remove pkg-install.in which stopped heartbeat on
Sep 4 2017, 11:47 AM

Sep 1 2017

grembo added a comment to D12196: graphics/intel-backlight: support newer GPUs and propose to take over maintainership on behalf of FreeBSDDesktop.

Thanks for taking over, I don't have any recent hardware or the time to maintain/test this myself at the moment.

Sep 1 2017, 2:00 AM

Aug 8 2017

grembo committed rS322253: Fix typo in cyapa out of bounds check..
Fix typo in cyapa out of bounds check.
Aug 8 2017, 1:27 PM

Jul 1 2017

grembo committed rP444856: MFH: r444819 r444855.
MFH: r444819 r444855
Jul 1 2017, 11:21 PM
grembo committed rP444855: Don't run shebangfix on symlinks.
Don't run shebangfix on symlinks
Jul 1 2017, 11:11 PM
grembo committed rP444819: Upgrade devel/libphutil, devel/arcanist and devel/phabricator to 20170630.
Upgrade devel/libphutil, devel/arcanist and devel/phabricator to 20170630
Jul 1 2017, 12:11 PM

Apr 7 2017

grembo committed rP437949: Fix version string, improve package naming.
Fix version string, improve package naming
Apr 7 2017, 6:01 PM

Mar 29 2017

grembo committed rD50098: Add Viacheslav Mikerov to the list of additional contributors for.
Add Viacheslav Mikerov to the list of additional contributors for
Mar 29 2017, 12:36 AM
grembo committed rP437178: Add nlohmann-json v2.1.1, JSON library for Modern C++..
Add nlohmann-json v2.1.1, JSON library for Modern C++.
Mar 29 2017, 12:29 AM

Mar 28 2017

grembo abandoned D5624: Fix typo in header..

Upstream fixed this in the meantime.

Mar 28 2017, 11:11 PM
grembo closed D5754: Replace revision and publication date in generated documentation with more useful data..

Never mind, apparently I can accept it myself and this is good enough to allow me to close it.

Mar 28 2017, 11:09 PM
grembo accepted D5754: Replace revision and publication date in generated documentation with more useful data..

@wblock This has been committed quite some time ago, but as @hrs requested changes, I can't close it (this would only have happened if the svn revision mentioned the review). As it was committed, I would prefer not to abandon it. Any ideas how to solve this?

Mar 28 2017, 11:08 PM
grembo accepted D8647: PHP 7 support.
Mar 28 2017, 11:05 PM
grembo closed D6726: Remove remainder of legacy_aliases feature by committing rS316117: In r289137 the legacy_aliases compatibility shims for ata were removed,.
Mar 28 2017, 11:03 PM
grembo committed rS316117: In r289137 the legacy_aliases compatibility shims for ata were removed,.
In r289137 the legacy_aliases compatibility shims for ata were removed,
Mar 28 2017, 11:03 PM
grembo committed rP437172: Style fixes, no PORTREVISION bump required.
Style fixes, no PORTREVISION bump required
Mar 28 2017, 10:53 PM
grembo committed rP437171: Update devel/buildbot* to 0.9.5.
Update devel/buildbot* to 0.9.5
Mar 28 2017, 10:41 PM
grembo closed D10162: Summary: Change to buildbot 0.9.5 by committing rP437171: Update devel/buildbot* to 0.9.5.
Mar 28 2017, 10:41 PM
grembo updated the diff for D10162: Summary: Change to buildbot 0.9.5.

Update to 0.9.5, including missing files and fixing pending upstream.
Use PORTVERSION in dependencies (as all parts of buildbot need
to get updated at the same time.

Mar 28 2017, 10:30 PM
grembo commandeered D10162: Summary: Change to buildbot 0.9.5.

As the patch gets quite complicated and I would like to reference this review in the commit, I'll take over the revision and update the diff.

Mar 28 2017, 10:15 PM
grembo added a comment to D10162: Summary: Change to buildbot 0.9.5.

@rodrigc This commit breaks most of the unit tests:

Mar 28 2017, 8:24 PM
grembo added a comment to D10162: Summary: Change to buildbot 0.9.5.
In D10162#210112, @mat wrote:

You missed the third step which tells you to do "svn move" (or "svn copy", but here it is svn move.)

As it is too late, because buildbot-slave is gone, it is going to be a bit more complicated, a bit of a mix from the copy and the resurection. What you're going to need to do is:

  • copy the current buildbot-worker directory somewhere
  • svn rm buildbot-worker
  • svn commit (this will break INDEX and ports that have a dependency on it, but you're fixing it in the next commit, so, it's "ok")
  • svn cp 'svn+ssh://repo.freebsd.org/ports/head/devel/buildbot-slave/@437058' buildbot-worker
  • pull back the changes from buildbot-slave to buildbot-worker.
  • svn commit (this will unbreak INDEX and all)
Mar 28 2017, 3:46 PM
grembo committed rP437133: Fix failed rename of buildbot-slave to buildbot-worker 2/2.
Fix failed rename of buildbot-slave to buildbot-worker 2/2
Mar 28 2017, 3:42 PM
grembo committed rP437132: Fix failed rename of buildbot-slave to buildbot-worker 1/2.
Fix failed rename of buildbot-slave to buildbot-worker 1/2
Mar 28 2017, 3:37 PM
grembo added a comment to D10162: Summary: Change to buildbot 0.9.5.
In D10162#210106, @mat wrote:

Before any work on buildbot-worker can get in the tree, it needs to be removed and added back properly.

Mar 28 2017, 2:48 PM
grembo requested changes to D10162: Summary: Change to buildbot 0.9.5.

Thanks for opening this, much appreciated. I started working on this in parallel and there are a few more changes to it (running unit tests showed more dependencies that are missing - maybe only for the test target, but unclear at this point). Once I figured out all the details I'll commit the updated versions, until then it's probably best if you abandon this review.

Mar 28 2017, 2:12 PM

Mar 27 2017

grembo committed rP437089: Add hhdate 2.1.0.35, date and time library based on the C++11 (and.
Add hhdate 2.1.0.35, date and time library based on the C++11 (and
Mar 27 2017, 10:35 PM
grembo committed rP437068: Add buildbot-www 0.9.4, continuous Integration Framework (WWW)..
Add buildbot-www 0.9.4, continuous Integration Framework (WWW).
Mar 27 2017, 6:18 PM
grembo committed rP437067: Add buildbot-waterfall-view 0.9.4, continuous Integration Framework.
Add buildbot-waterfall-view 0.9.4, continuous Integration Framework
Mar 27 2017, 6:18 PM
grembo committed rP437066: Add buildbot-console-view 0.9.4, continuous Integration Framework.
Add buildbot-console-view 0.9.4, continuous Integration Framework
Mar 27 2017, 6:16 PM
grembo committed rP437065: Add buildbot-pkg 0.9.4, continuous Integration Framework (packaging)..
Add buildbot-pkg 0.9.4, continuous Integration Framework (packaging).
Mar 27 2017, 6:12 PM
grembo committed rP437060: Update to 0.9.4.
Update to 0.9.4
Mar 27 2017, 4:53 PM
grembo committed rP437059: Rename buildbot-slave to buildbot-worker, update to 0.9.4.
Rename buildbot-slave to buildbot-worker, update to 0.9.4
Mar 27 2017, 4:48 PM
grembo committed rP437048: Update to 0.12.4.
Update to 0.12.4
Mar 27 2017, 2:32 PM

Mar 16 2017

grembo committed rP436277: Update to 0.19.
Update to 0.19
Mar 16 2017, 1:17 PM

Mar 15 2017

grembo committed rP436226: Update tp 0.17.2.
Update tp 0.17.2
Mar 15 2017, 11:35 AM
grembo committed rP436210: Update to 2.6.1.
Update to 2.6.1
Mar 15 2017, 11:31 AM

Mar 12 2017

grembo committed rP436023: Add py-ramlfications 0.1.9, python parser for RAML..
Add py-ramlfications 0.1.9, python parser for RAML.
Mar 12 2017, 8:15 PM
grembo committed rP436022: Add py-jsonref 0.1, implementation of JSON Reference for Python..
Add py-jsonref 0.1, implementation of JSON Reference for Python.
Mar 12 2017, 8:11 PM

Feb 28 2017

grembo committed rD50023: add Andreas Sommer to contributors for textproc/kiss-templates.
add Andreas Sommer to contributors for textproc/kiss-templates
Feb 28 2017, 11:38 PM
grembo committed rP435110: New port: textproc/kiss-templates.
New port: textproc/kiss-templates
Feb 28 2017, 11:29 PM

Feb 2 2017

grembo committed rD49913: Renew grembo's PGP key.
Renew grembo's PGP key
Feb 2 2017, 6:03 PM

Jan 30 2017

grembo committed rP432888: Fix 64-bit platform detection for pre C++11 compilers..
Fix 64-bit platform detection for pre C++11 compilers.
Jan 30 2017, 10:29 PM

Jan 29 2017

grembo committed rP432801: Allow building devel/py-ice with clang 4.0, based on bug report.
Allow building devel/py-ice with clang 4.0, based on bug report
Jan 29 2017, 9:39 PM

Jan 16 2017

grembo committed rP431649: Fix build with LibreSSL.
Fix build with LibreSSL
Jan 16 2017, 2:24 PM

Nov 15 2016

grembo committed rP426170: Fix icegridnode, so it applies property changes to shared communicators.
Fix icegridnode, so it applies property changes to shared communicators
Nov 15 2016, 2:52 PM

Nov 5 2016

grembo committed rP425398: Fix data encryption at rest when building with LibreSSL.
Fix data encryption at rest when building with LibreSSL
Nov 5 2016, 4:56 PM

Oct 28 2016

grembo committed rP424853: Make libskarnet.so a runtime dependency..
Make libskarnet.so a runtime dependency.
Oct 28 2016, 2:22 PM

Oct 12 2016

grembo committed rP423875: Update ice ports to 3.6.3.
Update ice ports to 3.6.3
Oct 12 2016, 5:24 PM

Oct 3 2016

grembo committed rP423223: Update devel/arcanist, devel/libphutil, devel/phabricator to 20161003.
Update devel/arcanist, devel/libphutil, devel/phabricator to 20161003
Oct 3 2016, 7:58 PM

Sep 28 2016

grembo added a comment to D1955: Expand the SMBUS API to add a smbus_trans() function..

@avg Unfortunately I don't have much time at my hands right now and - like you pointed out - this has been committed quite a while ago. So I think it's best if you open a PR and create a patch/new code review. If time permits, I'm more than happy to help you testing the improved code.

Sep 28 2016, 12:18 PM

Aug 16 2016

grembo committed rP420291: Remove pid file that was added by accident when stagifying the port..
Remove pid file that was added by accident when stagifying the port.
Aug 16 2016, 5:13 PM

Aug 10 2016

grembo accepted D7453: Add smbios sysctl entries for fields for SMBIOS up to version 2.4.
Aug 10 2016, 1:57 PM

Jul 10 2016

grembo committed rP418315: Fix icegridadmin's handling of properties on shared communicators.
Fix icegridadmin's handling of properties on shared communicators
Jul 10 2016, 12:47 PM

Jun 13 2016

grembo committed rP416855: Fix build on CURRENT..
Fix build on CURRENT.
Jun 13 2016, 6:54 PM

Jun 6 2016

grembo committed rP416489: Make dependency on aspell optional.
Make dependency on aspell optional
Jun 6 2016, 9:27 PM
grembo closed D6732: Make aspell support optional, allow installing of aspell later by committing rP416489: Make dependency on aspell optional.
Jun 6 2016, 9:27 PM
grembo awarded D6732: Make aspell support optional, allow installing of aspell later a Baby Tequila token.
Jun 6 2016, 9:21 PM
grembo committed rS301500: MFC r297052:.
MFC r297052:
Jun 6 2016, 11:08 AM
grembo updated the diff for D6732: Make aspell support optional, allow installing of aspell later.

Obviously, thanks.

Jun 6 2016, 9:23 AM

Jun 5 2016

grembo retitled D6732: Make aspell support optional, allow installing of aspell later from to Make aspell support optional, allow installing of aspell later.
Jun 5 2016, 2:03 PM

Jun 4 2016

grembo retitled D6726: Remove remainder of legacy_aliases feature from to Remove remainder of legacy_aliases feature.
Jun 4 2016, 12:45 PM

May 30 2016

grembo committed rS300990: Fix ig4 operation for certain machines.
Fix ig4 operation for certain machines
May 30 2016, 9:05 AM
grembo closed D6586: Fix ig4 operation for certain machines (from DragonFly) by committing rS300990: Fix ig4 operation for certain machines.
May 30 2016, 9:05 AM

May 28 2016

grembo updated the diff for D6586: Fix ig4 operation for certain machines (from DragonFly).

Fix comment as pointed out by @jhb

May 28 2016, 12:04 PM

May 27 2016

grembo retitled D6586: Fix ig4 operation for certain machines (from DragonFly) from to Fix ig4 operation for certain machines (from DragonFly).
May 27 2016, 1:10 AM

Apr 6 2016

grembo committed rP412616: Update ice ports to 3.6.2.
Update ice ports to 3.6.2
Apr 6 2016, 1:09 PM

Apr 2 2016

grembo added inline comments to D5754: Replace revision and publication date in generated documentation with more useful data..
Apr 2 2016, 3:43 PM
grembo updated the diff for D5754: Replace revision and publication date in generated documentation with more useful data..

Add -s to grep to silence error messages in stages of the build
when certain files don't exist yet.

Apr 2 2016, 3:43 PM

Mar 31 2016

grembo added a comment to D5754: Replace revision and publication date in generated documentation with more useful data..

@hrs (edited, so it makes more sense)

Mar 31 2016, 10:44 PM
grembo added a comment to D5754: Replace revision and publication date in generated documentation with more useful data..

@hrs
Can you please suggest how to accomplish what this is doing (and I think what this is doing is extremely important, I was embarrassed when I showed the Porters Handbook to someone and it said that it was last updated two years ago) in a style sheet in a way that is less complex (this is not about parsing XML, but about getting an SVN keyword out of a group of text files, which is super stable, compatible and will work even on files that are part of the documentation, even if they're not XML)?

Mar 31 2016, 10:31 PM

Mar 27 2016

grembo added a comment to D5754: Replace revision and publication date in generated documentation with more useful data..

Kind of went the opposite direction in terms of perl, I find the result to be quite readable though.

Mar 27 2016, 8:35 PM
grembo updated the diff for D5754: Replace revision and publication date in generated documentation with more useful data..

Separate lastrevision into multiple, more structured fields in Makefile.
Remove perl from the mix.
Add tail command to doc.commands.mk.

Mar 27 2016, 8:34 PM
grembo retitled D5754: Replace revision and publication date in generated documentation with more useful data. from to Replace revision and publication date in generated documentation with more useful data..
Mar 27 2016, 2:22 PM

Mar 26 2016

grembo committed rP411965: Add optional dependency on mbstring for encodings support.
Add optional dependency on mbstring for encodings support
Mar 26 2016, 8:40 PM
grembo committed rP411914: Add new port: devel/libcppformat (an open-source formatting library for C++).
Add new port: devel/libcppformat (an open-source formatting library for C++)
Mar 26 2016, 2:31 AM

Mar 19 2016

grembo committed rS297052: Update fetch.1 and fetch.3 to reflect libfetch's actual use of CA bundles.
Update fetch.1 and fetch.3 to reflect libfetch's actual use of CA bundles
Mar 19 2016, 11:55 AM
grembo closed D5558: Update fetch.1 and fetch.3 to reflect libfetch's actual use of CA bundles by committing rS297052: Update fetch.1 and fetch.3 to reflect libfetch's actual use of CA bundles.
Mar 19 2016, 11:55 AM

Mar 18 2016

grembo updated the diff for D5558: Update fetch.1 and fetch.3 to reflect libfetch's actual use of CA bundles.

More updates based on @wblock's input.

Mar 18 2016, 4:02 PM

Mar 16 2016

grembo added inline comments to D5558: Update fetch.1 and fetch.3 to reflect libfetch's actual use of CA bundles.
Mar 16 2016, 4:04 PM