- User Since
- May 16 2014, 11:25 AM (370 w, 10 h)
Thu, Jun 10
@bdrewery But don't you think that
@mat @swills It doesn't seem like you got around to resolve this yet, so we're still in a situation where the documented way of using REINPLACE_ARGS will create different workdirs depending if DEVELOPER is on or not.
@lwhsu I see that the git repo was added to CGIs in the meantime (which is good), but the remainder of the navigation remains out of synch with what's on the main web site.
Just to repeat an earlier comment and asking portmgr to comment - then this review can progress or be abandoned and either way there will be a documented decision.
Wed, Jun 9
@ceri Thanks for taking the time to review.
@mat Next time, please show some basic respect and comment on a review that has been made obsolete by your own contribution (especially since I made it clear that I'm ok if you don't like it).
Make wording omre general, use root prompt ("#").
Adding docs, as this might be more appropriate(?)
Mon, May 31
Fri, May 21
May 18 2021
@adridg As you've been sending out regular messages about following the commit message conventions. What do you think?
May 14 2021
Use contemporary terminology
May 13 2021
Does this change anything about the patch though (which in the end implements a force flag, which isn't nuanced at all)? Would you prefer a different name of the flag that emphasizes that you think this error shouldn't be ignored?
Updated the diff using arcanist, as using raw diff upload the way I did won't get us far.
Updating diff using arcanist
Put some more effort into this...
Minor changes. It's a bit ugly how options are defined and excluded right now,
but it works well enough for someone (hopefully) take it from there.
May 7 2021
Sorry for all the noise, .arcconfig vs. git migration.
Add quoting like in the original template.
Add main branch to .arcconfig (we don't use master)
Prevent extra empty line when ammending.
May 6 2021
Apr 29 2021
Apr 15 2021
Apr 12 2021
Mar 24 2021
Feb 28 2021
Jan 31 2021
You can reproduce the problem easily by going to:
Jan 27 2021
Jan 26 2021
@carlavilla This builds now locally, so it can be properly reviewed.
Fix things after incorporating changes that happened in the meantime.
I'll make it build locally first and then re-open...
Jan 18 2021
Jan 15 2021
Jan 14 2021
Jan 12 2021
Jan 5 2021
@swills p.s. Besides the patch being simple, I figured that not calling sed_checked.sh was in line with what is done in case REINPLACE_CMD has been overridden, as changing REINPLACE_ARGS is also a way to alter REINPLACE_CMD.
I am sorry but this is a no. The ports are broken, and the framework is telling you they are, and all you want to do is stop the framework telling you they are broken. If you don't care, just don't build with DEVELOPER set, and everything will be silent again.
Jan 4 2021
Jan 2 2021
Jan 1 2021
Nov 30 2020
Oct 27 2020
Sep 17 2020
Aug 27 2020
Aug 26 2020
Aug 19 2020
Jul 21 2020
Jul 19 2020
Jul 10 2020
The change this was based on was backed out in rS363060 to come up with a better strategy. This renders this change pointless, as I assume the next attempt will include this anyway.
Jul 8 2020
Jun 28 2020
Jun 27 2020
Change wording as proposed by 0mp