- User Since
- May 16 2014, 11:25 AM (213 w, 6 d)
Wed, Jun 6
@kib Updated by tree to r334733 and applied the patch, it's working as expected, thanks!
Apr 20 2018
Feb 11 2018
Fix typo and extra whitespace
Feb 9 2018
Add support for controlling micmute LED
Feb 2 2018
Please note that man page changes are pending, but will be added to the review before committing any changes.
Jan 30 2018
Add support for controlling the keyboard backlight found in newer lenovo models.
Jan 29 2018
@rodrigc I think this can be closed.
Jan 25 2018
Jan 24 2018
Jan 22 2018
Sep 24 2017
@koobs Just glanced at it, trusting your judgement.
Sep 7 2017
Sep 4 2017
Sep 1 2017
Thanks for taking over, I don't have any recent hardware or the time to maintain/test this myself at the moment.
Aug 8 2017
Jul 1 2017
Apr 7 2017
Mar 29 2017
Mar 28 2017
Upstream fixed this in the meantime.
Never mind, apparently I can accept it myself and this is good enough to allow me to close it.
@wblock This has been committed quite some time ago, but as @hrs requested changes, I can't close it (this would only have happened if the svn revision mentioned the review). As it was committed, I would prefer not to abandon it. Any ideas how to solve this?
Update to 0.9.5, including missing files and fixing pending upstream.
Use PORTVERSION in dependencies (as all parts of buildbot need
to get updated at the same time.
As the patch gets quite complicated and I would like to reference this review in the commit, I'll take over the revision and update the diff.
@rodrigc This commit breaks most of the unit tests:
Thanks for opening this, much appreciated. I started working on this in parallel and there are a few more changes to it (running unit tests showed more dependencies that are missing - maybe only for the test target, but unclear at this point). Once I figured out all the details I'll commit the updated versions, until then it's probably best if you abandon this review.
Mar 27 2017
Mar 16 2017
Mar 15 2017
Mar 12 2017
Feb 28 2017
Feb 2 2017
Jan 30 2017
Jan 29 2017
Jan 16 2017
Nov 15 2016
Nov 5 2016
Oct 28 2016
Oct 12 2016
Oct 3 2016
Sep 28 2016
@avg Unfortunately I don't have much time at my hands right now and - like you pointed out - this has been committed quite a while ago. So I think it's best if you open a PR and create a patch/new code review. If time permits, I'm more than happy to help you testing the improved code.
Aug 16 2016
Aug 10 2016
Jul 10 2016
Jun 13 2016
Jun 6 2016
Jun 5 2016
Jun 4 2016
May 30 2016
May 28 2016
Fix comment as pointed out by @jhb
May 27 2016
Apr 6 2016
Apr 2 2016
Add -s to grep to silence error messages in stages of the build
when certain files don't exist yet.
Mar 31 2016
@hrs (edited, so it makes more sense)
Can you please suggest how to accomplish what this is doing (and I think what this is doing is extremely important, I was embarrassed when I showed the Porters Handbook to someone and it said that it was last updated two years ago) in a style sheet in a way that is less complex (this is not about parsing XML, but about getting an SVN keyword out of a group of text files, which is super stable, compatible and will work even on files that are part of the documentation, even if they're not XML)?
Mar 27 2016
Kind of went the opposite direction in terms of perl, I find the result to be quite readable though.
Separate lastrevision into multiple, more structured fields in Makefile.
Remove perl from the mix.
Add tail command to doc.commands.mk.
Mar 26 2016
Mar 19 2016
Mar 18 2016
More updates based on @wblock's input.