Page MenuHomeFreeBSD

Update dns/hostdb to use GitHub
ClosedPublic

Authored by rodrigc on Mar 28 2017, 6:11 AM.

Details

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rodrigc created this revision.Mar 28 2017, 6:11 AM
rodrigc updated this revision to Diff 26718.Mar 28 2017, 6:13 AM

Fix whitespace

Tested with:
poudriere testport -j 10 -p development -o dns/hostdb

rodrigc updated this revision to Diff 26720.Mar 28 2017, 6:50 AM

Remove GH_PROJECT

rodrigc updated this revision to Diff 26721.Mar 28 2017, 7:14 AM

Remove code.google.com URL

ak accepted this revision.Mar 28 2017, 7:42 AM
ak added a subscriber: ak.

Looks good for me.

This revision is now accepted and ready to land.Mar 28 2017, 7:42 AM
This revision was automatically updated to reflect the committed changes.
mat added inline comments.Mar 28 2017, 8:37 AM
head/dns/hostdb/Makefile
6

bumping PORTREVISION does not seem to make a lot of sense as the only thing you changed is moving to github. Either the commit hash you choose is the one corresponding to 1.004, and in that case, it is the exact same thing, or it is not 1.004 and in that case PORTVERSION should have been changed.

ak added inline comments.Mar 28 2017, 8:46 AM
head/dns/hostdb/Makefile
6

There are identical, I've checked. But I think that bump is ok, unless old rule that you bump when package change (WWW in this case) doesn't true anymore.

mat added inline comments.Mar 28 2017, 8:53 AM
head/dns/hostdb/Makefile
6

WWW is metadata, we do not bump solely on metadata changes. A bit like MAINTAINER change, you never see anyone bumping for MAINTAINER change.