Differential D10159

Update dns/hostdb to use GitHub
ClosedPublic
Actions

Authored by • rodrigc on Mar 28 2017, 6:11 AM.

Tags

None

Referenced Files

	F105767650: D10159.diff
	Fri, Dec 20, 10:10 AM

	Unknown Object (File)
	Thu, Dec 12, 1:32 AM

	Unknown Object (File)
	Thu, Dec 5, 11:33 AM

	Unknown Object (File)
	Wed, Dec 4, 11:39 PM

	Unknown Object (File)
	Sat, Nov 30, 9:16 AM

	Unknown Object (File)
	Sat, Nov 30, 9:16 AM

	Unknown Object (File)
	Sat, Nov 30, 9:15 AM

	Unknown Object (File)
	Sat, Nov 30, 9:11 AM

Subscribers

Details

Reviewers

Group Reviewers

Ports Committers

Commits

rP437099: Move from google code to github

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• rodrigc created this revision.Mar 28 2017, 6:11 AM

Herald added a subscriber: mat. · View Herald TranscriptMar 28 2017, 6:11 AM

Harbormaster completed remote builds in B8324: Diff 26717.Mar 28 2017, 6:11 AM

Fix whitespace

Harbormaster completed remote builds in B8325: Diff 26718.Mar 28 2017, 6:14 AM

• rodrigc added a reviewer: Ports Committers.Mar 28 2017, 6:16 AM

Tested with:
poudriere testport -j 10 -p development -o dns/hostdb

Remove GH_PROJECT

Harbormaster completed remote builds in B8327: Diff 26720.Mar 28 2017, 6:50 AM

Remove code.google.com URL

Harbormaster completed remote builds in B8328: Diff 26721.Mar 28 2017, 7:14 AM

Looks good for me.

This revision is now accepted and ready to land.Mar 28 2017, 7:42 AM

Closed by commit rP437099: Move from google code to github (authored by • rodrigc). · Explain WhyMar 28 2017, 8:06 AM

This revision was automatically updated to reflect the committed changes.

mat added inline comments.Mar 28 2017, 8:37 AM

head/dns/hostdb/Makefile
6	bumping PORTREVISION does not seem to make a lot of sense as the only thing you changed is moving to github. Either the commit hash you choose is the one corresponding to 1.004, and in that case, it is the exact same thing, or it is not 1.004 and in that case PORTVERSION should have been changed.

ak added inline comments.Mar 28 2017, 8:46 AM

head/dns/hostdb/Makefile
6	There are identical, I've checked. But I think that bump is ok, unless old rule that you bump when package change (WWW in this case) doesn't true anymore.

mat added inline comments.Mar 28 2017, 8:53 AM

head/dns/hostdb/Makefile
6	WWW is metadata, we do not bump solely on metadata changes. A bit like MAINTAINER change, you never see anyone bumping for MAINTAINER change.

Revision Contents
Changeset List

Path

Size

head/

dns/

hostdb/

10 lines

5 lines

3 lines

Diff 26722

head/dns/hostdb/Makefile

Loading...

head/dns/hostdb/distinfo

Loading...

head/dns/hostdb/pkg-descr

Loading...