Page MenuHomeFreeBSD

Update dns/hostdb to use GitHub
ClosedPublic

Authored by rodrigc on Mar 28 2017, 6:11 AM.
Tags
None
Referenced Files
F105062135: D10159.diff
Thu, Dec 12, 1:32 AM
Unknown Object (File)
Thu, Dec 5, 11:33 AM
Unknown Object (File)
Wed, Dec 4, 11:39 PM
Unknown Object (File)
Sat, Nov 30, 9:16 AM
Unknown Object (File)
Sat, Nov 30, 9:16 AM
Unknown Object (File)
Sat, Nov 30, 9:15 AM
Unknown Object (File)
Sat, Nov 30, 9:11 AM
Unknown Object (File)
Sat, Nov 30, 9:10 AM
Subscribers

Details

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Tested with:
poudriere testport -j 10 -p development -o dns/hostdb

ak added a subscriber: ak.

Looks good for me.

This revision is now accepted and ready to land.Mar 28 2017, 7:42 AM
This revision was automatically updated to reflect the committed changes.
head/dns/hostdb/Makefile
6

bumping PORTREVISION does not seem to make a lot of sense as the only thing you changed is moving to github. Either the commit hash you choose is the one corresponding to 1.004, and in that case, it is the exact same thing, or it is not 1.004 and in that case PORTVERSION should have been changed.

head/dns/hostdb/Makefile
6

There are identical, I've checked. But I think that bump is ok, unless old rule that you bump when package change (WWW in this case) doesn't true anymore.

head/dns/hostdb/Makefile
6

WWW is metadata, we do not bump solely on metadata changes. A bit like MAINTAINER change, you never see anyone bumping for MAINTAINER change.