Page MenuHomeFreeBSD

koobs (Kubilay Kocak)
User

Projects

User Details

User Since
May 22 2014, 10:41 AM (229 w, 5 d)

Recent Activity

Today

koobs committed rP482271: lang/python27,35+: Remove MAKE_JOBS_UNSAFE.
lang/python27,35+: Remove MAKE_JOBS_UNSAFE
Wed, Oct 17, 6:24 AM
koobs closed D17579: lang/python27,35+: Remove MAKE_JOBS_UNSAFE.
Wed, Oct 17, 6:24 AM
koobs updated the summary of D17579: lang/python27,35+: Remove MAKE_JOBS_UNSAFE.
Wed, Oct 17, 6:21 AM
koobs updated the summary of D17579: lang/python27,35+: Remove MAKE_JOBS_UNSAFE.
Wed, Oct 17, 6:19 AM
koobs accepted D17592: sysutils/py-pyznap: Add concurrent to USE_PYTHON.

Don't forget to add relevant bits to TEST PLAN section so its clear (explicit) to reviewers/mentors that the change were run through, and pass QA:

Wed, Oct 17, 1:51 AM
koobs updated the summary of D17592: sysutils/py-pyznap: Add concurrent to USE_PYTHON.
Wed, Oct 17, 1:49 AM
koobs updated the summary of D17592: sysutils/py-pyznap: Add concurrent to USE_PYTHON.
Wed, Oct 17, 1:49 AM

Yesterday

koobs accepted D17533: net/intel-ixl-kmod: Remove -Werror from CFLAGS.
Tue, Oct 16, 10:40 AM · Intel Networking
koobs created D17579: lang/python27,35+: Remove MAKE_JOBS_UNSAFE.
Tue, Oct 16, 6:46 AM

Tue, Oct 9

koobs added a comment to D17443: net/intel-ix-kmod: New port for 10g Intel Ethernet Base Driver.

Looks good except for -Werror. This all matches the port WIP I have in my tree, except for the additions:

MANPAGENAME=        ixgbe
 MANPAGELINKS=        ix if_ix if_ixgbe
 ​MAX_NETMAP_OSVERSION=        1199999  # Doesn't build w/NETMAP on 12

Will do. Do you have any specific warnings showing up for you?

Tue, Oct 9, 12:44 PM · Intel Networking

Mon, Oct 8

koobs committed rP481527: MFH: r481437 math/py-graphillion: Update to 1.2.
MFH: r481437 math/py-graphillion: Update to 1.2
Mon, Oct 8, 8:56 AM
koobs committed rP481526: MFH: r481438 comms/hylafax: Fix build with Clang 6 (and GCC7).
MFH: r481438 comms/hylafax: Fix build with Clang 6 (and GCC7)
Mon, Oct 8, 8:54 AM

Sun, Oct 7

koobs added a comment to D16863: [NEW PORT] devel/py-bumpversion: Version-bump your software with a single command.

Missing responses to: https://reviews.freebsd.org/D16863?id=47167#369395 - In particular:

Sun, Oct 7, 11:43 AM
koobs accepted D17334: devel/py-pytest-xprocess: Update pkg-descr.
Sun, Oct 7, 11:40 AM
koobs committed rP481438: comms/hylafax: Fix build with Clang 6 (and GCC7).
comms/hylafax: Fix build with Clang 6 (and GCC7)
Sun, Oct 7, 10:29 AM
koobs requested changes to D17443: net/intel-ix-kmod: New port for 10g Intel Ethernet Base Driver.

Looks good except for -Werror. This all matches the port WIP I have in my tree, except for the additions:

Sun, Oct 7, 10:09 AM · Intel Networking
koobs committed rP481437: math/py-graphillion: Update to 1.2.
math/py-graphillion: Update to 1.2
Sun, Oct 7, 9:57 AM

Sat, Oct 6

koobs committed rP481316: irc/py-limnoria: Update to 2018.09.09.
irc/py-limnoria: Update to 2018.09.09
Sat, Oct 6, 4:49 AM

Thu, Oct 4

koobs accepted D17391: devel/py-btest: Add python to CATEGORIES..
Thu, Oct 4, 3:49 AM

Thu, Sep 27

koobs updated the summary of D17334: devel/py-pytest-xprocess: Update pkg-descr.
Thu, Sep 27, 1:34 PM
koobs requested changes to D17334: devel/py-pytest-xprocess: Update pkg-descr.
Thu, Sep 27, 1:34 PM

Wed, Sep 26

koobs accepted D17255: [NEW PORT] benchmarks/linux-vdbench: Command line disk I/O benchmark utility.
Wed, Sep 26, 5:36 AM
koobs added inline comments to D17255: [NEW PORT] benchmarks/linux-vdbench: Command line disk I/O benchmark utility.
Wed, Sep 26, 4:49 AM
koobs requested changes to D16863: [NEW PORT] devel/py-bumpversion: Version-bump your software with a single command.
Wed, Sep 26, 4:47 AM
koobs accepted D17313: [new port] devel/py-pytest-xprocess: Pytest plugin to manage external processes across test runs.

Perfect

Wed, Sep 26, 2:46 AM

Fri, Sep 21

koobs requested changes to D17255: [NEW PORT] benchmarks/linux-vdbench: Command line disk I/O benchmark utility.

We must be able to QA ports with poudriere, even when they're RESTRICTED, whilst also retaining the ability for the 'package building for distribution' use-case to no violate license terms.

Fri, Sep 21, 2:12 AM

Tue, Sep 18

koobs added inline comments to D17201: multimedia/libx264: add -znotext to LDFLAGS on i386, for lld.
Tue, Sep 18, 3:05 AM
koobs accepted D17201: multimedia/libx264: add -znotext to LDFLAGS on i386, for lld.

Any change fixing this issue was (and is) explicitly approved (subject to @emaste confidence in solution/QA) per bugzilla issue comment: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230214#c7

Tue, Sep 18, 3:02 AM

Mon, Sep 17

koobs accepted D17188: devel/py-pytest-timeout: Update to 1.3.2.

LGTM

Mon, Sep 17, 9:05 AM

Sep 12 2018

koobs added inline comments to D17099: biology/py-cutadapt: Upgrade to 1.18.
Sep 12 2018, 3:21 AM

Sep 10 2018

koobs added a comment to D17099: biology/py-cutadapt: Upgrade to 1.18.
In D17099#364458, @jrm wrote:

This is a quote from @koobs from a past review.

Python packages that provide end-user, console scripts, or other files in common/shared locations should tested to be, or made to be USE_PYTHON=concurrent safe. Concurrent safe means two package installs of the same port for different python versions (eg: py27-foo and py36-foo) do not conflict (each file in common locations has a unique filename). USE_PYTHON=concurrent handles most common examples automatically (localbase/bin/*, docs).

Sep 10 2018, 2:02 AM
koobs requested changes to D17099: biology/py-cutadapt: Upgrade to 1.18.
Sep 10 2018, 2:00 AM

Aug 26 2018

koobs committed rP478091: MFH: r477627 devel/git: Add missing (send-email) dependency.
MFH: r477627 devel/git: Add missing (send-email) dependency
Aug 26 2018, 12:26 AM

Aug 22 2018

koobs committed rP477764: MFH: r476488 security/py-cryptography: Update to 2.3.
MFH: r476488 security/py-cryptography: Update to 2.3
Aug 22 2018, 2:15 AM

Aug 21 2018

koobs committed rP477708: MFH: r476826 sysutils/dvd+rw-tools: Fix issue appending more than 25gb on BD-R….
MFH: r476826 sysutils/dvd+rw-tools: Fix issue appending more than 25gb on BD-R…
Aug 21 2018, 7:18 AM
koobs committed rP477707: MFH: r476722 x11-wm/blackbox: Fix build with Clang 6, Fix TOOLS_ONLY option.
MFH: r476722 x11-wm/blackbox: Fix build with Clang 6, Fix TOOLS_ONLY option
Aug 21 2018, 7:16 AM

Aug 20 2018

koobs added a comment to D16716: devel/py-pbr update to 4.2.0.

@matthew Syntactical change looks fine, but I'd want to test dependents for compatibility given the major version bump. I'd expect to find some that pinned pbr to < 4

Aug 20 2018, 8:57 AM
koobs committed rP477627: devel/git: Add missing (send-email) dependency.
devel/git: Add missing (send-email) dependency
Aug 20 2018, 5:08 AM
koobs accepted D16776: Update sysutils/py-supervisor to 3.3.4. Improve port.
Aug 20 2018, 1:21 AM
koobs accepted D16759: mail/mblaze: Unix utilities to deal with Maildir.
Aug 20 2018, 1:19 AM

Aug 13 2018

koobs accepted D16699: mail/managesieve3: Implements an RFC-5804 Manage Sieve client.

Accepted with port ordering change (it should go below USES)

Aug 13 2018, 1:24 PM
koobs accepted D16699: mail/managesieve3: Implements an RFC-5804 Manage Sieve client.

Accepted, with two minor review items that while aren't 'strictly' necessary, are good for consistency (both for individual ports, and against other similar ports)

Aug 13 2018, 9:30 AM

Aug 12 2018

koobs committed rP476961: devel/py-intbitset: Patch out march/mtune/-O3 (Respect CFLAGS).
devel/py-intbitset: Patch out march/mtune/-O3 (Respect CFLAGS)
Aug 12 2018, 5:00 AM

Aug 11 2018

koobs committed rP476858: devel/py-click: Level up ports compliance.
devel/py-click: Level up ports compliance
Aug 11 2018, 3:32 AM

Aug 10 2018

koobs accepted D16658: mail/bincimap: Fix build with Clang 6.0.0.

Merge security updates and all non-version updates to the quarterly branch when/where possible. I've added MFH to the proposed commit log message

Aug 10 2018, 10:28 PM
koobs updated the summary of D16658: mail/bincimap: Fix build with Clang 6.0.0.
Aug 10 2018, 10:27 PM
koobs committed rP476826: sysutils/dvd+rw-tools: Fix issue appending more than 25gb on BD-R DL discs.
sysutils/dvd+rw-tools: Fix issue appending more than 25gb on BD-R DL discs
Aug 10 2018, 10:05 AM

Aug 9 2018

koobs committed rP476722: x11-wm/blackbox: Fix build with Clang 6, Fix TOOLS_ONLY option.
x11-wm/blackbox: Fix build with Clang 6, Fix TOOLS_ONLY option
Aug 9 2018, 6:43 AM

Aug 7 2018

koobs accepted D16605: devel/ipython: Remove leftover artifact after removing GCC dependency.
Aug 7 2018, 10:46 PM
koobs updated the summary of D16605: devel/ipython: Remove leftover artifact after removing GCC dependency.
Aug 7 2018, 10:46 PM
koobs requested changes to D16605: devel/ipython: Remove leftover artifact after removing GCC dependency.

Except for this probably requiring a PORTREVISION bump since the package contents are changed, it appears fine, assuming *all* the lines being removed are relevant to that GCC_RUNTIME.

Aug 7 2018, 9:44 AM
koobs committed rP476584: devel/py-requests: Bump pinned idna dependency version.
devel/py-requests: Bump pinned idna dependency version
Aug 7 2018, 9:11 AM
koobs committed rP476565: www/py-gandi.cli: Update to 1.2.
www/py-gandi.cli: Update to 1.2
Aug 7 2018, 4:36 AM
koobs committed rP476564: www/py-rfc3987: Update to 1.3.8.
www/py-rfc3987: Update to 1.3.8
Aug 7 2018, 4:26 AM
koobs committed rP476563: www/py-txrequests: Update to 0.9.6.
www/py-txrequests: Update to 0.9.6
Aug 7 2018, 3:53 AM
koobs committed rP476562: devel/py-pyflakes: Update to 2.0.0.
devel/py-pyflakes: Update to 2.0.0
Aug 7 2018, 3:44 AM
koobs committed rP476561: devel/py-lazy: Update to 1.3.
devel/py-lazy: Update to 1.3
Aug 7 2018, 3:20 AM
koobs committed rP476560: dns/py-idna: Update to 2.7.
dns/py-idna: Update to 2.7
Aug 7 2018, 2:56 AM
koobs committed rP476559: math/py-pycosat: Update to 0.6.3.
math/py-pycosat: Update to 0.6.3
Aug 7 2018, 2:43 AM
koobs committed rP476558: devel/py-pygithub: Update to 1.40.
devel/py-pygithub: Update to 1.40
Aug 7 2018, 2:42 AM
koobs committed rP476557: devel/py-pretend: Update to 1.0.9.
devel/py-pretend: Update to 1.0.9
Aug 7 2018, 2:08 AM

Aug 6 2018

koobs accepted D16508: devel/ipython: Update to 6.5.0.

Nice work, looks good!

Aug 6 2018, 10:51 AM
koobs updated the summary of D16508: devel/ipython: Update to 6.5.0.
Aug 6 2018, 10:50 AM
koobs updated the summary of D16508: devel/ipython: Update to 6.5.0.
Aug 6 2018, 5:31 AM
koobs added a comment to D16508: devel/ipython: Update to 6.5.0.

This LGTM. @farrokhi Could you edit the revision SUMMARY to include a proposed commit log message please (including any relevant Property: value lines). Please include a link to a release notes, changelog, and link to any migration/upgrade notes (if required, this is a major version upgrade) and an explanation for USE_GCC removal (im assuming it just now builds with clang, but clarifying this in the message is nice)

Aug 6 2018, 5:21 AM
koobs committed rP476488: security/py-cryptography: Update to 2.3.
security/py-cryptography: Update to 2.3
Aug 6 2018, 3:25 AM
koobs committed rP476487: security/py-cryptography: Add tag forgery vulnerability.
security/py-cryptography: Add tag forgery vulnerability
Aug 6 2018, 3:23 AM

Aug 5 2018

koobs reopened D16508: devel/ipython: Update to 6.5.0.

Reopening

Aug 5 2018, 11:10 PM
koobs accepted D16567: devel/py-pytest-timeout: Update to 1.3.1.

LGTM, thanks @loader!

Aug 5 2018, 1:01 AM

Aug 1 2018

koobs requested changes to D16508: devel/ipython: Update to 6.5.0.

@farrokhi Can you rebase your changes after @rm's commit and update the diff here

Aug 1 2018, 9:26 AM

Jul 31 2018

koobs accepted D16524: comms/py-adafruit-ampy: Adafruit MicroPython tool.

Looks good!

Jul 31 2018, 11:18 PM
koobs accepted D16508: devel/ipython: Update to 6.5.0.

For future reviews, please include a proposed commit log message including rationale for changes (where not clear from the diff) in the SUMMARY section, and include QA confirmation in the TEST PLAN section, something like:

Jul 31 2018, 11:15 PM
koobs requested changes to D16508: devel/ipython: Update to 6.5.0.
Jul 31 2018, 4:23 AM
koobs accepted D16483: comms/py-esptool: Utility to communicate with Espressif ESP8266 & ESP32 chips.

Use MASTER_SITES=CHEESESHOP by default for Python package distribution files when the source distribution (sdist) is published there (as this one is), unless there is a compelling temporary case to use an alternative source location (like GitHub); such as missing test files / important data files, etc. In these cases, ask upstream to include relevant files in the sdist

Jul 31 2018, 4:20 AM
koobs updated the summary of D16483: comms/py-esptool: Utility to communicate with Espressif ESP8266 & ESP32 chips.
Jul 31 2018, 4:16 AM
koobs updated the summary of D16365: Update devel/libhtp to 0.5.27.
Jul 31 2018, 4:13 AM
koobs accepted D16365: Update devel/libhtp to 0.5.27.

Thanks @garga

Jul 31 2018, 4:13 AM
koobs committed rP475964: net/czmq: Update to 4.1.1.
net/czmq: Update to 4.1.1
Jul 31 2018, 1:00 AM

Jul 30 2018

koobs committed rP475926: devel/py-dateutil: Update to 2.7.3.
devel/py-dateutil: Update to 2.7.3
Jul 30 2018, 11:30 PM
koobs committed rP475859: www/moinmoin: Add recaptcha v2 and email verification support.
www/moinmoin: Add recaptcha v2 and email verification support
Jul 30 2018, 12:05 AM
koobs closed D16315: www/moinmoin: Add recaptcha v2 and verifyemail support patches.
Jul 30 2018, 12:05 AM

Jul 29 2018

koobs updated the diff for D16315: www/moinmoin: Add recaptcha v2 and verifyemail support patches.

Lowercase RECAPTCHA_DESC

Jul 29 2018, 11:31 PM

Jul 25 2018

koobs committed rP475304: databases/py-pylibmc: Update to 1.5.2.
databases/py-pylibmc: Update to 1.5.2
Jul 25 2018, 10:18 AM
koobs committed rP475286: sysutils/py-diffoscope: Update to 99.
sysutils/py-diffoscope: Update to 99
Jul 25 2018, 12:23 AM
koobs committed rP475285: archivers/py-libarchive-c: Add LICENSE_FILE.
archivers/py-libarchive-c: Add LICENSE_FILE
Jul 25 2018, 12:14 AM
koobs committed rP475284: archivers/py-libarchive-c: Update to 2.8.
archivers/py-libarchive-c: Update to 2.8
Jul 25 2018, 12:09 AM

Jul 24 2018

koobs updated the summary of D16365: Update devel/libhtp to 0.5.27.
Jul 24 2018, 9:39 AM
koobs added a comment to D16365: Update devel/libhtp to 0.5.27.

@delphij Is that acceptance for approval to MFH ?

Sorry, yes it is for MFH. Consider it pre-approved as long as maintainer (@koobs) accepts.

Jul 24 2018, 9:39 AM
koobs added a comment to D16365: Update devel/libhtp to 0.5.27.

@delphij Is that acceptance for approval to MFH ?

Jul 24 2018, 4:49 AM
koobs requested changes to D16365: Update devel/libhtp to 0.5.27.
Jul 24 2018, 4:48 AM
koobs added a comment to D16365: Update devel/libhtp to 0.5.27.

Does this pass QA ?(testport for all supported freebsd versions/archs, make test)

Jul 24 2018, 2:34 AM
koobs updated the summary of D16365: Update devel/libhtp to 0.5.27.
Jul 24 2018, 2:33 AM

Jul 22 2018

koobs closed D15856: Update devel/py-pika to 0.11.2.

Not sure why the the review wasn't automatically closed, possibly because i had (based on) after the differential ID

Jul 22 2018, 11:27 AM
koobs committed rP475102: devel/py-pika: Update to 0.12.0.
devel/py-pika: Update to 0.12.0
Jul 22 2018, 11:24 AM
koobs accepted D15856: Update devel/py-pika to 0.11.2.

I have a WIP about to land, adding:

Jul 22 2018, 11:21 AM
koobs updated the test plan for D16378: lang/pypy and lang/pypy3: Fix rvmprof build on FreeBSD.
Jul 22 2018, 11:00 AM · Python
koobs added a comment to D16378: lang/pypy and lang/pypy3: Fix rvmprof build on FreeBSD.

Does the change pass QA (poudriere) on supported/expected FreeBSD versions/archs without regression?

Jul 22 2018, 11:00 AM · Python
koobs updated the summary of D16378: lang/pypy and lang/pypy3: Fix rvmprof build on FreeBSD.
Jul 22 2018, 10:59 AM · Python
koobs updated the summary of D16378: lang/pypy and lang/pypy3: Fix rvmprof build on FreeBSD.
Jul 22 2018, 10:58 AM · Python
koobs accepted D16367: devel/py-pytest-timeout: Update to 1.3.0.

Feel free to omit any - itemized changes lines that just describe 'what' the diff already shows. The whys (causes, rationales, explanations) are the important bits in the log message.

Jul 22 2018, 10:53 AM