Page MenuHomeFreeBSD

koobs (Kubilay Kocak)
User

Projects

User Details

User Since
May 22 2014, 10:41 AM (393 w, 18 h)

Recent Activity

Thu, Nov 18

koobs added a comment to D31945: libmd: Only define SHA256_Transform_c when using the ARM64 ifunc..

Thanks for tagging @kevans. The *SAN link failures and environment/build configuration are here: https://lists.freebsd.org/archives/freebsd-current/2021-September/000488.html

Thu, Nov 18, 1:50 AM
koobs requested changes to D32265: editors/texworks: Update to 0.6.6.
Thu, Nov 18, 1:30 AM
koobs updated the summary of D32265: editors/texworks: Update to 0.6.6.
Thu, Nov 18, 1:29 AM
koobs added a comment to D32264: devel/tex-synctex: Update to 1.21.0.

Also, explain files/patch-* removal (upstreamed? something else?) in the differential SUMMARY

Thu, Nov 18, 1:28 AM
koobs requested changes to D32264: devel/tex-synctex: Update to 1.21.0.
  1. as this change doesn't affect them to my understandings,
Thu, Nov 18, 1:28 AM
koobs updated the summary of D32264: devel/tex-synctex: Update to 1.21.0.
Thu, Nov 18, 1:23 AM
koobs added a comment to D32265: editors/texworks: Update to 0.6.6.

Acceptance pending QA confirmation (portlint, poudriere)

Thu, Nov 18, 1:20 AM
koobs updated the summary of D32265: editors/texworks: Update to 0.6.6.
Thu, Nov 18, 1:20 AM
koobs accepted D32776: [NEW] devel/texlab: Language Server Protocol for LaTeX.

Requesting review from rust

Thu, Nov 18, 1:18 AM
koobs retitled D32776: [NEW] devel/texlab: Language Server Protocol for LaTeX from [new port] devel/texlab: Language Server Protocol for LaTeX to [NEW] devel/texlab: Language Server Protocol for LaTeX.
Thu, Nov 18, 1:17 AM
koobs requested changes to D32031: graphics/py-wand: Add DOCS option Pass MAINTAINER'ship.
Thu, Nov 18, 1:10 AM
koobs added a comment to D32031: graphics/py-wand: Add DOCS option Pass MAINTAINER'ship.

Looks good, modulo adding numpy to TEST_DEPENDS

Thu, Nov 18, 1:10 AM

Fri, Nov 5

koobs reopened D25569: [NEW] deskutils/bookworm: Simple, focused ebook reader.
Fri, Nov 5, 11:39 PM
koobs requested changes to D32031: graphics/py-wand: Add DOCS option Pass MAINTAINER'ship.
Fri, Nov 5, 10:40 PM
koobs added a comment to D32031: graphics/py-wand: Add DOCS option Pass MAINTAINER'ship.

The package (sdist) ships with tests: In these cases add TEST_DEPENDS and a (do)-test target so runtime QA can be executed easily.

Fri, Nov 5, 10:40 PM
koobs added a comment to D32031: graphics/py-wand: Add DOCS option Pass MAINTAINER'ship.

Separately, I note upstream docs for installation on FreeBSD are outdated: https://docs.wand-py.org/en/0.6.7/guide/install.html#install-wand-on-freebsd

Fri, Nov 5, 10:22 PM
koobs retitled D32031: graphics/py-wand: Add DOCS option Pass MAINTAINER'ship from graphics/py-wand: Add docs, clean up Makefile, pass maintainership to graphics/py-wand: Add DOCS option Pass MAINTAINER'ship.
Fri, Nov 5, 10:20 PM
koobs updated subscribers of D32031: graphics/py-wand: Add DOCS option Pass MAINTAINER'ship.

Note: @sunpoet took maintainership in dc41320718b8

Fri, Nov 5, 10:18 PM
koobs added a comment to D32031: graphics/py-wand: Add DOCS option Pass MAINTAINER'ship.

Change DOCS_BUILD_DEPENDS to >=0
USES= python is the same as python:3.6+ ( https://cgit.freebsd.org/ports/tree/Mk/Uses/python.mk#n27 )

Fri, Nov 5, 10:12 PM
koobs added a comment to D32031: graphics/py-wand: Add DOCS option Pass MAINTAINER'ship.

fwiw, I see this at the end of the build but these errors seems to be bogus?

...
===> Creating unique files: Move MAN files needing SUFFIX
===> Creating unique files: Move files needing SUFFIX
====> Compressing man pages (compress-man)
Fri, Nov 5, 10:04 PM
koobs updated the summary of D32031: graphics/py-wand: Add DOCS option Pass MAINTAINER'ship.
Fri, Nov 5, 10:02 PM

Nov 3 2021

koobs retitled D32322: emulators/i386-wine{-devel}: Delete ports from emulators/i386-wine{-devel}: Delete portd to emulators/i386-wine{-devel}: Delete ports.
Nov 3 2021, 1:13 AM
koobs added a comment to D32322: emulators/i386-wine{-devel}: Delete ports.

Do emulators/wine and emulators/wine-devel in quarterly support i386? If so:

Nov 3 2021, 1:12 AM
koobs retitled D32322: emulators/i386-wine{-devel}: Delete ports from emulators/i386-wine & i386-wine-devel: Deletion to emulators/i386-wine{-devel}: Delete portd.
Nov 3 2021, 1:06 AM

Oct 25 2021

koobs added a comment to D32631: Create new man page sysctl_machdep(4) to document the machdep namespace.

Thanks Felix!

Oct 25 2021, 1:49 AM

Oct 16 2021

koobs updated the summary of D25569: [NEW] deskutils/bookworm: Simple, focused ebook reader.
Oct 16 2021, 12:49 AM
koobs retitled D25569: [NEW] deskutils/bookworm: Simple, focused ebook reader from deskutils/bookworm to [NEW] deskutils/bookworm: Simple, focused ebook reader.
Oct 16 2021, 12:49 AM

Oct 8 2021

koobs added a comment to D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..

Ping portmgr

Oct 8 2021, 8:26 AM
koobs requested changes to D31489: lang/python310: Introduce DTRACE option.
Oct 8 2021, 7:44 AM
koobs updated the summary of D31489: lang/python310: Introduce DTRACE option.
Oct 8 2021, 7:43 AM
koobs added a comment to D31119: games/lwjgl3: Lightweight Java Game Library 3.

Additionally: Should we move games/lwjgl to games/lwjgl2 leaving the portname open for this, or are both 2.x and 3.x going to be long-lived concurrent branches in the long-term?

Oct 8 2021, 7:37 AM
koobs requested changes to D31119: games/lwjgl3: Lightweight Java Game Library 3.
Oct 8 2021, 7:36 AM
koobs added a comment to D31119: games/lwjgl3: Lightweight Java Game Library 3.

Does lwjgl3 have a test suite? If so, it would be great to hook it up in a test target with TEST_DEPENDS where necessary

Oct 8 2021, 7:36 AM

Oct 5 2021

koobs added a comment to D29816: [NEW] games/runelite: Open source Old School RuneScape client.

Already accepted :) Nice work @Alexander88207_protonmail.com

Oct 5 2021, 11:43 PM

Oct 4 2021

koobs added a comment to D32281: security/py-cryptography: Add LibreSSL 3.4.0 support.

Thanks for this Charli

Oct 4 2021, 11:27 PM
koobs retitled D32281: security/py-cryptography: Add LibreSSL 3.4.0 support from security/py-cryptography: support LibreSSL 3.4.0 to security/py-cryptography: Add LibreSSL 3.4.0 support.
Oct 4 2021, 11:25 PM
koobs updated the summary of D32281: security/py-cryptography: Add LibreSSL 3.4.0 support.
Oct 4 2021, 11:25 PM

Oct 3 2021

koobs accepted D29816: [NEW] games/runelite: Open source Old School RuneScape client.
Oct 3 2021, 1:27 AM
koobs updated the summary of D29816: [NEW] games/runelite: Open source Old School RuneScape client.
Oct 3 2021, 12:56 AM
koobs added a comment to D29816: [NEW] games/runelite: Open source Old School RuneScape client.

Pending QA confirmation LGTM 👍

Oct 3 2021, 12:56 AM

Oct 2 2021

koobs added inline comments to D29816: [NEW] games/runelite: Open source Old School RuneScape client.
Oct 2 2021, 7:05 AM
koobs added inline comments to D29816: [NEW] games/runelite: Open source Old School RuneScape client.
Oct 2 2021, 6:09 AM
koobs added inline comments to D29816: [NEW] games/runelite: Open source Old School RuneScape client.
Oct 2 2021, 4:36 AM
koobs added inline comments to D29816: [NEW] games/runelite: Open source Old School RuneScape client.
Oct 2 2021, 2:01 AM

Oct 1 2021

koobs retitled D29816: [NEW] games/runelite: Open source Old School RuneScape client from New Port: games/runelite: Open source Old School RuneScape client to [NEW] games/runelite: Open source Old School RuneScape client.
Oct 1 2021, 5:27 AM
koobs requested changes to D29816: [NEW] games/runelite: Open source Old School RuneScape client.
  • Does this pass QA (portlint (and or portfmt) and poudriere?)
  • Replace hard-coded /usr/local with PREFIX [1]
Oct 1 2021, 5:27 AM

Sep 25 2021

koobs added a comment to D32140: devel/ruby-build: Update to 20210925.
  • Is the current SUMMARY the complete proposed commit log message?
    • Is this a bugfix release? Will it be MFH'd?
Sep 25 2021, 10:55 PM
koobs added a reviewer for D32140: devel/ruby-build: Update to 20210925: Contributor Reviewers (ports).
Sep 25 2021, 10:53 PM

Sep 6 2021

koobs retitled D31782: */py-dj31-*: Deprecate Django 3.1 ports and consumers from *: Deprecate Django 3.1 and its consumers to */py-dj31-*: Deprecate Django 3.1 ports and consumers.
Sep 6 2021, 8:52 AM
koobs updated the summary of D31783: lang/python36: Deprecate and set to expire.
Sep 6 2021, 8:50 AM
koobs accepted D31783: lang/python36: Deprecate and set to expire.
Sep 6 2021, 8:49 AM
koobs updated the summary of D31783: lang/python36: Deprecate and set to expire.
Sep 6 2021, 8:48 AM
koobs accepted D31782: */py-dj31-*: Deprecate Django 3.1 ports and consumers.
In D31782#718519, @kai wrote:

I'm -1 on a new/separate variable, and maintain that having an expiration date (end-of-life etc) being 'deprecated' (now) logically and semantically makes sense. The reason why porters handbook
says otherwise [1] is because these variables have ports/framework/implementation specific meanings, somewhat more overloaded than a pure metadata or only-descriptive definition. For example EXPIRATION_DATE is used to delete ports, where from a maintainer perspective, its valuable to be able to describe an end-of-life date at any time, all the way from port creation to the time its deleted. This would for example allow for automatic 'messages' to users as they 'approached' that date, progressively getting 'stronger' as they got closer.

[1] "It is possible to set DEPRECATED without an EXPIRATION_DATE (for instance, recommending a newer version of the port), but the converse does not make any sense."

Ah, ok, I got somewhat misled by the phrase I wonder what breaks if EXPIRATION_DATE is set without DEPRECATED. :) from https://reviews.freebsd.org/D30977#700968. :)

Of course, this makes sense, provided that an EoL date is known from upstream, to put it into DEPRECATED without an EXPIRATION_DATE in a timely manner. A new variable would then be completely superfluous.

Sep 6 2021, 8:47 AM
koobs added a comment to D31783: lang/python36: Deprecate and set to expire.
  • Use upstream language in messaging (this is distinct with ports descriptions/uses of variables)
  • 3.6 is currently in security 'maintenance status', and has an 'end-of-life' date of 2021-12-23
  • Link to upstream refs where they exist and are beneficial to the user
Sep 6 2021, 3:43 AM
koobs added a comment to D31782: */py-dj31-*: Deprecate Django 3.1 ports and consumers.

I'm -1 on a new/separate variable, and maintain that having an expiration date (end-of-life etc) being 'deprecated' (now) logically and semantically makes sense. The reason why porters handbook
says otherwise [1] is because these variables have ports/framework/implementation specific meanings, somewhat more overloaded than a pure metadata or only-descriptive definition. For example EXPIRATION_DATE is used to delete ports, where from a maintainer perspective, its valuable to be able to describe an end-of-life date at any time, all the way from port creation to the time its deleted. This would for example allow for automatic 'messages' to users as they 'approached' that date, progressively getting 'stronger' as they got closer.

Sep 6 2021, 3:37 AM
koobs requested changes to D31782: */py-dj31-*: Deprecate Django 3.1 ports and consumers.
  • Use terminology upstream uses
  • Link to the upstream url so users have details
  • Mention the EoL date(s) in the message
  • 'Has expired' is not accurate/correct semantically, particularly for a port that hasn't reached the EXPIRATION_DATE yet.
Sep 6 2021, 3:31 AM
koobs added a comment to D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..

Ping portmgr

Sep 6 2021, 1:01 AM

Aug 27 2021

koobs requested changes to D31434: Update mail/dovecot and mail/dovecot-pigeonhole.
Aug 27 2021, 3:57 AM

Aug 12 2021

koobs accepted D31264: emulators/virtualbox-ose: Update to 6.1.26.

No objections, lets just explicitly include/explain that in the commot log message, and include any upstream references (if they exist)

Aug 12 2021, 2:08 AM

Aug 11 2021

koobs updated subscribers of D31489: lang/python310: Introduce DTRACE option.
Aug 11 2021, 1:18 AM
koobs added reviewers for D31489: lang/python310: Introduce DTRACE option: Python, koobs.
Aug 11 2021, 1:18 AM
koobs added a comment to D31489: lang/python310: Introduce DTRACE option.

Forgot one other thing in previous review. dtrace has been an option in Python for a (long) while, and we would want to add this option across all relevent Python ports

Aug 11 2021, 1:17 AM

Aug 10 2021

koobs added inline comments to D31489: lang/python310: Introduce DTRACE option.
Aug 10 2021, 11:48 AM

Aug 9 2021

koobs added a comment to D31434: Update mail/dovecot and mail/dovecot-pigeonhole.

Question, are these the port changes logically related in some way, or need to be committed together, or just as a convenience in a single differential revision?

Aug 9 2021, 12:48 AM
koobs updated the summary of D31434: Update mail/dovecot and mail/dovecot-pigeonhole.
Aug 9 2021, 12:47 AM
koobs added inline comments to D31434: Update mail/dovecot and mail/dovecot-pigeonhole.
Aug 9 2021, 12:46 AM
koobs retitled D31434: Update mail/dovecot and mail/dovecot-pigeonhole from Update Dovecot & Pigeonhole to Update Dovecot, Pigeonhole, fts-xapian.
Aug 9 2021, 12:39 AM
koobs retitled D31434: Update mail/dovecot and mail/dovecot-pigeonhole from Dovecot update to Update Dovecot & Pigeonhole.
Aug 9 2021, 12:39 AM

Aug 7 2021

koobs added a comment to D31434: Update mail/dovecot and mail/dovecot-pigeonhole.

Format Summary like a well-formed commit log message, in this case two of them, and include QA in test plan section:

Aug 7 2021, 2:52 AM

Jul 31 2021

koobs added a comment to D31264: emulators/virtualbox-ose: Update to 6.1.26.

@madpilot Yep, sure, those are the things that just stood out to me as odd, or in need of improvement.

Jul 31 2021, 2:20 PM

Jul 30 2021

koobs added inline comments to D31264: emulators/virtualbox-ose: Update to 6.1.26.
Jul 30 2021, 11:58 PM

Jul 25 2021

koobs accepted D24324: Allow category_port_VARS= in make.conf for arbitrary per-port overrides..

Ping on portmgr

Jul 25 2021, 11:21 PM

Jul 22 2021

koobs updated the summary of D23803: devel/py-yaml: Rename to py-pyyaml.
Jul 22 2021, 1:48 AM
koobs accepted D23803: devel/py-yaml: Rename to py-pyyaml.
Jul 22 2021, 1:47 AM

Jul 20 2021

koobs requested changes to D23803: devel/py-yaml: Rename to py-pyyaml.

Thanks you for rebasing/updating this differential Derek. Minor update request (MOVED reason)

Jul 20 2021, 2:02 AM
koobs updated the summary of D23803: devel/py-yaml: Rename to py-pyyaml.
Jul 20 2021, 2:01 AM

Jul 19 2021

koobs added a comment to D10597: Intel iwm 8265 support.

man iwn shows the 8265 is now supported:

Jul 19 2021, 3:58 AM

Jul 12 2021

koobs added a comment to D30977: *: Create Django 3.2 ports for net-mgmt/netbox.

Apart from requiring new copies of django ports for each supported version, where proper django support in the framework would be preferred, the change good @kai

Jul 12 2021, 4:24 AM

Jul 11 2021

koobs added a comment to D31119: games/lwjgl3: Lightweight Java Game Library 3.

Note also that with poudriere you can easily test i386 (and other ARCHs) on an amd64 host, which uses jails. If you need help #freebsd-ports @ Libera IRC

Jul 11 2021, 10:35 AM
koobs retitled D31119: games/lwjgl3: Lightweight Java Game Library 3 from games/lwjgl3: New port to games/lwjgl3: Lightweight Java Game Library 3.
Jul 11 2021, 10:33 AM
koobs requested changes to D31119: games/lwjgl3: Lightweight Java Game Library 3.

@me_cameronkatri.com Could you provide this change (new port) as a diff against the existing games/lwjgl port and add a comment regarding patch-build.xml and why its necessary.

Jul 11 2021, 10:31 AM
koobs added a reviewer for D31119: games/lwjgl3: Lightweight Java Game Library 3: koobs.
Jul 11 2021, 10:25 AM

Jul 8 2021

koobs updated the summary of D31086: lang/python*: Replace DISABLED_EXTENSIONS with Setup.local.
Jul 8 2021, 1:45 AM
koobs accepted D31086: lang/python*: Replace DISABLED_EXTENSIONS with Setup.local.

@danilo 👍 just update the test plan section to mention those combinations that were tested

Jul 8 2021, 1:45 AM
koobs updated the summary of D31086: lang/python*: Replace DISABLED_EXTENSIONS with Setup.local.
Jul 8 2021, 1:44 AM

Jul 7 2021

koobs added a comment to D16863: [NEW PORT] devel/py-bumpversion: Version-bump your software with a single command.

@loader This can land if its all up to date (now that the shared options description change has landed)

Jul 7 2021, 2:47 AM
koobs requested changes to D23803: devel/py-yaml: Rename to py-pyyaml.

@dereks_lifeofadishwasher.com Can you check if this still applies and update it if necessary? @danilo is current maintainer and can handle resolution

Jul 7 2021, 2:46 AM
koobs updated the summary of D23803: devel/py-yaml: Rename to py-pyyaml.
Jul 7 2021, 2:45 AM
koobs added a comment to D31086: lang/python*: Replace DISABLED_EXTENSIONS with Setup.local.

Change looks good. Can we confirm successful QA for the three supported modules, by forcing BUILD_DEPENDS on them so it can be tested in poudriere

Jul 7 2021, 2:39 AM
koobs retitled D31086: lang/python*: Replace DISABLED_EXTENSIONS with Setup.local from lang/python*: Fix DISABLED_EXTENSIONS to lang/python*: Replace DISABLED_EXTENSIONS with Setup.local.
Jul 7 2021, 2:37 AM
koobs updated the summary of D31086: lang/python*: Replace DISABLED_EXTENSIONS with Setup.local.
Jul 7 2021, 2:32 AM
koobs added a reviewer for D31086: lang/python*: Replace DISABLED_EXTENSIONS with Setup.local: Python.
Jul 7 2021, 2:31 AM

Jul 2 2021

koobs retitled D30977: *: Create Django 3.2 ports for net-mgmt/netbox from *: Create some Django 3.2 ports for use with net-mgmt/netbox to *: Create Django 3.2 ports for net-mgmt/netbox.
Jul 2 2021, 2:45 AM
koobs updated the summary of D30977: *: Create Django 3.2 ports for net-mgmt/netbox.
Jul 2 2021, 2:45 AM

Jun 30 2021

koobs added a comment to D17459: Mk/bsd.options.desc.mk: Add version control systems OPTION descriptions.

@loader Thanks for adding everyone to review. Commit does not block on maintainer approval.

Jun 30 2021, 12:20 AM

Jun 29 2021

koobs added a comment to D17459: Mk/bsd.options.desc.mk: Add version control systems OPTION descriptions.

If you'd like, feel free to email maintainers privately as a heads up (in case they don't notice).

Jun 29 2021, 12:03 PM
koobs accepted D17459: Mk/bsd.options.desc.mk: Add version control systems OPTION descriptions.

I'm happy if you're happy. Ship it when ready :)

Jun 29 2021, 12:03 PM
koobs added a comment to D30475: lang/python310: add python 3.10.0.beta2.

Latest change from python39: https://gist.github.com/54c25485e2052743c6f8bdd85f56452e
Please state clearly which changes are still required to get this landed.

Jun 29 2021, 3:02 AM
koobs requested changes to D17459: Mk/bsd.options.desc.mk: Add version control systems OPTION descriptions.

All looks good, except:

Jun 29 2021, 2:53 AM
koobs updated the summary of D17459: Mk/bsd.options.desc.mk: Add version control systems OPTION descriptions.
Jun 29 2021, 2:35 AM