koobs (Kubilay Kocak)
User

Projects

User Details

User Since
May 22 2014, 10:41 AM (190 w, 6 d)

Recent Activity

Dec 15 2017

koobs added a comment to D12655: www/py-aiohttp: update to 2.3.1.

PR patch is otherwise approved (URL removed to this review).

Dec 15 2017, 7:29 AM
koobs requested changes to D12655: www/py-aiohttp: update to 2.3.1.

PR patch is an update to 2.3.6, this is an update to 2.3.6

Dec 15 2017, 7:29 AM
koobs accepted D12655: www/py-aiohttp: update to 2.3.1.

LGTM, apologies for the delay

Dec 15 2017, 7:26 AM

Dec 11 2017

koobs accepted D13435: textproc/py-parso: Python Parser.

Ideally add TEST_DEPENDS (pytest) and test (do-test) target to make running test suite for QA easy.

Dec 11 2017, 11:12 AM

Dec 8 2017

koobs accepted D13410: security/py-{acme,certbot}: update to 0.20.0.

LGTM, thank yoU! Please include Changelog: <url> in commit log message. I've updated the commit log message in the review SUMMARY section, just update it to include the URL

Dec 8 2017, 12:54 AM
koobs updated the summary of D13410: security/py-{acme,certbot}: update to 0.20.0.
Dec 8 2017, 12:53 AM
koobs updated the summary of D13410: security/py-{acme,certbot}: update to 0.20.0.
Dec 8 2017, 12:53 AM

Dec 7 2017

koobs requested changes to D13400: [new port] biology/p5-trimgalore: Wrapper around Cutadapt and FastQC for adapter and quality trimming.
Dec 7 2017, 1:13 AM

Nov 28 2017

koobs accepted D12499: devel/buildbot*: Rename all buildbot ports.

LGTM

Nov 28 2017, 10:13 AM
koobs updated the summary of D12499: devel/buildbot*: Rename all buildbot ports.
Nov 28 2017, 10:12 AM

Nov 8 2017

koobs added a comment to D12822: [NEW PORT] sysutils/py-superlance: Superlance plugins for supervisord.

Then superlance does not "support 3.x" in its current form and USES=2.7 is correct :)

Nov 8 2017, 7:29 AM
koobs requested changes to D12933: New port, www/qutebrowser: Keyboard-driven, vim-like browser based on PyQt5.
Nov 8 2017, 1:26 AM
koobs accepted D12822: [NEW PORT] sysutils/py-superlance: Superlance plugins for supervisord.

If supervisor is an actual (compulsory and version unconditional) dependency and it only supports 2.7, then the dependent package cannot by definition support anything other than 2.7

Nov 8 2017, 1:16 AM
koobs added a comment to D12970: sysutils/py-diffoscope: Update to 88.

Full URL's are not required

Nov 8 2017, 1:02 AM

Nov 7 2017

koobs requested changes to D12822: [NEW PORT] sysutils/py-superlance: Superlance plugins for supervisord.
Nov 7 2017, 3:51 PM
koobs accepted D12970: sysutils/py-diffoscope: Update to 88.

Looks good!

Nov 7 2017, 3:51 PM
koobs updated the test plan for D12970: sysutils/py-diffoscope: Update to 88.
Nov 7 2017, 3:51 PM

Nov 6 2017

koobs added a comment to D12965: New Port: net/czmq4: High-level C Binding for ZeroMQ (Version 4).

Is there a reason to add the port, rather than update net/czmq?

Nov 6 2017, 1:35 AM

Nov 3 2017

koobs requested changes to D12499: devel/buildbot*: Rename all buildbot ports.
Nov 3 2017, 12:35 AM
koobs updated the summary of D12499: devel/buildbot*: Rename all buildbot ports.
Nov 3 2017, 12:35 AM
koobs retitled D12499: devel/buildbot*: Rename all buildbot ports from devel/buildbot -> devel/py-buildbot: Rename to devel/buildbot*: Rename all buildbot ports.
Nov 3 2017, 12:33 AM

Oct 29 2017

koobs committed rP453089: finance/py-stripe: Revert (part of) r426059.
finance/py-stripe: Revert (part of) r426059
Oct 29 2017, 4:03 AM

Oct 26 2017

koobs committed rP452916: www/py-tvdb_api: Add missing dependencies.
www/py-tvdb_api: Add missing dependencies
Oct 26 2017, 11:36 AM
koobs committed rP452915: [NEW] www/py-requests-cache: Persistent cache for requests library.
[NEW] www/py-requests-cache: Persistent cache for requests library
Oct 26 2017, 11:34 AM

Oct 22 2017

koobs accepted D12482: security/py-{acme,certbot}: update to 0.19.0.
Oct 22 2017, 11:18 PM

Oct 16 2017

koobs committed rP452177: security/openssh-portable: Remove groff dependency.
security/openssh-portable: Remove groff dependency
Oct 16 2017, 7:26 AM
koobs closed D11793: security/openssh-portable: Remove groff dependency.
Oct 16 2017, 7:26 AM
koobs updated the summary of D11793: security/openssh-portable: Remove groff dependency.
Oct 16 2017, 7:22 AM

Oct 11 2017

koobs committed rP451723: www/py-gandi.cli: Update to 1.0.
www/py-gandi.cli: Update to 1.0
Oct 11 2017, 12:13 AM

Sep 29 2017

koobs added a comment to D12479: devel/buildbot*: Update to 0.9.11, Add.

@koobs why wasn't this review updated after I committed rP450642 ?

Sep 29 2017, 2:17 PM
koobs added inline comments to D12499: devel/buildbot*: Rename all buildbot ports.
Sep 29 2017, 2:15 PM
koobs requested changes to D12519: [NEW PORT] devel/py-subprocess32: Backport of the subprocess module from Python 3.2 & 3.3.
Sep 29 2017, 2:11 PM
koobs updated the summary of D12519: [NEW PORT] devel/py-subprocess32: Backport of the subprocess module from Python 3.2 & 3.3.
Sep 29 2017, 2:11 PM

Sep 27 2017

koobs updated the summary of D12328: sysutils/py-diffoscope: Update to 86.
Sep 27 2017, 6:29 AM
koobs accepted D12328: sysutils/py-diffoscope: Update to 86.

LGTM, nice work!

Sep 27 2017, 6:29 AM
koobs updated the test plan for D12328: sysutils/py-diffoscope: Update to 86.
Sep 27 2017, 6:28 AM
koobs added a comment to D12328: sysutils/py-diffoscope: Update to 86.

@ygy Output looks fine (generally, look for warnings or exits with a failure/fatal error to identify issues)

Sep 27 2017, 4:30 AM

Sep 26 2017

koobs requested changes to D12499: devel/buildbot*: Rename all buildbot ports.

All ports:

Sep 26 2017, 6:24 AM

Sep 25 2017

koobs committed rP450619: www/py-yarl: Update to 0.12.0.
www/py-yarl: Update to 0.12.0
Sep 25 2017, 4:20 PM
koobs requested changes to D12475: security/py-libnacl: Update to 1.5.2.

Can you confirm portlint/maketest is OK (ive updated TEST PLAN section for those results)

Sep 25 2017, 4:14 PM
koobs retitled D12475: security/py-libnacl: Update to 1.5.2 from security/py-libnacl: update to upstream version 1.5.2 to security/py-libnacl: Update to 1.5.2.
Sep 25 2017, 4:12 PM
koobs committed rP450578: security/py-openssl: Fix RUN_DEPENDS.
security/py-openssl: Fix RUN_DEPENDS
Sep 25 2017, 9:22 AM
koobs committed rP450577: security/py-{acme,certbot}: Update to 0.18.2.
security/py-{acme,certbot}: Update to 0.18.2
Sep 25 2017, 9:10 AM

Sep 24 2017

koobs committed rP450479: security/py-cryptography: Update to 2.0.3.
security/py-cryptography: Update to 2.0.3
Sep 24 2017, 5:01 AM
koobs added a comment to D12479: devel/buildbot*: Update to 0.9.11, Add.

If the 4 failing look like false positives, non-trivial or non-concerning, feel free to defer (Disclaimer: I am not MAINTAINER yet)

Sep 24 2017, 3:49 AM
koobs added a comment to D12479: devel/buildbot*: Update to 0.9.11, Add.

If @grembo is happy with (solely) my review and doesn't have time, he can just accept, in which case, I'm happy for this to land pending:

Sep 24 2017, 3:02 AM
koobs retitled D12479: devel/buildbot*: Update to 0.9.11, Add from devel/buildbot*: Update to 0.9.11, Add buildbot-grid-view to devel/buildbot*: Update to 0.9.11, Add.
Sep 24 2017, 2:58 AM
koobs added 1 blocking reviewer(s) for D12479: devel/buildbot*: Update to 0.9.11, Add: grembo.
Sep 24 2017, 2:48 AM
koobs accepted D12479: devel/buildbot*: Update to 0.9.11, Add.

Missed this due to log output:

Sep 24 2017, 2:48 AM
koobs updated the test plan for D12479: devel/buildbot*: Update to 0.9.11, Add.
Sep 24 2017, 2:47 AM
koobs added a comment to D12479: devel/buildbot*: Update to 0.9.11, Add.

This looks OK to land, unless the gridview port addition can be made in a separate commit (preferred), either before this commit if it supports the current port version, or after if it requires 0.9.11.

Sep 24 2017, 2:43 AM
koobs added a comment to D12479: devel/buildbot*: Update to 0.9.11, Add.

@rodrigc Thanks for the detail, though logs aren't explicitly sought (at least by me :])

Sep 24 2017, 2:40 AM
koobs added a comment to D12479: devel/buildbot*: Update to 0.9.11, Add.

Also, can gridview be added separately (after landing 0.9.11), or does 0.9.11 require it?

Sep 24 2017, 2:03 AM
koobs added a comment to D12479: devel/buildbot*: Update to 0.9.11, Add.

Lastly, and this has been coming a long-time, but buildbot* ports have been non-compliance with Python packages since their birth:

Sep 24 2017, 12:45 AM
koobs added a comment to D12479: devel/buildbot*: Update to 0.9.11, Add.

test target (for Python packages) should invoke a specific version of Python, by whatever method, rather than LOCALBASE scripts, which can/may point to any (and incorrect) Python versions at any time.

Sep 24 2017, 12:39 AM
koobs requested changes to D12479: devel/buildbot*: Update to 0.9.11, Add.

Could you please add change of maintainer to MAINTAINER=koobs@f.o (per Bugzilla #220564 Comment 10)

Sep 24 2017, 12:36 AM
koobs updated the summary of D12479: devel/buildbot*: Update to 0.9.11, Add.
Sep 24 2017, 12:35 AM
koobs retitled D12479: devel/buildbot*: Update to 0.9.11, Add from Update buildbot to 0.9.11 and add buildbot-grid-view to devel/buildbot*: Update to 0.9.11, Add buildbot-grid-view.
Sep 24 2017, 12:34 AM
koobs updated the summary of D12478: Update to Twisted 17.9.0.
Sep 24 2017, 12:00 AM

Sep 18 2017

koobs updated the summary of D12399: net/flower: Update to 0.10.
Sep 18 2017, 3:11 AM
koobs accepted D12399: net/flower: Update to 0.10.

Looks fine if it passes QA

Sep 18 2017, 3:11 AM
koobs retitled D12399: net/flower: Update to 0.10 from Upgrade Flower to the latest upstream version, 0.10. to net/flower: Update to 0.10.
Sep 18 2017, 3:10 AM

Sep 17 2017

koobs accepted D12394: [NEW PORT] devel/py-pytest-cov: Pytest plugin for measuring coverage.
Sep 17 2017, 5:29 AM
koobs accepted D12319: [NEW PORT] graphics/py-graphviz: Simple Python interface for Graphviz.

Always add test/QA results to TEST PLAN (so people don't need to go searching for them)

Sep 17 2017, 5:27 AM
koobs retitled D12319: [NEW PORT] graphics/py-graphviz: Simple Python interface for Graphviz from New port graphics/py-graphviz (Already existed) to [NEW PORT] graphics/py-graphviz: Simple Python interface for Graphviz.
Sep 17 2017, 5:25 AM
koobs committed rP449985: MOVED/UPDATING: Improve cmake-modules entries.
MOVED/UPDATING: Improve cmake-modules entries
Sep 17 2017, 5:22 AM

Sep 16 2017

koobs committed rP449941: sysutils/py-supervisor: Update to 3.3.3.
sysutils/py-supervisor: Update to 3.3.3
Sep 16 2017, 3:59 AM

Sep 15 2017

koobs committed rP449906: www/py-gandi.cli: Update to 0.22.
www/py-gandi.cli: Update to 0.22
Sep 15 2017, 3:19 PM

Sep 13 2017

koobs accepted D12362: security/py-{acme,certbot}: update to 0.18.1.

Looks good, nice commit log message. ship it :)

Sep 13 2017, 11:32 PM
koobs updated the summary of D12362: security/py-{acme,certbot}: update to 0.18.1.
Sep 13 2017, 11:31 PM
koobs updated the summary of D12362: security/py-{acme,certbot}: update to 0.18.1.
Sep 13 2017, 11:30 PM
koobs added a comment to D12328: sysutils/py-diffoscope: Update to 86.

This may be a perl ports framework issue or bug, as the port dependency is declared and satisfied at the first minor version > 5.24 < 5.25 level, but the framework (configure) target uses an exact build version (5.24.2) level to check for perl. There are some similar (recent, June, July, August) google results for the same error, for mytop, firefox, chromium and other ports.

Sep 13 2017, 11:28 PM

Sep 12 2017

koobs added a comment to D12328: sysutils/py-diffoscope: Update to 86.

I added some details (to the TEST PLAN section of the review) of what needs to be tested (portlint, poudriere, make test). Just edit the review and add the results.

Sep 12 2017, 1:14 PM
koobs requested changes to D12328: sysutils/py-diffoscope: Update to 86.

Syntactically looks OK. Please confirm QA results/OK in TEST PLAN section

Sep 12 2017, 9:10 AM
koobs retitled D12328: sysutils/py-diffoscope: Update to 86 from Update sysutils/py-diffoscope to version 86 to sysutils/py-diffoscope: Update to 86.
Sep 12 2017, 9:09 AM
koobs committed rP449679: www/py-gandi.cli: Update to 0.21.
www/py-gandi.cli: Update to 0.21
Sep 12 2017, 9:05 AM

Sep 11 2017

koobs added a comment to D12309: [NEW PORT] audio/py-opuslib: Python bindings to the libopus, IETF low-delay audio codec.

Approved, obviously pending SUBDIR addition to category/Makefile

Sep 11 2017, 1:07 PM
koobs accepted D12309: [NEW PORT] audio/py-opuslib: Python bindings to the libopus, IETF low-delay audio codec.

@ultima Thanks for clarifying. Not a blocker for commit, but ask upstream (or ask maintainer to ask upstream) to add tests/test files to the source distribution. This usually takes the form of adding entries to MANIFEST.in to include the files/dirs.

Sep 11 2017, 1:07 PM
koobs added a comment to D12312: [NEW PORT] net-im/py-unmessage: Privacy enhanced instant messenger.

Missing SUBDIR addition to category/Makefile in changeset

New port needs entries in the category Makefile. Other than that, this looks fine.

I was planning on using the Tools/scripts/addport script to add the port which automatically adds this bit. Is this acceptable or does it require to be in the Phabricator differential?

Sep 11 2017, 12:59 PM
koobs added dependencies for D12312: [NEW PORT] net-im/py-unmessage: Privacy enhanced instant messenger: D12309: [NEW PORT] audio/py-opuslib: Python bindings to the libopus, IETF low-delay audio codec, D12310: [NEW PORT] security/py-pyaxo: Python implementation of the Axolotl ratchet protocol, D12311: [NEW PORT] security/py-txtorcon: Twisted-based Tor controller client.
Sep 11 2017, 12:57 PM
koobs added a dependent revision for D12311: [NEW PORT] security/py-txtorcon: Twisted-based Tor controller client: D12312: [NEW PORT] net-im/py-unmessage: Privacy enhanced instant messenger.
Sep 11 2017, 12:57 PM
koobs added a dependent revision for D12309: [NEW PORT] audio/py-opuslib: Python bindings to the libopus, IETF low-delay audio codec: D12312: [NEW PORT] net-im/py-unmessage: Privacy enhanced instant messenger.
Sep 11 2017, 12:57 PM
koobs added a dependent revision for D12310: [NEW PORT] security/py-pyaxo: Python implementation of the Axolotl ratchet protocol: D12312: [NEW PORT] net-im/py-unmessage: Privacy enhanced instant messenger.
Sep 11 2017, 12:57 PM
koobs requested changes to D12319: [NEW PORT] graphics/py-graphviz: Simple Python interface for Graphviz.

Removing a MOVED entry for a re-added (resurrected) port is standard/expected.

Sep 11 2017, 12:44 PM
koobs updated the summary of D12319: [NEW PORT] graphics/py-graphviz: Simple Python interface for Graphviz.
Sep 11 2017, 12:33 PM
koobs requested changes to D12312: [NEW PORT] net-im/py-unmessage: Privacy enhanced instant messenger.

Missing SUBDIR addition to category/Makefile in changeset

Sep 11 2017, 5:51 AM
koobs requested changes to D12311: [NEW PORT] security/py-txtorcon: Twisted-based Tor controller client.

Missing SUBDIR addition to category/Makefile in changeset

Sep 11 2017, 5:49 AM
koobs accepted D12310: [NEW PORT] security/py-pyaxo: Python implementation of the Axolotl ratchet protocol.

USES=python implies this package supports and has been tested with Python 3.x, however upstream trove classifiers do not explicitly mention which versions are supported, and packaging (poudriere) tests for Python 3.x are not apparent in TEST PLAN

Sep 11 2017, 5:47 AM
koobs requested changes to D12309: [NEW PORT] audio/py-opuslib: Python bindings to the libopus, IETF low-delay audio codec.
Sep 11 2017, 5:44 AM
koobs accepted D11677: New port: devel/py-cdg.
Sep 11 2017, 5:41 AM
koobs accepted D12198: mail/py-pymailq: Update to 0.8.0.

For any python package that allows/supports Python 3.x in the port, packaging tests/QA with Python 3.x are super handy.

Sep 11 2017, 5:38 AM

Aug 28 2017

koobs accepted D12068: Add py3-* packages for toposort and pyPEG2..

Looks OK, pending confirmation that port passes QA (poudriere w/ Python 3.x)

Aug 28 2017, 3:32 AM

Aug 21 2017

koobs committed rP448461: MFH: r448460.
MFH: r448460
Aug 21 2017, 10:38 AM
koobs committed rP448460: net/czmq: Squash -Werror flag.
net/czmq: Squash -Werror flag
Aug 21 2017, 10:36 AM

Aug 20 2017

koobs committed rP448376: net/libzmq4: Update to 4.2.2.
net/libzmq4: Update to 4.2.2
Aug 20 2017, 11:58 AM
koobs committed rP448355: MFH: r448354.
MFH: r448354
Aug 20 2017, 3:16 AM
koobs committed rP448354: devel/py-extras: Fix Python 3.x packaging.
devel/py-extras: Fix Python 3.x packaging
Aug 20 2017, 3:12 AM

Aug 19 2017

koobs committed rP448306: MFH: r448305.
MFH: r448305
Aug 19 2017, 12:54 PM
koobs committed rP448305: net/py-pcs: Limit USES=python (actually).
net/py-pcs: Limit USES=python (actually)
Aug 19 2017, 12:52 PM
koobs committed rP448304: MFH: r448303.
MFH: r448303
Aug 19 2017, 12:44 PM