Page MenuHomeFreeBSD

koobs (Kubilay Kocak)
User

Projects

User Details

User Since
May 22 2014, 10:41 AM (445 w, 5 d)

Recent Activity

Wed, Nov 30

koobs added a comment to D33918: bsdinstall: Add quotes around error message argument.

Did this end up being EN'd for currently supported RELEASE's ?

Wed, Nov 30, 9:57 PM

Oct 29 2022

koobs added a comment to D37047: lang/python27: Fix build with libressl 3.5.

Do any other lang/python* ports need similar treatment?

Oct 29 2022, 4:34 AM

Oct 18 2022

koobs added a comment to D34388: [NEW] mail/py-offlineimap3: Two-way synchronization of local Maildir and IMAP folders.

@dereks_lifeofadishwasher.com Can we the/an existing version format that upstream uses (vX.Y.Z), optionally suffixed appropriately with relevent git tag if its 'in between versions' ?

Oct 18 2022, 11:09 PM · Python

Sep 30 2022

koobs added a comment to D36620: Remove telnetd.

Could you list deprecation/removal here please: https://wiki.freebsd.org/DeprecationPlan

Sep 30 2022, 1:20 AM

Jun 22 2022

koobs requested changes to D35506: [NEW] devel/awscli2: Universal Command Line Interface for Amazon Web Services V2.

Apart from inline review items to address:

Jun 22 2022, 1:22 AM
koobs updated the summary of D35506: [NEW] devel/awscli2: Universal Command Line Interface for Amazon Web Services V2.
Jun 22 2022, 1:20 AM
koobs updated the summary of D35506: [NEW] devel/awscli2: Universal Command Line Interface for Amazon Web Services V2.
Jun 22 2022, 1:19 AM
koobs retitled D35506: [NEW] devel/awscli2: Universal Command Line Interface for Amazon Web Services V2 from [NEW]: devel/awscli2: Universal Command Line Interface for Amazon Web Services V2 to [NEW] devel/awscli2: Universal Command Line Interface for Amazon Web Services V2.
Jun 22 2022, 1:18 AM
koobs retitled D35506: [NEW] devel/awscli2: Universal Command Line Interface for Amazon Web Services V2 from [NEW]: devel/awscli2: AWS CLI version 2 to [NEW]: devel/awscli2: Universal Command Line Interface for Amazon Web Services V2.
Jun 22 2022, 1:17 AM
koobs retitled D35506: [NEW] devel/awscli2: Universal Command Line Interface for Amazon Web Services V2 from devel/awscli2: New Port: AWS CLI version 2 to [NEW]: devel/awscli2: AWS CLI version 2.
Jun 22 2022, 1:17 AM
koobs added a comment to D35506: [NEW] devel/awscli2: Universal Command Line Interface for Amazon Web Services V2.
  • the noflavors was copied. I though this meant just one package using the default Python version so upgrades automatically each time a new Python is made as default. unlike Ansible which has to be deleted and reinstalled each time Python changes
Jun 22 2022, 1:16 AM
koobs added a comment to D35506: [NEW] devel/awscli2: Universal Command Line Interface for Amazon Web Services V2.

my understanding is:

  • that V1.x support will continue and be available PyPi
  • V2.x will not be available on PyPI but via a binary download from Amazon Currently only Mac/Win/Linux Installers are available
  • V2.x uses different auth API which is why I chose awscli2 to avoid confusion if someone upgraded an existing awscli then they would be get authentication failures
  • the noflavors was copied. I though this meant just one package using the default Python version so upgrades automatically each time a new Python is made as default. unlike Ansible which has to be deleted and reinstalled each time Python changes

Would you look at my revisions and let me know where improvements can be made.
Thanks

Jun 22 2022, 12:50 AM

Jun 19 2022

koobs added inline comments to D35513: [WIP] Adding devel/py-threadpoolctl.
Jun 19 2022, 12:35 AM
koobs added inline comments to D35513: [WIP] Adding devel/py-threadpoolctl.
Jun 19 2022, 12:34 AM

Jun 18 2022

koobs added inline comments to D35513: [WIP] Adding devel/py-threadpoolctl.
Jun 18 2022, 3:06 AM
koobs requested changes to D35506: [NEW] devel/awscli2: Universal Command Line Interface for Amazon Web Services V2.
Jun 18 2022, 2:49 AM

Jun 6 2022

koobs accepted D34389: [NEW] mail/py-rfc6555: Happy Eyeballs Algorithm described in RFC 6555.

LGTM mate, nice work!

Jun 6 2022, 1:21 AM · Python
koobs added a comment to D34389: [NEW] mail/py-rfc6555: Happy Eyeballs Algorithm described in RFC 6555.

As expected. I do USES -> USE_* -> *_FOO, but wont block review on that.

Jun 6 2022, 1:04 AM · Python

Jun 5 2022

koobs requested changes to D35404: [NEW PORT] textproc/cpptoml: Header-only C++ library for parsing TOML.
  • Minor categories update
  • Does this pass QA? I've added TEST PLAN items
Jun 5 2022, 11:17 PM
koobs updated the summary of D35404: [NEW PORT] textproc/cpptoml: Header-only C++ library for parsing TOML.
Jun 5 2022, 11:13 PM
koobs updated the summary of D35404: [NEW PORT] textproc/cpptoml: Header-only C++ library for parsing TOML.
Jun 5 2022, 11:13 PM
koobs retitled D35404: [NEW PORT] textproc/cpptoml: Header-only C++ library for parsing TOML from Add cpptoml to [NEW PORT] textproc/cpptoml: Header-only C++ library for parsing TOML.
Jun 5 2022, 11:12 PM
koobs requested changes to D34389: [NEW] mail/py-rfc6555: Happy Eyeballs Algorithm described in RFC 6555.
Jun 5 2022, 11:11 PM · Python

May 27 2022

koobs added a comment to D34079: [WIP] sysutils/fusefs-ntfs: Update to 2021.8.22.

Alexey, This diff is not not a ports commit proposal, as should be clear from the diff summary (WIP) and description:

May 27 2022, 1:39 AM

May 25 2022

koobs added reviewers for D27411: add altlog_jaillist to syslogd's rc script: kevans, yuripv, 0mp.

Add previous reviewers to ... Reviewers: as this ... needs review :)

May 25 2022, 11:47 PM · manpages, rc

May 22 2022

koobs requested changes to D35282: lang/python310: Add OPTIONS for: editline, ports editline, ports readline or none.

Thanks for this Piotr.

May 22 2022, 1:20 AM
koobs retitled D35282: lang/python310: Add OPTIONS for: editline, ports editline, ports readline or none from python310: give choice between base editline, ports editline, ports readline or none to lang/python310: Add OPTIONS for: editline, ports editline, ports readline or none.
May 22 2022, 1:12 AM
koobs added a reviewer for D35282: lang/python310: Add OPTIONS for: editline, ports editline, ports readline or none: Python.
May 22 2022, 1:12 AM

May 17 2022

koobs requested changes to D35226: www/py-caldav: Update to 0.9.0.
May 17 2022, 1:07 AM
koobs updated the test plan for D35226: www/py-caldav: Update to 0.9.0.
May 17 2022, 1:06 AM
koobs added inline comments to D35226: www/py-caldav: Update to 0.9.0.
May 17 2022, 1:05 AM
koobs updated the summary of D35226: www/py-caldav: Update to 0.9.0.
May 17 2022, 12:50 AM

May 13 2022

koobs accepted D33677: Mention vendor driver for if_re.

LGTM ship and merge it!

May 13 2022, 6:16 AM

Apr 25 2022

koobs abandoned D20817: editors/micro: Add (experimental) AUTOCOMPLETE option.

Upstream PR closed in favour of chasing LSP support:

Apr 25 2022, 1:05 AM

Apr 20 2022

koobs accepted D34859: www/py-django32: Switch consumers over to Django 3.2.
Apr 20 2022, 11:50 PM

Apr 18 2022

koobs added a comment to D34859: www/py-django32: Switch consumers over to Django 3.2.

What is the impact on those remaining port without Django 3.2 support after this change lands?

Apr 18 2022, 10:35 PM

Apr 9 2022

koobs accepted D34851: graphics/zathura: Update to 0.4.9.

LGTM

Apr 9 2022, 11:23 PM
koobs updated the summary of D34851: graphics/zathura: Update to 0.4.9.
Apr 9 2022, 11:23 PM
koobs requested changes to D34851: graphics/zathura: Update to 0.4.9.

After *_DEPENDS change, re-QA via poudriere to confirm dependency availability at build and run time.

Apr 9 2022, 12:17 AM
koobs added inline comments to D34851: graphics/zathura: Update to 0.4.9.
Apr 9 2022, 12:16 AM
koobs added inline comments to D34851: graphics/zathura: Update to 0.4.9.
Apr 9 2022, 12:02 AM
koobs added inline comments to D34851: graphics/zathura: Update to 0.4.9.
Apr 9 2022, 12:00 AM

Apr 8 2022

koobs updated the test plan for D34851: graphics/zathura: Update to 0.4.9.
Apr 8 2022, 11:58 PM
koobs accepted D34816: sysutils/dust: Update to v0.8.0.
Apr 8 2022, 11:54 PM
koobs updated the summary of D34816: sysutils/dust: Update to v0.8.0.
Apr 8 2022, 11:44 PM
koobs updated the summary of D34816: sysutils/dust: Update to v0.8.0.
Apr 8 2022, 11:43 PM
koobs updated the summary of D32265: editors/texworks: Update to 0.6.7.
Apr 8 2022, 11:41 PM
koobs accepted D32265: editors/texworks: Update to 0.6.7.

Add changelog link to commit log message.

Apr 8 2022, 11:40 PM
koobs updated the summary of D32265: editors/texworks: Update to 0.6.7.
Apr 8 2022, 11:40 PM
koobs accepted D34817: www/vultr-cli: Update to v2.12.2.

LGTM 👍

Apr 8 2022, 11:39 PM
koobs updated the summary of D34817: www/vultr-cli: Update to v2.12.2.
Apr 8 2022, 11:37 PM
koobs requested changes to D32266: graphics/zathura: Update to 0.4.8, Add SyncTeX support.
Apr 8 2022, 2:14 AM
koobs added a comment to D32265: editors/texworks: Update to 0.6.7.

Loop in folks involved in the recent text update

Apr 8 2022, 2:11 AM
koobs added reviewers for D32265: editors/texworks: Update to 0.6.7: tcberner, bofh, trond.endrestol_ximalas.info.
Apr 8 2022, 2:11 AM
koobs requested changes to D32265: editors/texworks: Update to 0.6.7.

Pending QA confirm on Python.

Apr 8 2022, 2:10 AM
koobs accepted D32264: devel/tex-synctex: Update to 1.21.0.

Include a note in commit log message that you're bumping dependent ports PORTREVISIONS due to shared library major version increase

Apr 8 2022, 2:07 AM
koobs added a comment to D32264: devel/tex-synctex: Update to 1.21.0.

Loop in people involved in recent text update

Apr 8 2022, 2:05 AM
koobs added reviewers for D32264: devel/tex-synctex: Update to 1.21.0: bofh, tcberner, trond.endrestol_ximalas.info.
Apr 8 2022, 2:05 AM
koobs accepted D34818: devel/wrangler: Update to v1.19.11.

Looks fine, add <Reason> to MFH

Apr 8 2022, 2:02 AM
koobs updated the test plan for D34818: devel/wrangler: Update to v1.19.11.
Apr 8 2022, 2:01 AM
koobs updated the summary of D34818: devel/wrangler: Update to v1.19.11.
Apr 8 2022, 2:01 AM
koobs added a comment to D34816: sysutils/dust: Update to v0.8.0.

Missing: Reviewed_by, Differential Revision and MFH attributes in SUMMARY

Apr 8 2022, 2:00 AM
koobs added a comment to D34817: www/vultr-cli: Update to v2.12.2.

Add (reason) to MFH line, so its clear to committers why

Apr 8 2022, 1:59 AM
koobs updated the summary of D34817: www/vultr-cli: Update to v2.12.2.
Apr 8 2022, 1:58 AM
koobs requested changes to D34816: sysutils/dust: Update to v0.8.0.

I don't understand the why/description in commit log message.

Apr 8 2022, 1:58 AM
koobs updated the summary of D34816: sysutils/dust: Update to v0.8.0.
Apr 8 2022, 1:56 AM

Mar 5 2022

koobs added inline comments to D34388: [NEW] mail/py-offlineimap3: Two-way synchronization of local Maildir and IMAP folders.
Mar 5 2022, 12:01 AM · Python

Mar 4 2022

koobs added inline comments to D34388: [NEW] mail/py-offlineimap3: Two-way synchronization of local Maildir and IMAP folders.
Mar 4 2022, 11:59 PM · Python

Mar 2 2022

koobs requested changes to D34388: [NEW] mail/py-offlineimap3: Two-way synchronization of local Maildir and IMAP folders.
  • Add TEST_DEPENDS and (do-)test target
  • Confirm QA (Added to TEST PLAN section)
Mar 2 2022, 11:00 PM · Python
koobs retitled D34388: [NEW] mail/py-offlineimap3: Two-way synchronization of local Maildir and IMAP folders from mail/py-offlineimap3: New port mail/py-offlineimap3 to [NEW] mail/py-offlineimap3: Two-way synchronization of local Maildir and IMAP folders.
Mar 2 2022, 10:37 PM · Python
koobs requested changes to D34389: [NEW] mail/py-rfc6555: Happy Eyeballs Algorithm described in RFC 6555.
  • Add TEST_DEPENDS and (do-)test target for QA
  • Need confirmation of QA in TEST PLAN
Mar 2 2022, 10:35 PM · Python
koobs retitled D34389: [NEW] mail/py-rfc6555: Happy Eyeballs Algorithm described in RFC 6555 from mail/py-rfc6555: New port mail/py-rfc6555 to [NEW] mail/py-rfc6555: Happy Eyeballs Algorithm described in RFC 6555.
Mar 2 2022, 10:33 PM · Python
koobs retitled D34390: [NEW] mail/py-imaplib2: Threaded Python IMAP4 client from [NEW[ mail/py-imaplib2: Threaded Python IMAP4 client to [NEW] mail/py-imaplib2: Threaded Python IMAP4 client.
Mar 2 2022, 10:30 PM
koobs added a comment to D34390: [NEW] mail/py-imaplib2: Threaded Python IMAP4 client.

You're correct the tests dir is not included in the sdist. However, those test are just to import the module. Maybe to test future absolute_import? I don't know how much value this would add. If you still think this is a good idea I can ask to include tests.

Mar 2 2022, 12:15 AM
koobs added a comment to D34390: [NEW] mail/py-imaplib2: Threaded Python IMAP4 client.

You're correct the tests dir is not included in the sdist. However, those test are just to import the module. Maybe to test future absolute_import? I don't know how much value this would add. If you still think this is a good idea I can ask to include tests.

Mar 2 2022, 12:14 AM

Mar 1 2022

koobs requested changes to D34390: [NEW] mail/py-imaplib2: Threaded Python IMAP4 client.
  • Upstream has a test suite. Add TEST_DEPENDS and (do-)test target for comprehensive and easy QA. If the PyPI sdist doesnt ship the tests, use github and ask upstream to package tests and test files for downstreams to use and reference. Don't depend or use tox, just run pytest directly. See existing ports for invocations. Add test results to maketest: in TEST PLAN section of this diff
  • Upstream declares python_requires = >=3.6 but also Programming Language :: Python :: 3.9. 3.10 is in the tree, and USES=python:<version-spec> should be capped to the versions it supports (and works and is tested with). Upstream (tox.ini) only CI's with envlist = py{36,37,38,39}. Ask upstream to add 3.10 and run tests with it. If it passes, leave <version-spec> uncapped, otherwise, cap it at 3.6-3.9
Mar 1 2022, 2:21 AM
koobs updated the test plan for D34390: [NEW] mail/py-imaplib2: Threaded Python IMAP4 client.
Mar 1 2022, 2:04 AM
koobs retitled D34390: [NEW] mail/py-imaplib2: Threaded Python IMAP4 client from mail/py-imaplib2: New port mail/py-imaplib2 to [NEW[ mail/py-imaplib2: Threaded Python IMAP4 client.
Mar 1 2022, 2:04 AM

Feb 25 2022

koobs added inline comments to D34079: [WIP] sysutils/fusefs-ntfs: Update to 2021.8.22.
Feb 25 2022, 11:15 PM

Jan 28 2022

koobs updated the diff for D34079: [WIP] sysutils/fusefs-ntfs: Update to 2021.8.22.

Refresh patch after git rm files, diff against origin/main

Jan 28 2022, 11:22 PM
koobs retitled D34079: [WIP] sysutils/fusefs-ntfs: Update to 2021.8.22 from Summary: sysutils/fusefs-ntfs: Update to 2021.8.22 to [WIP] sysutils/fusefs-ntfs: Update to 2021.8.22.
Jan 28 2022, 12:09 PM
koobs requested review of D34079: [WIP] sysutils/fusefs-ntfs: Update to 2021.8.22.
Jan 28 2022, 12:04 PM

Jan 2 2022

koobs added inline comments to D32265: editors/texworks: Update to 0.6.7.
Jan 2 2022, 11:35 PM
koobs added a comment to D33712: devel/texlab: Update to 3.3.1.

Link to versioned (tagged) version of relevent changelog files, rather than commits (ive updated this review summary)

Jan 2 2022, 11:29 PM
koobs updated the summary of D33712: devel/texlab: Update to 3.3.1.
Jan 2 2022, 11:29 PM
koobs requested changes to D32266: graphics/zathura: Update to 0.4.8, Add SyncTeX support.
Jan 2 2022, 11:23 PM
koobs added inline comments to D32265: editors/texworks: Update to 0.6.7.
Jan 2 2022, 12:41 AM
koobs requested changes to D32264: devel/tex-synctex: Update to 1.21.0.
Jan 2 2022, 12:39 AM
koobs requested changes to D32266: graphics/zathura: Update to 0.4.8, Add SyncTeX support.
Jan 2 2022, 12:33 AM
koobs retitled D32266: graphics/zathura: Update to 0.4.8, Add SyncTeX support from graphics/zathura: Update and add SyncTeX support to graphics/zathura: Update to 0.4.8, Add SyncTeX support.
Jan 2 2022, 12:31 AM

Jan 1 2022

koobs accepted D33712: devel/texlab: Update to 3.3.1.

Pending commit log message update

Jan 1 2022, 9:22 PM
koobs added a comment to D33712: devel/texlab: Update to 3.3.1.

Can you add a changelog link to the commit log message and set MFH depending on whether or not its a bugfix/security update (yes) or feature only (no)

Jan 1 2022, 9:22 PM
koobs updated the summary of D33712: devel/texlab: Update to 3.3.1.
Jan 1 2022, 9:21 PM

Nov 18 2021

koobs added a comment to D31945: libmd: Only define SHA256_Transform_c when using the ARM64 ifunc..

Thanks for tagging @kevans. The *SAN link failures and environment/build configuration are here: https://lists.freebsd.org/archives/freebsd-current/2021-September/000488.html

Nov 18 2021, 1:50 AM
koobs requested changes to D32265: editors/texworks: Update to 0.6.7.
Nov 18 2021, 1:30 AM
koobs updated the summary of D32265: editors/texworks: Update to 0.6.7.
Nov 18 2021, 1:29 AM
koobs added a comment to D32264: devel/tex-synctex: Update to 1.21.0.

Also, explain files/patch-* removal (upstreamed? something else?) in the differential SUMMARY

Nov 18 2021, 1:28 AM
koobs requested changes to D32264: devel/tex-synctex: Update to 1.21.0.
  1. as this change doesn't affect them to my understandings,
Nov 18 2021, 1:28 AM
koobs updated the summary of D32264: devel/tex-synctex: Update to 1.21.0.
Nov 18 2021, 1:23 AM
koobs added a comment to D32265: editors/texworks: Update to 0.6.7.

Acceptance pending QA confirmation (portlint, poudriere)

Nov 18 2021, 1:20 AM