Page MenuHomeFreeBSD

koobs (Kubilay Kocak)
User

Projects

User Details

User Since
May 22 2014, 10:41 AM (369 w, 2 d)

Recent Activity

Yesterday

koobs added a comment to D22012: Import dhcpcd(8) version 8.1.0 into FreeBSD base..

ISC DHCP client/relay end of maintenance:

Sat, Jun 19, 4:54 AM

Tue, Jun 15

koobs added a comment to D30475: lang/python310: add python 3.10.0.beta2.
Tue, Jun 15, 12:05 PM

Sat, Jun 12

koobs added a comment to D30475: lang/python310: add python 3.10.0.beta2.

See minor comments to clarify before landing this. Would still like to see this as a diff against the port it was based on

Sat, Jun 12, 1:42 AM
koobs updated the summary of D30475: lang/python310: add python 3.10.0.beta2.
Sat, Jun 12, 1:40 AM

Thu, Jun 10

koobs updated the summary of D30651: devel/py-bitstring: Update to 3.1.7.
Thu, Jun 10, 12:42 AM
koobs added a comment to D30651: devel/py-bitstring: Update to 3.1.7.
In D30651#690197, @sbz wrote:

Thanks @loader, just a minor nit in your commit message, it should be (full URL and no underscore for tags):

Differential Revision:        https://reviews.freebsd.org/D30651
Thu, Jun 10, 12:42 AM

Tue, Jun 8

koobs accepted D30661: [NEW] ftp/sftpgo: SFTP, FTP/S, and WebDAV server.

I'd agree with @skozlov here. IIRC, it is even recommended to use GitHub releases instead of tags, if releases are available.

Tue, Jun 8, 12:03 AM

Mon, Jun 7

koobs added inline comments to D30661: [NEW] ftp/sftpgo: SFTP, FTP/S, and WebDAV server.
Mon, Jun 7, 1:23 AM
koobs updated the summary of D30661: [NEW] ftp/sftpgo: SFTP, FTP/S, and WebDAV server.
Mon, Jun 7, 1:20 AM

Sun, Jun 6

koobs accepted D30646: security/pam-mysql: Update to 0.8.2.

Looks good. Approved if it passes QA for different values of USES=ssl (base, ssl, libre), otherwise add blocks to BROKEN, or IGNORE them, or report issues accordingly

Sun, Jun 6, 12:24 AM
koobs updated the summary of D30646: security/pam-mysql: Update to 0.8.2.
Sun, Jun 6, 12:23 AM

Fri, Jun 4

koobs added inline comments to D30646: security/pam-mysql: Update to 0.8.2.
Fri, Jun 4, 11:58 PM
koobs added a comment to D30475: lang/python310: add python 3.10.0.beta2.

Could you update review summary (proposed commit log message) & test plan (list of qa tests run), for our future selves

Fri, Jun 4, 11:54 PM
koobs added a comment to D30475: lang/python310: add python 3.10.0.beta2.

Apart from the hard-coded version in MASTER_SITES (minor)

Fixed. I've hardcoded it as it would have to be changed anyway for release, but with cutting away prerelease suffix it would work for both pre- and release versions.

What's the explanation for the NEWOPENSSL variable? Is the behaviour the same with ports versions of openssl, libressl?

python310 does not support archaic openssl from 11.x and fails to build crypto related modules there. The same for libressl. But with openssl from ports it's good even on 11.
I've updated the condition. Not sure if it should be BROKEN instead or should output some kind of warning.

Also the LIBFFI option needs to be removed, originally only done in python37 see: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=244782

Outstanding/open PR https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256141

Done.

Can this be run through complete QA?

What do you mean by "complete QA"?

The threshold to commit isn't really no objections, no?

The approval may not be required but as you can see this review led to some improvements.

Fri, Jun 4, 11:54 PM
koobs requested changes to D30475: lang/python310: add python 3.10.0.beta2.
Fri, Jun 4, 12:35 PM
koobs added a comment to D30475: lang/python310: add python 3.10.0.beta2.

This is now ready to land. I take it as there are no objections?

Fri, Jun 4, 12:35 PM
koobs added a comment to D30475: lang/python310: add python 3.10.0.beta2.

Is it possible to get this as a diff from python39 (or whatever its original source was)?

Available in the related PR https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256150, or do you need complete diff with plist?

Fri, Jun 4, 12:34 PM

Tue, Jun 1

koobs added a comment to D30473: [NEW] devel/py-setuptools44: Download, build, install, upgrade, and uninstall Python packages (Python 2.7).
Tue, Jun 1, 11:51 PM
koobs added a comment to D30475: lang/python310: add python 3.10.0.beta2.

Is it possible to get this as a diff from python39 (or whatever its original source was)?

Tue, Jun 1, 3:20 AM
koobs updated the summary of D30473: [NEW] devel/py-setuptools44: Download, build, install, upgrade, and uninstall Python packages (Python 2.7).
Tue, Jun 1, 1:36 AM
koobs accepted D30473: [NEW] devel/py-setuptools44: Download, build, install, upgrade, and uninstall Python packages (Python 2.7).
Tue, Jun 1, 1:36 AM

Mon, May 31

koobs added a comment to D30551: [NEW PORT] devel/py-reedsolo: Pure-Python Reed Solomon encoder/decoder.

@loader Looks good. Note you're implicit on all ports changesets, but its always good to get at least one independent review:

Mon, May 31, 2:10 AM
koobs removed a reviewer for D30473: [NEW] devel/py-setuptools44: Download, build, install, upgrade, and uninstall Python packages (Python 2.7): portmgr.
Mon, May 31, 2:09 AM
koobs added a comment to D30473: [NEW] devel/py-setuptools44: Download, build, install, upgrade, and uninstall Python packages (Python 2.7).

portmgr is not blocking. If this needs extra QA (exp-run), request via Bugzilla

Mon, May 31, 2:09 AM
koobs retitled D30473: [NEW] devel/py-setuptools44: Download, build, install, upgrade, and uninstall Python packages (Python 2.7) from devel/py-setuptools44: preserve older setuptools for python2 to [NEW] devel/py-setuptools44: Download, build, install, upgrade, and uninstall Python packages (Python 2.7).
Mon, May 31, 2:07 AM

Sun, May 30

koobs accepted D30323: www/pydio-cells: Fix build and overhaul.
Sun, May 30, 2:06 AM

Fri, May 28

koobs requested changes to D30323: www/pydio-cells: Fix build and overhaul.
Fri, May 28, 1:28 AM

Wed, May 26

koobs added a comment to D30323: www/pydio-cells: Fix build and overhaul.
  • For changes that are not feature additions, MFH. For all differentials, so its obvious and explicit, add to commit log message (summary)
Wed, May 26, 12:46 AM
koobs requested changes to D30323: www/pydio-cells: Fix build and overhaul.
Wed, May 26, 12:45 AM
koobs updated the summary of D30323: www/pydio-cells: Fix build and overhaul.
Wed, May 26, 12:41 AM

Tue, May 25

koobs added a reviewer for D30449: taskqueue: Add missing comma to TASKQUEUE_FAST_DEFINE_THREAD: scottl.
Tue, May 25, 2:30 AM
koobs retitled D30449: taskqueue: Add missing comma to TASKQUEUE_FAST_DEFINE_THREAD from TASKQUEUE_FAST_DEFINE_THREAD: add missing comma to taskqueue: Add missing comma to TASKQUEUE_FAST_DEFINE_THREAD.
Tue, May 25, 2:27 AM

Mon, May 24

koobs updated the summary of D29699: [NEW] misc/g810-led: Led controller for Logitech G- Keyboards.
Mon, May 24, 9:35 AM
koobs accepted D29699: [NEW] misc/g810-led: Led controller for Logitech G- Keyboards.

Looks good, nice work Alexander

Mon, May 24, 9:33 AM
koobs accepted D29699: [NEW] misc/g810-led: Led controller for Logitech G- Keyboards.

Nice work Alexander. Minor case nit in COMMENT, otherwise looks good

Mon, May 24, 3:02 AM
koobs updated the summary of D29699: [NEW] misc/g810-led: Led controller for Logitech G- Keyboards.
Mon, May 24, 3:01 AM
koobs retitled D29699: [NEW] misc/g810-led: Led controller for Logitech G- Keyboards from New Port: misc/g810-led: Led controller for Logitech G- Keyboards to [NEW] misc/g810-led: Led controller for Logitech G- Keyboards.
Mon, May 24, 3:01 AM

May 20 2021

koobs added a comment to D30338: misc/mbuffer: Update to 20210328.

Yep, rule of thumb:

May 20 2021, 12:09 AM

May 19 2021

koobs added a comment to D30338: misc/mbuffer: Update to 20210328.

One other note. When taking maintainer'ship or when combining multiple changes, land all changes that can be MFH'd first , and the version update separately.

May 19 2021, 11:13 AM
koobs accepted D30322: [NEW] devel/pydio-packr: Pydio port of packr v1.

Understood. Just be careful with PORTVERSION/DISTVERSION going backward for future tagged versions. See:

May 19 2021, 2:00 AM
koobs accepted D30338: misc/mbuffer: Update to 20210328.

I've tweaked the commit log message. This change also comes under implicit

May 19 2021, 1:55 AM
koobs updated the summary of D30338: misc/mbuffer: Update to 20210328.
May 19 2021, 1:54 AM

May 18 2021

koobs added a comment to D30322: [NEW] devel/pydio-packr: Pydio port of packr v1.

Can/should this port just be included (bundled as a dep) for www/pydio-cells?

May 18 2021, 6:42 AM
koobs updated the summary of D30322: [NEW] devel/pydio-packr: Pydio port of packr v1.
May 18 2021, 6:35 AM

May 17 2021

koobs added a comment to D30274: devel/p5-Pod-Coverage: Add missing dependency textproc/p5-Pod-Parser.

Good to go mate

May 17 2021, 3:08 AM

May 16 2021

koobs accepted D30274: devel/p5-Pod-Coverage: Add missing dependency textproc/p5-Pod-Parser.
  • Include all context/why in the commit log message. The entire differential summary should only need to ever be what the full commit log message will be, which includes all necessary detail for someone with zero knowledge to grok the full context of the committed change. I've updated the commit log message as an example of what I mean.
  • fetch, build, run, package failures are always Approved by: portmgr (blanket: <type> fix). The same reason can be used for the MFH <reason>. Update commit log message accordingly
May 16 2021, 2:14 AM
koobs updated the summary of D30274: devel/p5-Pod-Coverage: Add missing dependency textproc/p5-Pod-Parser.
May 16 2021, 2:11 AM

May 13 2021

koobs accepted D30199: [NEW] www/pydio-cells: nextgen file sharing platform.

Capitalize "N" in COMMENT=nextgen but otherwise looks good

May 13 2021, 12:48 AM

May 11 2021

koobs requested changes to D30199: [NEW] www/pydio-cells: nextgen file sharing platform.

Does testport pass?

May 11 2021, 1:04 AM
koobs retitled D30199: [NEW] www/pydio-cells: nextgen file sharing platform from www/pydio-cells: New port to [NEW] www/pydio-cells: nextgen file sharing platform.
May 11 2021, 1:04 AM
koobs updated the test plan for D30199: [NEW] www/pydio-cells: nextgen file sharing platform.
May 11 2021, 1:02 AM
koobs updated the summary of D30192: lang/python-doc-html: Unbreak makesum.
May 11 2021, 12:58 AM
koobs added a comment to D30192: lang/python-doc-html: Unbreak makesum.

Bugfixes are:

May 11 2021, 12:56 AM

May 3 2021

koobs added a comment to D29980: emulators/i386-wine: Update to 5.0.4 & take maintainership.

@gerald mentioned a desire to find new maintainers for wine ports, so this is timely, thank you :)

May 3 2021, 1:06 AM
koobs added a comment to D29982: emulators/i386-wine-devel: Update to 6.5 & take maintainership.

@gerald mentioned a desire to find new maintainers for wine ports, so this is timely, thank you :)

May 3 2021, 1:06 AM
koobs added a reviewer for D29982: emulators/i386-wine-devel: Update to 6.5 & take maintainership: gerald.
May 3 2021, 1:06 AM
koobs updated the summary of D29980: emulators/i386-wine: Update to 5.0.4 & take maintainership.
May 3 2021, 1:05 AM
koobs updated subscribers of D29982: emulators/i386-wine-devel: Update to 6.5 & take maintainership.

Thanks for offering to take maintainership and supporting our Wine ports @Alexander88207_protonmail.com

May 3 2021, 1:04 AM

Apr 26 2021

koobs added a comment to D29872: e1000: Improve device name strings .

Just a Q: Are any of these changes likely to cause issues with respect to scripts / devd rules, or other 'automatic' things that might leverage these description? If so, is there anything in particular we might be able to do to mitigate that?

Hi, not that I know of. Because the names were all the same in a family, I predict most people would sooner script off of 'em', 'igb' before reaching for these unwieldy strings. It appears in dmesg during attach i.e. em0: <Intel(R) I211 (Copper)"> or sysctl dev.em.0.%desc. That could change now that they are more useful, but I would encourage folks to script off of PCI ID numbers before reaching for strings. Even the pci-ids database strings change frequently enough when corrections come in, but I do suspect people occasionally script off of those despite the lack of stability (i.e. pciconf -lv em0). Let me know if you find out anything different as I would like to MFC this after 1 month to stable/12 and stable/13.

Apr 26 2021, 5:36 AM
koobs added a comment to D29872: e1000: Improve device name strings .

Just a Q: Are any of these changes likely to cause issues with respect to scripts / devd rules, or other 'automatic' things that might leverage these description? If so, is there anything in particular we might be able to do to mitigate that?

Apr 26 2021, 5:24 AM

Apr 19 2021

koobs added a member for Contributor Reviewers (ports): koobs.
Apr 19 2021, 8:10 AM

Apr 18 2021

koobs added a comment to D29717: books/porters-handbook: Add a note about portsmon out of service.

FWIW, portmon has been dead due to 'python' for more than a few years. It is unrelated to 'latest Python updates' which is ambiguous.

Apr 18 2021, 1:10 AM

Mar 30 2021

koobs updated subscribers of D29424: gvinum: add deprecation notice.

Apologies, recent edits come up in RecentChanges so they tend to get more eyes and in my case, natural follow-up :)

No worries, better that it moved before commit :)

Mar 30 2021, 11:26 AM
koobs removed a member for rust: koobs.
Mar 30 2021, 2:37 AM
koobs added a comment to D29424: gvinum: add deprecation notice.

@koobs moved the wiki page

Mar 30 2021, 2:27 AM

Mar 1 2021

koobs added a comment to D28981: copy_file_range(2): Fix for small values of input file offset and len.

Thanks @rmacklem :)

Mar 1 2021, 12:07 AM
koobs retitled D28981: copy_file_range(2): Fix for small values of input file offset and len from fix copy_file_range for small values of input file offset and len to copy_file_range(2): Fix for small values of input file offset and len.
Mar 1 2021, 12:06 AM

Feb 16 2021

koobs accepted D28572: sysutils/nfs-over-tls: Fix build with OpenSSL without KTLS patches.

@rmacklem Good to commit if it passes QA

Feb 16 2021, 1:24 AM
koobs updated the test plan for D28572: sysutils/nfs-over-tls: Fix build with OpenSSL without KTLS patches.
Feb 16 2021, 1:23 AM
koobs retitled D28572: sysutils/nfs-over-tls: Fix build with OpenSSL without KTLS patches from nfs-over-tls: update distinfo to sysutils/nfs-over-tls: Fix build with OpenSSL without KTLS patches.
Feb 16 2021, 1:22 AM
koobs added a comment to D28572: sysutils/nfs-over-tls: Fix build with OpenSSL without KTLS patches.

Also when (arc) creating reviews, include full context (I believe this is -C99999)

Feb 16 2021, 1:20 AM
koobs added a comment to D28572: sysutils/nfs-over-tls: Fix build with OpenSSL without KTLS patches.

Change looks good.

Feb 16 2021, 1:20 AM
koobs added a comment to D28572: sysutils/nfs-over-tls: Fix build with OpenSSL without KTLS patches.

Apologies, had to reset 2FA creds (lost) before I could login to review.

Feb 16 2021, 1:11 AM

Feb 9 2021

koobs added a comment to D28135: net/aquantia-atlantic-kmod: Fix CURRENT build post r353868 (iflib changes).

@koobs If you really don't have time, how about passing maintainership to @nyan_myuji.xyz ? He has more changes planned and is willing to take care of this port. I will help him to land more patches.

Feb 9 2021, 5:36 AM
koobs updated the summary of D28135: net/aquantia-atlantic-kmod: Fix CURRENT build post r353868 (iflib changes).
Feb 9 2021, 12:37 AM
koobs accepted D28135: net/aquantia-atlantic-kmod: Fix CURRENT build post r353868 (iflib changes).

@philip I may not have time to day, but the change is otherwise approved

Feb 9 2021, 12:37 AM

Jan 31 2021

koobs accepted D28172: net/v2ray: Update to 4.34.0.

@loader Feel free from now on to:

Jan 31 2021, 1:24 AM

Jan 25 2021

koobs accepted D28320: security/meek: Add missing build dependency goptlib, remove BROKEN.

Nice work @loader!

Jan 25 2021, 7:24 AM
koobs added a comment to D28135: net/aquantia-atlantic-kmod: Fix CURRENT build post r353868 (iflib changes).

@philip @lwhsu Thank you both for review. Feel free to commit this (pending adding upstream comments to patches).

Jan 25 2021, 7:16 AM

Jan 14 2021

koobs added inline comments to D28135: net/aquantia-atlantic-kmod: Fix CURRENT build post r353868 (iflib changes).
Jan 14 2021, 2:15 AM
koobs updated the summary of D28135: net/aquantia-atlantic-kmod: Fix CURRENT build post r353868 (iflib changes).
Jan 14 2021, 2:14 AM
koobs added 1 blocking reviewer(s) for D28135: net/aquantia-atlantic-kmod: Fix CURRENT build post r353868 (iflib changes): koobs.
Jan 14 2021, 2:12 AM
koobs updated the summary of D28135: net/aquantia-atlantic-kmod: Fix CURRENT build post r353868 (iflib changes).
Jan 14 2021, 2:12 AM
koobs added a comment to D28135: net/aquantia-atlantic-kmod: Fix CURRENT build post r353868 (iflib changes).

This needs:

Jan 14 2021, 2:12 AM
koobs retitled D28135: net/aquantia-atlantic-kmod: Fix CURRENT build post r353868 (iflib changes) from Fix net/aquantia-atlantic-kmod post r353868 iflib changes to net/aquantia-atlantic-kmod: Fix CURRENT build post r353868 (iflib changes).
Jan 14 2021, 2:11 AM

Jan 3 2021

koobs added a comment to D27778: emulators/qemu: Enable user networking by default.

In the absence of poudriere (one should set it up), you can run the set of commands outlined here:

Jan 3 2021, 1:29 AM
koobs added a comment to D27778: emulators/qemu: Enable user networking by default.

hi!

In D27778#620891, @bofh wrote:

Also Question: do any of the other qemu-* ports need to have this change made too, or do they all inherit/child port off the main one (I haven't looked)

All qemu-* ports needs to be updated.

Can I just try to land this one first, and worry about the others later? I'd at least like to see a working qemu port with user networking available for other freebsd users to test with.

Jan 3 2021, 1:01 AM

Dec 28 2020

koobs requested changes to D27778: emulators/qemu: Enable user networking by default.
Dec 28 2020, 9:15 AM

Dec 27 2020

koobs added inline comments to D27778: emulators/qemu: Enable user networking by default.
Dec 27 2020, 3:34 AM
koobs added a comment to D27778: emulators/qemu: Enable user networking by default.

For future reference sake: Ports compliance/recommendations require ports to 'unbundle' any bundled libraries (in this case slirp) except in cases where that is creates an unnecessary or inappropriate support or maintenance burden (such as go / node modules). We'll land this change in the short term until a slirp port can be produced

Dec 27 2020, 2:08 AM
koobs added a comment to D27778: emulators/qemu: Enable user networking by default.

Also Question: do any of the other qemu-* ports need to have this change made too, or do they all inherit/child port off the main one (I haven't looked)

Dec 27 2020, 2:07 AM
koobs updated the summary of D27778: emulators/qemu: Enable user networking by default.
Dec 27 2020, 2:05 AM
koobs added a comment to D27778: emulators/qemu: Enable user networking by default.

@adrian Can you confirm QA passes (portlint/poudriere, filling out TEST PLAN section) and add MFH: value <branch|no> <reason> in commit log message

Dec 27 2020, 2:05 AM
koobs retitled D27778: emulators/qemu: Enable user networking by default from [qemu] add user networking by default to emulators/qemu: Enable user networking by default.
Dec 27 2020, 2:03 AM

Dec 4 2020

koobs committed rP556973: security/py-cryptography: Update to 2.9.2 [2].
security/py-cryptography: Update to 2.9.2 [2]
Dec 4 2020, 11:31 AM

Nov 30 2020

koobs accepted D26969: net/v2ray: Update to 4.33.0.

LGTM

Nov 30 2020, 9:07 AM
koobs added a comment to D26969: net/v2ray: Update to 4.33.0.
  • Add <reason> to MFH: line regardless of value
  • Any reason for not renaming the port per the upstream rename, or is the product name still the same with only the repo name changing?
Nov 30 2020, 1:21 AM
koobs updated the summary of D26969: net/v2ray: Update to 4.33.0.
Nov 30 2020, 1:20 AM

Nov 12 2020

koobs accepted D27187: security/py-ecdsa: Update to 0.16.0.

Perfect :)

Nov 12 2020, 11:34 AM
koobs updated the summary of D27187: security/py-ecdsa: Update to 0.16.0.
Nov 12 2020, 11:34 AM