Page MenuHomeFreeBSD

editors/texworks: Update to 0.6.6
Needs RevisionPublic

Authored by kfv_kfv.io on Oct 1 2021, 7:04 PM.

Details

Reviewers
hrs
koobs
Summary
editors/texworks: Update to 0.6.6

- Update PLIST_FILES and include additional icons for desktop users

Reviewed_by: koobs, ??
Approved by:
Differential_Revision: D32265

Blocks: D32264

Test Plan
  • portlint: passed
  • testport: passed
  • runtime: I don't know texworks, but I built and tried it successfully on FreeBSD 13.0-RELEASE

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 41899
Build 38787: arc lint + arc unit

Event Timeline

koobs edited the test plan for this revision. (Show Details)

Acceptance pending QA confirmation (portlint, poudriere)

koobs requested changes to this revision.Nov 18 2021, 1:29 AM
koobs edited the summary of this revision. (Show Details)
This revision now requires changes to proceed.Nov 18 2021, 1:29 AM

Acceptance pending QA confirmation (portlint, poudriere)

Both portlint and poudriere testport successfully passed.

editors/texworks/Makefile
40–43

Explain all changes in commit log (formatted) message in review summary. Something like:

- Include additional icons for desktop users

Or similar, which describes value/rationale to readers

52

Should we pass explicit PYTHON_VERSION here ?

What is cmake's behaviour when its not passed and multiple version of python exist on the system?

If the default version (or version it finds), is different than the Python version for this port build, it will be built incorrectly.

kfv_kfv.io marked an inline comment as done.
editors/texworks/Makefile
52

Does PYTHON_USES= python:3.4+ in line 51 not precede PYTHON_CMAKE_BOOL. If it does, we'll be safe. Otherwise, yes, it'll either build incorrectly or fail altogether.

editors/texworks/Makefile
52

USES=python only imports Mk/Uses/python.mk and sets variables (like PYTHON_VER). It doesn't (can't) know how to pass the environment to any particular build system.

I believe CMakeLists files usually have a variable for explicitly setting the Python version one wants to use/build with.

editors/texworks/Makefile
52

Oh OK, I see, you're right. Do you think using something like PYTHON_CMAKE_ON could do the job? I haven't ever used CMake professionally but just checked the CMakeLists.txt and there I found this:

if (WITH_PYTHON)
  CONFIG_VERSION("Python" "${PYTHON_VERSION_STRING}")
endif()

So, I think we need something like the following:

PYTHON_CMAKE_ON=   -DPYTHONVERSION:STRING="${PYTHON_VER}"

Right?