Page MenuHomeFreeBSD

devel/tex-synctex: Update to 1.21.0
Needs RevisionPublic

Authored by kfv_kfv.io on Oct 1 2021, 6:40 PM.

Details

Reviewers
hrs
koobs
Group Reviewers
Contributor Reviewers (ports)
Summary
devel/tex-synctex: Update to 1.21.0

- Remove various patches to improve and ease maintenance by bringing them
  together and excluding unnecessary components directly in the Makefile patch
  from their corresponding macros. Couldn't think of a better way, especially
  since we're using the original TeX Live codebase to extract and build the SyncTeX
  component separately.
- Add synctex_version.h header.

Reviewed_by: koobs, ??
Approved by: 
Differential_Revision: D32264

Dependant ports editors/texworks and graphics/zathura are updated in
in D32265 and D32266, respectively. PORTREVISION of editors/gummi,
net-mgmt/netmagis-www, and print/texlive-full are also incremented. For
texlive-full, though, I am not sure if I've done it correctly.

In the meanwhile, as explained above, old patchfiles are deleted as I've
brought configuration arguments into the main Makefile. This way, we can
maintain the port more easily in future.

Test Plan
  • portlint: passed
  • testport: passed
  • runtime: I used it for days on FreeBSD 13.0-RELEASE

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 42867
Build 39755: arc lint + arc unit

Event Timeline

koobs edited the test plan for this revision. (Show Details)
koobs requested changes to this revision.Nov 18 2021, 1:28 AM
  1. as this change doesn't affect them to my understandings,

I'm under the impression bumping shared library major versions requires bumping dependents. In what sense does this major version change not affect them?

  1. Do any other tex ports require updating in tandem with this? I'm under the impression all ports are usually updated as a set, or are they individually update'able?
  1. Add QA confirmation to TEST PLAN section
devel/tex-synctex/Makefile
22–28

Can you explain the why for this change chunk please (in the differential summary)

26–49

Can you explain the why for this change chunk please (in the differential summary)

devel/tex-synctex/files/patch-Makefile.in
1–18

Add patch header comment explaining the why (rationale) for this change. Include any upstream reference links (issues, pr's, commits) where applicable

This revision now requires changes to proceed.Nov 18 2021, 1:28 AM

Also, explain files/patch-* removal (upstreamed? something else?) in the differential SUMMARY

I'm under the impression bumping shared library major versions requires bumping dependents. In what sense does this major version change not affect them?

True, my apologies. I'll take care of them.

Also, explain files/patch-* removal (upstreamed? something else?) in the differential SUMMARY

Sure, roger that.

  • Fix portlint errors
  • Update PORTREVISION of dependant ports
kfv_kfv.io edited the test plan for this revision. (Show Details)

Both portlint and poudriere testport successfully passed.

  • Add PORTREVISION for print/texlive-full
kfv_kfv.io marked an inline comment as done.
kfv_kfv.io added inline comments.
devel/tex-synctex/files/patch-Makefile.in
1–18

The SyncTeX project is part of the TeXLive project and is separated from devel/tex-web2c to devel/tex-synctex in rP392909. The patch makes sure no other component is built, tested, or installed since only SyncTeX utility and its libraries are required.

kfv_kfv.io marked an inline comment as done.
  • Document the patchfile
koobs requested changes to this revision.Sun, Jan 2, 12:39 AM
koobs added inline comments.
devel/tex-synctex/Makefile
22–48

Explain these changes in the commit log message (in the formatted section). Something like:

- Disable all optional dependencies in CONFIGURE_ARGS so they're never auto-detected

Or similar

devel/tex-synctex/files/patch-Makefile.in
9

Are there any dynamic/configure or build methods to disable installation of 'EXTRA_PROGRAMS' without patching it out here?

Note also: commit log summaries should include 'rationale' for changes too, like this one (we we patched it out versus another way), like:

- Patch out EXTRA_PROGRAMS. There's no dynamic method to disable these at present'
This revision now requires changes to proceed.Sun, Jan 2, 12:39 AM
kfv_kfv.io marked 3 inline comments as done.

@koobs: Done. Let me know if there's anything left. Thank you so much.