Rebase against current tree, and update to 0.72

Looks good to me with the created-by and svn-cp change.

Still looks good to me.

@pizzamig may I just upgrade yours, @mat had a point there.

It looks like graphics/kimagemapeditor is a KDE5 port so it is fine?

PKGNAMESUFFIX= # hack: uses kde:4 but we don't want the pkgname suffix
^ right, that comment made the regexp match :D

Thanks!

• 2018-12-31
  • deskutils/strigi (is a leaf port that should go with KDE4)
  • graphics/kimagemapeditor
  • graphics/gnash has a KDE4-option
  • net/libproxy-kde
  • net-im/ekiga has two KDE4-options
  • print/frescobaldi should be deprecated (or updated to 3.0.0)
  • security/subversion-kwallet
  • www/opera
  • x11/kde4

There are some minor improvents you can do. After that, it can go in :)

Make sure this is an svn cp of lang/ghc

Looks good to me now.

In D18397#391471, @arrowd wrote:

I forgot to add it to category Makefile, but can't update the revision now, for some reason:

>>> [28] <http> https://reviews.freebsd.org/api/differential.creatediff
 <<< [28] <http> 61,157,363 us
 
 [2018-12-01 08:17:07] EXCEPTION: (HTTPFutureCURLResponseStatus) [cURL/92] (https://reviews.freebsd.org/api/differential.creatediff) The cURL library raised an error while making a request. You may be able to find more information about this error (error code: 92) on the cURL site: http://curl.haxx.se/libcurl/c/libcurl-errors.html# at [<phutil>/src/future/http/HTTPSFuture.php:408]
 arcanist(), phutil()
   #0 HTTPSFuture::isReady() called at [<phutil>/src/future/Future.php:37]
   #1 Future::resolve(NULL) called at [<phutil>/src/future/FutureProxy.php:34]
   #2 FutureProxy::resolve() called at [<phutil>/src/conduit/ConduitClient.php:64]
   #3 ConduitClient::callMethodSynchronous(string, array) called at [<arcanist>/src/workflow/ArcanistDiffWorkflow.php:519]
   #4 ArcanistDiffWorkflow::run() called at [<arcanist>/scripts/arcanist.php:394]

The fix for the phonon's is

FLAVORS=qt5 qt4

instead of using

FLAVOR?= ${FLAVORS:[2]}

Moin moin -- the patch does not apply for me.

In D17741#390918, @rene wrote:

• update to r486205
• mark some ports broken as they do not build (yet) with Qt5
  
  Clients of multimedia/phonon should build with qt5 but poudriere gets confused, stating it cannot find the qt5 flavor of multimedia/phonon

@rene : https://svnweb.freebsd.org/ports?view=revision&revision=485966 -- brew can be un-deprecated.

Please don't. Qt4 does not imply KDE4, and if I won't be able to keep Qt4 alive, I'd have to revert the removal in my local tree. Reverting just the Qt4 bits (without the KDE4) would be a huge pain saver. Given there's still plenty of Qt4-based software, there should be some time gap between deprecating KDE4 from the generic, KDE-agnostic software.

In D17741#385591, @rene wrote:

In D17741#379185, @tcberner wrote:

In D17741#379166, @jhale wrote:

There seems to be quite a few ports here that depend on x11/kdelibs-kde4 which is set to be removed on 2018-12-31. Shouldn’t those ports also be removed on 2018-12-31?

I would say so, as they will be broken by the removal.

So better set their expiration dates to 2018-12-31.

I don't see any change in plist files which looks suspicious given that a file is claimed to be moved from one to another package

Close.

Looks good to me.

Add dropped conflict, and fix existing.

Looks good to me.

Fix typo in address

You can find the documentation on it here: Order of Variables

Address changes.

Looks good to me.

Address @rene's comments.

Update

Wouldn't phpflavors make sense here?

Looks good to me.

Make sure you have create the new ports via svn cp, so that it has the history.

Moin moin

In D17726#380953, @rigoletto wrote:

Make Guake py36 only.

Update.

Ping

You need to disable flavors or give it a unique pkg name per flavor.

In D17726#378869, @tcberner wrote:

I would merge the 10-ish import locale->import gettext patches into one

^ alternatively, you could also use a REINPLACE_CMD to sed /import/s|locale|gettext

In D17741#379255, @jhale wrote:

Option corrections. :)

In D17741#379166, @jhale wrote:

There seems to be quite a few ports here that depend on x11/kdelibs-kde4 which is set to be removed on 2018-12-31. Shouldn’t those ports also be removed on 2018-12-31?

Update

In D17741#379148, @rene wrote:

There could be more ports where the QT4 dependency is optional, please recheck all ports.Those ports must not expire, only their QT4 bits should be removed manually. Otherwise rmport will happily remove them.

Looks good to me, once you add the '\n' to the last lines of the pkg-descrs

In D17740#379092, @rene wrote:

The wordy version in your example should be

. if ${FLAVOR} == qt4
DEPRECATED=		Qt4 has been EOL since december 2015
EXPIRATION_DATE=	2019-03-15
. endif

woops, copy & paste error, corrected.