[with the += -> - change ^^]

Can you prepare a commit message? [also remember there is a PR for this]

Address @kdwm comments

In D17447#373901, @antoine wrote:

Could this kind of change be done just before quarterly ? this makes MFH painful.

Looks good to me. Let me know if svn is picky about missing properties on the new files :)

Looks good to me.

it might make sens to write in the commit message what it is

In D17456#373352, @tijl wrote:

In D17456#372420, @tcberner wrote:

Todo:

• cups-filters (update or patch)

Done in https://svnweb.freebsd.org/changeset/ports/481734.

In D13078#372447, @yuri wrote:

I have a port that takes the option that is one of 5 choices. It will use OPTIONS_SINGLE. The name of the selected option needs to be passed as a cmake variable value.

If there is an option section, it is reasonable to have a helper variable that contains all currently selected values. It can simplify certain cases.

The alternative is to have .if/.else/.endif for every choice element.

Can this be approved and committed?

Looks good to me.

Todo:

• cups-filters (update or patch)
• inkscape

@tijl print/cups-filters needs an upgrade to something lie 1.21.3 too:

• https://github.com/OpenPrinting/cups-filters/releases/tag/release-1-21-3

Please get rid of the flavors again. poppler-qt4 will be dropped from the tree soon, so it makes sense to switch this to Qt5 only already.

Add :insource to the ports that need it.

Sounds good to me

uniquefiles:dirs didn't take, so I switched back to the maual override.

Reoder option, use uniquedir, and remove uneeded change in plist-sub

In D17447#372154, @mat wrote:

There does not seem to be any use of :insource, do you plan on having the exp-run tell you which port will need it?

(Other than that, looks good.)

Fix MOVED.lint

Looks good to me now.

Looks good to me now.

Looks good to me

See also my neglected D15972 .

Let me explicitely state, that you could have done this implicitely :)

In D17413#371467, @fernape wrote:

There is also dns/powerdns-recursor40 which also builds fine. I asked the submitter if there is any reason not to bump PORTREVISION for that one

Sounds like a good idea -- everything that makes this port simpler is a step in the right direction :)

Give me an m give me an a give me a math/Makefile change

Remove pkg-plist-py3

Looks good to me if it still works.

Looks fine :)

Intersting, with this, we could probably also get rid of the second hunk in patch-src_common_Configuration.h -- the somewhat fix to $path, right?

There are other ports depending on the now flavored x11/libfm -- maybe they should be flavored too? -- like x11/lxpanel.

A new port needs something else :) -- an entry to the categroy Makefile

Looks good to me.

Oki then, let's give @hrs some time to look at it :)

Still looks good to me, yes :)