Looks good to me. You should probably upstream that.

Looks good to me.

LGTM

Looks good to me -- but please make sure that all the consumers still build fine with it.
Otherwise, please fix them [first] :)

Looks good to me.

Looks good to me.

sysutils/daggy seems to be broken by the update

You're still missing the new headers.

There seem to be some plist issues:

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: include/botan-2/botan/argon2.h
Error: Orphaned: include/botan-2/botan/asio_async_ops.h
Error: Orphaned: include/botan-2/botan/asio_context.h
Error: Orphaned: include/botan-2/botan/asio_error.h
Error: Orphaned: include/botan-2/botan/asio_stream.h
Error: Orphaned: include/botan-2/botan/bcrypt_pbkdf.h
Error: Orphaned: include/botan-2/botan/certstor_flatfile.h
Error: Orphaned: include/botan-2/botan/certstor_system.h
Error: Orphaned: include/botan-2/botan/sodium.h
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: include/botan-2/botan/b64_filt.h
Error: Missing: include/botan-2/botan/hex_filt.h
===> Error: Plist issues found.

The alternative would be to have a port that simply installes the shared gtk header.

Sorry for being so timeouty on this. @greg_unrelenting.technology , could you rebase the review to the current tree, so we can proceed with it?

don't forget converters/Makefile :)

ping

In that case, I would go ahead. Some is better than none :)

Looks (x)sane enought to me.

So, if I understand you correctly this makes it work on *some* instead of *none* of the versions?

Create canberra.mk and convert tree to use it.

As discussed with @swills

Thanks.

See also D20828 .

looks good to me

In D20802#450348, @mat wrote:

I don't think the <sect2> are needed, the section is not long, and having examples in a separate subsection does not make a lot of sense (to me at least).
Do you mind if I work on the formatting/presentation? It will probably go faster than going back and forth with all the small remarks I'll think of.