I think the CPACK option is a good idea -- so ship if after the change mat requested.

Please commit the fix to get rid of the shipped icons first.

Looks good to me.

Fix phonon-designerplugins' PKGNAMESUFFIX

Use helper to set PKGNAMESUFFIX

• Fixup MOVED
• set PKGNAMESUFFIX via the helper

my guess is your nexst suggestion is to get rid of LIBPROXY_SLAVE and see if PKGNAMESUFFIX is set? :D

Use lowercase names for LIBPROXY_SLAVES

Nope, looks good for me.

You need to add it to the textproc/Makefile too

Let's hope not too many :)

Looks good to me.

Apart from the eMail it looks fine.

This fails to patch for me on current -- interstingly it works on 10.4...

ping portmgr i.e. @mat :)

ping @mat :)

CURDIR:H in the masterport again.

Your last change looks broken :)

Otheriwse, it looks good -- but as you are not the maintainer, you need to get the OK for rihaz.jerrin@gmail.com first.

I had a similar patch prepared but seem to have forgotten about it :)

Thanks for checking :)

If @rakuco has nothing more to add, it looks fine to me.

I assume you also checked the slave port devel/bazel-clang38? :)

I think you're fine without the explicit approval here.

You could also think about making the python one a slave of the other while you're here.

Change to .CURDIR in masterport and fix the others.

In D15023#332095, @fernape wrote:

Hi there :)

Does this revision need more changes/testing?

Sorry, I forgot to accept it :)

You need to bump the PORTTREVISION too.

Move variables around, use CURDIR/..

Fix CMAKE_ARGS for libproxy-webkit3.

Without fancy option magic... :)
... and with working mozjs on 10.4

Looks sensible.

In D15655#330950, @mat wrote:

Side note, I don't really like abusing OPTIONS with a vengeance like this, I think it was better before with the LIBPROXY_SLAVE variable.

.. actually exclude it

• Cleanup python part
• Don't exclude the current option.

Reduce the number of 'kde's in the names.

@mat, do you have an idea how to do the python stuff nicer?

Did not auto close

Looks good to me.