In D40181#914807, @vvd wrote:

Build tested in poudriere on 12.4, 13.1 and 13.2 amd64.

lgtm, thanks

Moin moin

The metaports don't have their version updated, you could likely just use
PORTVERSION=${_GST1_VERSION}
in those too

looks good to me

This looks sensible to me (and I assume/know it is well tested by you). Please make sure to bump ports depending on magick, so that the new flavored dependency is certainly picked up.

overcome by events

here are some more non-technical nit-picks, before I finally have time to really look at it :)

ship it

• Trigger: ignore pkg's arg and walk site-lib-dir on our own

... refactor a bit

• Fix lua bool

• Remove old trigger ucl

@mandree, @vishwin could you please check the rework.

arc failed to push to D34739

• Reinstate python-pycache port containing the trigger

• Fix print statements again (no arrows requested)

• Unify print statements

Revert the no-compile change (for a separate review).

In D38165#885757, @kai wrote:

In D38165#885649, @tcberner wrote:

I of course did not read a single patch in files/ :).

But I trust you made sure it works fine.

This is understandable, because in files/ lurk several dangers. :)

Ping? In the meantime, had anyone else of kde@ been able to test this diff of www/qt5-webengine a bit with some consumers?

sorry for the silence -- I generally assume that your patches work :D

I'll rebuild my repo with it, and will see whether kmail works tomorrow.

No worries and thank you for the feedback. :)

My only concern was that www/qt5-webengine can be cross-checked for runtime by someone else, to avoid the kind of silly glitches that happened with www/qt6-webengine due a hardcoded path that was overlooked.

If I still hadn't heard anything after the ping, I'd have set the next weekend as an ETA to finally get this diff into the ports tree. :D

P.S.: Regarding the aarch64 platform I cannot give an info if its buildable. Presumably, someone will have to adjust some patches afterwards.