• if you override KDE_FRAMEKWORS_VERSION instead of PORTVERSION the distfile would land in frameworks/5.38.1 -- which might be less confusing.
• also note, that the change between 5.38.0 and 5.38.1 is only needed if you want to use plasma5-khotkeys, which is not in ports yet.

Regenerate against current tree.

ping multimedia

Add tab.

Add patch from gentoo [1] to fix libextractor.

Bump revisions.

Or did you mean even setting it to DISTVERSION=0.26-trunk ?

Use DISTVERSION

ship it

Looks good to me. when comparing with
https://www.freebsd.org/doc/en/articles/contributors/staff-committers.html

Given that the exp-run was fine, I think this should be good to go.
@rakuco do you think it's fine to just mark graphics/nomacs broken for now? -- I did not yet receive any response on the update pr for it, and as it is a major update, I would like some response ore wait for some timeout.

Looks good to me.

Update kf5-extra-cmake-modules distinfo

Thanks antoine.

Add the session files for

• kde4 (in x11/kde4-workspace -- makes more sense than to ship it with sddm)
• xinitrc

and a launch script for the latter.

sddm++

https://github.com/mean00/avidemux2/commit/68df30b902540e6f299dc63ea3ae53b3d353cbe4 contains a fix for the narrowing, probably.

You might reconsider just dropping this port given
https://github.com/sebastianbergmann/git/commit/e92926d76127378fc9f461fa3e6bbbe70a2165b5

Looks good to me.

In D12043#250992, @6yearold_gmail.com wrote:

In D12043#250952, @tcberner wrote:

Also

Warning: Couldn't figure out C compiler information!
         Make sure you're using GNU gcc, or clang

I think you still need to modify one of the files I mentioned in the 8.0.2 review to get rid of that.

If I understand it right, this message is produced by bootstrap GHC, which is not yet aware of FreeBSD clang (patch-compiler_main_SysTools.hs patch). The resulting GHC does not produce these messages anymore.

Also

Warning: Couldn't figure out C compiler information!
         Make sure you're using GNU gcc, or clang

Fix fetch (PORTVERSION derives from DISTVERISON and is modified)

Fix kf5-kxmlgui (revert attica5 -> attica)

I used it for a while in konqueror & otter to test, and it seemed fine.

In D9048#248479, @rakuco wrote:

not sure if you're waiting for feedback; still looks good to me.

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221339

Obvious typo is obvious...

Fix skrooge

Reinstate the EPGF patch. The upstreamed one just adds some if (OS = ) instead of directly setting the path, so this one is easier.

Don't specify license.

Use pathfix (modified) and official tar.xz file -- MASTER_SITES seems a bit hacky.

Update lang/ghc's plist to include the manpage.

Switch to new diff.

Update MOVED.

Switch to @pgj's newest diff.

I think I did not commit this, because like kdesvn it will need kboomarkedit, I think...

Don't drop marble...

Unbreak the okular and kate component again.

In D11899#246695, @groot_kde.org wrote:

Other than minor comments, LGTM.

I think this is the same way we did it for the other ports we already updated.

Exp-run pr: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221278

Add CONFLICTS_INSTALL.

• fix plist of kdelibs4
• libksane component

• remove holiday dependency in plasma5-plasma-workspace
• chase some renamed USE_KDE components