games/lwjgl3: new port - required for games/minecraft-client 1.20.x

[vvd]

Summary

This port required for games/minecraft-client (Java Minecraft Client) 1.20.x run on FreeBSD without linux compatibility layer.

Upstream support FreeBSD on amd64 only, but on linux they support i386, arm* and ppc* too - if somebody can and want to add support for other arches - welcome.

Tested build in poudriere and in live system 13.2-p10 amd64.

Some details are here: https://github.com/LWJGL/lwjgl3/issues/421#issuecomment-1964114740

The port have a lot of "controversial decisions" and hacks now.

[arrowd]

games/lwjgl3/Makefile

109

Can't the dynamic library be used there?

139

libc.so.[0-9] would be better there.

[tcberner]

I get a linker error on current:

   [Linker] ld: error: relocation R_X86_64_32S cannot be used against symbol '.Lswitch.table.ffi_prep_cif_machdep_efi64'; recompile with -fPIC
   [Linker] >>> defined in /wrkdirs/usr/ports/games/lwjgl3/work/lwjgl3-de8bd86/bin/libs/native/freebsd/x64/org/lwjgl/libffi.a(ffiw64.o)
   [Linker] >>> referenced by ffiw64.o:(ffi_prep_cif_machdep_efi64) in archive /wrkdirs/usr/ports/games/lwjgl3/work/lwjgl3-de8bd86/bin/libs/native/freebsd/x64/org/lwjgl/libffi.a
   [Linker]
[...]

[vvd]

In D44263#1009719, @tcberner wrote:

I get a linker error on current:

   [Linker] ld: error: relocation R_X86_64_32S cannot be used against symbol '.Lswitch.table.ffi_prep_cif_machdep_efi64'; recompile with -fPIC
   [Linker] >>> defined in /wrkdirs/usr/ports/games/lwjgl3/work/lwjgl3-de8bd86/bin/libs/native/freebsd/x64/org/lwjgl/libffi.a(ffiw64.o)
   [Linker] >>> referenced by ffiw64.o:(ffi_prep_cif_machdep_efi64) in archive /wrkdirs/usr/ports/games/lwjgl3/work/lwjgl3-de8bd86/bin/libs/native/freebsd/x64/org/lwjgl/libffi.a
   [Linker]
[...]

I forgot to say that devel/libffi must be build with CFLAGS+=-fPIC in Makefile.
Added kbowling@ (maintainer of the devel/libffi) to CC.

[vvd]

games/lwjgl3/Makefile

109

This is more of a question for upstream - they did so.

139

What to do when becomes libc.so.10?

[vvd]

games/lwjgl3/files/patch-modules_lwjgl_jemalloc_src_generated_java_org_lwjgl_system_jemalloc_JEmalloc.java

53

This part can be removed.

[arrowd]

games/lwjgl3/Makefile

109

Well, try the .so, don't blindly follow upstream.

139

Right, maybe libc.so.[0-9]* then...

[vvd]

games/lwjgl3/Makefile

109

The build system aims to link statically with this library. For all platforms.
I don't know how to fix this quickly.

139

How is this different from libc.so.* then?

[vvd]

games/lwjgl3/Makefile

139

I checked 11.4, 12.4, 13.2, 13.3, 14.0 - all have libc.so.7.
No bumps.

[arrowd]

games/lwjgl3/Makefile

139

How is this different from libc.so.* then?

Who knows what this wildcard might match. I've seen libraries ending with .full and it also might be a .debug suffix. I still think that [0-9] is fine and when we get to 10, the port would just need to be updated.

[arrowd]

Statically linking to libffi is still a show-stopper. It shouldn't be required.

[vvd]

Explanation why upstream use static link with libffi: https://github.com/LWJGL/lwjgl3/issues/421#issuecomment-1992147241
I also ask to help explain to upstream what ports are and what the work of maintainers is.
My English is too bad to do this correctly even with the help of online translators.

[vvd]

games/lwjgl3/Makefile

139

I hardcoded in patch libc.so.7.
After bump (in 15? in 16?) I'll update port.

[vvd]

Replaced static link with libffi with dynamic!

[arrowd]

Don't forget to add the port to games/Makefile.

[vvd]

Better handle with libffi.