net/remmina: fix build with GVNC if gtk-vnc build without PULSEAUDIO and sort out dependencies

[vvd]

Summary

Changes:

1. If net/gtk-vnc build with PULSEAUDIO off then build of the net/remmina fails if GVNC option is on:

pkg-static: Unable to access file /tmp/work/usr/ports/net/remmina/work-default/stage/usr/local/lib/remmina/plugins/remmina-plugin-gvnc.so:No such file or directory
pkg-static: Unable to access file /tmp/work/usr/ports/net/remmina/work-default/stage/usr/local/share/icons/hicolor/scalable/emblems/org.remmina.Remmina-gvnc-symbolic.svg:No such file or directory

Added patch to fix build remmina-plugin-gvnc.so plugin. Tested run using this plugin without pulse.

2. Port have 2 options with same name GVNC.

3. Options GVNC and VNC are mixed up.

4. Removed unnecessary dependencies (from atk, pcre, jpeg, harfbuzz, gnutls, xkbfile and etc).

5. Moved dependency from libsoup to WWW only.

6. Replaced dependency from libfreerdp2.so (not linked) with libfreerdp-client2.so and libwinpr2.so.2 (linked).

Tested build with a lot of different combinations of options in poudriere and in live system 13.2-p10 amd64.
Tested run too.

[tcberner]

net/remmina/Makefile

37

^

CMAKE_OFF=WITH_APPINDICATOR

[vvd]

net/remmina/Makefile

37

Agree. Done.

[fernape]

Thank you very much for the cleanup.
I had a build test to fix the VNC - GVNC mixup. Unfortunately it requires rebuilding rust and my machine dies since the box is doing other things that can't wait.

[vvd]

In D44152#1007314, @fernape wrote:

Thank you very much for the cleanup.
I had a build test to fix the VNC - GVNC mixup. Unfortunately it requires rebuilding rust and my machine dies since the box is doing other things that can't wait.

So should I wait until you test?

[fernape]

In D44152#1007320, @vvd wrote:

In D44152#1007314, @fernape wrote:

Thank you very much for the cleanup.
I had a build test to fix the VNC - GVNC mixup. Unfortunately it requires rebuilding rust and my machine dies since the box is doing other things that can't wait.

So should I wait until you test?

No need.

[vvd]

So you approve the review and I can commit it? :-)

[fernape]

In D44152#1007330, @vvd wrote:

So you approve the review and I can commit it? :-)

LGTM, but I don't feel comfortable approving without build testing.
I'll let the approval to your mentor.
You can use reviewed by: fernape in the commit log though :-)

[fernape]

I finally manage to do some testing.

Thanks for your work.

[tcberner]

ship it