Contributor Reviewers (ports)Tag
ActivePublic

Details

Description

A group that committers can join (opt-in to) to be notified of revisions created by contributors (non-committers).

Perfect for grooming and teaching proactive contributors for future mentorship.

Recent Activity

Fri, Aug 3

uzsolt_uzsolt.hu added a member for Contributor Reviewers (ports): uzsolt_uzsolt.hu.
Fri, Aug 3, 9:40 AM

Wed, Aug 1

0mp added a member for Contributor Reviewers (ports): 0mp.
Wed, Aug 1, 3:45 PM

Tue, Jul 31

freebsd_ports_k-worx.org added inline comments to D16484: Add new port textproc/scancode-toolkit.
Tue, Jul 31, 2:12 PM · Contributor Reviewers (ports)
freebsd_ports_k-worx.org updated the diff for D16484: Add new port textproc/scancode-toolkit.

The updated diff contains a revision of the install target regarding the ${RLN} operations as pointed out by mat@:

Tue, Jul 31, 2:01 PM · Contributor Reviewers (ports)

Mon, Jul 30

mat added inline comments to D16484: Add new port textproc/scancode-toolkit.
Mon, Jul 30, 9:04 PM · Contributor Reviewers (ports)
freebsd_ports_k-worx.org added inline comments to D16484: Add new port textproc/scancode-toolkit.
Mon, Jul 30, 5:42 PM · Contributor Reviewers (ports)
freebsd_ports_k-worx.org updated the diff for D16484: Add new port textproc/scancode-toolkit.

Addressing given hints and suggestions from mat@:

Mon, Jul 30, 5:23 PM · Contributor Reviewers (ports)
mat added inline comments to D16484: Add new port textproc/scancode-toolkit.
Mon, Jul 30, 1:15 PM · Contributor Reviewers (ports)
freebsd_ports_k-worx.org updated the diff for D16484: Add new port textproc/scancode-toolkit.

Addressing the remarks given by mat@:

Mon, Jul 30, 11:29 AM · Contributor Reviewers (ports)
mat added inline comments to D16484: Add new port textproc/scancode-toolkit.
Mon, Jul 30, 10:15 AM · Contributor Reviewers (ports)
freebsd_ports_k-worx.org updated the diff for D16484: Add new port textproc/scancode-toolkit.

Addressing a suggestion miwi@ gave me on IRC:

Mon, Jul 30, 9:42 AM · Contributor Reviewers (ports)

Sun, Jul 29

freebsd_ports_k-worx.org added inline comments to D16484: Add new port textproc/scancode-toolkit.
Sun, Jul 29, 3:31 PM · Contributor Reviewers (ports)
freebsd_ports_k-worx.org updated the diff for D16484: Add new port textproc/scancode-toolkit.

Addressed the hint from mat@:

Sun, Jul 29, 3:29 PM · Contributor Reviewers (ports)
mat added inline comments to D16484: Add new port textproc/scancode-toolkit.
Sun, Jul 29, 2:25 PM · Contributor Reviewers (ports)
freebsd_ports_k-worx.org added a comment to D16484: Add new port textproc/scancode-toolkit.
In D16484#350055, @pfg wrote:

I think you still have to fix the shebang on "configure".

I created a new issue on github to track the fixes:

https://github.com/nexB/scancode-toolkit/issues/1147

Sun, Jul 29, 1:16 PM · Contributor Reviewers (ports)
pfg added a comment to D16484: Add new port textproc/scancode-toolkit.

I think you still have to fix the shebang on "configure".

Sun, Jul 29, 12:55 AM · Contributor Reviewers (ports)
pfg added a comment to D16484: Add new port textproc/scancode-toolkit.

Cool thanks! Please try to upstream the changes when you can.

Sun, Jul 29, 12:46 AM · Contributor Reviewers (ports)

Sat, Jul 28

miwi added a project to D16484: Add new port textproc/scancode-toolkit: Contributor Reviewers (ports).
Sat, Jul 28, 4:32 PM · Contributor Reviewers (ports)

Jul 15 2018

tcberner closed D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..
Jul 15 2018, 1:34 PM · Contributor Reviewers (ports)

Jun 30 2018

lbdm_privacychain.ch updated the diff for D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..

Minor.

Jun 30 2018, 11:47 PM · Contributor Reviewers (ports)
lbdm_privacychain.ch updated the diff for D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..

Done. ^^

Jun 30 2018, 5:14 PM · Contributor Reviewers (ports)
lbdm_privacychain.ch retitled D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar. from [New PORT] x11/admiral: Executes multiple programs concurrently to generate output for bars. to [New PORT] x11/admiral: Merge concurrent outputs for a status bar..
Jun 30 2018, 5:14 PM · Contributor Reviewers (ports)
mat added inline comments to D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..
Jun 30 2018, 10:01 AM · Contributor Reviewers (ports)
adridg added a comment to D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..

Fine except for the confusion over "bars"

Jun 30 2018, 9:27 AM · Contributor Reviewers (ports)
tcberner added a comment to D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..

Is everyone happy with this now? :)

Jun 30 2018, 7:23 AM · Contributor Reviewers (ports)

Jun 19 2018

mat added a comment to D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..

Thank you @mat I thought ${COPYTREE_SHARE} would just worked for files.

Jun 19 2018, 11:41 AM · Contributor Reviewers (ports)

Jun 18 2018

lbdm_privacychain.ch updated the diff for D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..

Thank you @mat I thought ${COPYTREE_SHARE} would just worked for files.

Jun 18 2018, 10:11 PM · Contributor Reviewers (ports)
mat added inline comments to D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..
Jun 18 2018, 9:42 PM · Contributor Reviewers (ports)
lbdm_privacychain.ch updated the diff for D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..

Done.

Jun 18 2018, 5:14 PM · Contributor Reviewers (ports)
mat added inline comments to D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..
Jun 18 2018, 10:17 AM · Contributor Reviewers (ports)

Jun 16 2018

lbdm_privacychain.ch updated the diff for D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..

Done.

Jun 16 2018, 6:13 PM · Contributor Reviewers (ports)
tobik added inline comments to D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..
Jun 16 2018, 8:20 AM · Contributor Reviewers (ports)
lbdm_privacychain.ch updated the diff for D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..

Re-organizing OPTIONS.

Jun 16 2018, 8:08 AM · Contributor Reviewers (ports)
lbdm_privacychain.ch updated the diff for D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..

Fix contiguous blank lines.

Jun 16 2018, 8:06 AM · Contributor Reviewers (ports)
lbdm_privacychain.ch updated the diff for D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..

With these changes I get this error message:

Jun 16 2018, 8:02 AM · Contributor Reviewers (ports)
tobik added a comment to D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..

Done.

I think PLIST_FILES cannot be used when PORTEXAMPLES is set, can you confirm please?

Thanks!

Jun 16 2018, 7:55 AM · Contributor Reviewers (ports)
lbdm_privacychain.ch updated the diff for D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..

I think PLIST_FILES cannot be used when PORTEXAMPLES is set, can you confirm please?

Jun 16 2018, 7:50 AM · Contributor Reviewers (ports)
lbdm_privacychain.ch added inline comments to D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..
Jun 16 2018, 4:01 AM · Contributor Reviewers (ports)
lbdm_privacychain.ch added inline comments to D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..
Jun 16 2018, 4:00 AM · Contributor Reviewers (ports)
tobik added inline comments to D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..
Jun 16 2018, 3:28 AM · Contributor Reviewers (ports)
lbdm_privacychain.ch updated the summary of D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar..
Jun 16 2018, 2:55 AM · Contributor Reviewers (ports)
lbdm_privacychain.ch retitled D15840: [New PORT] x11/admiral: Merge concurrent outputs for a status bar. from [New PORT] x11/admiral to [New PORT] x11/admiral: Executes multiple programs concurrently to generate output for bars..
Jun 16 2018, 2:52 AM · Contributor Reviewers (ports)

Jun 2 2018

tcberner added a member for Contributor Reviewers (ports): tcberner.
Jun 2 2018, 3:44 PM

May 21 2018

mat added inline comments to D15079: Update sysutils/hared to 1.0-45.
May 21 2018, 2:59 PM · Contributor Reviewers (ports)

May 18 2018

0mp added inline comments to D15079: Update sysutils/hared to 1.0-45.
May 18 2018, 3:51 PM · Contributor Reviewers (ports)
dvl added inline comments to D15079: Update sysutils/hared to 1.0-45.
May 18 2018, 3:40 PM · Contributor Reviewers (ports)
0mp added inline comments to D15079: Update sysutils/hared to 1.0-45.
May 18 2018, 3:34 PM · Contributor Reviewers (ports)
mat added inline comments to D15079: Update sysutils/hared to 1.0-45.
May 18 2018, 1:14 PM · Contributor Reviewers (ports)

May 17 2018

dvl closed D15079: Update sysutils/hared to 1.0-45.
May 17 2018, 2:12 PM · Contributor Reviewers (ports)
dvl added a comment to D15079: Update sysutils/hared to 1.0-45.
In D15079#326073, @0mp wrote:

@dvl Great!

BTW, I think you've missed the sysutils/py-hared part of the patch I provided: https://reviews.freebsd.org/D15079?id=41496

May 17 2018, 2:12 PM · Contributor Reviewers (ports)