matthew (Matthew Seaman)
User

Projects

User Details

User Since
May 10 2014, 7:23 AM (214 w, 5 d)

Recent Activity

Yesterday

matthew accepted D15930: textproc/py-qrcode: Update to 6.0.

lgtm

Wed, Jun 20, 9:51 PM
matthew requested changes to D15930: textproc/py-qrcode: Update to 6.0.

What mat said. Always use PY_FLAVOR for python dependencies.

Wed, Jun 20, 8:52 PM

Sat, Jun 16

matthew accepted D15841: Migrate tcpdump to a dedicated user.

Approved, subject to addressing my latest comments.

Sat, Jun 16, 8:09 PM
matthew added a comment to D15841: Migrate tcpdump to a dedicated user.

Test builds with the USER option selected are failing when trying to create the tcpdump group due to a malformed GIDs line.
Fixing that locally means everything builds OK, although there is this warning at the end of the configure phase:

Sat, Jun 16, 8:00 PM
matthew added a reviewer for D15841: Migrate tcpdump to a dedicated user: matthew.
Sat, Jun 16, 7:00 AM
matthew added a comment to D15841: Migrate tcpdump to a dedicated user.

This is good, but you need to add the last bit that will create the special user when the package is installed.

Sat, Jun 16, 7:00 AM

Tue, Jun 12

matthew committed rS334992: Take in Peter Grehan's commit bit for safe-keeping, at his own request..
Take in Peter Grehan's commit bit for safe-keeping, at his own request.
Tue, Jun 12, 8:19 AM

Sun, Jun 10

matthew closed D10413: FreeBSD Project Associates.
Sun, Jun 10, 4:08 PM
matthew committed rD51812: Update wording to highlight that FreeBSD Project Members are meant to.
Update wording to highlight that FreeBSD Project Members are meant to
Sun, Jun 10, 4:08 PM

Fri, Jun 8

matthew accepted D15678: Update security/bro to 2.5.4.
Fri, Jun 8, 3:43 PM
matthew added a comment to D15678: Update security/bro to 2.5.4.

Can you add a VuXML entry (will need yet another review...) /before/ you commit here -- add the VuXML Id under the Security: tag in the commit message for this.
Also, don't forget to add MFH: 2018Q2. Once ports-secteam approves, you're approved for the merge to the quarterly branch too.

Fri, Jun 8, 3:35 PM

Thu, Jun 7

matthew created D15695: Report on PGP key validity.
Thu, Jun 7, 5:47 PM

Mon, Jun 4

matthew committed rS334608: Restore kevlo's src commit bit after only 4 months and 3 weeks away..
Restore kevlo's src commit bit after only 4 months and 3 weeks away.
Mon, Jun 4, 5:55 AM

Sun, May 27

matthew committed rP470968: Update to 8.35.0.
Update to 8.35.0
Sun, May 27, 8:37 AM

Sat, May 26

matthew committed rP470951: Update to 2.4.
Update to 2.4
Sat, May 26, 10:40 PM

Fri, May 25

matthew committed rP470823: Update to 4.8.1.
Update to 4.8.1
Fri, May 25, 7:51 AM

May 18 2018

matthew committed rP470266: Update to 1.2.16.
Update to 1.2.16
May 18 2018, 5:18 AM

May 17 2018

matthew committed rP470249: Update to 7.4.0.
Update to 7.4.0
May 17 2018, 9:46 PM

May 7 2018

matthew accepted D15312: devel/xtensa-esp32-elf: Fix build as non-root user (pkg-fallout).

I can't reproduce whatever pkg-fallout was unhappy about.

May 7 2018, 3:30 PM

May 4 2018

matthew accepted D15287: devel/xtensa-esp32-elf: merge *-configure and *-build targets.

lgtm

May 4 2018, 8:03 AM

May 3 2018

matthew accepted D15271: New port: devel/xtensa-esp32-elf - build the Espressif ESP32 toolchain to support Arduino and FreeRTOS projects.

Yes, everything builds just fine on 10.4 and 11.1, which are the currently supported versions.

May 3 2018, 9:40 PM
matthew added a comment to D15271: New port: devel/xtensa-esp32-elf - build the Espressif ESP32 toolchain to support Arduino and FreeRTOS projects.

Test builds I ran overnight all failed on 10.3-RELEASE due to 'bad C++ code' in many of the dependencies. Of course, since yesterday I should be testing on 10.4-RELEASE...

I spent the last few weeks upgrading ~50 systems from 10.3 to 11.1-RELEASE (starting with my build servers), should I create a 10.4-RELEASE jail to test with?

May 3 2018, 9:04 AM
matthew added a comment to D15271: New port: devel/xtensa-esp32-elf - build the Espressif ESP32 toolchain to support Arduino and FreeRTOS projects.

Test builds I ran overnight all failed on 10.3-RELEASE due to 'bad C++ code' in many of the dependencies. Of course, since yesterday I should be testing on 10.4-RELEASE...

May 3 2018, 6:09 AM

May 2 2018

matthew added a comment to D15271: New port: devel/xtensa-esp32-elf - build the Espressif ESP32 toolchain to support Arduino and FreeRTOS projects.

Yes, you need a COMMENT line -- it's required in all ports. What you have is fine.

May 2 2018, 10:55 PM

Apr 28 2018

matthew committed rP468537: * Review port dependencies based on composer.json files included in.
* Review port dependencies based on composer.json files included in
Apr 28 2018, 11:24 AM

Apr 22 2018

matthew committed rD51582: Extend the expiration date for my PGP keys for another two years..
Extend the expiration date for my PGP keys for another two years.
Apr 22 2018, 8:10 AM

Apr 21 2018

matthew committed rP467899: MFH: r466558 r466791 r467800.
MFH: r466558 r466791 r467800
Apr 21 2018, 4:30 PM

Apr 19 2018

matthew committed rP467800: Security Update to 4.8.0.1.
Security Update to 4.8.0.1
Apr 19 2018, 7:21 PM
matthew committed rP467799: Document the latest phpMyAdmin vulnerabilities.
Document the latest phpMyAdmin vulnerabilities
Apr 19 2018, 7:17 PM

Apr 15 2018

matthew committed rP467436: Update to 8.34.0.
Update to 8.34.0
Apr 15 2018, 9:26 PM

Apr 8 2018

matthew committed rP466791: Upgrade to 4.8.0.
Upgrade to 4.8.0
Apr 8 2018, 10:54 AM

Apr 5 2018

matthew accepted D14970: Add PHP flavors to phpMyAdmin..

lgtm

Apr 5 2018, 1:11 PM

Apr 2 2018

matthew committed rP466259: Modernization: switch to USES=php:web.
Modernization: switch to USES=php:web
Apr 2 2018, 8:12 PM

Mar 31 2018

matthew abandoned D12592: New USES+=django and Django default version.

Yeah. This approach is a non-starter. Adding django bits to python.mk is probably a better route as Antoine suggests,
but that'sbasically a start-over.

Mar 31 2018, 5:49 PM
matthew committed rP466040: Update to 2.2.0.
Update to 2.2.0
Mar 31 2018, 11:26 AM

Mar 30 2018

matthew committed rP465968: Upgrade to 1.2.5.
Upgrade to 1.2.5
Mar 30 2018, 1:16 PM

Mar 25 2018

matthew committed rP465548: Update to 1.2.15.
Update to 1.2.15
Mar 25 2018, 10:05 PM

Mar 17 2018

matthew committed rP464771: Update to 7.3.0.
Update to 7.3.0
Mar 17 2018, 9:12 AM

Mar 15 2018

matthew committed rP464626: Update to 5.1.46.
Update to 5.1.46
Mar 15 2018, 7:48 PM
matthew committed rP464566: Update to 1.0.3.
Update to 1.0.3
Mar 15 2018, 7:31 AM
matthew committed rP464564: Update to 1.6.1.
Update to 1.6.1
Mar 15 2018, 7:04 AM

Mar 12 2018

matthew accepted D14659: www/chromium: add CUPS option.

Ah -- I see cpm@ has commented on the bugzilla PR. Remember to add him to the Approved by: line when you commit.
lgtm

Mar 12 2018, 7:28 AM
matthew added a comment to D14659: www/chromium: add CUPS option.

This looks OK, on the face of it, although I'm having some (hopefully temporary) local troubles getting a test build to work.
Are you in contact with the chromium@ developers? According to https://wiki.freebsd.org/Chromium that's rene@freebsd.org or cpm@freebsd.org:
it might be worth adding them as reviewers.

Mar 12 2018, 7:22 AM

Mar 7 2018

matthew committed rP463832: Upgrade to 8.33.1.
Upgrade to 8.33.1
Mar 7 2018, 9:29 PM

Mar 6 2018

matthew committed rP463694: Update to 4.7.9.
Update to 4.7.9
Mar 6 2018, 7:32 AM

Mar 1 2018

matthew committed rS330134: Take in remko's src commit bit for archiving, at his own request..
Take in remko's src commit bit for archiving, at his own request.
Mar 1 2018, 12:05 AM

Feb 23 2018

matthew committed rP462699: MFH: r462566.
MFH: r462566
Feb 23 2018, 2:11 PM
matthew committed rP462687: Update to 8.33.0.
Update to 8.33.0
Feb 23 2018, 12:24 PM

Feb 22 2018

matthew committed rP462566: Security update to 4.7.8.
Security update to 4.7.8
Feb 22 2018, 7:20 AM
matthew committed rP462564: Document the latest phpMyAdmin security advisory PMASA-2018-1.
Document the latest phpMyAdmin security advisory PMASA-2018-1
Feb 22 2018, 7:15 AM

Feb 20 2018

matthew accepted D14444: security/bro: Update to 2.5.3 and address security advisory.

lgtm

Feb 20 2018, 7:20 PM

Feb 19 2018

matthew accepted D14378: security/bro: Add a NETMAP option to build and install the bro netmap plugin.

lgtm

Feb 19 2018, 6:30 AM

Feb 16 2018

matthew accepted D14378: security/bro: Add a NETMAP option to build and install the bro netmap plugin.

lgtm

Feb 16 2018, 7:25 AM
matthew accepted D14395: Mark bro < 2.5.3 as vulnerable.

lgtm

Feb 16 2018, 6:38 AM

Feb 9 2018

matthew accepted D14218: www/mini_httpd: Update to 1.28 and address security advisory.

but you should create (and get reviewed) a VuXML entry for the vulnerabilities before you commit, and reference the VuXML from your commit
message. The 'Security' tab in the commit template should contain the VuXMLid, although it is frequently used for other identifying numbers.

Feb 9 2018, 7:27 AM

Feb 8 2018

matthew committed rP461198: Update to 7.2.1.
Update to 7.2.1
Feb 8 2018, 7:05 AM

Feb 4 2018

matthew committed rP460879: Patches to make the code compatible with clang-6.0 / C++17 -- this will.
Patches to make the code compatible with clang-6.0 / C++17 -- this will
Feb 4 2018, 9:16 AM

Jan 29 2018

matthew committed rP460243: Upgrade to 0.2.2.
Upgrade to 0.2.2
Jan 29 2018, 7:44 AM
matthew committed rP460242: Update to 0.5.3.
Update to 0.5.3
Jan 29 2018, 7:42 AM
matthew added a comment to D14102: New port: lang/retro12: Clean, elegant, and pragmatic dialect of Forth.
In D14102#295965, @yuri wrote:

The submitter says in Bugzilla that he obtained the 0mp@FreeBSD.org address during the Google Summer of Code. He also uses this address for one other port.
Either this address can be kept as MAINTAINER, or it can also be changed to his other e-mail address.

Jan 29 2018, 6:41 AM

Jan 17 2018

matthew committed rP459291: Update to 7.2.0.
Update to 7.2.0
Jan 17 2018, 10:18 PM

Jan 16 2018

matthew accepted D13902: textproc/py-qrcode fix man page path.

LGTM, but remember that you should get maintainer approval before committing.

Jan 16 2018, 10:55 AM
matthew added a comment to D8996: Make the base package each have a different origin..

Considering the recent changes in ports to do with FLAVORS, which has definitively broken the 1-to-1 relation between pkg name and port origin, is this change still desirable?

Jan 16 2018, 10:38 AM

Jan 11 2018

matthew committed rP458801: Update to 2.1.1.
Update to 2.1.1
Jan 11 2018, 10:57 PM

Jan 10 2018

matthew committed rP458701: Update to 8.32.0.
Update to 8.32.0
Jan 10 2018, 11:17 PM
matthew committed rS327799: Take in kevlo's commit bit, at his own request..
Take in kevlo's commit bit, at his own request.
Jan 10 2018, 10:19 PM

Jan 7 2018

matthew committed rP458373: Update to 7.1.2.
Update to 7.1.2
Jan 7 2018, 7:17 PM

Jan 5 2018

matthew added inline comments to D12592: New USES+=django and Django default version.
Jan 5 2018, 7:13 AM

Jan 4 2018

matthew updated the diff for D12592: New USES+=django and Django default version.
  • Merge branch 'master' into arcpatch-D12592
  • Add new py-django-netfields port
Jan 4 2018, 7:30 AM

Jan 3 2018

matthew added inline comments to D12592: New USES+=django and Django default version.
Jan 3 2018, 6:59 PM
matthew updated the diff for D12592: New USES+=django and Django default version.
  • Merge branch 'master' into arcpatch-D12592
Jan 3 2018, 6:35 AM

Jan 2 2018

matthew added inline comments to D12592: New USES+=django and Django default version.
Jan 2 2018, 4:14 PM
matthew updated the diff for D12592: New USES+=django and Django default version.
  • Merge branch 'master' into arcpatch-D12592
Jan 2 2018, 6:51 AM

Jan 1 2018

matthew updated the diff for D12592: New USES+=django and Django default version.
  • Merge branch 'master' into arcpatch-D12592
Jan 1 2018, 9:01 PM
matthew updated the summary of D12592: New USES+=django and Django default version.
Jan 1 2018, 8:26 AM

Dec 31 2017

matthew updated the diff for D12592: New USES+=django and Django default version.

Fix remaining build problems. Every Django related port now builds
correctly.

Dec 31 2017, 9:21 PM
matthew updated the diff for D12592: New USES+=django and Django default version.

Major rework of the code, modelled on python.mk

Dec 31 2017, 9:46 AM

Dec 29 2017

matthew committed rP457518: Switch dependency from the deprecated sysutils/rubygem-hiera1 to….
Switch dependency from the deprecated sysutils/rubygem-hiera1 to…
Dec 29 2017, 6:26 PM

Dec 23 2017

matthew committed rP457102: Security Upate to 4.7.7.
Security Upate to 4.7.7
Dec 23 2017, 7:33 PM
matthew committed rP457086: Document phpMyAdmin PMSA-2017-9: Critical XSRF/CSRF vulnerability..
Document phpMyAdmin PMSA-2017-9: Critical XSRF/CSRF vulnerability.
Dec 23 2017, 5:03 PM
matthew committed rS327104: Restore Wolfram Schneider's commit bit at his request. Conrad Meyer.
Restore Wolfram Schneider's commit bit at his request. Conrad Meyer
Dec 23 2017, 12:44 PM

Dec 21 2017

matthew added a comment to D12592: New USES+=django and Django default version.
In D12592#283856, @mat wrote:
Dec 21 2017, 3:50 PM
matthew added a comment to D12592: New USES+=django and Django default version.

Merge upstream changes -- ie. package flavours. www/seahub is
problematic, causing the whole poudriere bulk to fail if included in
the list of package targets. Other than that, builds correctly with
both py27 and py36.

Creating django111 and django20 flavours would be interesting, but
that implies packages with multiple flavors which is a problem.

  • Use the Django pkgname prefix for dependencies
  • Add django-2.0 to the list of possible versions.

    ToDo:

    fix www/seahub DJANGO_REL -- release value equivalent to PYTHON_REL

It maybe time to rename the port to py-seahub. Is this the issue you are running into? Seahub only runs on py27 and django 18. Let me know if there is anything I can assist with.

Dec 21 2017, 1:21 PM

Dec 19 2017

matthew updated the diff for D12592: New USES+=django and Django default version.

Merge upstream changes -- ie. package flavours. www/seahub is
problematic, causing the whole poudriere bulk to fail if included in
the list of package targets. Other than that, builds correctly with
both py27 and py36.

Dec 19 2017, 6:43 AM

Dec 13 2017

matthew added a comment to D13473: devel/youcompleteme: Code-completion engine for Vim.

Test build shows plist problems -- seems there are files left over:

=>> Checking for extra files and directories
=>> Error: Files or directories left over:
@dir share/vim/vimfiles
@dir share/vim/vimfiles/doc
share/vim/vimfiles/doc/tags
build of devel/youcompleteme | YouCompleteMe-g20171203 ended at Wed Dec 13 12:43:26 GMT 2017
build time: 00:04:55
Dec 13 2017, 3:33 PM
matthew added inline comments to D13473: devel/youcompleteme: Code-completion engine for Vim.
Dec 13 2017, 7:42 AM

Dec 12 2017

matthew added a comment to D12592: New USES+=django and Django default version.
In D12592#281340, @mat wrote:

So, this is the time to update this and make it use flavors no ?

Dec 12 2017, 1:30 PM

Dec 2 2017

matthew committed rP455381: Update to 5.1.45.
Update to 5.1.45
Dec 2 2017, 6:12 PM
matthew committed rP455380: Upgrade to 7.1.1.
Upgrade to 7.1.1
Dec 2 2017, 6:07 PM

Dec 1 2017

matthew added a comment to D13262: New port: devel/arduino-bsd-mk - build Arduino sketches with make(1).

Note: be sure to use ${PORTSDIR}/Tools/scripts/addport to commit your new port -- this will ensure that it gets hooked up to the ports tree correctly.

Dec 1 2017, 7:32 AM
matthew accepted D13262: New port: devel/arduino-bsd-mk - build Arduino sketches with make(1).

LGTM

Dec 1 2017, 7:29 AM
matthew committed rP455250: Upgrade to 4.7.6.
Upgrade to 4.7.6
Dec 1 2017, 7:07 AM

Nov 30 2017

matthew committed rP455172: Update to 8.31.0.
Update to 8.31.0
Nov 30 2017, 7:01 AM

Nov 29 2017

matthew added inline comments to D13262: New port: devel/arduino-bsd-mk - build Arduino sketches with make(1).
Nov 29 2017, 7:19 AM

Nov 27 2017

matthew requested changes to D13262: New port: devel/arduino-bsd-mk - build Arduino sketches with make(1).
Nov 27 2017, 6:58 AM

Nov 26 2017

matthew accepted D13254: Update the package description WWW url for devel/arduino-mk.

LGTM

Nov 26 2017, 8:15 PM

Nov 19 2017

matthew updated the diff for D12592: New USES+=django and Django default version.

Track upstream changes

Nov 19 2017, 11:06 AM

Nov 17 2017

matthew committed rP454364: Update to 7.1.0.
Update to 7.1.0
Nov 17 2017, 7:38 AM

Nov 7 2017

matthew committed rP453673: Update to 2.6.1.
Update to 2.6.1
Nov 7 2017, 7:37 PM
matthew committed rS325521: Take in ngie's commit bit at their own request..
Take in ngie's commit bit at their own request.
Nov 7 2017, 7:36 PM