In D25742#574817, @lwhsu wrote:

In D25742#574814, @miguel_gocobachi.dev wrote:

Last commit was Jun 30 of this year https://github.com/kakserpom/phpdaemon/commit/9362e586d21343de7fb511f6b3cbfc5ae13a4364

Indeed, sorry that I always got confused by github's new interface. From the commit log, there seems to have lots of fixes after the 1.0-beta release. Would it be a better choice to use a snapshot instead of using a beta release from 4 years ago?

In D25742#574813, @lwhsu wrote:

In D25742#571172, @miguel_gocobachi.dev wrote:

I think I got all the comments covered.

Yeah, all the files look good now and build is fine. I am somehow a bit hesitated to add this because I'm curious if there is any party using this, or there is any software depends on this. The upstream development seems stopped for 4 years. I am happy to add this port even the possible user is very few, but I want to know more about the potential users of this port first.

In D25569#573948, @0mp wrote:

Hmm, it looks like make test is failing (at least when I test it in poudriere).

Have you experienced that? This is the relevant part from the logs of make test:

cd /wrkdirs/usr/ports/deskutils/bookworm/work/bookworm-1.1.2/build && ninja test                                                                                                                           [135/5179]
[0/1] Running all tests.
1/2 Validate desktop file OK             0.01s
2/2 Validate appdata file FAIL           13.55s (exit status 1)

Ok:                 1
Expected Fail:      0
Fail:               1
Unexpected Pass:    0
Skipped:            0
Timeout:            0


The output from the failed tests:

2/2 Validate appdata file FAIL           13.55s (exit status 1)

--- command ---
20:18:52 /usr/local/bin/appstream-util validate /wrkdirs/usr/ports/deskutils/bookworm/work/bookworm-1.1.2/build/data/com.github.babluboy.bookworm.appdata.xml
--- stdout ---
/wrkdirs/usr/ports/deskutils/bookworm/work/bookworm-1.1.2/build/data/com.github.babluboy.bookworm.appdata.xml: FAILED:
? tag-missing           : <translation> not specified
? tag-invalid           : <release> version was duplicated
? attribute-invalid     : <screenshot> height too large [https://raw.githubusercontent.com/babluboy/bookworm/gh-pages/images/BookwormLibraryView.png] maximum is 900px
? style-invalid         : <image> has vertical padding [https://raw.githubusercontent.com/babluboy/bookworm/gh-pages/images/BookwormLibraryView.png]
? style-invalid         : <image> has horizontal padding [https://raw.githubusercontent.com/babluboy/bookworm/gh-pages/images/BookwormLibraryView.png]
? style-invalid         : <p> does not end in '.|:|!' [Right to Left Reading]
? style-invalid         : <li> cannot end in '.' [Use of GResource to speed up loading of icons, scripts, etc.]
? style-invalid         : <p> does not end in '.|:|!' [Annotations and two page views]
? style-invalid         : <p> is too short [Annotations and two page views]
? style-invalid         : <p> does not end in '.|:|!' [Support for MOBI format and UX improvements]
? style-invalid         : <p> is too short [Support for MOBI format and UX improvements]
? style-invalid         : <p> does not end in '.|:|!' [UX improvements for list view and other preference customizations]
? style-invalid         : <p> does not end in '.|:|!' [Comics support and UX improvements]
? style-invalid         : <p> is too short [Comics support and UX improvements]
? style-invalid         : <p> does not end in '.|:|!' [PDF support and UX improvements]
? style-invalid         : <p> is too short [PDF support and UX improvements]
? style-invalid         : <p> does not end in '.|:|!' [Initial release with support for EPUB format]
? style-invalid         : <p> is too short [Initial release with support for EPUB format]
? tag-invalid           : <release> versions are not in order [1.0.0 before 1.1.0]
--- stderr ---
Validation of files failed
-------

thanks guys, I though @wulf was the maintainer as well. But thank you very much for following this up all of you.

I think I got all the comments covered.

Suggestion applied following @mat, @lbartoletti, @zeising

@lwhsu this is ready to be merged.

@wulf or @lwhsu can you merge this into the ports tree? thanks!

In D25742#569683, @zeising wrote:

Can you also include the patch for www/Makefile?

zeising PR suggestions applied

0.0.3 version bumped

applied 0mp suggestions

applied wulf recomendations

understood, thanks!

Updates following the reviews suggestions:

I think I found the solution for this one.