Page MenuHomeFreeBSD

[NEW] deskutils/bookworm: Simple, focused ebook reader
ClosedPublic

Authored by miguel_gocobachi.dev on Jul 6 2020, 12:48 AM.

Details

Summary
[NEW] deskutils/bookworm: Simple, focused ebook reader

Bookworm is a simple, focused eBook reader.

Read the books you love without having to worry about the different format
complexities like epub, pdf, mobi, cbr, etc. This version supports EPUB, PDF
and Comics (CBR and CBZ) formats with support for more formats to follow soon.

WWW: https://babluboy.github.io/bookworm/

Reviewed_by: ??
Differential_Revision: D25569
Test Plan

ePub, MOBI, PDF working so far

  • portlint: ??
  • testport: ??
  • maketest: ?? (ninja test)
  • runtime: ??

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Hmm, it looks like make test is failing (at least when I test it in poudriere).

Have you experienced that? This is the relevant part from the logs of make test:

cd /wrkdirs/usr/ports/deskutils/bookworm/work/bookworm-1.1.2/build && ninja test                                                                                                                           [135/5179]
[0/1] Running all tests.
1/2 Validate desktop file OK             0.01s
2/2 Validate appdata file FAIL           13.55s (exit status 1)

Ok:                 1
Expected Fail:      0
Fail:               1
Unexpected Pass:    0
Skipped:            0
Timeout:            0


The output from the failed tests:

2/2 Validate appdata file FAIL           13.55s (exit status 1)

--- command ---
20:18:52 /usr/local/bin/appstream-util validate /wrkdirs/usr/ports/deskutils/bookworm/work/bookworm-1.1.2/build/data/com.github.babluboy.bookworm.appdata.xml
--- stdout ---
/wrkdirs/usr/ports/deskutils/bookworm/work/bookworm-1.1.2/build/data/com.github.babluboy.bookworm.appdata.xml: FAILED:
? tag-missing           : <translation> not specified
? tag-invalid           : <release> version was duplicated
? attribute-invalid     : <screenshot> height too large [https://raw.githubusercontent.com/babluboy/bookworm/gh-pages/images/BookwormLibraryView.png] maximum is 900px
? style-invalid         : <image> has vertical padding [https://raw.githubusercontent.com/babluboy/bookworm/gh-pages/images/BookwormLibraryView.png]
? style-invalid         : <image> has horizontal padding [https://raw.githubusercontent.com/babluboy/bookworm/gh-pages/images/BookwormLibraryView.png]
? style-invalid         : <p> does not end in '.|:|!' [Right to Left Reading]
? style-invalid         : <li> cannot end in '.' [Use of GResource to speed up loading of icons, scripts, etc.]
? style-invalid         : <p> does not end in '.|:|!' [Annotations and two page views]
? style-invalid         : <p> is too short [Annotations and two page views]
? style-invalid         : <p> does not end in '.|:|!' [Support for MOBI format and UX improvements]
? style-invalid         : <p> is too short [Support for MOBI format and UX improvements]
? style-invalid         : <p> does not end in '.|:|!' [UX improvements for list view and other preference customizations]
? style-invalid         : <p> does not end in '.|:|!' [Comics support and UX improvements]
? style-invalid         : <p> is too short [Comics support and UX improvements]
? style-invalid         : <p> does not end in '.|:|!' [PDF support and UX improvements]
? style-invalid         : <p> is too short [PDF support and UX improvements]
? style-invalid         : <p> does not end in '.|:|!' [Initial release with support for EPUB format]
? style-invalid         : <p> is too short [Initial release with support for EPUB format]
? tag-invalid           : <release> versions are not in order [1.0.0 before 1.1.0]
--- stderr ---
Validation of files failed
-------
In D25569#573948, @0mp wrote:

Hmm, it looks like make test is failing (at least when I test it in poudriere).

Have you experienced that? This is the relevant part from the logs of make test:

cd /wrkdirs/usr/ports/deskutils/bookworm/work/bookworm-1.1.2/build && ninja test                                                                                                                           [135/5179]
[0/1] Running all tests.
1/2 Validate desktop file OK             0.01s
2/2 Validate appdata file FAIL           13.55s (exit status 1)

Ok:                 1
Expected Fail:      0
Fail:               1
Unexpected Pass:    0
Skipped:            0
Timeout:            0


The output from the failed tests:

2/2 Validate appdata file FAIL           13.55s (exit status 1)

--- command ---
20:18:52 /usr/local/bin/appstream-util validate /wrkdirs/usr/ports/deskutils/bookworm/work/bookworm-1.1.2/build/data/com.github.babluboy.bookworm.appdata.xml
--- stdout ---
/wrkdirs/usr/ports/deskutils/bookworm/work/bookworm-1.1.2/build/data/com.github.babluboy.bookworm.appdata.xml: FAILED:
? tag-missing           : <translation> not specified
? tag-invalid           : <release> version was duplicated
? attribute-invalid     : <screenshot> height too large [https://raw.githubusercontent.com/babluboy/bookworm/gh-pages/images/BookwormLibraryView.png] maximum is 900px
? style-invalid         : <image> has vertical padding [https://raw.githubusercontent.com/babluboy/bookworm/gh-pages/images/BookwormLibraryView.png]
? style-invalid         : <image> has horizontal padding [https://raw.githubusercontent.com/babluboy/bookworm/gh-pages/images/BookwormLibraryView.png]
? style-invalid         : <p> does not end in '.|:|!' [Right to Left Reading]
? style-invalid         : <li> cannot end in '.' [Use of GResource to speed up loading of icons, scripts, etc.]
? style-invalid         : <p> does not end in '.|:|!' [Annotations and two page views]
? style-invalid         : <p> is too short [Annotations and two page views]
? style-invalid         : <p> does not end in '.|:|!' [Support for MOBI format and UX improvements]
? style-invalid         : <p> is too short [Support for MOBI format and UX improvements]
? style-invalid         : <p> does not end in '.|:|!' [UX improvements for list view and other preference customizations]
? style-invalid         : <p> does not end in '.|:|!' [Comics support and UX improvements]
? style-invalid         : <p> is too short [Comics support and UX improvements]
? style-invalid         : <p> does not end in '.|:|!' [PDF support and UX improvements]
? style-invalid         : <p> is too short [PDF support and UX improvements]
? style-invalid         : <p> does not end in '.|:|!' [Initial release with support for EPUB format]
? style-invalid         : <p> is too short [Initial release with support for EPUB format]
? tag-invalid           : <release> versions are not in order [1.0.0 before 1.1.0]
--- stderr ---
Validation of files failed
-------

I actually did not run that, I was leaving the rest to you.

0mp added a subscriber: 0mp.

Thanks for the update! Unfortunately, I cannot test the patch myself at the moment. I'll change reviewers to Contributor Reviewers (ports)

Would you like to become the maintainer of this port, @miguel_gocobachi.dev? You've done all the heavy lifting here!

Also, the port is ready to land. I'll commit it once you give me green light.

This revision is now accepted and ready to land.Wed, Oct 6, 7:47 PM
In D25569#729852, @0mp wrote:

Would you like to become the maintainer of this port, @miguel_gocobachi.dev? You've done all the heavy lifting here!

Also, the port is ready to land. I'll commit it once you give me green light.

Okay, I guess that is fair. I will take it as maintainer then. Thank you.

This revision was automatically updated to reflect the committed changes.
koobs retitled this revision from deskutils/bookworm to [NEW] deskutils/bookworm: Simple, focused ebook reader.Sat, Oct 16, 12:49 AM
koobs edited the summary of this revision. (Show Details)
koobs edited the test plan for this revision. (Show Details)
koobs edited the summary of this revision. (Show Details)