- User Since
- May 7 2015, 2:41 AM (256 w, 4 d)
Sat, Apr 4
Thu, Apr 2
Wed, Apr 1
Tue, Mar 31
Mon, Mar 30
Nice catch, thanks!
Sat, Mar 28
Minor nit above, nothing important.
Thu, Mar 26
Mon, Mar 23
Sat, Mar 21
Fri, Mar 20
Approved with my comment above.
Wed, Mar 11
Mon, Mar 9
Sun, Mar 8
Mar 6 2020
Mar 4 2020
Feb 28 2020
Feb 27 2020
Would this affect xorg-server as well?
I believe you have to make the UPDATING more verbose, to explain to people more about the change. They might not be aware of libxkbcommon, or which of xf86-input-libinput and xf86-input-keyboard they use. Perhaps you can add part of pkg-message also to updating?
I also wonder if we have the same pattern of shm_open() posix_fallocate() in other places (mesa comes to mind). I haven't looked though.
Can you please explain this to me a bit more, please?
This is a bug (or missing feature) in FreeBSD 12 that posix_fallocate() doesn't work with shm_open()? Should we poke @kevans about merging that change to FreeBSD 12 if possible?
I believe that the code will call os_resize_anonyous_file(), which call posix_fallocate(), even with the call to memfd_create(), if this works on FreeBSD 13, perhaps the patch should be made conditional on that version anyway? Or am I misreading the wayland code?
Apologies for all the question, I'm just a bit confused trying to understand it all.
Thank you for debugging this!
Feb 26 2020
Have you checked that downstream consumers are ok with the static library disappearing?
Once that's done, this is OK.
Feb 25 2020
Please leave the FIXDRM option off for now, we might want to enable it in the future, but would like some more time to figure out what's going on.
There is no need to bump portrevision I think, since the default package stays the same.
Feb 24 2020
Update patch to remove BROKEN=
Feb 23 2020
LGTM, I'll leave it to you to decide on committing it now, or holding for D23696.
I believe a portrevision bump of wayland is warranted, since it changes the code wayland is compiled with.
I'd like to wait for https://reviews.freebsd.org/D23696, since you state yourself that you work around the issue in a quite hackis way, and this way we don't have to bump wayland version twice.
This patch is also missing portrevision bump, which is needed since you change dependencies.
Feb 21 2020
Feb 20 2020
Idea is to merge it to v4.16 and then pick it into 5.0.
I just made a PR for this in the drm-kms repo, can you please have a look in case I screwed something up.
I've seen this, I'll fix the drm drivers and update tonight.
Feb 17 2020
This has been committed, but I made a mistake in the commit log so it wasn't picked up properly. Close this.
Feb 15 2020
Are the meson patches submitted upstream?
Here is a link to the upstream pull request and discussion, it's also linked in the Makefile, but put it here as well.
There are comments on the suggested patches upstream. Until those are resolved, this is not approved.
Feb 14 2020
Where did the static libraries go?
I don't know if they are used, but an exp-run might be warranted if we remove them from the package.
I'm not a fan of ripping out that commit, I rather we wait for https://github.com/jiixyj/epoll-shim/issues/15, but go ahead, we can fix that later.
Feb 13 2020
Feb 12 2020
I have no problems with this change from an x11 perspective. However, please give @hselasky the chance to chime in, since he knows much more about the lkpi than I do.