Page MenuHomeFreeBSD

zeising (Niclas Zeising)
User

Projects

User Details

User Since
May 7 2015, 2:41 AM (343 w, 6 d)

Recent Activity

Wed, Nov 10

zeising accepted D32911: net/rpki-client: Update to 7.5.

LGTM, approved!

Wed, Nov 10, 9:55 PM

Mon, Nov 8

zeising accepted D32766: x11/xorgproto: Update to 2021.5.

good to go, approved!

Mon, Nov 8, 5:54 PM

Nov 1 2021

zeising accepted D32763: x11/xkbcomp: Update to 1.4.5.

lgtm

Nov 1 2021, 2:42 PM
zeising accepted D32764: x11/xkeyboard-config: Update to 2.3.4.

LGTM

Nov 1 2021, 2:41 PM
zeising accepted D32765: x11/libXi: Update to 1.8.

lgtm

Nov 1 2021, 2:39 PM
zeising added a comment to D32766: x11/xorgproto: Update to 2021.5.

In the past we have done exp-runs to be sure when updating xorgproto. Even if the change set is small, it is probably a good idea to do that here as well, since this port has a lot of direct and indirect dependencies.

Nov 1 2021, 2:38 PM
zeising accepted D32762: x11/libXfixes: Update to 6.0.0.

LGTM

Nov 1 2021, 2:36 PM

Oct 18 2021

zeising accepted D32539: x11-servers/xorg-server: Update to 1.20.13.

LGTM

Oct 18 2021, 4:52 PM

Oct 15 2021

zeising added a comment to D32497: graphics/gpu-firmware-gpu: Rework the ports to be a metaport.

I have no objections to this, as long as the default is to install all firmware, to avoid confusion for users.

Oct 15 2021, 11:15 AM

Sep 17 2021

zeising added a comment to D31962: linux: For better compatibility, provide compatible endian.h.

Please do an exp-run before this goes in. At least mesa ports provide their own endian stuff in some cases and should be checked that they still are OK.

Sep 17 2021, 3:16 PM

Sep 6 2021

zeising added a comment to D31856: graphics/seexpr missing libgen include.

@danfe maintains seexpr, so pass this to him.

Sep 6 2021, 10:29 AM
zeising edited reviewers for D31856: graphics/seexpr missing libgen include, added: danfe; removed: x11.
Sep 6 2021, 10:28 AM

Aug 6 2021

zeising accepted D31218: net/rpki-client: Update to 7.2.

Fix the comment above, and this is good to go.

Aug 6 2021, 9:02 PM

Jul 19 2021

zeising accepted D31165: mesa*: Update to 21.1.4.
Jul 19 2021, 3:58 PM
zeising accepted D31003: graphics/libdrm: Update to 2.4.107.
Jul 19 2021, 3:55 PM

Jul 15 2021

zeising accepted D30930: Mk/bsd.default-versions: Remove libglvnd optionality.
Jul 15 2021, 6:03 PM

Jul 9 2021

zeising accepted D31078: net/rpki-client: Update to 7.1.

LGTM, thanks for doing this!

Jul 9 2021, 6:47 PM

Jul 7 2021

zeising added a comment to D31078: net/rpki-client: Update to 7.1.

Thanks for looking into this!
Just two questions above.

Jul 7 2021, 5:49 AM

Jun 30 2021

zeising added a comment to D30930: Mk/bsd.default-versions: Remove libglvnd optionality.

Per discussion with x11@ libglvnd will be the only GL provider supported by ports.

Context missing; is there a log of the discussion?

There is no direct log, PRs and reviews were used to record decisions or needs for discussion

Seems like this was discussed somewhere else, mind providing links to these discussions?

It was my first meeting.

There is a lack of transparency here.

Jun 30 2021, 5:58 AM

Jun 25 2021

zeising requested changes to D30869: graphics/libGLU: Update to 9.0.2.
Jun 25 2021, 9:58 AM

May 31 2021

zeising added a comment to D30557: x11/xtrans: don't unlink existing UNIX sockets.

I would like upstream to at least comment on the MR before we merge it into the FreeBSD ports tree.

May 31 2021, 6:30 AM

May 28 2021

zeising accepted D30356: graphics/libdrm: update to 2.4.106.

lgtm

May 28 2021, 11:22 AM

May 15 2021

zeising accepted D30207: devel/xorg-macros: update to 1.19.3.

Sorry, thought I'd approved this already.

May 15 2021, 4:55 PM

May 13 2021

zeising accepted D30203: x11/xorgproto: update to 2021.4.

Have you checked that the xorg stack builds with this change?

libX11/xorgproto have plenty of consumers outside of X.org stack, total around 2219 ports. I've asked for exp-run in bug 255771 but you may need to approve in advance, so it doesn't end up like bug 246767.

May 13 2021, 7:53 AM

May 11 2021

zeising accepted D30205: x11-toolkits/libXaw: update to 1.0.14.

Looks good!

May 11 2021, 10:01 AM
zeising accepted D30204: x11/libXres: update to 1.2.1.

Looks good

May 11 2021, 10:00 AM
zeising accepted D30206: x11-fonts/fonttosfnt: update to 1.2.1.

Looks good!

May 11 2021, 9:57 AM
zeising added a comment to D30207: devel/xorg-macros: update to 1.19.3.

Have you checked that the xorg stack builds with this change?

May 11 2021, 9:56 AM
zeising added a comment to D30203: x11/xorgproto: update to 2021.4.

Have you checked that the xorg stack builds with this change?

May 11 2021, 9:56 AM
zeising accepted D30202: x11/libX11: update to 1.7.0.

LGTM

May 11 2021, 9:53 AM

Apr 14 2021

zeising requested changes to D29756: Create a mail/spamassassin metaport allowing it to use the GA version or the -devel version.

This seems to create a lot of complexity for very little gain.
Normally, we have the -devel ports beside the regular ports, without having what is basically a meta port that acts as a slave port to *both* the -devel and release version.

Apr 14 2021, 6:54 AM

Apr 4 2021

zeising requested changes to D29360: graphics/wayland: enable cr_pid on FreeBSD >= 12.3.
Apr 4 2021, 11:10 AM
zeising added a comment to D29360: graphics/wayland: enable cr_pid on FreeBSD >= 12.3.

@mat already gave you feedback which you haven't acted on. I agree with him that you need a good __FreeBSD_version for FreeBSD 12, probably the next bump after the relevant change went into base. If no such bump has happened yet, it is easy enough to ask for it.
You also need to bump portrevision. Even if the packages will be rebuilt by poudriere on OSVERSION bumps, they will normally not be reinstalled in such case.

Apr 4 2021, 11:10 AM

Mar 10 2021

zeising accepted D29196: x11/xscreensaver: update to 5.45.

Looks good.
I see upstream has switched things around a bit...
Thanks for doing this!

Mar 10 2021, 6:32 PM
zeising added a comment to D29196: x11/xscreensaver: update to 5.45.

And thanks for taking the time to create a phab diff for me. :)

Mar 10 2021, 6:32 PM

Jan 26 2021

zeising requested review of D28356: Sweeping update to add FreeBSD_14 where there was also FreeBSD_13.
Jan 26 2021, 4:39 PM
zeising committed rP562692: x11-drivers/xf86-input-synaptics: Enable EVDEV on 14.
x11-drivers/xf86-input-synaptics: Enable EVDEV on 14
Jan 26 2021, 3:53 PM

Dec 26 2020

zeising committed R9:83de4c62b7de: share/pgpkeys: Update my key (authored by zeising).
share/pgpkeys: Update my key
Dec 26 2020, 11:11 AM

Dec 3 2020

zeising committed rP556923: MFH: r556790.
MFH: r556790
Dec 3 2020, 8:42 PM

Dec 1 2020

zeising committed rP556790: xorg-server: Add patches to fix security issues.
xorg-server: Add patches to fix security issues
Dec 1 2020, 7:48 PM
zeising committed rP556787: vuxml: document xorg-server vulnerabilities.
vuxml: document xorg-server vulnerabilities
Dec 1 2020, 7:37 PM

Nov 11 2020

zeising added a comment to D27171: LinuxKPI: Reimplement irq_work queue on top of fast taskqueue.

If it requires updates to drm-current-kmod and drm-devel-kmod, as well as might cause binary breakage, then it shouldn't be MFCd. We have enough trouble already with drm-kmod breaking between minor releases and in stable.

Nov 11 2020, 8:27 PM
zeising added a comment to D27171: LinuxKPI: Reimplement irq_work queue on top of fast taskqueue.

Why do we need a __FreeBSD_version bump? Especially if it is also slated for MFC?

Nov 11 2020, 7:30 PM

Oct 28 2020

zeising added a comment to D26989: Switch to USES=metaport.

I am wary about changing FONTDIR, it might be used elsewhere, there are references to such a variable in other places in the ports tree, but I don't have time to investigate those further right now.
Apart from the USES=metaport change, this feels like it is mostly churn for no apparent benefit.

Oct 28 2020, 3:14 PM

Oct 26 2020

zeising committed rP553321: audio/strawberry: Update to 0.8.2.
audio/strawberry: Update to 0.8.2
Oct 26 2020, 6:30 AM

Oct 25 2020

zeising committed rP553251: Add new port: x11/gtk-app-menu.
Add new port: x11/gtk-app-menu
Oct 25 2020, 10:43 AM
zeising committed rP553248: cad/gtkwave: Update to 3.3.107.
cad/gtkwave: Update to 3.3.107
Oct 25 2020, 10:35 AM

Oct 21 2020

zeising committed rP552885: cad/iverilog: Update to 11.0.
cad/iverilog: Update to 11.0
Oct 21 2020, 7:21 PM
zeising committed rP552876: x11-fonts/fonttosfnt: Update to 1.2.0.
x11-fonts/fonttosfnt: Update to 1.2.0
Oct 21 2020, 5:52 PM

Oct 13 2020

zeising committed rP552282: x11/xcb-proto: Update to 1.14.1.
x11/xcb-proto: Update to 1.14.1
Oct 13 2020, 7:50 PM
zeising committed rP552281: x11/xkeyboard-config: Update to 2.31.
x11/xkeyboard-config: Update to 2.31
Oct 13 2020, 7:49 PM
zeising committed rP552280: x11/libinput: Update to 1.16.2.
x11/libinput: Update to 1.16.2
Oct 13 2020, 7:47 PM

Oct 11 2020

zeising added a comment to D26682: graphics/mesa*: Update to 20.2.
In D26682#596061, @manu wrote:

A few things, small nits.
What happened with the TLS (thread local storage) stuff? I know we talked about it, but I don't remember the result of the discussion. It looks like the patches to disable it has been removed locally. Are they added upstream or are we enabling TLS stuff now?

TLS is always disabled for us.
I'm not against enabling it for some version of FreeBSD but I need to test first (and on multiple arches too) so it's easier to leave it disabled for now.
See https://gitlab.freedesktop.org/mesa/mesa/-/blob/20.2/meson.build#L425

Oct 11 2020, 3:50 PM
zeising accepted D26682: graphics/mesa*: Update to 20.2.

Two small nits, but this looks good.
I haven't yet had time to test on 12.1 and 11.4.
Reviewed-by: zeising

Oct 11 2020, 3:49 PM

Oct 9 2020

zeising added a comment to D26682: graphics/mesa*: Update to 20.2.

You also need to change the rename of xatracker in x11-drivers/xf86-video-vmware. Something like the attached should work.

Oct 9 2020, 11:37 PM
zeising added a comment to D26682: graphics/mesa*: Update to 20.2.

A few things, small nits.
What happened with the TLS (thread local storage) stuff? I know we talked about it, but I don't remember the result of the discussion. It looks like the patches to disable it has been removed locally. Are they added upstream or are we enabling TLS stuff now?

Oct 9 2020, 9:36 PM

Oct 5 2020

zeising abandoned D9512: x11-servers/xorg-server: Xorg devd device discovery with evdev.

Abandoning this, since these changes should be superseded by the update of xserver to 1.20.

Oct 5 2020, 6:59 PM · x11
zeising commandeered D9512: x11-servers/xorg-server: Xorg devd device discovery with evdev.
Oct 5 2020, 6:59 PM · x11
zeising added a comment to D26682: graphics/mesa*: Update to 20.2.

A couple of things I found after looking briefly (and also from your WIP patch at some point). I'll do a more throughout check later in the week.

Oct 5 2020, 6:29 PM
zeising added a member for linuxkpi: zeising.
Oct 5 2020, 6:12 PM

Oct 3 2020

zeising added inline comments to D26646: Cleanup ports after 11.3-EOL.
Oct 3 2020, 9:50 AM

Sep 30 2020

zeising committed rP550741: devel/libmtdev: Update to 1.1.6.
devel/libmtdev: Update to 1.1.6
Sep 30 2020, 7:47 PM
zeising committed rP550739: devel/py-evdev: Update to 1.3.0.
devel/py-evdev: Update to 1.3.0
Sep 30 2020, 7:43 PM
zeising committed rP550738: devel/libevdev: Update to teh lastest snapshot.
devel/libevdev: Update to teh lastest snapshot
Sep 30 2020, 7:40 PM

Sep 29 2020

zeising committed rS366263: MF stable/12 r366258:.
MF stable/12 r366258:
Sep 29 2020, 5:22 PM
zeising committed rS366259: MFC r366186: bsdconfig, bsdinstall: Prune dead mirrors.
MFC r366186: bsdconfig, bsdinstall: Prune dead mirrors
Sep 29 2020, 3:38 PM
zeising committed rS366258: MFC r366186: bsdconfig, bsdinstall: Prune dead mirrors.
MFC r366186: bsdconfig, bsdinstall: Prune dead mirrors
Sep 29 2020, 3:38 PM

Sep 28 2020

zeising committed rP550448: devel/libgudev: Update to 234.
devel/libgudev: Update to 234
Sep 28 2020, 8:19 PM
zeising committed rP550446: x11/libwacom: Update to 1.5.
x11/libwacom: Update to 1.5
Sep 28 2020, 8:15 PM
zeising closed D26350: x11/lib{wacom,input}: update to 1.5 / 1.16.1.
Sep 28 2020, 8:15 PM
zeising committed rP550444: x11/libinput: Update to 1.6.1.
x11/libinput: Update to 1.6.1
Sep 28 2020, 8:05 PM
zeising committed rP550443: Bump portrevision for devel/evdev-proto.
Bump portrevision for devel/evdev-proto
Sep 28 2020, 8:00 PM
zeising committed rP550442: devel/evdev-proto: Update to 5.8.
devel/evdev-proto: Update to 5.8
Sep 28 2020, 7:58 PM

Sep 26 2020

zeising committed rS366186: bsdconfig, bsdinstall: Prune dead mirrors.
bsdconfig, bsdinstall: Prune dead mirrors
Sep 26 2020, 4:27 PM
zeising closed D26535: Cleanup dead mirrors.
Sep 26 2020, 4:27 PM
zeising committed rP550181: vuxml: Update pango entry for CVE-2019-1010238.
vuxml: Update pango entry for CVE-2019-1010238
Sep 26 2020, 1:10 PM
zeising committed rP550180: MFH: r550179.
MFH: r550179
Sep 26 2020, 1:08 PM
zeising committed rP550179: x11/toolcits-pango: Actually apply security patch.
x11/toolcits-pango: Actually apply security patch
Sep 26 2020, 1:06 PM

Sep 23 2020

zeising added a comment to D26535: Cleanup dead mirrors.

Tag clusteradm too - do we have details about DNS changes for these mirrors?

Sep 23 2020, 6:58 PM
zeising added a reviewer for D26535: Cleanup dead mirrors: clusteradm.
Sep 23 2020, 6:55 PM
zeising added a comment to D26535: Cleanup dead mirrors.

As a side note, it might be good to add the CDN we have, and perhaps switch from ftp:// to http(s):// where it's available.

Sep 23 2020, 6:40 PM
zeising requested review of D26535: Cleanup dead mirrors.
Sep 23 2020, 6:39 PM

Sep 19 2020

zeising committed rP549045: devel/cscope: Pass to submitter.
devel/cscope: Pass to submitter
Sep 19 2020, 5:33 PM
zeising committed rP548990: sysutils/zfs-snapshot-mgmt: pass to submitter.
sysutils/zfs-snapshot-mgmt: pass to submitter
Sep 19 2020, 2:35 PM
zeising committed rP548958: cad/gmsh: Fix fetch.
cad/gmsh: Fix fetch
Sep 19 2020, 11:03 AM

Sep 18 2020

zeising committed rP548921: devel/nasm: Update to 2.15.05.
devel/nasm: Update to 2.15.05
Sep 18 2020, 10:04 PM

Sep 17 2020

zeising added a comment to D26461: mesa-libs: Add glesv1 lib.

Libepoxy is some glue library, and it had an explicit dep on glesv2, so I thought it might do things with glesv1 as well. I just wanted to be sure.

Sep 17 2020, 4:02 PM
zeising accepted D26460: mesa: Remove sparc64 patches.

Mabye put a NOT_FOR_ARCHS=sparc64 and NOT_FOR_ARCHS_REASON=not supported or something in mesa-dri/Makefile.common. Just in case someone is brave enough to try building this on sparc64.

Sep 17 2020, 3:50 PM
zeising added a comment to D26461: mesa-libs: Add glesv1 lib.

Also, portmgr is blocking review because changes to Mk/, but Mk/Uses/gl.mk is x11@ responsibility, so it should be OK.

Sep 17 2020, 3:48 PM
zeising accepted D26461: mesa-libs: Add glesv1 lib.

Can you double check that graphics/libepoxy doesn't need updating as well. Just build it in poudriere with this change to mesa and see if it works.
Looking good otherwise.

Sep 17 2020, 3:47 PM

Sep 16 2020

zeising committed rP548803: x11-drivers/xf86-video-ati-legacy: Delete port.
x11-drivers/xf86-video-ati-legacy: Delete port
Sep 16 2020, 8:58 PM
zeising added a comment to D26450: Remove APM (series of commits, but shown as one for review).
In D26450#588478, @imp wrote:

You probably want to remove tools/build/options/WITHOUT_APM since that option is gone and update tools/build/options/WITHOUT_ACPI to indicate that it also governs the installation of the apm(8) userland utility. OptionalObsoleteFiles.inc probably need to take this into account also.

WITHOUT_APM already is on the remove list. OptionalObsoleteFiles has been updated. Please check to make sure it's been correctly updated. I've not re-run the script that generates src.conf.5, though.

Sep 16 2020, 3:56 PM
zeising requested changes to D26450: Remove APM (series of commits, but shown as one for review).

You need to remove the .Xr to apmd(8) from rc.conf(5) and acpiconf(8) as well, and references to apm(4) from apm(8).

Sep 16 2020, 8:30 AM
zeising added a comment to D26450: Remove APM (series of commits, but shown as one for review).

You probably want to remove tools/build/options/WITHOUT_APM since that option is gone and update tools/build/options/WITHOUT_ACPI to indicate that it also governs the installation of the apm(8) userland utility. OptionalObsoleteFiles.inc probably need to take this into account also.

Sep 16 2020, 7:49 AM
zeising accepted D26438: mesa*: Only add x11 dependancy if it's requested.

Small nit.
Looking good otherwise.

Sep 16 2020, 7:10 AM
zeising added a member for desktop: zeising.
Sep 16 2020, 7:08 AM

Sep 13 2020

zeising committed rP548498: x11/libxkbcommon: Update to 1.0.1.
x11/libxkbcommon: Update to 1.0.1
Sep 13 2020, 6:28 PM
zeising committed rP548494: x11/xcb-util-xrm: Update to 1.3.
x11/xcb-util-xrm: Update to 1.3
Sep 13 2020, 5:45 PM
zeising committed rP548493: x11/libxcb: Re-add runtime dependency on pthread-stubs.
x11/libxcb: Re-add runtime dependency on pthread-stubs
Sep 13 2020, 5:35 PM
zeising committed rP548488: x11-servers/xorg-server: Update to 1.20.9.
x11-servers/xorg-server: Update to 1.20.9
Sep 13 2020, 5:04 PM