Page MenuHomeFreeBSD

zeising (Niclas Zeising)
User

Projects

User Details

User Since
May 7 2015, 2:41 AM (215 w, 6 d)

Recent Activity

Today

zeising added inline comments to D20724: Change USE_XORG to USES=xorg and USES=xorg-cat.
Wed, Jun 26, 5:44 PM
zeising added a comment to D20724: Change USE_XORG to USES=xorg and USES=xorg-cat.
In D20724#449198, @mat wrote:
In D20724#449059, @mat wrote:

I think you are trying to put really too much magic in xorg-cat.

I am merely replicating the functionality that was in bsd.xorg.mk. All of this is in the old bsd.xorg.mk, and there it works. bsd.xorg.mk is only pulled in from bsd.ports.mk if USE_XORG or XORG_CAT is defined, perhaps it is better left this way, rather than converted to USES?

Save for the generic framework files, nothing should be left as a bsd.*.mk file, everything should be moved to a USES. The move is better if it is done by someone who actually understands what the file does.

Wed, Jun 26, 3:55 PM
zeising added a comment to D20724: Change USE_XORG to USES=xorg and USES=xorg-cat.
In D20724#449170, @tijl wrote:

I found two ports with USES=autoreconf and XORG_CAT: x11-drivers/xf86-input-egalax and x11-drivers/xf86-video-intel. The former isn't maintained by x11@ and is fetched from github. If such non-X.org ports are allowed to use XORG_CAT then they may be fetched from gitlab and not need autoreconf for instance, so you cannot include autoreconf.mk. If XORG_CAT is only meant for X.org ports and use by other ports is unsupported then you can keep the libtool.mk and autoreconf.mk includes (as in 9e63b55 but without " || ${USES:Mautoreconf}") and for special cases like x11-drivers/xf86-video-intel you can add "USES= autoreconf libtool" to the port Makefile instead of just USES=autoreconf.

Wed, Jun 26, 3:43 PM
zeising added a comment to D20724: Change USE_XORG to USES=xorg and USES=xorg-cat.
In D20724#449059, @mat wrote:

I think you are trying to put really too much magic in xorg-cat.

Wed, Jun 26, 8:50 AM

Yesterday

zeising added a comment to D20724: Change USE_XORG to USES=xorg and USES=xorg-cat.
In D20724#449034, @tijl wrote:

I think the problem is you are including autoreconf.mk before setting libtool_ARGS. Try moving "libtool_ARGS?= #empty" to right before each libtool.mk include (there are two) so it's only defined if libtool is used. Then include autoreconf.mk if "USE_GITLAB && BUILDSYS == autotools" right after ". endif # ${_XORG_CAT} == <category>".

Tue, Jun 25, 9:03 PM
zeising added a reviewer for D20724: Change USE_XORG to USES=xorg and USES=xorg-cat: tijl.
Tue, Jun 25, 7:18 PM
zeising set the repository for D20724: Change USE_XORG to USES=xorg and USES=xorg-cat to rP FreeBSD ports repository.

Update patch again.
Move things around in Uses/autoreconf.mk to check for libtool things later. Uses/autoreconf.mk checks if libtool is being used, by checking libtool_ARGS, and if it's set, add a dependency on libtoolize. Move this check later, in the POSTMKINCLUDED phase, to avoid issues where we're hitting autoreconf before setting libtool_ARGS, and then not bringing in libtoolize.

Tue, Jun 25, 5:31 PM
zeising added inline comments to D20724: Change USE_XORG to USES=xorg and USES=xorg-cat.
Tue, Jun 25, 3:15 PM
zeising added a comment to D20724: Change USE_XORG to USES=xorg and USES=xorg-cat.

Updated diff based on comments from @mat

Tue, Jun 25, 3:15 PM
zeising added a comment to D20732: Update porter's handbook for USES=xorg.
In D20732#448839, @mat wrote:
In D20732#448815, @mat wrote:

Could you also add documentation for USES=xorg-cat?

I purposefully omitted it, since it is supposed to be internal to xorg ports, not used by other ports, similar to qt-dist.mk.

Mmmm, I do not understand, you mean I'll have to document it myself when the other review hits the tree? All USES have to be documented, otherwise, the only one who knows how it works is you, so, the bus factor is 1, and it is very bad.

Tue, Jun 25, 3:09 PM
zeising added a comment to D20732: Update porter's handbook for USES=xorg.
In D20732#448815, @mat wrote:

Could you also add documentation for USES=xorg-cat?

Tue, Jun 25, 2:38 PM

Mon, Jun 24

zeising committed rP505058: MFH: r505057.
MFH: r505057
Mon, Jun 24, 9:39 PM
zeising committed rP505057: graphics/drm-fbsd12.0-kmod: Update snapshot.
graphics/drm-fbsd12.0-kmod: Update snapshot
Mon, Jun 24, 9:38 PM

Sun, Jun 23

zeising created D20732: Update porter's handbook for USES=xorg.
Sun, Jun 23, 9:15 PM
zeising added a comment to D20724: Change USE_XORG to USES=xorg and USES=xorg-cat.

Updated based on comments from @tobik .

Sun, Jun 23, 6:42 PM
zeising added a comment to D20724: Change USE_XORG to USES=xorg and USES=xorg-cat.
In D20724#448218, @kwm wrote:

This porters-handbook chapter needs to be updated/rewritten, maybe there are other bits elsewhere in the porters-handbook that also need attention.
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/using-x11.html

Sun, Jun 23, 6:38 PM
zeising added a comment to D20724: Change USE_XORG to USES=xorg and USES=xorg-cat.

Thank you very much for the review @tobik !
I think I've fixed everything, I'm just going to do a local smoke test, and then I'll update the patch in phabricator as well.

Sun, Jun 23, 5:33 PM

Sat, Jun 22

zeising committed rP504915: x11/libXi: Update to 1.7.10.
x11/libXi: Update to 1.7.10
Sat, Jun 22, 11:13 PM
zeising added a comment to D20724: Change USE_XORG to USES=xorg and USES=xorg-cat.

Some notes about the patch: Uses/xorg.mk and possibly Uses/xorg-cat.mk will be copied from bsd.xorg.mk using svn cp or svn mv as needed. Current patch is pulled from our git repo with rename detection turned off when generating the patch.

Sat, Jun 22, 9:37 PM
zeising created D20724: Change USE_XORG to USES=xorg and USES=xorg-cat.
Sat, Jun 22, 9:35 PM
zeising committed rP504885: x11/xorgproto: update to 2019.1.
x11/xorgproto: update to 2019.1
Sat, Jun 22, 7:33 PM

Mon, Jun 17

zeising committed rP504434: x11-fonts/encodings: Update to 1.0.5.
x11-fonts/encodings: Update to 1.0.5
Mon, Jun 17, 8:48 PM
zeising committed rS349150: pci.4: Use plural configuration registers.
pci.4: Use plural configuration registers
Mon, Jun 17, 5:36 PM
zeising committed rS349146: pci.4: wordsmith and add missing words.
pci.4: wordsmith and add missing words
Mon, Jun 17, 4:55 PM
zeising closed D20671: Add missing words and word smith in pci(4).
Mon, Jun 17, 4:54 PM
zeising created D20671: Add missing words and word smith in pci(4).
Mon, Jun 17, 10:33 AM
zeising committed rS349133: pci(4): Document PCIOCATTACHED.
pci(4): Document PCIOCATTACHED
Mon, Jun 17, 5:42 AM
zeising closed D20652: Document the PCIOCATTACHED ioctl(2) in pci(4).
Mon, Jun 17, 5:41 AM

Sun, Jun 16

zeising committed rP504376: x11/sessreg: Update to 1.1.2.
x11/sessreg: Update to 1.1.2
Sun, Jun 16, 8:59 PM
zeising committed rP504374: x11/xkeyboard-config: Update to 2.27.
x11/xkeyboard-config: Update to 2.27
Sun, Jun 16, 8:49 PM
zeising committed rP504373: x11/libxshmfence: Update to 1.3.
x11/libxshmfence: Update to 1.3
Sun, Jun 16, 8:48 PM
zeising committed rP504372: x11/libxkbfile: Update to 1.1.0.
x11/libxkbfile: Update to 1.1.0
Sun, Jun 16, 8:43 PM
zeising committed rP504371: x11/libxkbcommon: Update to 0.8.4.
x11/libxkbcommon: Update to 0.8.4
Sun, Jun 16, 8:42 PM
zeising committed rP504370: x11/libXxf86dga: Update to 1.1.5.
x11/libXxf86dga: Update to 1.1.5
Sun, Jun 16, 8:40 PM
zeising committed rP504369: x11/libXvMC: Update to 1.0.11.
x11/libXvMC: Update to 1.0.11
Sun, Jun 16, 8:39 PM
zeising committed rP504368: x11/libXrandr: Update to 1.5.2.
x11/libXrandr: Update to 1.5.2
Sun, Jun 16, 8:37 PM
zeising committed rP504367: x11/libXext: Update to 1.3.4.
x11/libXext: Update to 1.3.4
Sun, Jun 16, 8:36 PM
zeising committed rP504366: x11/libXdamage: Update to 1.1.5.
x11/libXdamage: Update to 1.1.5
Sun, Jun 16, 8:35 PM
zeising committed rP504365: x11/libXcursor: Update to 1.2.0.
x11/libXcursor: Update to 1.2.0
Sun, Jun 16, 8:33 PM
zeising committed rP504364: x11/libXcomposite: Update to 0.4.5.
x11/libXcomposite: Update to 0.4.5
Sun, Jun 16, 8:31 PM
zeising committed rP504363: x11-toolkits/libXmu: Update to 1.1.3.
x11-toolkits/libXmu: Update to 1.1.3
Sun, Jun 16, 8:30 PM
zeising committed rP504362: x11-fonts/libFS: Update to 1.0.8.
x11-fonts/libFS: Update to 1.0.8
Sun, Jun 16, 8:28 PM
D20153: x11-drivers/xf86-video-vmware: Enable hardware accelerated graphics in VMware is now accepted and ready to land.

LGTM

Sun, Jun 16, 6:45 PM
D20652: Document the PCIOCATTACHED ioctl(2) in pci(4) now requires review to proceed.

Updates based on comments from @imp and some wordsmithing.

Sun, Jun 16, 6:21 PM
D20153: x11-drivers/xf86-video-vmware: Enable hardware accelerated graphics in VMware is now accepted and ready to land.

One minor nit, otherwise you're good to go.

Sun, Jun 16, 9:47 AM

Sat, Jun 15

zeising updated the diff for D20652: Document the PCIOCATTACHED ioctl(2) in pci(4).

Fixes based on comments from @bcr .
mandoc -Tlint complains a lot about useless macro: Tn for all the .Tn PCI. This style is all over the file, and should probably be changed in a separate pass.

Sat, Jun 15, 2:21 PM
zeising requested changes to D20153: x11-drivers/xf86-video-vmware: Enable hardware accelerated graphics in VMware.

I assume you've run it through poudriere to ensure it builds and packages OK.
should libxatracker be made amd64 and i386 only? I assume it's only relevant for those architectures.

Sat, Jun 15, 1:30 PM
zeising created D20652: Document the PCIOCATTACHED ioctl(2) in pci(4).
Sat, Jun 15, 1:08 PM
zeising committed rP504232: devel/libevent: Grab.
devel/libevent: Grab
Sat, Jun 15, 7:44 AM

Mon, Jun 10

zeising closed D20507: enable synaptics and elantech touchpads by default.
Mon, Jun 10, 6:20 PM
zeising committed rS348873: psm(4): Enable touchpads and trackpads by default.
psm(4): Enable touchpads and trackpads by default
Mon, Jun 10, 6:20 PM
zeising committed rP503917: x11-drivers/xf86-video-tdfx: Update to 1.5.0.
x11-drivers/xf86-video-tdfx: Update to 1.5.0
Mon, Jun 10, 5:04 PM
zeising committed rP503906: x11-drivers/xf86-input-elographics: Update to 1.4.2.
x11-drivers/xf86-input-elographics: Update to 1.4.2
Mon, Jun 10, 4:31 PM
zeising committed rP503903: x11/xcalc: Update to 1.1.0.
x11/xcalc: Update to 1.1.0
Mon, Jun 10, 4:01 PM
zeising committed rP503902: x11/x11perf: Update to 1.6.1.
x11/x11perf: Update to 1.6.1
Mon, Jun 10, 3:55 PM
zeising committed rP503901: devel/makedepend: Update to 1.0.6.
devel/makedepend: Update to 1.0.6
Mon, Jun 10, 3:45 PM

Tue, Jun 4

zeising added a comment to D20507: enable synaptics and elantech touchpads by default.

I think editing xf86-input-mouse is the better option as well.

Tue, Jun 4, 8:45 PM
zeising added a comment to D20507: enable synaptics and elantech touchpads by default.

In any case, libinput list-devices does not return any output.

Tue, Jun 4, 2:21 PM
zeising added a comment to D20507: enable synaptics and elantech touchpads by default.

This was tried some years ago, but then reverted as the probing was deemed too intrusive (see r255152 and r255210). I don't know if something changed in the meantime.
I've had "synaptics_support" and "trackpoint_support" enabled for years on my Thinkpads without problems though.

Tue, Jun 4, 1:03 PM
zeising added a comment to D20507: enable synaptics and elantech touchpads by default.

This is for current only, where changes to the drivers has been made as well, and evdev is the default. Which version of FreeBSD are you using? Can you provide logs, and output from libinput list-devices.

Tue, Jun 4, 11:31 AM
zeising updated the diff for D20507: enable synaptics and elantech touchpads by default.

Also enable trackpad support by default.

Tue, Jun 4, 8:24 AM

Mon, Jun 3

zeising added inline comments to D20507: enable synaptics and elantech touchpads by default.
Mon, Jun 3, 8:33 PM
zeising created D20507: enable synaptics and elantech touchpads by default.
Mon, Jun 3, 8:27 PM

May 24 2019

zeising committed rP502475: cad/gtkwave: Update to 3.3.101.
cad/gtkwave: Update to 3.3.101
May 24 2019, 3:15 PM

May 23 2019

zeising committed rP502351: MFH: r502350.
MFH: r502350
May 23 2019, 7:00 PM
zeising committed rP502350: graphics/drm-legacy-kmod: Update snapshot.
graphics/drm-legacy-kmod: Update snapshot
May 23 2019, 6:59 PM

May 22 2019

zeising committed rS348114: Fix ObsoleteFiles after ethernet driver removal.
Fix ObsoleteFiles after ethernet driver removal
May 22 2019, 4:59 PM
zeising closed D20351: ObsoleteFiles: Manuals are generally .gz.
May 22 2019, 4:59 PM
zeising created D20351: ObsoleteFiles: Manuals are generally .gz.
May 22 2019, 6:32 AM

May 21 2019

zeising committed rP502191: MFH: r502190.
MFH: r502190
May 21 2019, 6:25 AM
zeising committed rP502190: graphics/drm-devel-kmod: fix package.
graphics/drm-devel-kmod: fix package
May 21 2019, 6:24 AM
zeising committed rP502189: MFH: r502187.
MFH: r502187
May 21 2019, 5:53 AM
zeising committed rP502187: Hook graphics/drm-current-kmod to the build.
Hook graphics/drm-current-kmod to the build
May 21 2019, 5:51 AM

May 20 2019

zeising committed rP502169: MFH: r502165 r502166 r502167 r502168.
MFH: r502165 r502166 r502167 r502168
May 20 2019, 8:45 PM
zeising committed rP502168: graphics/drm-current-kmod: Adjust FreeBSD compat.
graphics/drm-current-kmod: Adjust FreeBSD compat
May 20 2019, 8:39 PM
zeising committed rP502167: Remove old drm-devel-kmod entry.
Remove old drm-devel-kmod entry
May 20 2019, 8:34 PM
zeising committed rP502166: drm-kmod ports: Update conflicts.
drm-kmod ports: Update conflicts
May 20 2019, 8:30 PM
zeising committed rP502165: add graphics/drm-devel-kmod.
add graphics/drm-devel-kmod
May 20 2019, 8:28 PM

May 19 2019

zeising committed rP502045: MFH: r502043.
MFH: r502043
May 19 2019, 8:07 PM
zeising committed rP502043: graphics/drm-current-kmod: Update snapshot.
graphics/drm-current-kmod: Update snapshot
May 19 2019, 8:03 PM

May 16 2019

zeising accepted D20181: For the LinuxKPI allow loading the same DMA address multiple times without any prior unload.

This has been running fine during the night. From a graphics drivers no apparent regressions are visible, from light testing.

May 16 2019, 5:49 AM

May 15 2019

zeising added a comment to D20181: For the LinuxKPI allow loading the same DMA address multiple times without any prior unload.

Running the latest version of this patch on top of r347562M.
Machine boots and graphics comes up no problems, this with the built in Intel graphics in i7-3520M.
I'll leave the machine running during the night, in case something happens.

May 15 2019, 8:36 PM
zeising added a comment to D20097: Fix regression issues after r346645 in the LinuxKPI.

What is remaining in this review?

May 15 2019, 4:37 PM

May 7 2019

zeising added a hashtag to x11: #graphics.
May 7 2019, 2:22 PM
zeising added a comment to D20181: For the LinuxKPI allow loading the same DMA address multiple times without any prior unload.

I'll give this a spin and look for regressions in graphics land, but it might take a day or two. Can you add x11 as group reviewer?

May 7 2019, 1:32 PM

May 3 2019

zeising accepted D20097: Fix regression issues after r346645 in the LinuxKPI.

This is still running fine from a graphics perspective.
DRM has been broken for some time now, what's needed to get this in?

May 3 2019, 4:16 PM

May 2 2019

zeising added a comment to D20097: Fix regression issues after r346645 in the LinuxKPI.

I've been running the new version of the patch for about 2 hours without any graphics issues. I'll let the computer run through the night.

May 2 2019, 7:55 PM

May 1 2019

zeising added a comment to D20097: Fix regression issues after r346645 in the LinuxKPI.

I've had further success stories graphics wise, and my laptop is still running, so from a graphics perspective, this is good to go.

May 1 2019, 8:11 PM
zeising accepted D20097: Fix regression issues after r346645 in the LinuxKPI.

I've been running this for about 8 hours, on a mostly idle laptop with Firefox running, so far so good. I would like to give the reporters on the mailing list some time to test as well, since the hang is very random (I might have been lucky). I'll keep running the patch though.

May 1 2019, 7:51 AM

Apr 30 2019

zeising committed rP500563: MFH: r499933 r500562.
MFH: r499933 r500562
Apr 30 2019, 8:36 PM
zeising committed rP500562: Update drm driver snapshots.
Update drm driver snapshots
Apr 30 2019, 8:28 PM

Apr 29 2019

zeising added a comment to D20097: Fix regression issues after r346645 in the LinuxKPI.

Hi!
Is this related to the recent graphics GPU hungs, or is this another issue?
Just checking so that I know what to look for.

Apr 29 2019, 6:36 PM
zeising committed rS346899: Add a note to MAINTAINERS for lkpi for graphics.
Add a note to MAINTAINERS for lkpi for graphics
Apr 29 2019, 6:21 PM

Apr 27 2019

zeising added a comment to D20064: Add emulators/fs-uae-devel port.

In general, I'm not sure -devel ports are usually slave ports, slave ports are more often to have ports with different options, such as nox11 variants. You also need to check with the owner of the original port for approval, since you're touching that one. You also need do add CONFLICTS since I assume both ports can't be installed at the same time (installing things in the same place).

Apr 27 2019, 8:26 AM

Apr 24 2019

zeising committed rP499907: MFH: r499905.
MFH: r499905
Apr 24 2019, 8:07 PM
zeising committed rP499905: Update drm kmod ports.
Update drm kmod ports
Apr 24 2019, 7:51 PM

Mar 26 2019

zeising committed rP496883: x11-wm/xcompmgr: Update to 1.1.8.
x11-wm/xcompmgr: Update to 1.1.8
Mar 26 2019, 9:54 AM

Mar 24 2019

zeising committed rP496706: devel/imake: Update to 1.0.8.
devel/imake: Update to 1.0.8
Mar 24 2019, 7:12 AM

Mar 23 2019

zeising committed rP496630: x11/xtrans: Update to 1.4.0.
x11/xtrans: Update to 1.4.0
Mar 23 2019, 6:58 AM
zeising committed rP496629: x11-fonts/mkfontscale: Update to 1.2.1.
x11-fonts/mkfontscale: Update to 1.2.1
Mar 23 2019, 5:10 AM