- User Since
- May 7 2015, 2:41 AM (298 w, 4 d)
Dec 26 2020
Dec 3 2020
Dec 1 2020
Nov 11 2020
If it requires updates to drm-current-kmod and drm-devel-kmod, as well as might cause binary breakage, then it shouldn't be MFCd. We have enough trouble already with drm-kmod breaking between minor releases and in stable.
Why do we need a __FreeBSD_version bump? Especially if it is also slated for MFC?
Oct 28 2020
I am wary about changing FONTDIR, it might be used elsewhere, there are references to such a variable in other places in the ports tree, but I don't have time to investigate those further right now.
Apart from the USES=metaport change, this feels like it is mostly churn for no apparent benefit.
Oct 26 2020
Oct 25 2020
Oct 21 2020
Oct 13 2020
Oct 11 2020
Two small nits, but this looks good.
I haven't yet had time to test on 12.1 and 11.4.
Oct 9 2020
You also need to change the rename of xatracker in x11-drivers/xf86-video-vmware. Something like the attached should work.
A few things, small nits.
What happened with the TLS (thread local storage) stuff? I know we talked about it, but I don't remember the result of the discussion. It looks like the patches to disable it has been removed locally. Are they added upstream or are we enabling TLS stuff now?
Oct 5 2020
Abandoning this, since these changes should be superseded by the update of xserver to 1.20.
A couple of things I found after looking briefly (and also from your WIP patch at some point). I'll do a more throughout check later in the week.
Oct 3 2020
Sep 30 2020
Sep 29 2020
Sep 28 2020
Sep 26 2020
Sep 23 2020
As a side note, it might be good to add the CDN we have, and perhaps switch from ftp:// to http(s):// where it's available.
Sep 19 2020
Sep 18 2020
Sep 17 2020
Libepoxy is some glue library, and it had an explicit dep on glesv2, so I thought it might do things with glesv1 as well. I just wanted to be sure.
Mabye put a NOT_FOR_ARCHS=sparc64 and NOT_FOR_ARCHS_REASON=not supported or something in mesa-dri/Makefile.common. Just in case someone is brave enough to try building this on sparc64.
Also, portmgr is blocking review because changes to Mk/, but Mk/Uses/gl.mk is x11@ responsibility, so it should be OK.
Can you double check that graphics/libepoxy doesn't need updating as well. Just build it in poudriere with this change to mesa and see if it works.
Looking good otherwise.
Sep 16 2020
You need to remove the .Xr to apmd(8) from rc.conf(5) and acpiconf(8) as well, and references to apm(4) from apm(8).
You probably want to remove tools/build/options/WITHOUT_APM since that option is gone and update tools/build/options/WITHOUT_ACPI to indicate that it also governs the installation of the apm(8) userland utility. OptionalObsoleteFiles.inc probably need to take this into account also.
Looking good otherwise.
Sep 13 2020
Sep 12 2020
Awesome! Great work!
Sep 9 2020
Ran it through my poudriere setup withot any issues.
One more thing, can you update the version check in graphics/drm-kmod/Makefile as well?
One small nit above, nothing important.
@arichardson I'm not sure that is enough, there might be ports that include bsd.lib.mk from Makefiles in their respective tarballs.
Note, I haven't test built this, I trust that you've given it a spin in poudriere or similar.
You might want to bump portrevision as well, just to be sure.
Sep 6 2020
Sep 5 2020
Sep 3 2020
Sep 2 2020
Sep 1 2020
This is mostly intended to be committed to 13 to be merged to 12.
Aug 31 2020
How is the backlight adjustments exposed to users?
Do we need to change drm-current-kmod?