Page MenuHomeFreeBSD

net/rpki-client: Update to 7.1
ClosedPublic

Authored by otis on Jul 6 2021, 5:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 7, 6:32 AM
Unknown Object (File)
Thu, Dec 5, 4:49 PM
Unknown Object (File)
Sat, Nov 30, 7:49 AM
Unknown Object (File)
Sat, Nov 30, 7:49 AM
Unknown Object (File)
Wed, Nov 27, 6:25 AM
Unknown Object (File)
Wed, Nov 27, 6:15 AM
Unknown Object (File)
Nov 4 2024, 9:09 PM
Unknown Object (File)
Oct 24 2024, 12:13 PM

Details

Summary
  • Update to 7.1
  • Adjust dependencies
  • Reformat with portclippy/portfmt

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

otis requested review of this revision.Jul 6 2021, 5:11 PM

Thanks for looking into this!
Just two questions above.

net/rpki-client/Makefile
12

Is it possible to make the port use base OpenSSL?

31–33

Is this still true when using libretls?

otis marked an inline comment as done.Jul 7 2021, 7:20 AM
otis added inline comments.
net/rpki-client/Makefile
12

Is it possible to make the port use base OpenSSL?

rpki-client, as of now, requires *both*, OpenSSL and LibreTLS (or LibreSSL). It uses functions libtls.

otis marked 2 inline comments as done.Jul 7 2021, 7:21 AM
otis added inline comments.
net/rpki-client/Makefile
31–33

Is this still true when using libretls?

Yes, it still requires *both* OpenSSL and LibreTLS. We can drop this once RELENG_11 will drop out of support.

It seems one needs to add something along the following lines to make the port compile.

LDFLAGS+=    -L/usr/local/lib
CFLAGS+=     -I/usr/local/include

the system needs to be aware to look for the LibreTLS headers in the /usr/local hierarchy

otis marked an inline comment as done.Jul 9 2021, 2:56 PM

It seems one needs to add something along the following lines to make the port compile.

LDFLAGS+=    -L/usr/local/lib
CFLAGS+=     -I/usr/local/include

the system needs to be aware to look for the LibreTLS headers in the /usr/local hierarchy

This is being handled automagically from within ports framework.

LGTM, thanks for doing this!

net/rpki-client/Makefile
12

Is it possible to make the port use base OpenSSL?

rpki-client, as of now, requires *both*, OpenSSL and LibreTLS (or LibreSSL). It uses functions libtls.

Thanks for the explanation.
At first, I thought it was just libtls that was needed.

31–33

Noted. Makes sense to keep it if base OpenSSL is still needed.

This revision is now accepted and ready to land.Jul 9 2021, 6:47 PM
This revision was automatically updated to reflect the committed changes.