Page MenuHomeFreeBSD

mesa*: Only add x11 dependancy if it's requested
ClosedPublic

Authored by manu on Tue, Sep 15, 3:01 PM.

Details

Summary

This allow to have a full setup without any x11 deps.

Signed-off-by: Emmanuel Vadot <manu@freebsd.org>

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

manu requested review of this revision.Tue, Sep 15, 3:01 PM
manu created this revision.
zeising accepted this revision.Wed, Sep 16, 7:10 AM
zeising added a subscriber: zeising.

Small nit.
Looking good otherwise.

graphics/mesa-dri/Makefile
11 ↗(On Diff #77053)

You remove USES=xorg completely here (I can't see it added anywhere else) which is OK since it's pulled in in Makefile.common I think.

graphics/mesa-libs/Makefile
51 ↗(On Diff #77053)

You readd USES=xorg here, shouldn't this be pulled in by mesa-dri/Makefile.common?

This revision is now accepted and ready to land.Wed, Sep 16, 7:10 AM
manu added inline comments.Wed, Sep 16, 7:13 AM
graphics/mesa-dri/Makefile
11 ↗(On Diff #77053)

Yes the only USES= xorg is now done in Makefile.common.

graphics/mesa-libs/Makefile
51 ↗(On Diff #77053)

Yes it's not needed here, I'll remove it when commiting.

This revision was automatically updated to reflect the committed changes.