Differential D26438

mesa*: Only add x11 dependancy if it's requested
ClosedPublic
Actions

Authored by manu on Sep 15 2020, 3:01 PM.

Tags

None

Referenced Files

	F106070838: D26438.diff
	Tue, Dec 24, 9:55 PM

	Unknown Object (File)
	Mon, Dec 9, 4:19 AM

	Unknown Object (File)
	Fri, Dec 6, 12:30 AM

	Unknown Object (File)
	Thu, Dec 5, 1:11 PM

	Unknown Object (File)
	Thu, Nov 28, 1:27 PM

	Unknown Object (File)
	Thu, Nov 28, 1:24 PM

	Unknown Object (File)
	Thu, Nov 28, 1:24 PM

	Unknown Object (File)
	Thu, Nov 28, 1:08 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rP548829: mesa*: Only add x11 dependancy if it's requested

Summary

This allow to have a full setup without any x11 deps.

Signed-off-by: Emmanuel Vadot <manu@freebsd.org>

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 33569
Build 30821: arc lint + arc unit

Event Timeline

manu requested review of this revision.Sep 15 2020, 3:01 PM

manu created this revision.

Harbormaster completed remote builds in B33569: Diff 77053.Sep 15 2020, 3:01 PM

Small nit.
Looking good otherwise.

graphics/mesa-dri/Makefile
11	You remove USES=xorg completely here (I can't see it added anywhere else) which is OK since it's pulled in in Makefile.common I think.
graphics/mesa-libs/Makefile
51	You readd USES=xorg here, shouldn't this be pulled in by mesa-dri/Makefile.common?

This revision is now accepted and ready to land.Sep 16 2020, 7:10 AM

manu added inline comments.Sep 16 2020, 7:13 AM

graphics/mesa-dri/Makefile
11	Yes the only USES= xorg is now done in Makefile.common.
graphics/mesa-libs/Makefile
51	Yes it's not needed here, I'll remove it when commiting.

Closed by commit rP548829: mesa*: Only add x11 dependancy if it's requested (authored by manu). · Explain WhySep 17 2020, 9:22 AM

This revision was automatically updated to reflect the committed changes.

manu added a commit: rP548829: mesa*: Only add x11 dependancy if it's requested.

Revision Contents
Changeset List

Path

Size

graphics/

mesa-dri/

13 lines

Makefile.common

4 lines

mesa-libs/

11 lines

14 lines

Diff 77053

graphics/mesa-dri/Makefile

Loading...

graphics/mesa-dri/Makefile.common

Loading...

graphics/mesa-libs/Makefile

Loading...

graphics/mesa-libs/pkg-plist

Loading...