Page MenuHomeFreeBSD

graphics/seexpr missing libgen include
Needs ReviewPublic

Authored by zielonka.michal_gmail.com on Sep 6 2021, 9:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 9, 4:45 AM
Unknown Object (File)
Tue, Dec 3, 2:33 AM
Unknown Object (File)
Oct 21 2024, 4:41 PM
Unknown Object (File)
Sep 28 2024, 2:20 PM
Unknown Object (File)
Sep 24 2024, 3:30 AM
Unknown Object (File)
Sep 18 2024, 12:56 PM
Unknown Object (File)
Sep 8 2024, 9:19 AM
Unknown Object (File)
Sep 8 2024, 1:51 AM
Subscribers

Details

Reviewers
danfe
Summary

I'm receiving during building from port error message:
src/tests/imageTests.cpp:465:38: error: use of undeclared identifier 'basename'

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

zeising added a subscriber: zeising.

@danfe maintains seexpr, so pass this to him.

danfe retitled this revision from graphics/seexp missing libgen include to graphics/seexpr missing libgen include.Sep 6 2021, 12:38 PM

Thanks for the report. The problem does not manifest itself on our package build cluster because devel/googletest is not installed by default, so it went unnoticed. I'll address this shortly, meanwhile, you can either pkg delete googletest, or build the port as make build CMAKE_OFF=BUILD_TESTS and remove three files from the pkg-plist prior to packaging.

Thanks for the response. It's first my attempt making MR on phabricator. I thought that I'm making something like MR from github :). I have already working locally graphics/seexpr with proposed patch.

I have already working locally graphics/seexpr with proposed patch.

Ah, that's right. There is no really need for an immediate pull request or something, the issue is not just the missing include, but the whole situation with the tests, dependency on GTest, whether or not to enable them by default, pkg-plist issue, etc. I need some time to think how to deal with it in its entirety.