I'm receiving during building from port error message:
src/tests/imageTests.cpp:465:38: error: use of undeclared identifier 'basename'
Details
- Reviewers
danfe
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Thanks for the report. The problem does not manifest itself on our package build cluster because devel/googletest is not installed by default, so it went unnoticed. I'll address this shortly, meanwhile, you can either pkg delete googletest, or build the port as make build CMAKE_OFF=BUILD_TESTS and remove three files from the pkg-plist prior to packaging.
Thanks for the response. It's first my attempt making MR on phabricator. I thought that I'm making something like MR from github :). I have already working locally graphics/seexpr with proposed patch.
Ah, that's right. There is no really need for an immediate pull request or something, the issue is not just the missing include, but the whole situation with the tests, dependency on GTest, whether or not to enable them by default, pkg-plist issue, etc. I need some time to think how to deal with it in its entirety.