Page MenuHomeFreeBSD

mesa-libs: Add glesv1 lib
ClosedPublic

Authored by manu on Sep 17 2020, 3:18 PM.

Details

Summary

There is no real reason to disable glesv1 so add it to the build.
While here add a USE_GL for it.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

manu requested review of this revision.Sep 17 2020, 3:18 PM
zeising added a subscriber: zeising.

Can you double check that graphics/libepoxy doesn't need updating as well. Just build it in poudriere with this change to mesa and see if it works.
Looking good otherwise.

Also, portmgr is blocking review because changes to Mk/, but Mk/Uses/gl.mk is x11@ responsibility, so it should be OK.

libepoxy is ok.
Why did you though there could be a problem ?

Libepoxy is some glue library, and it had an explicit dep on glesv2, so I thought it might do things with glesv1 as well. I just wanted to be sure.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 19 2020, 9:34 AM
Closed by commit rP548950: mesa-libs: Add glesv1 lib (authored by manu). · Explain Why
This revision was automatically updated to reflect the committed changes.