Page MenuHomeFreeBSD
Differential D26461

mesa-libs: Add glesv1 lib
ClosedPublic
Actions

Authored by manu on Sep 17 2020, 3:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 6:42 AM
Unknown Object (File)
Mon, Dec 9, 4:40 AM
Unknown Object (File)
Wed, Dec 4, 11:47 PM
Unknown Object (File)
Oct 22 2024, 7:10 PM
Unknown Object (File)
Oct 2 2024, 6:50 PM
Unknown Object (File)
Oct 2 2024, 12:53 PM
Unknown Object (File)
Sep 30 2024, 3:31 PM
Unknown Object (File)
Sep 26 2024, 9:40 PM
View All 79 Files
Subscribers
mat
zeising

Details

Reviewers
zeising
Group Reviewers
x11
portmgr
O5: Ports Framework(Owns No Changed Paths)
Commits
rP548950: mesa-libs: Add glesv1 lib
Summary

There is no real reason to disable glesv1 so add it to the build.
While here add a USE_GL for it.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

manu created this revision.Sep 17 2020, 3:18 PM
Herald added a reviewer: portmgr. · View Herald TranscriptSep 17 2020, 3:18 PM
Herald added a subscriber: mat. · View Herald Transcript
manu requested review of this revision.Sep 17 2020, 3:18 PM
zeising accepted this revision.Sep 17 2020, 3:47 PM
zeising added a subscriber: zeising.

Can you double check that graphics/libepoxy doesn't need updating as well. Just build it in poudriere with this change to mesa and see if it works.
Looking good otherwise.

zeising added a comment.Sep 17 2020, 3:48 PM

Also, portmgr is blocking review because changes to Mk/, but Mk/Uses/gl.mk is x11@ responsibility, so it should be OK.

manu added a comment.Sep 17 2020, 3:50 PM

libepoxy is ok.
Why did you though there could be a problem ?

zeising added a comment.Sep 17 2020, 4:02 PM

Libepoxy is some glue library, and it had an explicit dep on glesv2, so I thought it might do things with glesv1 as well. I just wanted to be sure.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 19 2020, 9:34 AM
Closed by commit rP548950: mesa-libs: Add glesv1 lib (authored by manu). · Explain Why
This revision was automatically updated to reflect the committed changes.
manu added a commit: rP548950: mesa-libs: Add glesv1 lib.
Owners added a reviewer: O5: Ports Framework.Sep 19 2020, 9:34 AM

Revision Contents
Changeset List

PathSize
Mk/
Uses/
3 lines
graphics/
libxatracker/
3 lines
mesa-dri/
3 lines
mesa-libs/
2 lines
8 lines

Diff 77134

View Options

Mk/Uses/gl.mk

Loading...
View Options

graphics/libxatracker/Makefile

Loading...
View Options

graphics/mesa-dri/Makefile.common

Loading...
View Options

graphics/mesa-libs/Makefile

Loading...
View Options

graphics/mesa-libs/pkg-plist

Loading...