Page MenuHomeFreeBSD

Create a mail/spamassassin metaport allowing it to use the GA version or the -devel version
AbandonedPublic

Authored by cy on Apr 14 2021, 3:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 8:36 AM
Unknown Object (File)
Sun, Nov 24, 7:08 AM
Unknown Object (File)
Wed, Nov 20, 5:29 AM
Unknown Object (File)
Wed, Nov 20, 1:19 AM
Unknown Object (File)
Tue, Nov 19, 12:46 PM
Unknown Object (File)
Oct 1 2024, 7:35 AM
Unknown Object (File)
Sep 8 2024, 12:23 PM
Unknown Object (File)
Sep 6 2024, 1:38 AM

Details

Reviewers
zeising
otis
Summary

This is the same approach used with multiple versions of krb5, xpdf, and cfengine. The diff looks a little daunting, the summary of changes is below:

slippy$ git st
On branch spamassassin
Changes to be committed:

(use "git restore --staged <file>..." to unstage)

modified: spamassassin-devel/Makefile
modified: spamassassin/Makefile
new file: spamassassin3/Makefile
renamed: spamassassin/distinfo -> spamassassin3/distinfo
renamed: spamassassin/files/pkg-message.in -> spamassassin3/files/pkg-message.in
renamed: spamassassin/files/sa-spamd.in -> spamassassin3/files/sa-spamd.in
renamed: spamassassin/pkg-descr -> spamassassin3/pkg-descr
renamed: spamassassin/pkg-plist -> spamassassin3/pkg-plist

slippy$

The modifications to mail/spamassassin and mail/spamassassin-devel are to suffix the package name if MASTERDIR is not set or if set assume the name of the main port.

All a person needs to do is add SPAMASSASSIN_VERSION=-devel to make.conf. Otherwise it will default to the GA version of spamassassin.

Test Plan

This is working with the krb5, cfengine, and xpdf ports.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

cy requested review of this revision.Apr 14 2021, 3:39 AM
cy created this revision.
cy edited the summary of this revision. (Show Details)

Fix a cut&paste error.

zeising requested changes to this revision.Apr 14 2021, 6:54 AM

This seems to create a lot of complexity for very little gain.
Normally, we have the -devel ports beside the regular ports, without having what is basically a meta port that acts as a slave port to *both* the -devel and release version.

Can you explain why this is needed in the first place? Why can't the -devel port be added as either a slave port of the release version, or just as another version beside the regular version?

I also wonder if it is possible to get a diff of mail/spamassassin/Makefile and mail/spamassassin3/Makefile before you make the changes to mail/spamassassin/Makefile. Right now, in the phab diff, it looks like mail/spamassassin3/Makefile is a completely new file, but I guess it it copied from the original file?

This revision now requires changes to proceed.Apr 14 2021, 6:54 AM

This came about through private email from otis@ regarding many ports depending mail/spamassassin instead of optionally depending on either ports. This was my suggestion. My reply suggestion was this approach. I will leave it to someone else to resolve.

Yes, I brought this up. My original aim was to make some ports (mail/spamass-rules, mail/spamass-milter) to depend on mail/spamassassin-devel instead of mail/spamassassin or at least, to let the user choose which port they want to use as a dependency.