www/pecl-yar: Update to 2.1.2
ClosedPublic
Actions

Authored by miguel_gocobachi.dev on Jun 30 2020, 11:12 PM.

Details

Reviewers

lwhsu
miwi
miguel_gocobachi.dev

Commits

rP544177: Update to 2.1.2

Summary

www/pecl-yar upgrade to 2.1.2

I would like to know if this is the standard way of replacing inline texts,
the default configure did not find the -lcurl, I need to pass the -L with
the correct path.

https://bugs.freebsd.org/247674

Test Plan

poudriere

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

miguel_gocobachi.dev created this revision.Jun 30 2020, 11:12 PM

Herald added a subscriber: mat. · View Herald TranscriptJun 30 2020, 11:12 PM

miguel_gocobachi.dev requested review of this revision.Jun 30 2020, 11:12 PM

Harbormaster completed remote builds in B32074: Diff 73932.Jun 30 2020, 11:12 PM

I think I found the solution for this one.

LDFLAGS+=       -L${LOCALBASE}/lib ${EXTRA_LIBS}

lwhsu added a reviewer: miwi.Jul 1 2020, 2:53 AM

lwhsu edited the summary of this revision. (Show Details)Jul 1 2020, 2:56 AM

lwhsu added inline comments.

www/pecl-yar/Makefile
6 ↗	(On Diff #73932)	No need to add PORTREVISION here.
21 ↗	(On Diff #73932)	Are those white space changes intentional?

lwhsu requested changes to this revision.Jul 1 2020, 2:58 AM

This revision now requires changes to proceed.Jul 1 2020, 2:58 AM

miguel_gocobachi.dev added inline comments.Jul 1 2020, 3:04 AM

www/pecl-yar/Makefile
6 ↗	(On Diff #73932)	in which scenarios the PORTREVISION needs to be changed? (I am learning, my bad I thought it needs to be updated for a new change)
21 ↗	(On Diff #73932)	I think I ran portfmt

Updates following the reviews suggestions:

Remove portrevision

Harbormaster completed remote builds in B32080: Diff 73942.Jul 1 2020, 3:20 AM

lwhsu added inline comments.Jul 1 2020, 3:31 AM

www/pecl-yar/Makefile
6 ↗	(On Diff #73932)	please check https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-naming.html#makefile-portrevision-example
21 ↗	(On Diff #73932)	oh that's fine, I don't think this spaces are mandatory, it's more like personal preference. I recommend that don't do style change if not necessary. (at least not in the same commit)

understood, thanks!

Tested with poudriere for all flavors www/pecl-yar@all on 12_1_amd64 12_1_i386 11_3_amd64 11_3_i386

This revision is now accepted and ready to land.Jul 1 2020, 4:58 AM

lwhsu retitled this revision from Makefile standards for patching inline to www/pecl-yar: Update to 2.1.2.Jul 1 2020, 5:20 AM

0mp added a subscriber: 0mp.Jul 1 2020, 9:51 AM

0mp added inline comments.

www/pecl-yar/Makefile
19 ↗	(On Diff #73942)	`-L${LOCALBASE}/lib` could be replaced with `USES=localbase:ldconfig`. https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/uses-localbase.html BTW, what is the EXTRA_LIBS for?

miguel_gocobachi.dev marked an inline comment as done.Jul 1 2020, 12:25 PM

miguel_gocobachi.dev added inline comments.

www/pecl-yar/Makefile
19 ↗	(On Diff #73942)	The compiler was failing because it was unable to provide the correct path for curl, so I found this peace of code in another port. So, hope it just for appending other libs added with Mk.