Page MenuHomeFreeBSD

wulf (Vladimir Kondratyev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 3 2017, 8:47 AM (210 w, 5 d)

Recent Activity

Today

wulf added a comment to D30795: LinuxKPI: Add compiler barriers to list_for_each_entry_lockless macro.

The commit message has some spelling errors - can you fix?

Thu, Jun 17, 11:43 AM
wulf retitled D30795: LinuxKPI: Add compiler barriers to list_for_each_entry_lockless macro from LinuxKPI: Use list_for_each_entry_rcu macro as a base to to LinuxKPI: Add compiler barriers to list_for_each_entry_lockless macro.
Thu, Jun 17, 11:41 AM

Yesterday

wulf requested review of D30795: LinuxKPI: Add compiler barriers to list_for_each_entry_lockless macro.
Wed, Jun 16, 11:55 PM
wulf requested review of D30781: LinuxKPI: Fix atomic_dec_and_lock_irqsave function.
Wed, Jun 16, 12:24 AM

Tue, Jun 15

wulf added a comment to D30767: LinuxKPI: Add #defines required by drm-kmod v5.5.
In D30767#691741, @manu wrote:

Where is that used ? Can't find anything in the 5.5-wip branch.

Tue, Jun 15, 8:23 AM

Mon, Jun 14

wulf added reviewers for D30767: LinuxKPI: Add #defines required by drm-kmod v5.5: hselasky, manu.
Mon, Jun 14, 11:32 PM
wulf requested review of D30767: LinuxKPI: Add #defines required by drm-kmod v5.5.
Mon, Jun 14, 11:31 PM
wulf added inline comments to D30760: LinuxKPI: Allow kmem_cache_free() to be called from critical sections.
Mon, Jun 14, 11:27 PM
wulf updated the diff for D30760: LinuxKPI: Allow kmem_cache_free() to be called from critical sections.
Mon, Jun 14, 11:25 PM

Sun, Jun 13

wulf added reviewers for D30760: LinuxKPI: Allow kmem_cache_free() to be called from critical sections: hselasky, manu, nc.
Sun, Jun 13, 10:55 PM
wulf requested review of D30760: LinuxKPI: Allow kmem_cache_free() to be called from critical sections.
Sun, Jun 13, 10:53 PM
wulf committed R10:7c55c8c7ff72: ums(4): Start USB xfers on opening of evdev node unconditionally. (authored by wulf).
ums(4): Start USB xfers on opening of evdev node unconditionally.
Sun, Jun 13, 10:08 PM
wulf committed R10:8696dd92ffb7: ums(4): Do not stop USB xfers on FIFO close when evdev is still active (authored by wulf).
ums(4): Do not stop USB xfers on FIFO close when evdev is still active
Sun, Jun 13, 10:08 PM
wulf committed R10:e9dd950507ed: iwmbtfw(8): Improve Intel 7260/7265 adaptors handling (authored by wulf).
iwmbtfw(8): Improve Intel 7260/7265 adaptors handling
Sun, Jun 13, 10:03 PM
wulf committed R10:a4a738ba7575: ums(4): Do not stop USB xfers on FIFO close when evdev is still active (authored by wulf).
ums(4): Do not stop USB xfers on FIFO close when evdev is still active
Sun, Jun 13, 10:03 PM
wulf committed R10:927742783f9e: ums(4): Start USB xfers on opening of evdev node unconditionally. (authored by wulf).
ums(4): Start USB xfers on opening of evdev node unconditionally.
Sun, Jun 13, 10:03 PM
wulf committed R10:a303f4b1c1d3: usbhid(4): Add second set of USB transfers to work in polled mode. (authored by wulf).
usbhid(4): Add second set of USB transfers to work in polled mode.
Sun, Jun 13, 10:03 PM
wulf committed R10:4458105f0647: usbhid(4): Fix NULL pointer dereference in usbd_xfer_max_len() (authored by wulf).
usbhid(4): Fix NULL pointer dereference in usbd_xfer_max_len()
Sun, Jun 13, 10:03 PM

Mon, May 31

wulf committed R10:5236888db771: iichid(4): disable interrupt on suspend (authored by fbsd_opal.com).
iichid(4): disable interrupt on suspend
Mon, May 31, 7:36 PM
wulf committed R10:da93a73f8346: iwmbtfw(8): Improve Intel 7260/7265 adaptors handling (authored by wulf).
iwmbtfw(8): Improve Intel 7260/7265 adaptors handling
Mon, May 31, 7:34 PM
wulf closed D30543: iwmbtfw(8): Improve 7260 adaptors handling.
Mon, May 31, 7:34 PM

Sat, May 29

wulf added a comment to D30020: bhyve: add virtio-input emulation.

Could you test https://reviews.freebsd.org/D30542 ?
It should fix

Cannot gain exklusive access to the input device
Occurs when using legacy drivers for FreeBSD

Sat, May 29, 1:25 PM · bhyve
wulf updated the test plan for D30543: iwmbtfw(8): Improve 7260 adaptors handling.
Sat, May 29, 1:19 PM
wulf requested review of D30543: iwmbtfw(8): Improve 7260 adaptors handling.
Sat, May 29, 1:16 PM
wulf requested review of D30542: evdev: Extend EVIOCGRAB ioctl scope to cover kbd/sysmouse interfaces.
Sat, May 29, 1:12 PM

Fri, May 28

wulf committed R10:9aa0e5af75d0: usbhid(4): Add second set of USB transfers to work in polled mode. (authored by wulf).
usbhid(4): Add second set of USB transfers to work in polled mode.
Fri, May 28, 8:31 PM
wulf committed R10:e889a462d878: usbhid(4): Fix NULL pointer dereference in usbd_xfer_max_len() (authored by wulf).
usbhid(4): Fix NULL pointer dereference in usbd_xfer_max_len()
Fri, May 28, 8:31 PM
wulf closed D30486: usbhid(4): Add second set of USB transfers to work in polled mode..
Fri, May 28, 8:31 PM
wulf closed D30485: usbhid(4): Fix NULL pointer dereference in usbd_xfer_max_len().
Fri, May 28, 8:31 PM

Thu, May 27

wulf requested review of D30486: usbhid(4): Add second set of USB transfers to work in polled mode..
Thu, May 27, 12:58 AM
wulf requested review of D30485: usbhid(4): Fix NULL pointer dereference in usbd_xfer_max_len().
Thu, May 27, 12:56 AM

Sun, May 23

wulf committed R10:0be693b3d5f1: iwmbtfw(8): Add support for Intel 7260/7265 bluetooth adapter firmwares (authored by pitwuu_gmail.com).
iwmbtfw(8): Add support for Intel 7260/7265 bluetooth adapter firmwares
Sun, May 23, 10:47 PM
wulf committed R10:05ab03a31798: ums(4): Do not stop USB xfers on FIFO close when evdev is still active (authored by wulf).
ums(4): Do not stop USB xfers on FIFO close when evdev is still active
Sun, May 23, 10:44 PM
wulf committed R10:47791339f0cf: ums(4): Start USB xfers on opening of evdev node unconditionally. (authored by wulf).
ums(4): Start USB xfers on opening of evdev node unconditionally.
Sun, May 23, 10:44 PM
wulf closed D30343: ums(4): Start USB xfers on opening of evdev node unconditionally..
Sun, May 23, 10:44 PM
wulf closed D30342: ums(4): Do not stop USB xfers on FIFO close when evdev is still active.
Sun, May 23, 10:44 PM

Wed, May 19

wulf added inline comments to D30342: ums(4): Do not stop USB xfers on FIFO close when evdev is still active.
Wed, May 19, 7:47 AM

Tue, May 18

wulf requested review of D30343: ums(4): Start USB xfers on opening of evdev node unconditionally..
Tue, May 18, 11:24 PM
wulf updated the summary of D30342: ums(4): Do not stop USB xfers on FIFO close when evdev is still active.
Tue, May 18, 11:22 PM
wulf updated the diff for D30342: ums(4): Do not stop USB xfers on FIFO close when evdev is still active.

While here use bitwise operations for UMS_EVDEV_OPENED flag.

Tue, May 18, 11:19 PM
wulf requested review of D30342: ums(4): Do not stop USB xfers on FIFO close when evdev is still active.
Tue, May 18, 10:57 PM

May 4 2021

wulf committed R10:fe70d7b26d7a: iwmbtfw(8): Add support for Intel 7260/7265 bluetooth adapter firmwares (authored by Philippe Michaud-Boudreault <pitwuu@gmail.com>).
iwmbtfw(8): Add support for Intel 7260/7265 bluetooth adapter firmwares
May 4 2021, 11:53 PM
wulf committed R11:676dbc240b8a: comms/iwmbt-firmware: Update to 20210315 revision 2 (authored by wulf).
comms/iwmbt-firmware: Update to 20210315 revision 2
May 4 2021, 11:17 PM

Apr 30 2021

wulf committed R10:83235903d5dc: ng_ubt: Block attachment of uninitialized Intel Wireless 7265 (authored by wulf).
ng_ubt: Block attachment of uninitialized Intel Wireless 7265
Apr 30 2021, 8:17 PM
wulf committed R10:51b2d043692c: hkbd: Fix typo which disables keyboard input in kdb (authored by wulf).
hkbd: Fix typo which disables keyboard input in kdb
Apr 30 2021, 8:17 PM
wulf committed R10:ad711fa497d5: ng_ubt: Do not clear stall before receiving of HCI command response. (authored by wulf).
ng_ubt: Do not clear stall before receiving of HCI command response.
Apr 30 2021, 8:17 PM
wulf committed R10:3f5ce99dc625: ng_ubt: Use DEFINE_CLASS_1 macro for kobj inheritance. (authored by wulf).
ng_ubt: Use DEFINE_CLASS_1 macro for kobj inheritance.
Apr 30 2021, 8:17 PM
wulf committed R10:91e562169c0b: hidmap: add missing opt_hid.h to module Makefile (authored by wulf).
hidmap: add missing opt_hid.h to module Makefile
Apr 30 2021, 8:17 PM
wulf committed R10:61860b0a488f: ichsmb: Add PCI ID for Intel Gemini Lake SMBus controller (authored by wulf).
ichsmb: Add PCI ID for Intel Gemini Lake SMBus controller
Apr 30 2021, 8:17 PM
wulf committed R10:610e72370607: pchtherm: Add IDs for CannonLake-H, CometLake and Lewisburg controllers (authored by wulf).
pchtherm: Add IDs for CannonLake-H, CometLake and Lewisburg controllers
Apr 30 2021, 8:17 PM

Apr 28 2021

wulf added inline comments to D30020: bhyve: add virtio-input emulation.
Apr 28 2021, 10:29 PM · bhyve
wulf added a comment to D30020: bhyve: add virtio-input emulation.

Cannot gain exklusive access to the input device

You are doing EVIOCGRAB, so it would be exclusive against other evdev clients.
But yes, that currently won't exclude keyboards from the vt console, or mouses from various legacy interfaces (that moused uses, etc.).
Shouldn't be an issue if you do have a GUI running, but of course not every VM host is a desktop.
Pinging @wulf — would be nice to make evdev_grab_client tell the driver to pause vt kbd events etc.

Apr 28 2021, 9:49 PM · bhyve

Apr 24 2021

wulf committed R10:e68d76c054d2: hkbd: Fix typo which disables keyboard input in kdb (authored by wulf).
hkbd: Fix typo which disables keyboard input in kdb
Apr 24 2021, 7:03 PM

Apr 22 2021

wulf committed R10:55eb41bb1fb6: hv_kbd: Fix build with EVDEV_SUPPORT kernel option disabled. (authored by wulf).
hv_kbd: Fix build with EVDEV_SUPPORT kernel option disabled.
Apr 22 2021, 10:14 PM

Apr 15 2021

wulf committed R10:788a171c7776: ng_ubt: Block attachment of uninitialized Intel Wireless 7265 (authored by wulf).
ng_ubt: Block attachment of uninitialized Intel Wireless 7265
Apr 15 2021, 2:30 PM
wulf committed R10:52489f2a55e6: ng_ubt: Do not clear stall before receiving of HCI command response. (authored by wulf).
ng_ubt: Do not clear stall before receiving of HCI command response.
Apr 15 2021, 2:30 PM
wulf committed R10:d605d7294843: ng_ubt: Use DEFINE_CLASS_1 macro for kobj inheritance. (authored by wulf).
ng_ubt: Use DEFINE_CLASS_1 macro for kobj inheritance.
Apr 15 2021, 2:30 PM
wulf closed D29775: ng_ubt: Do not clear stall unconditionally before receiving of HCI command response..
Apr 15 2021, 2:29 PM
wulf requested review of D29775: ng_ubt: Do not clear stall unconditionally before receiving of HCI command response..
Apr 15 2021, 1:28 PM

Apr 14 2021

wulf committed R10:8e84712d01eb: hidmap: add missing opt_hid.h to module Makefile (authored by wulf).
hidmap: add missing opt_hid.h to module Makefile
Apr 14 2021, 8:07 PM
wulf committed R10:6678e75e4ff9: pchtherm: Add IDs for CannonLake-H, CometLake and Lewisburg controllers (authored by wulf).
pchtherm: Add IDs for CannonLake-H, CometLake and Lewisburg controllers
Apr 14 2021, 10:17 AM
wulf committed R10:fb451895fba7: ichsmb: Add PCI ID for Intel Gemini Lake SMBus controller (authored by wulf).
ichsmb: Add PCI ID for Intel Gemini Lake SMBus controller
Apr 14 2021, 12:59 AM

Apr 12 2021

wulf committed R10:e4643aa4c4ff: hv_kbd: Add support for K_XLATE and K_CODE modes for gen 2 VMs (authored by wulf).
hv_kbd: Add support for K_XLATE and K_CODE modes for gen 2 VMs
Apr 12 2021, 3:50 AM
wulf committed R10:774cbf9b64c2: hv_kbd: Fix leaked $FreeBSD$ expansion (authored by wulf).
hv_kbd: Fix leaked $FreeBSD$ expansion
Apr 12 2021, 3:50 AM
wulf committed R10:c2a159286c76: hv_kbd: Add evdev protocol support for gen 2 VMs (authored by wulf).
hv_kbd: Add evdev protocol support for gen 2 VMs
Apr 12 2021, 3:50 AM
wulf closed D28171: Hyper-V kbd: Add support for K_XLATE and K_CODE modes for gen 2 VMs.
Apr 12 2021, 3:50 AM
wulf closed D28170: Hyper-V kbd: Add evdev protocol support for gen 2 VMs.
Apr 12 2021, 3:50 AM
wulf committed R10:30b132ffe699: ig4: Add PCI IDs for Intel Gemini Lake I2C controller. (authored by wulf).
ig4: Add PCI IDs for Intel Gemini Lake I2C controller.
Apr 12 2021, 3:50 AM
wulf committed R10:99bc385243e8: hid: add opt_hid.h to modules that use HID_DEBUG (authored by wulf).
hid: add opt_hid.h to modules that use HID_DEBUG
Apr 12 2021, 3:50 AM
wulf committed R10:09d2a7a67b54: ig4: Add PCI IDs for Intel Gemini Lake I2C controller. (authored by wulf).
ig4: Add PCI IDs for Intel Gemini Lake I2C controller.
Apr 12 2021, 3:49 AM
wulf committed R10:fd140c52160a: epoll: Store epoll_event udata member in ext member of kevent. (authored by wulf).
epoll: Store epoll_event udata member in ext member of kevent.
Apr 12 2021, 3:49 AM

Apr 11 2021

wulf added a comment to D29111: Add AT_EMPTY_PATH.

Seems to work perfectly for at least fstatat(2) and fchownat(2). Thanks for working on it!

Apr 11 2021, 2:20 PM

Apr 8 2021

wulf added a comment to D29323: Implement O_PATH.
In D29323#665100, @kib wrote:

Fix propagating FKQALLOWED

Apr 8 2021, 11:38 PM
wulf added a comment to D29323: Implement O_PATH.

Could you please give me the min example?

Apr 8 2021, 8:26 PM
wulf added a comment to D29323: Implement O_PATH.

Move FKQALLOWED to the final f_flag value.

Apr 8 2021, 7:48 PM
wulf added a comment to D29323: Implement O_PATH.

Check access on open and allow kevent vnode filter for O_PATH files if VOP_ACCESS(VREAD) passed.

Apr 8 2021, 6:29 PM

Apr 7 2021

wulf added a comment to D29323: Implement O_PATH.

Why VWRITE?

It depends on orthogonality of O_PATH
If we consider O_PATH flag to be orthogonal to other access mode flags like O_RDONLY, O_WRONLY and O_RDWR, we should pass VWRITE to VOP_ACCESS if O_WRONLY or O_RDWR is specified in open() flag list.
If O_PATH is just a next access mode in the list and it can not be combined with other aforementioned O_* flags, then only VREAD should be passed to VOP_ACCESS unconditionally.

Apr 7 2021, 10:07 PM
wulf added a comment to D29323: Implement O_PATH.

You mean, with O_PATH we should check the snapshot of current access rights when fd is passed to kqueue for vnode filter?

Apr 7 2021, 4:13 PM
wulf added a comment to D29323: Implement O_PATH.

Can you elaborate more?

Apr 7 2021, 9:47 AM

Apr 6 2021

wulf added a comment to D29323: Implement O_PATH.

Do we still consider it wrong?

Apr 6 2021, 10:16 PM

Apr 5 2021

wulf added a comment to D29323: Implement O_PATH.
In D29323#663265, @kib wrote:

Can you formulate exactly what should we deny? I do not see how to limit this usefully, unless you can provide a criteria, I will roll back enablement of the kqueue' vnode filter.

Apr 5 2021, 7:10 PM
wulf added a comment to D29323: Implement O_PATH.

I am able to open 600 root:wheel files as ordinary user with O_PATH flag added. Is it intended behavior?
If yes, we should deny kevent() for such a fds as it is a security hole.

Apr 5 2021, 4:30 PM

Apr 3 2021

wulf added inline comments to D29323: Implement O_PATH.
Apr 3 2021, 2:26 PM

Mar 3 2021

wulf closed D28995: hid: add opt_hid.h to modules that use HID_DEBUG.
Mar 3 2021, 10:45 PM
wulf committed R10:6241b57131a6: hid: add opt_hid.h to modules that use HID_DEBUG (authored by wulf).
hid: add opt_hid.h to modules that use HID_DEBUG
Mar 3 2021, 10:45 PM

Mar 1 2021

wulf accepted D28995: hid: add opt_hid.h to modules that use HID_DEBUG.
Mar 1 2021, 10:07 PM

Feb 23 2021

wulf committed R10:9bdb559d9726: ukbd: Fix handling of keyboard ErrorRollOver reports (authored by wulf).
ukbd: Fix handling of keyboard ErrorRollOver reports
Feb 23 2021, 11:45 PM
wulf committed R10:98b3658c4e8a: hkbd: Fix handling of keyboard ErrorRollOver reports (authored by wulf).
hkbd: Fix handling of keyboard ErrorRollOver reports
Feb 23 2021, 11:44 PM
wulf committed R10:e7211ca03a85: ukbd: Fix handling of keyboard ErrorRollOver reports (authored by wulf).
ukbd: Fix handling of keyboard ErrorRollOver reports
Feb 23 2021, 11:44 PM
wulf committed R10:9262a9ce06a6: hidraw: Make HIDIOCGRDESCSIZE ioctl return report descriptor size (authored by wulf).
hidraw: Make HIDIOCGRDESCSIZE ioctl return report descriptor size
Feb 23 2021, 11:43 PM
wulf committed R10:bbacb7ce7295: ig4: Add PCI IDs for Intel Gemini Lake I2C controller. (authored by wulf).
ig4: Add PCI IDs for Intel Gemini Lake I2C controller.
Feb 23 2021, 10:25 PM

Feb 18 2021

wulf added a comment to D28746: ig4(4): Add an EMAG device type.
In D28746#643683, @manu wrote:

I agree with Warner here, having a table would be nicer.

Feb 18 2021, 5:37 PM

Feb 14 2021

wulf committed rP565272: new port: sysutils/hid-tools.
new port: sysutils/hid-tools
Feb 14 2021, 11:07 PM
wulf committed rP565271: sysutils/iichid: Update to 0.0.6.
sysutils/iichid: Update to 0.0.6
Feb 14 2021, 10:50 PM

Feb 13 2021

wulf committed R10:f988d7fa050e: hidraw: Make HIDIOCGRDESCSIZE ioctl return report descriptor size (authored by wulf).
hidraw: Make HIDIOCGRDESCSIZE ioctl return report descriptor size
Feb 13 2021, 6:21 PM
wulf committed R10:812c59ed614d: hkbd: Fix handling of keyboard ErrorRollOver reports (authored by wulf).
hkbd: Fix handling of keyboard ErrorRollOver reports
Feb 13 2021, 6:21 PM
wulf committed R10:032d3153877e: ukbd: Fix handling of keyboard ErrorRollOver reports (authored by wulf).
ukbd: Fix handling of keyboard ErrorRollOver reports
Feb 13 2021, 6:21 PM

Feb 8 2021

wulf added a comment to D28543: hid: bump HID_ITEM_MAXUSAGES to 8.
In D28543#638978, @imp wrote:
In D28543#638950, @wulf wrote:

Could you share the HID report descriptor of your device?

How do I do that?

Feb 8 2021, 11:49 PM
wulf added a comment to D28521: dev/usb/input/wsp: Add sysctl tunable for Z-Axis inversion.

Thanks! Would you be able to commit it for me?

Feb 8 2021, 9:47 PM · Contributor Reviews (base)
wulf accepted D28543: hid: bump HID_ITEM_MAXUSAGES to 8.

Could you share the HID report descriptor of your device?

Feb 8 2021, 9:42 PM