Page MenuHomeFreeBSD

wulf (Vladimir Kondratyev)
User

Projects

User Details

User Since
Jun 3 2017, 8:47 AM (463 w, 6 d)

Recent Activity

Today

wulf added a comment to D56500: rtlbtfw: handle partial reads when loading firmware.

I committed mmap()-based changes. See: https://cgit.freebsd.org/src/commit/?id=87ed6840a0a6320295f6abb43a987d20ae126cf7

Fri, Apr 24, 3:19 PM
wulf committed rG87ed6840a0a6: rtlbtfw(8): Load firmware from filesystem with mmap() (authored by wulf).
rtlbtfw(8): Load firmware from filesystem with mmap()
Fri, Apr 24, 3:16 PM

Yesterday

wulf committed rGc0e26f7b29dd: hkbd/ukbd: sysctls to swap macbook kbd modifiers (authored by ~Not Toby <0x2b@0xff.art>).
hkbd/ukbd: sysctls to swap macbook kbd modifiers
Thu, Apr 23, 5:11 AM
wulf added a comment to D56500: rtlbtfw: handle partial reads when loading firmware.

Although it looks good, replacing read() with mmap() -> memcpy() -> munmap() sequence would make code simpler and cleaner

Thu, Apr 23, 4:06 AM

Wed, Apr 22

wulf committed rG6d00a0e09aaa: wsp(4): Make evdev interface operational if sysmouse one is not opened (authored by wulf).
wsp(4): Make evdev interface operational if sysmouse one is not opened
Wed, Apr 22, 8:09 PM
wulf committed rG0268f2ef8478: bcm5974(4): Fix pre-2015 Apple touchpad support (authored by wulf).
bcm5974(4): Fix pre-2015 Apple touchpad support
Wed, Apr 22, 8:09 PM
wulf committed rGcc6016af8461: wsp(4): Do not handle pressure on non-ForceTouch devices (authored by wulf).
wsp(4): Do not handle pressure on non-ForceTouch devices
Wed, Apr 22, 8:09 PM
wulf committed rGad5bf14a3dcb: bcm5974(4): Do not handle pressure on non-ForceTouch devices (authored by wulf).
bcm5974(4): Do not handle pressure on non-ForceTouch devices
Wed, Apr 22, 8:09 PM
wulf committed rG5c8640e863a1: hid: Change Usage Page names to match documentation (authored by wulf).
hid: Change Usage Page names to match documentation
Wed, Apr 22, 8:09 PM
wulf committed rG665ea58a3134: iwmbtfw(8): Identify device type based on HCI quieries result (authored by wulf).
iwmbtfw(8): Identify device type based on HCI quieries result
Wed, Apr 22, 8:09 PM
wulf committed rG26408151bb1d: rtlbtfw(8): Add support for Realtek 8852CE (authored by fakeshadow1337_gmail.com).
rtlbtfw(8): Add support for Realtek 8852CE
Wed, Apr 22, 8:09 PM
wulf committed rG10678006c6db: asmc(4): Add PnP record (authored by wulf).
asmc(4): Add PnP record
Wed, Apr 22, 8:09 PM
wulf committed rG03fb1afc3ca7: hkbd(4): add some extra handy fn key bindings (authored by Toby Slight <tslight@pm.me>).
hkbd(4): add some extra handy fn key bindings
Wed, Apr 22, 8:09 PM
wulf committed rGfec425a2a8b7: ukbd(4): make debug guard consistent with hkbd(4) (authored by Toby Slight <tslight@pm.me>).
ukbd(4): make debug guard consistent with hkbd(4)
Wed, Apr 22, 8:09 PM
wulf committed rG5138ea094d35: bluetooth: add device IDs for Intel AX411 and BE200 adapters (authored by chris.longros_gmail.com).
bluetooth: add device IDs for Intel AX411 and BE200 adapters
Wed, Apr 22, 8:09 PM
wulf committed rG393c53fd219d: hkbd(4): be more cautious & explicit about Apple vendor checking (authored by tslight <tslight@pm.com>).
hkbd(4): be more cautious & explicit about Apple vendor checking
Wed, Apr 22, 8:08 PM
wulf committed rG39db3b9fc194: ukbd(4): backport Apple function keys support from hkbd(4) (authored by tslight <tslight@pm.com>).
ukbd(4): backport Apple function keys support from hkbd(4)
Wed, Apr 22, 8:08 PM
wulf committed rG0af73c16e79a: hkbd(4): fix handling of apple function keys in hid and evdev (authored by tslight <tslight@pm.com>).
hkbd(4): fix handling of apple function keys in hid and evdev
Wed, Apr 22, 8:08 PM
wulf committed rG537159a58760: psm(4): Add middle button support for Elantech V4 touchpads (authored by wulf).
psm(4): Add middle button support for Elantech V4 touchpads
Wed, Apr 22, 8:08 PM

Sun, Apr 12

wulf committed rG817e6995a19c: wsp(4): Make evdev interface operational if sysmouse one is not opened (authored by wulf).
wsp(4): Make evdev interface operational if sysmouse one is not opened
Sun, Apr 12, 6:10 PM
wulf committed rGdc5a94962e21: wsp(4): Do not handle pressure on non-ForceTouch devices (authored by wulf).
wsp(4): Do not handle pressure on non-ForceTouch devices
Sun, Apr 12, 6:10 PM
wulf committed rG9d0404cfe92c: bcm5974(4): Do not handle pressure on non-ForceTouch devices (authored by wulf).
bcm5974(4): Do not handle pressure on non-ForceTouch devices
Sun, Apr 12, 6:10 PM
wulf committed rGd6477cd3a5c3: bcm5974(4): Fix pre-2015 Apple touchpad support (authored by wulf).
bcm5974(4): Fix pre-2015 Apple touchpad support
Sun, Apr 12, 6:10 PM
wulf committed rG84488787f42b: iwmbtfw(8): Identify device type based on HCI quieries result (authored by wulf).
iwmbtfw(8): Identify device type based on HCI quieries result
Sun, Apr 12, 6:10 PM
wulf committed rG2ba6ce584a8c: hid: Change Usage Page names to match documentation (authored by wulf).
hid: Change Usage Page names to match documentation
Sun, Apr 12, 6:10 PM

Sat, Apr 11

wulf added inline comments to D56345: hid: add Sony PS5 DualSense controller driver.
Sat, Apr 11, 8:37 PM
wulf added a comment to D56345: hid: add Sony PS5 DualSense controller driver.

IMO it would be good to rename driver from ps5dualsense to ps5dsense to be inline with ps4dshock. That is up to you.

Sat, Apr 11, 8:15 PM
wulf added a comment to D56345: hid: add Sony PS5 DualSense controller driver.

Looks mostly good.
There are some missing parts. TODO:

  1. Add manpage. You may take share/man/man4/ps4dshock.4 as starting point. Do not forget to add missing touchpad and accelerometer support to BUGS section.
  2. Add ps5dualsense.c to sys/conf/files and sys/conf/NOTES
  3. Add ps5dualsense subdir to sys/modules/hid/Makefile
Sat, Apr 11, 4:46 PM

Fri, Apr 10

wulf added inline comments to D56345: hid: add Sony PS5 DualSense controller driver.
Fri, Apr 10, 9:38 PM

Sun, Mar 29

wulf committed rG1c10825c6e5f: asmc(4): Bump manpage date after edition (authored by wulf).
asmc(4): Bump manpage date after edition
Sun, Mar 29, 7:08 PM
wulf committed rGf3fc362c0fb2: bluetooth: remove redundant 0x0bda entries from ng_ubt_rtl, rtlbtfw (authored by chris.longros_gmail.com).
bluetooth: remove redundant 0x0bda entries from ng_ubt_rtl, rtlbtfw
Sun, Mar 29, 7:03 PM
wulf committed rG5d7862fb998f: asmc(4): Add support for backlight(9) interface (authored by wulf).
asmc(4): Add support for backlight(9) interface
Sun, Mar 29, 7:02 PM
wulf committed rG056e29070f08: asmc(4): Add PnP record (authored by wulf).
asmc(4): Add PnP record
Sun, Mar 29, 7:02 PM
wulf closed D56137: bluetooth: remove redundant 0x0bda entries from ng_ubt_rtl, rtlbtfw.
Sun, Mar 29, 7:02 PM
wulf accepted D56137: bluetooth: remove redundant 0x0bda entries from ng_ubt_rtl, rtlbtfw.
Sun, Mar 29, 5:18 PM
wulf committed rGd82bcf5681dd: bluetooth: add device IDs for Intel AX411 and BE200 adapters (authored by chris.longros_gmail.com).
bluetooth: add device IDs for Intel AX411 and BE200 adapters
Sun, Mar 29, 1:18 PM
wulf committed rG920ad3cef178: ukbd(4): make debug guard consistent with hkbd(4) (authored by Toby Slight <tslight@pm.me>).
ukbd(4): make debug guard consistent with hkbd(4)
Sun, Mar 29, 1:18 PM
wulf committed rGbb8230f838c8: hkbd(4): add some extra handy fn key bindings (authored by Toby Slight <tslight@pm.me>).
hkbd(4): add some extra handy fn key bindings
Sun, Mar 29, 1:18 PM
wulf committed rG103325323c7d: hkbd(4): be more cautious & explicit about Apple vendor checking (authored by tslight <tslight@pm.com>).
hkbd(4): be more cautious & explicit about Apple vendor checking
Sun, Mar 29, 1:18 PM
wulf committed rG40f55eada592: ukbd(4): backport Apple function keys support from hkbd(4) (authored by tslight <tslight@pm.com>).
ukbd(4): backport Apple function keys support from hkbd(4)
Sun, Mar 29, 1:18 PM
wulf committed rGf54caa04edd9: hkbd(4): fix handling of apple function keys in hid and evdev (authored by tslight <tslight@pm.com>).
hkbd(4): fix handling of apple function keys in hid and evdev
Sun, Mar 29, 1:18 PM
wulf closed D56122: bluetooth: add device IDs for Intel AX411 and BE200 adapters.
Sun, Mar 29, 1:17 PM

Sat, Mar 28

wulf added a comment to D56137: bluetooth: remove redundant 0x0bda entries from ng_ubt_rtl, rtlbtfw.

It seems that more files should be fixed. See your previous patch: https://reviews.freebsd.org/D56126

Sat, Mar 28, 10:03 PM
wulf added a comment to D56126: bluetooth: Add Realtek RTL8852CE device ID (0x0bda:0x0852).

You're right, the generic Realtek rule already covers this. I missed the USB_VENDOR match at the top of the table. Abandoning this diff.

Good point about the other 0x0bda entries too -- I can submit a cleanup diff to drop those if you'd like.

Sat, Mar 28, 9:44 PM
wulf added a comment to D56126: bluetooth: Add Realtek RTL8852CE device ID (0x0bda:0x0852).

Other Realtek entries are inherited from Linux. I think we can drop them.

Sat, Mar 28, 9:12 PM
wulf added a comment to D56126: bluetooth: Add Realtek RTL8852CE device ID (0x0bda:0x0852).

Realtek devices are handled by generic Realtek rule. Does it work for you?

Sat, Mar 28, 9:10 PM
wulf added a comment to D56122: bluetooth: add device IDs for Intel AX411 and BE200 adapters.

Alder Lake system is not needed

Sat, Mar 28, 12:24 PM
wulf accepted D56122: bluetooth: add device IDs for Intel AX411 and BE200 adapters.

LGTM. Could you test Intel BT identify patch from https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290639 ?

Sat, Mar 28, 10:06 AM

Mar 23 2026

wulf added a comment to D56026: hid/hsctrl: Add support for Wireless Radio Button.

Radio button can not be correctly handled with hidmap. MS does strange things here assuming every event in report as a keypress. E.g. ASUS TUF always reported radio key as depressed that brokes Linux but works on Windows

Mar 23 2026, 12:31 PM
wulf added a comment to D56026: hid/hsctrl: Add support for Wireless Radio Button.
Mar 23 2026, 12:09 PM

Mar 9 2026

wulf added a comment to D55710: acpi_system76: Add support for battary charge thresholds.

It will trigger enumeration value ‘S76_CTRL_MAX’ not specifically handled in switch if -Wswitch option is passed to compiler.
From [1]:

-Wswitch

Warn whenever a switch statement has an index of enumerated type and lacks a case for one or more of the named codes of that enumeration. (The presence of a default label prevents this warning.) case labels that do not correspond to enumerators also provoke warnings when this option is used, unless the enumeration is marked with the flag_enum attribute. This warning is enabled by -Wall.

Obviously case S76_CTRL_MAX is not generally handled in switch() statements.

Mar 9 2026, 8:28 AM

Mar 8 2026

wulf accepted D55710: acpi_system76: Add support for battary charge thresholds.
Mar 8 2026, 8:34 PM
wulf accepted D55716: acpi_system76: Add backlight(9) support for keyboard.
Mar 8 2026, 8:29 PM
wulf accepted D55176: linuxkpi: Handle bin attributes in sysfs attribute groups.
Mar 8 2026, 3:37 PM
wulf added inline comments to D55716: acpi_system76: Add backlight(9) support for keyboard.
Mar 8 2026, 11:21 AM
wulf added a comment to D55175: linuxkpi: Add device under parent, not under class.

I dislike this idea.
The sysctl sys.class.drm.card0-DP-1 path matches Linux while sysctl sys.device.drmn1.card0.card0-DP-1 not

Mar 8 2026, 9:56 AM
wulf added inline comments to D55710: acpi_system76: Add support for battary charge thresholds.
Mar 8 2026, 8:26 AM
wulf added inline comments to D55694: acpi_system76: Support for acpi-controlled buttons on System76.
Mar 8 2026, 7:50 AM
wulf added inline comments to D55716: acpi_system76: Add backlight(9) support for keyboard.
Mar 8 2026, 7:28 AM

Mar 7 2026

wulf added a comment to D55694: acpi_system76: Support for acpi-controlled buttons on System76.

The keyboard_color has full RGB coverage and accept 24-bit value as its input, so I don't think registering it in backlight be a good idea.

Mar 7 2026, 4:41 PM
wulf added a comment to D55694: acpi_system76: Support for acpi-controlled buttons on System76.

Adding of EVDEV interface to notyfy userland software would be good idea too. See sys/dev/acpi_support/acpi_asus_wmi.c again

Mar 7 2026, 4:17 PM
wulf added a comment to D55694: acpi_system76: Support for acpi-controlled buttons on System76.

could you take another look at the code?

Mar 7 2026, 4:15 PM
wulf added a comment to D55694: acpi_system76: Support for acpi-controlled buttons on System76.

We have backlight(9) interface since FreeBSD 13

Mar 7 2026, 8:28 AM

Mar 5 2026

wulf added inline comments to D55176: linuxkpi: Handle bin attributes in sysfs attribute groups.
Mar 5 2026, 5:38 AM

Mar 3 2026

wulf accepted D55626: hid: Fix 'strenght' typo in hpen.c.

LGTM

Mar 3 2026, 10:21 PM

Feb 17 2026

wulf committed rGb66993bd51d3: evdev: Drop comments from input-event-codes.h (authored by wulf).
evdev: Drop comments from input-event-codes.h
Feb 17 2026, 10:21 PM
wulf committed rG262ea9d9a9aa: evdev: Sync event codes with Linux kernel 6.18 (authored by wulf).
evdev: Sync event codes with Linux kernel 6.18
Feb 17 2026, 10:20 PM
wulf committed rG0280fef4ba5e: evdev: Drop comments from input-event-codes.h (authored by wulf).
evdev: Drop comments from input-event-codes.h
Feb 17 2026, 8:42 PM
wulf committed rG4291d770fd8a: evdev: Sync event codes with Linux kernel 6.18 (authored by wulf).
evdev: Sync event codes with Linux kernel 6.18
Feb 17 2026, 8:42 PM
wulf committed rG5bf02d480f5b: evdev: Drop comments from input-event-codes.h (authored by wulf).
evdev: Drop comments from input-event-codes.h
Feb 17 2026, 8:42 PM
wulf committed rG09f1db900c6c: evdev: Sync event codes with Linux kernel 6.18 (authored by wulf).
evdev: Sync event codes with Linux kernel 6.18
Feb 17 2026, 8:42 PM
wulf committed rG11231c820699: msconvd(8): Drop mentions of Bus/InPort mouse support in manual page (authored by wulf).
msconvd(8): Drop mentions of Bus/InPort mouse support in manual page
Feb 17 2026, 8:42 PM
wulf committed rG68ab94288203: psm: Fix three finger tap on elantech v4 touchpads (authored by Robert Wahlberg <freebsd@robertwahlberg.se>).
psm: Fix three finger tap on elantech v4 touchpads
Feb 17 2026, 8:41 PM
wulf committed rGd0e1b3edee70: hid: Make game controllers accessible to members of the game group (authored by wulf).
hid: Make game controllers accessible to members of the game group
Feb 17 2026, 8:41 PM
wulf committed rGbcc06806430a: evdev: Allow setting of character device ownership and access mode (authored by wulf).
evdev: Allow setting of character device ownership and access mode
Feb 17 2026, 8:41 PM

Feb 10 2026

wulf committed rG89aa8a94053f: evdev: Drop comments from input-event-codes.h (authored by wulf).
evdev: Drop comments from input-event-codes.h
Feb 10 2026, 11:00 PM
wulf committed rG20a3c611f53d: moused(8): Use KQUEUE_CPONFORK flag to pass kqueue fd through fork (authored by wulf).
moused(8): Use KQUEUE_CPONFORK flag to pass kqueue fd through fork
Feb 10 2026, 11:00 PM
wulf committed rG3d85dcd1a9aa: psm(4): Add middle button support for Elantech V4 touchpads (authored by wulf).
psm(4): Add middle button support for Elantech V4 touchpads
Feb 10 2026, 11:00 PM

Dec 24 2025

wulf committed rG198ef2a31cee: LinuxKPI: bump __FreeBSD_version for vmap_pfn implementation (authored by wulf).
LinuxKPI: bump __FreeBSD_version for vmap_pfn implementation
Dec 24 2025, 8:13 PM
wulf committed rG304c24df44d3: LinuxKPI: Implement vmap_pfn (authored by wulf).
LinuxKPI: Implement vmap_pfn
Dec 24 2025, 8:13 PM
wulf committed rGbbc5f5483723: LinuxKPI: Move vmap-related code from linux_compat.c to linux_page.c (authored by wulf).
LinuxKPI: Move vmap-related code from linux_compat.c to linux_page.c
Dec 24 2025, 8:13 PM

Dec 17 2025

wulf committed rG1a26b161d829: LinuxKPI: bump __FreeBSD_version for vmap_pfn implementation (authored by wulf).
LinuxKPI: bump __FreeBSD_version for vmap_pfn implementation
Dec 17 2025, 9:32 PM
wulf committed rGdf49fd8efa1a: LinuxKPI: Implement vmap_pfn (authored by wulf).
LinuxKPI: Implement vmap_pfn
Dec 17 2025, 9:32 PM
wulf committed rG20ce906157df: LinuxKPI: Move vmap-related code from linux_compat.c to linux_page.c (authored by wulf).
LinuxKPI: Move vmap-related code from linux_compat.c to linux_page.c
Dec 17 2025, 9:32 PM
wulf closed D54225: LinuxKPI: Implement vmap_pfn.
Dec 17 2025, 9:32 PM
wulf closed D54223: LinuxKPI: Move vmap-related code from linux_compat.c to linux_page.c.
Dec 17 2025, 9:32 PM
wulf committed rGd3690a599586: devfs: make destroy_dev() a release barrier for cdevpriv destructors runs (authored by kib).
devfs: make destroy_dev() a release barrier for cdevpriv destructors runs
Dec 17 2025, 9:08 PM
wulf added inline comments to D54225: LinuxKPI: Implement vmap_pfn.
Dec 17 2025, 1:49 PM
wulf updated the diff for D54225: LinuxKPI: Implement vmap_pfn.

Fix braino. size->count

Dec 17 2025, 1:46 PM
wulf updated the diff for D54225: LinuxKPI: Implement vmap_pfn.

Update page table in chunks having faked page array fit in malloc zone

Dec 17 2025, 1:23 PM

Dec 16 2025

wulf committed R11:babbf84d64a8: comms/rtlbt-firmware: Update to 20251111 (authored by wulf).
comms/rtlbt-firmware: Update to 20251111
Dec 16 2025, 10:37 PM
wulf added inline comments to D54225: LinuxKPI: Implement vmap_pfn.
Dec 16 2025, 2:24 PM
wulf abandoned D54226: LinuxKPI: Factor out _lkpi_vunmap() function.

Not needed after D54225 changes

Dec 16 2025, 2:14 PM
wulf abandoned D54224: amd64 pmap: Add pmap_qmapdev_attr function.

D54225 uses pmap_qenter() now

Dec 16 2025, 2:13 PM
wulf updated the diff for D54225: LinuxKPI: Implement vmap_pfn.

Use pmap_qenter() instead homegrown pmap_qmapdev_attr()

Dec 16 2025, 2:11 PM

Dec 15 2025

wulf updated the diff for D54225: LinuxKPI: Implement vmap_pfn.

s/lkpi_/linuxkpi_/
Add actual arch name to panic message

Dec 15 2025, 4:34 PM
wulf added inline comments to D54225: LinuxKPI: Implement vmap_pfn.
Dec 15 2025, 4:32 PM

Dec 14 2025

wulf updated the diff for D54223: LinuxKPI: Move vmap-related code from linux_compat.c to linux_page.c.

s/linux_/lkpi_/ in function names

Dec 14 2025, 10:40 PM
wulf added a comment to D54226: LinuxKPI: Factor out _lkpi_vunmap() function.

This should be joined with D54223

Dec 14 2025, 10:13 PM
wulf added a comment to D54223: LinuxKPI: Move vmap-related code from linux_compat.c to linux_page.c.

This should be joined with D54226

Dec 14 2025, 10:12 PM