- User Since
- Jun 3 2017, 8:47 AM (94 w, 3 d)
Mon, Mar 11
Sun, Mar 10
Mon, Feb 25
Sun, Feb 24
Feb 24 2019
Feb 15 2019
I hope you won't mind if I change sysctl name from "input_id" to "id" and disable exposure of optional properties like "uniq" and "phys" if they are not set. Just to be consistent with ioctl interface.
Feb 10 2019
Jan 22 2019
Jan 21 2019
One thing I dislike in this patch is a native/cuse evdev handling inconsistency.
To handle native device creation one should listen for EVDEV devd events while to handle cuse devices CDEV devd events should be processed.
You can not just listen for CDEV devd events as there is a race window between cdev and sysctl creation.
I think this can be fixed with using of single sysctl node. See kern.geom.confxml or kern.geom.conftxt for example.
Jan 18 2019
Jan 9 2019
linux/input.h is a list of magic numbers required at build time only. It should be kept in BUILD_DEPENDS IMO.
Jan 6 2019
I am AFK for now and will be for ~2 weeks
Dec 31 2018
I am objecting to EvdevProbe()-derived part (device type autodetection). It is better to add a KPI to set device type directly rather then via execution of libmagic. We have about 10 evdev drivers in source tree so it's possible to update them all. EvdevProbe()-derived part could be used as (deprecated) fallback option in that case.
Dec 30 2018
I hope -1700 value is tested. It does not work for my "softbuttons bar at a bottom" laptop leaving softbutton area outside reportable region so I have to use -2200 to make it working. But "softbuttons bar at a top" touchpad should behave differently here.
Dec 29 2018
Please assign hw.psm.synaptics.softbuttons_y sysctl some negative value so /dev/psm0 users get benefits from this change too.
Nov 25 2018
Nov 24 2018
Nov 17 2018
Nov 10 2018
Nov 9 2018
I am unaware of any current ill effects
Oct 31 2018
D17687 committed as r339917 made remaining parts of this revision senseless.
Oct 27 2018
Most important parts has been committed as r339823 and r339824. They fix evdev/KDB interaction with disabling dangerous codepaths.
This way raised some objections in the past which is addressed in remaining part of the review (true lockless mode). But, I dislike this part as It introduces some complications like polling callouts. That is why it has not been committed yet.
The further plan is to wait untill r339823/r339824 MFC and than abandon this revision if no new objections raised.
Oct 25 2018
Skip HID descriptor reading if WMT_IGNORE quirk is enabled.
Oct 24 2018
Sep 23 2018
Regenerate diff after r337720
Sep 4 2018
Aug 29 2018
Aug 22 2018
Please, test this patch on top of unmodified wmt.c:
Aug 21 2018
To make things easier I attached the patch that does p.3. and p.4.
Aug 20 2018
hid_report_size() should not be used unconditionally here as it calculates total size of all input reports rather than size of one given report. I guess that something wrong with HID descriptor
Aug 13 2018
Aug 7 2018
Useless softc casts removed
Workaround knlist_cleardel() 'Mutex owned' assertion that happens on 'lockless' device detach.
It is caused by devfs which calls evdev_dtor() with driver's lock (Giant) already taken.
#if 1 replaced with #if __FreeBSD_version >= 1200000
Aug 5 2018
Aug 4 2018
Jul 21 2018
Maybe you should bump the __FreeBSD_version due to changing a structure size.
No need. hid_data is private structure
Jul 19 2018
Jun 10 2018
Jun 9 2018
Jun 3 2018
May 5 2018
Unfortunately, it looks like backtrace of a panic in the kernel dumper. Actual panic precedes it
May 1 2018
Apr 30 2018
Apr 29 2018
Sorry for bad wording. Could you start from p.1: revert only ukbd.c, kbdmux.c and atkbd.c. This should effectively revert all changes
Apr 21 2018
Apr 15 2018
Mar 11 2018
Apply manpage fixes by Warren Block