Page MenuHomeFreeBSD

wulf (Vladimir Kondratyev)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 3 2017, 8:47 AM (85 w, 3 d)

Recent Activity

Yesterday

wulf added a comment to D18694: evdev: add devctl notifications and sysctls with device info.

One thing I dislike in this patch is a native/cuse evdev handling inconsistency.
To handle native device creation one should listen for EVDEV devd events while to handle cuse devices CDEV devd events should be processed.
You can not just listen for CDEV devd events as there is a race window between cdev and sysctl creation.
I think this can be fixed with using of single sysctl node. See kern.geom.confxml or kern.geom.conftxt for example.

Mon, Jan 21, 12:34 PM

Fri, Jan 18

wulf committed rS343163: psm(4): detect Lenovo top-button clickpads.
psm(4): detect Lenovo top-button clickpads
Fri, Jan 18, 10:20 PM
wulf closed D18676: psm: detect Lenovo top-button clickpads, set INPUT_PROP_TOPBUTTONPAD evdev property.
Fri, Jan 18, 10:20 PM
wulf committed rS343160: MFC r340926:.
MFC r340926:
Fri, Jan 18, 9:26 PM
wulf committed rS343159: MFC r340926:.
MFC r340926:
Fri, Jan 18, 9:25 PM
wulf committed rS343158: MFC r340912,r340913:.
MFC r340912,r340913:
Fri, Jan 18, 9:12 PM
wulf committed rS343157: MFC r340912,r340913:.
MFC r340912,r340913:
Fri, Jan 18, 9:11 PM
wulf committed rS343155: MFC r340338:.
MFC r340338:
Fri, Jan 18, 8:59 PM

Wed, Jan 9

wulf added a comment to D18791: devel/libevdev, devel/libmtdev: advertise evdev-proto as API dependency.

linux/input.h is a list of magic numbers required at build time only. It should be kept in BUILD_DEPENDS IMO.

Wed, Jan 9, 3:00 PM

Sun, Jan 6

wulf added a comment to D18694: evdev: add devctl notifications and sysctls with device info.

I am AFK for now and will be for ~2 weeks

Sun, Jan 6, 12:03 AM

Mon, Dec 31

wulf added a comment to D18694: evdev: add devctl notifications and sysctls with device info.

Though I wouldn't say it's only a "deprecated" option — we're not going to require userspace uinput drivers to explicitly identify themselves..

Mon, Dec 31, 3:50 PM
wulf requested changes to D18694: evdev: add devctl notifications and sysctls with device info.

I am objecting to EvdevProbe()-derived part (device type autodetection). It is better to add a KPI to set device type directly rather then via execution of libmagic. We have about 10 evdev drivers in source tree so it's possible to update them all. EvdevProbe()-derived part could be used as (deprecated) fallback option in that case.

Mon, Dec 31, 4:28 AM

Sun, Dec 30

wulf accepted D18676: psm: detect Lenovo top-button clickpads, set INPUT_PROP_TOPBUTTONPAD evdev property.

I hope -1700 value is tested. It does not work for my "softbuttons bar at a bottom" laptop leaving softbutton area outside reportable region so I have to use -2200 to make it working. But "softbuttons bar at a top" touchpad should behave differently here.

Sun, Dec 30, 2:57 PM

Sat, Dec 29

wulf added a comment to D18676: psm: detect Lenovo top-button clickpads, set INPUT_PROP_TOPBUTTONPAD evdev property.

Please assign hw.psm.synaptics.softbuttons_y sysctl some negative value so /dev/psm0 users get benefits from this change too.

Sat, Dec 29, 5:46 AM

Nov 25 2018

wulf committed rS340926: evdev: Fix pause key release event in AT keyboard set 1 to evdev xlat-or..
evdev: Fix pause key release event in AT keyboard set 1 to evdev xlat-or.
Nov 25 2018, 7:38 PM

Nov 24 2018

wulf committed rS340913: psm(4): Add minimal support for active AUX port multiplexers.
psm(4): Add minimal support for active AUX port multiplexers
Nov 24 2018, 9:25 PM
wulf committed rS340912: Revert r328640: Add kludge for 0x46 identity middle byte Synaptics touchpads..
Revert r328640: Add kludge for 0x46 identity middle byte Synaptics touchpads.
Nov 24 2018, 9:18 PM

Nov 17 2018

wulf committed rS340518: MFC r339823:.
MFC r339823:
Nov 17 2018, 8:18 PM

Nov 10 2018

wulf committed rS340338: wmt(4): Add PNP record so it could be picked by devd/devmatch..
wmt(4): Add PNP record so it could be picked by devd/devmatch.
Nov 10 2018, 10:14 PM
wulf closed D17689: wmt(4): Add PNP metadata.
Nov 10 2018, 10:14 PM

Nov 9 2018

wulf committed rS340305: MFC r337287:.
MFC r337287:
Nov 9 2018, 9:26 PM
wulf accepted D17912: Enable evdev driver and support in generic.

I am unaware of any current ill effects

Nov 9 2018, 7:04 PM

Oct 31 2018

wulf abandoned D15070: evdev - special lock-less mode for keyboard drivers.

D17687 committed as r339917 made remaining parts of this revision senseless.

Oct 31 2018, 6:50 PM

Oct 27 2018

wulf updated the diff for D15070: evdev - special lock-less mode for keyboard drivers.

Most important parts has been committed as r339823 and r339824. They fix evdev/KDB interaction with disabling dangerous codepaths.
This way raised some objections in the past which is addressed in remaining part of the review (true lockless mode). But, I dislike this part as It introduces some complications like polling callouts. That is why it has not been committed yet.
The further plan is to wait untill r339823/r339824 MFC and than abandon this revision if no new objections raised.

Oct 27 2018, 11:16 PM
wulf committed rS339824: evdev: disable evdev if it is invoked from KDB or panic context.
evdev: disable evdev if it is invoked from KDB or panic context
Oct 27 2018, 9:04 PM
wulf committed rS339823: evdev: Use console lock as evdev lock for all supported keyboard drivers..
evdev: Use console lock as evdev lock for all supported keyboard drivers.
Oct 27 2018, 8:23 PM

Oct 25 2018

wulf updated the diff for D17689: wmt(4): Add PNP metadata.

Skip HID descriptor reading if WMT_IGNORE quirk is enabled.

Oct 25 2018, 5:48 PM
wulf added a comment to D15070: evdev - special lock-less mode for keyboard drivers.

What is holding this from going in to the tree?

Oct 25 2018, 12:24 PM

Oct 24 2018

wulf added a comment to D16721: Touchscreen support for Touchscreens on amd64 and i386 platforms.

Hi!
Is it possible to split this revision into two parts? I'd like to see the EVDEV support go in, especially the option, since that can't be done runtime. The wmt device can be loaded at runtime and doesn't need to be in the kernel, I believe.

Oct 24 2018, 6:32 PM
wulf created D17689: wmt(4): Add PNP metadata.
Oct 24 2018, 6:27 PM
wulf added a comment to D15070: evdev - special lock-less mode for keyboard drivers.

What is holding this from going in to the tree?

Oct 24 2018, 6:06 PM

Sep 23 2018

wulf updated the diff for D15070: evdev - special lock-less mode for keyboard drivers.

Regenerate diff after r337720

Sep 23 2018, 8:55 AM

Sep 4 2018

wulf committed rS338458: wmt(4): Fix regression introduced in r337289.
wmt(4): Fix regression introduced in r337289
Sep 4 2018, 7:22 PM
wulf closed D16772: Fixing a broken touchscreen controller.
Sep 4 2018, 7:22 PM

Aug 29 2018

wulf added a comment to D16772: Fixing a broken touchscreen controller.

Hi Roberto,

Aug 29 2018, 10:01 PM

Aug 22 2018

wulf added a comment to D16772: Fixing a broken touchscreen controller.

Please, test this patch on top of unmodified wmt.c:

Aug 22 2018, 8:55 PM

Aug 21 2018

wulf added a comment to D16772: Fixing a broken touchscreen controller.

To make things easier I attached the patch that does p.3. and p.4.

Aug 21 2018, 4:24 PM

Aug 20 2018

wulf added a comment to D16721: Touchscreen support for Touchscreens on amd64 and i386 platforms.

So basically we only need device evdev and optinos EVDEV_SUPPORT in GENERIC?

Aug 20 2018, 3:57 PM
wulf added a comment to D16772: Fixing a broken touchscreen controller.

hid_report_size() should not be used unconditionally here as it calculates total size of all input reports rather than size of one given report. I guess that something wrong with HID descriptor

Aug 20 2018, 2:18 PM

Aug 13 2018

wulf committed rS337721: evdev: Remove evdev.ko linkage dependency on kbd driver.
evdev: Remove evdev.ko linkage dependency on kbd driver
Aug 13 2018, 7:05 PM
wulf committed rS337720: evdev: remove soft context from evdev methods parameter list..
evdev: remove soft context from evdev methods parameter list.
Aug 13 2018, 7:00 PM
wulf closed D16614: [evdev]: Minor KPI changes.
Aug 13 2018, 7:00 PM

Aug 7 2018

wulf updated the diff for D16614: [evdev]: Minor KPI changes.

Useless softc casts removed

Aug 7 2018, 11:35 PM
wulf added inline comments to D16614: [evdev]: Minor KPI changes.
Aug 7 2018, 8:02 PM
wulf updated the diff for D15070: evdev - special lock-less mode for keyboard drivers.

Workaround knlist_cleardel() 'Mutex owned' assertion that happens on 'lockless' device detach.
It is caused by devfs which calls evdev_dtor() with driver's lock (Giant) already taken.

Aug 7 2018, 7:46 PM
wulf updated the diff for D16614: [evdev]: Minor KPI changes.

#if 1 replaced with #if __FreeBSD_version >= 1200000

Aug 7 2018, 10:03 AM
wulf added inline comments to D16614: [evdev]: Minor KPI changes.
Aug 7 2018, 9:52 AM
wulf created D16614: [evdev]: Minor KPI changes.
Aug 7 2018, 9:38 AM

Aug 5 2018

wulf committed rS337348: uep(4): add evdev support.
uep(4): add evdev support
Aug 5 2018, 11:14 AM
wulf closed D11156: uep(4): add evdev support.
Aug 5 2018, 11:14 AM

Aug 4 2018

wulf committed rS337291: MFC r336577:.
MFC r336577:
Aug 4 2018, 12:45 PM
wulf committed rS337290: MFC r334555:.
MFC r334555:
Aug 4 2018, 12:41 PM
wulf committed rS337289: wmt(4): Use internal function to calculate input report size.
wmt(4): Use internal function to calculate input report size
Aug 4 2018, 12:31 PM
wulf committed rS337288: wmt(4): Read Microsoft's "Touch Hardware Quality Assurance" certificate blob.
wmt(4): Read Microsoft's "Touch Hardware Quality Assurance" certificate blob
Aug 4 2018, 12:29 PM
wulf committed rS337287: wmt(4): Read 'Contact count maximum' usage value from feature report.
wmt(4): Read 'Contact count maximum' usage value from feature report
Aug 4 2018, 12:24 PM

Jul 21 2018

wulf committed rS336577: Raise "Report Count" value limit in HID descriptor parser..
Raise "Report Count" value limit in HID descriptor parser.
Jul 21 2018, 2:20 PM
wulf closed D16357: Increase "Report Count" limit in HID descriptor parser.
Jul 21 2018, 2:20 PM
wulf added a comment to D16357: Increase "Report Count" limit in HID descriptor parser.

Maybe you should bump the __FreeBSD_version due to changing a structure size.

No need. hid_data is private structure

Jul 21 2018, 1:10 PM

Jul 19 2018

wulf created D16357: Increase "Report Count" limit in HID descriptor parser.
Jul 19 2018, 11:09 PM

Jun 10 2018

wulf committed rS334923: Drop MOUSE_GETVARS and MOUSE_SETVARS ioctls support..
Drop MOUSE_GETVARS and MOUSE_SETVARS ioctls support.
Jun 10 2018, 10:23 AM
wulf closed D15726: Drop MOUSE_GETVARS and MOUSE_SETVARS ioctls support..
Jun 10 2018, 10:23 AM

Jun 9 2018

wulf created D15726: Drop MOUSE_GETVARS and MOUSE_SETVARS ioctls support..
Jun 9 2018, 9:27 PM

Jun 3 2018

wulf committed rS334555: [evdev] Sync event codes with Linux kernel 4.16.
[evdev] Sync event codes with Linux kernel 4.16
Jun 3 2018, 10:53 AM

May 5 2018

wulf added a comment to D15070: evdev - special lock-less mode for keyboard drivers.

I continued to use the initial patch for a few days and got several similar panics (5 in total). The three panic strings I encountered are:

  • panic: mutex Giant owned at /mnt/home/dumbbell/Projects/freebsd/src/GIT/sys/kern/kern_event.c:2288
  • panic: sleepq_add: td 0xfffff8001875d560 to sleep on wchan 0xffffffff836e0fc0 with sleeping prohibited
  • panic: page fault

    The backtrace is always the same and is the one I shared earlier.

Unfortunately, it looks like backtrace of a panic in the kernel dumper. Actual panic precedes it

May 5 2018, 9:21 AM

May 1 2018

wulf committed rS333136: Fix bthidd build with GCC 4.2 after r333110.
Fix bthidd build with GCC 4.2 after r333110
May 1 2018, 8:03 AM

Apr 30 2018

wulf committed rS333113: bthidd(8): Add evdev protocol support for bluetooth keyboards and mouses.
bthidd(8): Add evdev protocol support for bluetooth keyboards and mouses
Apr 30 2018, 12:17 PM
wulf committed rS333112: bthidd(8): Add internal support for user-friendly name of remote devices..
bthidd(8): Add internal support for user-friendly name of remote devices.
Apr 30 2018, 10:49 AM
wulf committed rS333111: uinput: Add FreeBSD specific ioctl to set unique identifier of input device..
uinput: Add FreeBSD specific ioctl to set unique identifier of input device.
Apr 30 2018, 10:34 AM
wulf committed rS333110: bluetooth(3): Add helper functions that performs Bluetooth Remote Name Request.
bluetooth(3): Add helper functions that performs Bluetooth Remote Name Request
Apr 30 2018, 10:25 AM
wulf committed rS333109: libsdp: Add method that returns actual source BD_ADDR of SDP session..
libsdp: Add method that returns actual source BD_ADDR of SDP session.
Apr 30 2018, 10:16 AM
wulf closed D13456: bthidd: Add evdev protocol support.
Apr 30 2018, 10:16 AM

Apr 29 2018

wulf added a comment to D15070: evdev - special lock-less mode for keyboard drivers.

Sorry for bad wording. Could you start from p.1: revert only ukbd.c, kbdmux.c and atkbd.c. This should effectively revert all changes

Apr 29 2018, 3:19 PM
wulf added a comment to D15070: evdev - special lock-less mode for keyboard drivers.

However, I got two panics:

Apr 29 2018, 1:52 PM
wulf added a comment to D15070: evdev - special lock-less mode for keyboard drivers.

Do you have any advice to reproduce the deadlock when the patch is not applied?

Apr 29 2018, 11:23 AM
wulf updated the summary of D15070: evdev - special lock-less mode for keyboard drivers.
Apr 29 2018, 11:05 AM

Apr 21 2018

wulf added a comment to D13456: bthidd: Add evdev protocol support.

ping...

Apr 21 2018, 7:44 PM

Apr 15 2018

wulf created D15070: evdev - special lock-less mode for keyboard drivers.
Apr 15 2018, 12:56 AM

Mar 11 2018

wulf updated the diff for D13456: bthidd: Add evdev protocol support.

Apply manpage fixes by Warren Block

Mar 11 2018, 9:52 PM

Feb 18 2018

wulf committed rS329533: MFC r328864 (Synaptics part only):.
MFC r328864 (Synaptics part only):
Feb 18 2018, 10:12 PM
wulf committed rS329532: MFC r328864:.
MFC r328864:
Feb 18 2018, 10:05 PM

Feb 4 2018

wulf committed rS328864: psm(4): Fix panic occuring soon after PS/2 packet has been rejected by.
psm(4): Fix panic occuring soon after PS/2 packet has been rejected by
Feb 4 2018, 11:02 PM

Jan 31 2018

wulf committed rS328640: psm: Add a kludge to support 0x46 identity middle byte Synaptics touchpads.
psm: Add a kludge to support 0x46 identity middle byte Synaptics touchpads
Jan 31 2018, 10:18 PM
wulf committed rS328638: psm(4): Reduce psm watchdog verbosity.
psm(4): Reduce psm watchdog verbosity
Jan 31 2018, 9:47 PM
wulf committed rS328636: psm(4): Add support for HP EliteBook 1040 ForcePads..
psm(4): Add support for HP EliteBook 1040 ForcePads.
Jan 31 2018, 9:15 PM

Jan 28 2018

wulf added inline comments to D13456: bthidd: Add evdev protocol support.
Jan 28 2018, 9:14 PM
wulf updated the diff for D13456: bthidd: Add evdev protocol support.
  1. SDP-session descriptor exporter replaced with SDP-session local BD_ADDR exporter
  2. remote device name query helper has been moved to libbluetooth
  3. libsdp & libbluetooth manpages have been updated to reflect changes.
  4. Evdev device name format changed to "{REMOTE_NAME}, bdaddr {BD_ADDR}"
Jan 28 2018, 8:27 PM

Dec 23 2017

wulf added a comment to D13456: bthidd: Add evdev protocol support.

Okay, that was quite simple :) Something like this: https://github.com/myfreeweb/freebsd/commit/0c06a324311309228a8e2def334c603a390fac4f

I guess I can post it here after this gets merged.

Looks promising. Did you check what is transferring through sysmouse interface after trackpad has been switched to absolute mode?

Dec 23 2017, 12:52 PM
wulf added inline comments to D13456: bthidd: Add evdev protocol support.
Dec 23 2017, 12:10 PM
wulf updated the diff for D13456: bthidd: Add evdev protocol support.
  1. Fix bthidd manpage (by bcr).
  2. Add forgotten INPUT_PROP_POINTER property to evdev mouse descriptor.
  3. Minor uinput_rep_mouse() simplification (no functional changes).
  4. Comment evdev device name selection sequence.
Dec 23 2017, 11:58 AM

Dec 20 2017

wulf added a comment to D13456: bthidd: Add evdev protocol support.

Nice! Tested my Apple Magic Trackpad with this. Works as a basic mouse. But would be much better to have actual touchpad support (absolute motion, multi-touch)…

Dec 20 2017, 1:01 AM
wulf added a comment to D13456: bthidd: Add evdev protocol support.
In D13456#283044, @emax wrote:

my only comments are related to newly added "name" option / parameter. i can not seem to understand its purpose.

Dec 20 2017, 12:26 AM
wulf added inline comments to D13456: bthidd: Add evdev protocol support.
Dec 20 2017, 12:05 AM

Dec 19 2017

wulf updated the diff for D13456: bthidd: Add evdev protocol support.
  • Add getter for SDP session socket handle.
  • Use this getter to avoid access to private members.
  • hid_hci_remote_name_query now takes local bdattr as parameter not local HCI devname
Dec 19 2017, 11:46 PM

Dec 11 2017

wulf created D13456: bthidd: Add evdev protocol support.
Dec 11 2017, 10:04 PM

Dec 4 2017

wulf committed rS326543: MFC r325295:.
MFC r325295:
Dec 4 2017, 9:12 PM
wulf committed rS326541: MFC r325269:.
MFC r325269:
Dec 4 2017, 8:22 PM
wulf committed rS326540: MFC r325294:.
MFC r325294:
Dec 4 2017, 8:10 PM

Nov 20 2017

wulf closed D12983: evdev: USB scancode 0x54 is KEY_KPSLASH, not KEY_SLASH.
Nov 20 2017, 7:25 PM
wulf committed rS326021: evdev: change USB scancode 0x54 from KEY_SLASH to KEY_KPSLASH.
evdev: change USB scancode 0x54 from KEY_SLASH to KEY_KPSLASH
Nov 20 2017, 7:25 PM
wulf committed rS326020: Fix evdev codes for slash and asterisk numpad keys of AT-keyboards.
Fix evdev codes for slash and asterisk numpad keys of AT-keyboards
Nov 20 2017, 7:20 PM