User Details
- User Since
- Jun 3 2017, 8:47 AM (463 w, 6 d)
Today
I committed mmap()-based changes. See: https://cgit.freebsd.org/src/commit/?id=87ed6840a0a6320295f6abb43a987d20ae126cf7
Yesterday
Although it looks good, replacing read() with mmap() -> memcpy() -> munmap() sequence would make code simpler and cleaner
Wed, Apr 22
Sun, Apr 12
Sat, Apr 11
IMO it would be good to rename driver from ps5dualsense to ps5dsense to be inline with ps4dshock. That is up to you.
Looks mostly good.
There are some missing parts. TODO:
- Add manpage. You may take share/man/man4/ps4dshock.4 as starting point. Do not forget to add missing touchpad and accelerometer support to BUGS section.
- Add ps5dualsense.c to sys/conf/files and sys/conf/NOTES
- Add ps5dualsense subdir to sys/modules/hid/Makefile
Fri, Apr 10
Sun, Mar 29
Sat, Mar 28
It seems that more files should be fixed. See your previous patch: https://reviews.freebsd.org/D56126
Other Realtek entries are inherited from Linux. I think we can drop them.
Realtek devices are handled by generic Realtek rule. Does it work for you?
Alder Lake system is not needed
LGTM. Could you test Intel BT identify patch from https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=290639 ?
Mar 23 2026
Radio button can not be correctly handled with hidmap. MS does strange things here assuming every event in report as a keypress. E.g. ASUS TUF always reported radio key as depressed that brokes Linux but works on Windows
Mar 9 2026
It will trigger enumeration value ‘S76_CTRL_MAX’ not specifically handled in switch if -Wswitch option is passed to compiler.
From [1]:
-Wswitch
Warn whenever a switch statement has an index of enumerated type and lacks a case for one or more of the named codes of that enumeration. (The presence of a default label prevents this warning.) case labels that do not correspond to enumerators also provoke warnings when this option is used, unless the enumeration is marked with the flag_enum attribute. This warning is enabled by -Wall.
Obviously case S76_CTRL_MAX is not generally handled in switch() statements.
Mar 8 2026
I dislike this idea.
The sysctl sys.class.drm.card0-DP-1 path matches Linux while sysctl sys.device.drmn1.card0.card0-DP-1 not
Mar 7 2026
Adding of EVDEV interface to notyfy userland software would be good idea too. See sys/dev/acpi_support/acpi_asus_wmi.c again
We have backlight(9) interface since FreeBSD 13
Mar 5 2026
Mar 3 2026
Feb 17 2026
Feb 10 2026
Dec 24 2025
Dec 17 2025
Fix braino. size->count
Update page table in chunks having faked page array fit in malloc zone
Dec 16 2025
Not needed after D54225 changes
D54225 uses pmap_qenter() now
Use pmap_qenter() instead homegrown pmap_qmapdev_attr()
Dec 15 2025
s/lkpi_/linuxkpi_/
Add actual arch name to panic message
Dec 14 2025
s/linux_/lkpi_/ in function names
This should be joined with D54223
This should be joined with D54226
