Page MenuHomeFreeBSD

snd_hda(4): Add quirks for Lenovo ThinkBooks and ASUS TUFs
Needs ReviewPublic

Authored by wulf on Fri, Feb 14, 9:57 AM.

Details

Reviewers
christos
Summary

Includes pin configuration and generic quirks for ALC257 - ALC257
codecs initialization.

Sponsored by: Future Crew, LLC
MFC after: 1 month

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62436
Build 59320: arc lint + arc unit

Event Timeline

wulf requested review of this revision.Fri, Feb 14, 9:57 AM

The commit message says "ALC257 codecs initialization", but in hdaa_patch_direct() and in pin_patch_realtek.h we seem to be affecting other codecs as well. Shouldn't the commit message reflect that?

My HDA card also is ALC257, so I will make sure to test the patch ASAP.

sys/dev/sound/pci/hda/hdaa_patches.c
330

According to snd_hda.4:

loc      Connector physical location.  Can be specified as a number
         from 0 to 63.  This is a reference only value.  It is
         ignored by the snd_hda driver.

So I suppose these are not a functional changes, right?

716

I think we could simply call hdaa_read_coef() here.

720

And hdaa_write_coef() here. Or did you intentionally duplicate them?

770

Just out of curiosity, what does this do exactly? :-)

793

Stray newline.