Page MenuHomeFreeBSD
Differential D48809

[WIP] snd_hda: Attempt to automate pin patching
AbandonedPublic
Actions

Authored by christos on Feb 3 2025, 12:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 3, 7:23 AM
Unknown Object (File)
Tue, Feb 25, 1:53 PM
Unknown Object (File)
Mon, Feb 17, 12:57 PM
Unknown Object (File)
Sat, Feb 15, 1:07 AM
Unknown Object (File)
Wed, Feb 12, 1:05 AM
Unknown Object (File)
Sun, Feb 9, 11:32 PM
Unknown Object (File)
Sun, Feb 9, 7:00 AM
Unknown Object (File)
Wed, Feb 5, 2:20 PM
View All 10 Files
Subscribers
imp

Details

Reviewers
markj
emaste
dev_submerge.ch
mav
wulf
Summary

FILLME

Sponsored by: The FreeBSD Foundation
MFC after: 1 month

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 62438
Build 59322: arc lint + arc unit

Event Timeline

christos created this revision.Feb 3 2025, 12:39 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 3 2025, 12:39 PM
christos requested review of this revision.Feb 3 2025, 12:39 PM
Harbormaster completed remote builds in B62219: Diff 150402.Feb 3 2025, 12:39 PM
christos added a comment.EditedFeb 3 2025, 12:43 PM

This is still an experimental patch and not finished.

@dev_submerge.ch, @markj, @emaste: Because I do not have a machine to test this at the moment (I can only confirm it compiles), if you have HDA cards that require the pin patching code above the new code, could you please test this patch? I would like to see dev.hdac.X.pindump and the output of the device_printf()s, if we ever get there. The code above will also run, but if you want to isolate the patch, just comment everything out from the "New patches" comment up until the new code.

christos added inline comments.Feb 3 2025, 12:48 PM
sys/dev/sound/pci/hda/hdaa_patches.c
430

s/arrowed/allowed/

christos added inline comments.Feb 4 2025, 12:38 PM
sys/dev/sound/pci/hda/hdaa_patches.c
479

I think we should break here.

christos updated this revision to Diff 150528.Wed, Feb 5, 11:36 AM
  • Fix a typo.
  • break at the end of the loop.
Harbormaster completed remote builds in B62272: Diff 150528.Wed, Feb 5, 11:36 AM
christos updated this revision to Diff 151019.Fri, Feb 14, 1:09 PM

Add more printfs.

Harbormaster completed remote builds in B62438: Diff 151019.Fri, Feb 14, 1:09 PM
christos added reviewers: mav, wulf.Sat, Feb 15, 11:29 AM
christos added inline comments.
sys/dev/sound/pci/hda/hdaa_patches.c
480

Although here we are patching Jack pins, I think we might also want to take into account Fixed pins that usually have seq=0.

christos abandoned this revision.Tue, Feb 18, 7:27 PM

Abandoning in favor of a more sane approach. Related discussion: https://lists.freebsd.org/archives/freebsd-multimedia/2025-February/002845.html

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
pci/
hda/
100 lines

Diff 151019

View Options

sys/dev/sound/pci/hda/hdaa_patches.c

Loading...