Page MenuHomeFreeBSD
Feed Advanced Search

Sat, Oct 17

wulf added inline comments to D26823: devmatch(8): Respect mask field when matching strings..
Sat, Oct 17, 12:39 AM
wulf added inline comments to D26823: devmatch(8): Respect mask field when matching strings..
Sat, Oct 17, 12:32 AM
wulf requested review of D26824: Add plug and play information macroses for ACPI and I2C buses..
Sat, Oct 17, 12:26 AM
wulf requested review of D26823: devmatch(8): Respect mask field when matching strings..
Sat, Oct 17, 12:19 AM

Wed, Sep 30

wulf updated the diff for D26603: LinuxKPI: Implement ACPI bits required by drm-kmod in base system..

Use static inline functions instead of preprocessor #define's to rename ACPICA methods.

Wed, Sep 30, 9:53 PM
wulf updated the summary of D26603: LinuxKPI: Implement ACPI bits required by drm-kmod in base system..
Wed, Sep 30, 10:42 AM
wulf requested review of D26603: LinuxKPI: Implement ACPI bits required by drm-kmod in base system..
Wed, Sep 30, 10:35 AM
wulf requested review of D26602: acpi: Tweak _DSM method evaluation helpers. .
Wed, Sep 30, 10:21 AM

Sep 6 2020

wulf committed rS365383: MFC r364964: LinuxKPI: Implement ksize() function..
MFC r364964: LinuxKPI: Implement ksize() function.
Sep 6 2020, 5:40 PM

Aug 29 2020

wulf committed rS364964: LinuxKPI: Implement ksize() function..
LinuxKPI: Implement ksize() function.
Aug 29 2020, 7:26 PM
wulf closed D26215: LinuxKPI: Add ksize() implementation.
Aug 29 2020, 7:26 PM

Aug 28 2020

wulf added a comment to D26215: LinuxKPI: Add ksize() implementation.
In D26215#582535, @kib wrote:

I suppose this was extracted from realloc(9) ?

Aug 28 2020, 7:16 PM
wulf updated the diff for D26215: LinuxKPI: Add ksize() implementation.

Move main routine in to kern_malloc.c
Add pair of lines to malloc(9) manpage

Aug 28 2020, 7:15 PM

Aug 27 2020

wulf updated the summary of D26215: LinuxKPI: Add ksize() implementation.
Aug 27 2020, 8:57 PM
wulf requested review of D26215: LinuxKPI: Add ksize() implementation.
Aug 27 2020, 8:47 PM

Aug 6 2020

wulf accepted D25940: gpiokeys: first take at evdev support.

LGTM from evdev point of view

Aug 6 2020, 10:56 PM

Aug 5 2020

wulf added inline comments to D25940: gpiokeys: first take at evdev support.
Aug 5 2020, 12:18 AM

Jul 24 2020

wulf committed rP543383: sysutils/iichid: Update to 0.0.3.
sysutils/iichid: Update to 0.0.3
Jul 24 2020, 10:11 PM
wulf closed D25538: sysutils/iichid: Update to 0.0.3.
Jul 24 2020, 10:11 PM

Jul 23 2020

wulf added a comment to D25538: sysutils/iichid: Update to 0.0.3.
In D25538#570725, @wulf wrote:

is there a PR for this?

Really no. We have similar PR: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247787
I wrote to it's author to replace his patch with this one to not duplicate things.

I moved this patch to https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=247787

Jul 23 2020, 8:19 AM

Jul 22 2020

wulf added a comment to D25538: sysutils/iichid: Update to 0.0.3.

is there a PR for this?

Jul 22 2020, 8:15 PM
wulf added a comment to D25538: sysutils/iichid: Update to 0.0.3.

@wulf or @lwhsu can you merge this into the ports tree? thanks!

Jul 22 2020, 12:39 PM

Jul 21 2020

wulf committed rS363407: MFC 363205:.
MFC 363205:
Jul 21 2020, 11:38 PM
wulf committed rS363406: MFC r363205:.
MFC r363205:
Jul 21 2020, 11:36 PM

Jul 14 2020

wulf committed rS363205: linuxkpi: Ignore NULL pointers passed to string parameter of kstr(n)dup.
linuxkpi: Ignore NULL pointers passed to string parameter of kstr(n)dup
Jul 14 2020, 9:57 PM
wulf closed D25657: linuxkpi: Ignore NULL passed to string parametr of kstrdup().
Jul 14 2020, 9:57 PM

Jul 13 2020

wulf requested review of D25657: linuxkpi: Ignore NULL passed to string parametr of kstrdup().
Jul 13 2020, 10:04 PM

Jul 6 2020

wulf accepted D25538: sysutils/iichid: Update to 0.0.3.
Jul 6 2020, 3:46 PM
wulf added a comment to D25538: sysutils/iichid: Update to 0.0.3.

BTW I tagged current snapshot with 0.0.3. You can bump DISTVERSION to chase it.

Jul 6 2020, 11:04 AM

Jul 5 2020

wulf accepted D25538: sysutils/iichid: Update to 0.0.3.

LGTM

Jul 5 2020, 10:08 PM

Jul 1 2020

wulf added a comment to D25538: sysutils/iichid: Update to 0.0.3.

Following is Makefile I was going to submit to ports some time ago:

Jul 1 2020, 7:59 PM

Jun 25 2020

wulf closed D25390: atkbd/evdev: recognize the Chromebook menu key as F13 like Linux does.
Jun 25 2020, 12:09 AM
wulf committed rS362599: atkbd/evdev: recognize the Chromebook menu key as F13 like Linux does..
atkbd/evdev: recognize the Chromebook menu key as F13 like Linux does.
Jun 25 2020, 12:09 AM
wulf committed rS362598: MFC r362260:.
MFC r362260:
Jun 25 2020, 12:01 AM
wulf committed rS362597: MFC r362260:.
MFC r362260:
Jun 25 2020, 12:00 AM

Jun 22 2020

wulf accepted D25390: atkbd/evdev: recognize the Chromebook menu key as F13 like Linux does.

LGTM

Jun 22 2020, 3:15 PM

Jun 18 2020

wulf committed rS362260: evdev: Add AT translated set1 scancodes for 'Eisu' & 'Kana' keys..
evdev: Add AT translated set1 scancodes for 'Eisu' & 'Kana' keys.
Jun 18 2020, 9:20 AM

Jun 15 2020

wulf committed rS362209: MFC r361715:.
MFC r361715:
Jun 15 2020, 10:43 PM
wulf committed rS362208: MFC r361715:.
MFC r361715:
Jun 15 2020, 10:41 PM
wulf committed rS362207: MFC r360624:.
MFC r360624:
Jun 15 2020, 10:36 PM
wulf committed rS362206: MFC r360624:.
MFC r360624:
Jun 15 2020, 10:33 PM

Jun 2 2020

wulf committed rS361718: [psm] Workaround active PS/2 multiplexor hang.
[psm] Workaround active PS/2 multiplexor hang
Jun 2 2020, 1:05 AM
wulf committed rS361715: [psm] Do not disable trackpoint when hw.psm.elantech.touchpad_off is enabled.
[psm] Do not disable trackpoint when hw.psm.elantech.touchpad_off is enabled
Jun 2 2020, 12:54 AM

May 11 2020

wulf abandoned D24751: linuxkpi: Do not perform unbound sleeps in del_timer_sync().

Witness warnings are gone with your patch. Thank you.

May 11 2020, 8:25 AM

May 8 2020

wulf added a comment to D24751: linuxkpi: Do not perform unbound sleeps in del_timer_sync().

This patch is not correct. Del timer sync means that when this function returns, the callout structure shall no longer be in use. The only way to guarantee that is to use callout_drain()!
It is not good enough to only block the timer callback!

May 8 2020, 6:05 AM

May 7 2020

wulf requested review of D24751: linuxkpi: Do not perform unbound sleeps in del_timer_sync().
May 7 2020, 7:57 PM

May 4 2020

wulf committed rS360625: [evdev] Sync event codes with Linux kernel 5.6.
[evdev] Sync event codes with Linux kernel 5.6
May 4 2020, 11:00 AM
wulf committed rS360624: [evdev] Add AT translated set1 scancodes for F-unlocked F1-12 keys..
[evdev] Add AT translated set1 scancodes for F-unlocked F1-12 keys.
May 4 2020, 10:59 AM

May 3 2020

wulf committed rS360618: MFC r360355:.
MFC r360355:
May 3 2020, 11:40 PM
wulf committed rS360617: MFC r360353:.
MFC r360353:
May 3 2020, 11:38 PM

Apr 30 2020

wulf added inline comments to D24611: Update linuxkpi with changes needed for drm-v5.1.
Apr 30 2020, 12:02 AM

Apr 29 2020

wulf committed rP533392: MFH: r533211.
MFH: r533211
Apr 29 2020, 8:03 PM

Apr 27 2020

wulf committed rP533211: x11-drivers/xf86-input-synaptics: enable EVDEV by default on FreeBSD 12+.
x11-drivers/xf86-input-synaptics: enable EVDEV by default on FreeBSD 12+
Apr 27 2020, 11:20 PM

Apr 26 2020

wulf committed rS360355: ig4(4): Add PCI IDs for Intel Bay Trail I2C controllers..
ig4(4): Add PCI IDs for Intel Bay Trail I2C controllers.
Apr 26 2020, 8:16 PM
wulf committed rS360353: psm(4): Fix wrong key-release event occuring after trackpoint use..
psm(4): Fix wrong key-release event occuring after trackpoint use.
Apr 26 2020, 8:06 PM
wulf committed rS360352: MFC r359905:.
MFC r359905:
Apr 26 2020, 7:43 PM
wulf committed rS360351: MFC r359905:.
MFC r359905:
Apr 26 2020, 7:43 PM

Apr 19 2020

wulf added a comment to D24500: Use LIST_FOREACH_SAFE instead of LIST_FOREACH as we are removing elements in the middle..

When INVARIANT is enabled, the prev and next pointers would be TRASHIT'ed (set to -1 or 0xffffffffffffffff).

Apr 19 2020, 7:05 PM
wulf added a comment to D24500: Use LIST_FOREACH_SAFE instead of LIST_FOREACH as we are removing elements in the middle..

Do you have some local modifications of cdev.c? Especially with relaxed locking in evdev_dtor()?

Apr 19 2020, 11:30 AM
wulf added a comment to D24500: Use LIST_FOREACH_SAFE instead of LIST_FOREACH as we are removing elements in the middle..

But the thread which is woken up locks evdev too. It should postpone all the free()s until FOREACH loop is completed.

Apr 19 2020, 11:16 AM
wulf accepted D24500: Use LIST_FOREACH_SAFE instead of LIST_FOREACH as we are removing elements in the middle..

Thanks.
List item is free()-ed asynchronously in other thread which is woken up in evdev_notify_event(). That is why this panic is rare.

Apr 19 2020, 11:06 AM

Apr 18 2020

wulf accepted D24370: Change kern.evdev.rcpt_mask to 12 by default, to be more evdev friendly.
Apr 18 2020, 10:50 PM
wulf accepted D24370: Change kern.evdev.rcpt_mask to 12 by default, to be more evdev friendly.

LGTM (except EVDEV_RCPT_HW_KBD flag in powerpc case)

Apr 18 2020, 9:55 AM

Apr 13 2020

wulf committed rS359907: MFC r359428:.
MFC r359428:
Apr 13 2020, 10:21 PM
wulf committed rS359906: MFC r359428:.
MFC r359428:
Apr 13 2020, 10:19 PM
wulf committed rS359905: [evdev] Use proper mutex reference in autorepeat callout initialization..
[evdev] Use proper mutex reference in autorepeat callout initialization.
Apr 13 2020, 10:06 PM

Apr 12 2020

wulf added a comment to D24370: Change kern.evdev.rcpt_mask to 12 by default, to be more evdev friendly.

Looks mostly good to me. We should keep EVDEV_RCPT_KBDMUX for powerpc32 and EVDEV_SUPPORT #else branch is not needed.

Apr 12 2020, 8:52 PM

Mar 29 2020

wulf committed rS359431: MFC r358818:.
MFC r358818:
Mar 29 2020, 11:39 PM
wulf committed rS359429: evdev: return error rather than zero-length data on blocked read().
evdev: return error rather than zero-length data on blocked read()
Mar 29 2020, 11:01 PM
wulf committed rS359428: evdev: Add COMPAT_FREEBSD32 support for amd64 arch.
evdev: Add COMPAT_FREEBSD32 support for amd64 arch
Mar 29 2020, 11:00 PM

Mar 17 2020

wulf committed rS359056: MFC r358824:.
MFC r358824:
Mar 17 2020, 11:59 PM
wulf committed rS359055: MFC r358824:.
MFC r358824:
Mar 17 2020, 11:57 PM

Mar 14 2020

wulf committed rS359004: MFC r358895.
MFC r358895
Mar 14 2020, 10:07 PM
wulf committed rS359003: MFC r358895.
MFC r358895
Mar 14 2020, 10:04 PM

Mar 11 2020

wulf committed rS358895: wmt(4): Reapply r358872 (by hselasky) modified to use.
wmt(4): Reapply r358872 (by hselasky) modified to use
Mar 11 2020, 8:05 PM
wulf committed rS358892: wmt(4): revert r358872 (by hselasky).
wmt(4): revert r358872 (by hselasky)
Mar 11 2020, 7:58 PM

Mar 9 2020

wulf committed rS358824: wmt(4): Fix Synaptics Touch Digitizer V04 attachment.
wmt(4): Fix Synaptics Touch Digitizer V04 attachment
Mar 9 2020, 9:01 PM
wulf committed rS358820: iicbus(4): Add support for ACPI-based children enumeration.
iicbus(4): Add support for ACPI-based children enumeration
Mar 9 2020, 8:32 PM
wulf closed D22901: [iicbus] Add support for ACPI-based children enumeration.
Mar 9 2020, 8:32 PM
wulf committed rS358819: acpi: Export functions required by upcoming acpi_iicbus driver..
acpi: Export functions required by upcoming acpi_iicbus driver.
Mar 9 2020, 8:29 PM
wulf committed rS358818: acpi: Fix stalled value returned by acpi_get_device() after device deletion.
acpi: Fix stalled value returned by acpi_get_device() after device deletion
Mar 9 2020, 8:27 PM
wulf closed D22902: [acpi] Fix stalled value returned by acpi_get_device() after newbus device has been deleted.
Mar 9 2020, 8:27 PM

Feb 23 2020

wulf updated the diff for D22901: [iicbus] Add support for ACPI-based children enumeration.

Driver reworked to not depend on existing ACPI newbus device.
It deletes ACPI-hosted child and performs resource (IRQ) parsing and children power state (S0<->S3) management on his own.
No dummy driver required anymore.

Feb 23 2020, 8:20 PM

Feb 12 2020

wulf added a comment to D23615: This adds wulf7 / iichid on github to ports.

should we leave it open for any version/arch, or should we limit it. If limiting, I need a list of archs for ONLY_FOR_ARCHS and OSVERSIONS we shouldn't set IGNORE for

Feb 12 2020, 10:11 AM
wulf added a comment to D23615: This adds wulf7 / iichid on github to ports.

Fails building in 11amd64 with the following, so will at least set OSVERSION > 12* unless its expected or desirable for iichid to be test on 11:

Only 12.1+ is supported.

Feb 12 2020, 7:57 AM

Feb 11 2020

wulf added a comment to D23615: This adds wulf7 / iichid on github to ports.

I recommend to disable USB backend by default and leave it as build-time option as it is not completed yet and interferes with existing USB drivers.

Feb 11 2020, 11:11 AM
wulf added a comment to D23615: This adds wulf7 / iichid on github to ports.

@wulf : Do you think it's time to put this into base or let's add this as a port first?

Feb 11 2020, 11:04 AM

Dec 25 2019

wulf added a comment to D22901: [iicbus] Add support for ACPI-based children enumeration.
In D22901#501848, @jhb wrote:

So it would be helpful to see an acpidump of a system with these devices.

Dec 25 2019, 4:04 PM

Dec 23 2019

wulf added inline comments to D22901: [iicbus] Add support for ACPI-based children enumeration.
Dec 23 2019, 10:33 PM
wulf updated the diff for D22901: [iicbus] Add support for ACPI-based children enumeration.
Dec 23 2019, 10:27 PM

Dec 22 2019

wulf committed rS355994: MFC r354291 - r354322, r354327, r355596.
MFC r354291 - r354322, r354327, r355596
Dec 22 2019, 12:46 AM

Dec 21 2019

wulf created D22902: [acpi] Fix stalled value returned by acpi_get_device() after newbus device has been deleted.
Dec 21 2019, 9:36 PM
wulf created D22901: [iicbus] Add support for ACPI-based children enumeration.
Dec 21 2019, 9:03 PM

Dec 19 2019

wulf added a comment to D21565: atkbd,evdev: Interpret Google Assistant key on Chromebooks as right meta.

I don't think that Assistant key should be mapped to KEY_RIGHTMETA for following reasons:

  1. It is not really a meta key as it does not affect other key meanings like Shift, Alt, Ctrl and Win keys do.
  2. According to https://www.win.tue.nl/~aeb/linux/kbd/scancodes-6.html, scancode of 0x58 prefixed with 0xE0 is emitted by pressing of Fn+F12 keys on Logitech and Microsoft keyboards so the best matching evdev event would be KEY_FN_F12.
Dec 19 2019, 8:50 PM ยท x11

Dec 10 2019

wulf committed rS355596: [ig4] Remove unused methods from bus interface.
[ig4] Remove unused methods from bus interface
Dec 10 2019, 8:23 PM

Dec 3 2019

wulf committed rS355372: MFC r355065 - r355068: Linux epoll improvements..
MFC r355065 - r355068: Linux epoll improvements.
Dec 3 2019, 11:12 PM

Nov 24 2019

wulf added a comment to D22515: Linux epoll: Check both read and write kqueue events existence in EPOLL_CTL_ADD.

Do you think we could add all of these test cases to the tree somewhere?

Nov 24 2019, 9:06 PM
wulf committed rS355068: Linux epoll: Allow passing of any negative timeout value to epoll_wait.
Linux epoll: Allow passing of any negative timeout value to epoll_wait
Nov 24 2019, 8:51 PM
wulf closed D22517: Linux epoll: Allow passing of any negative timeout value to epoll_wait.
Nov 24 2019, 8:51 PM
wulf closed D22516: Linux epoll: Register events with zero event mask..
Nov 24 2019, 8:47 PM