Page MenuHomeFreeBSD

hid: Allow serial execution of HID_INTR_START method.
ClosedPublic

Authored by wulf on Jul 28 2025, 9:30 PM.
Tags
None
Referenced Files
F132125710: D51606.diff
Mon, Oct 13, 11:42 PM
Unknown Object (File)
Sat, Oct 11, 4:51 PM
Unknown Object (File)
Sat, Oct 11, 8:15 AM
Unknown Object (File)
Sat, Oct 11, 8:15 AM
Unknown Object (File)
Sat, Oct 11, 8:15 AM
Unknown Object (File)
Sat, Oct 11, 12:54 AM
Unknown Object (File)
Fri, Oct 10, 2:57 PM
Unknown Object (File)
Tue, Oct 7, 1:16 AM
Subscribers

Details

Summary

It is required to implement HQ_NO_READAHEAD HID quirk.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wulf requested review of this revision.Jul 28 2025, 9:30 PM
wulf retitled this revision from hid: Allow serial execution of HID_INTR_STOP method. to hid: Allow serial execution of HID_INTR_START method..Jul 30 2025, 6:22 PM

No major problem. Just some comments.

sys/dev/hid/hidbus.c
634

For a device is read_ahead based like u2f, I assume that the communication model is like a device will be opened and read a few times then close. In that case, should we stop interrupt frequently? Since drain all transfer is unneeded for sequential xfer and can save some time.

sys/dev/hid/hidbus.c
634

"interrupts" are stopped right in "interrupt" handler if any data have been received through avoiding of execution of usbd_transfer_submit(). That is enough to stop state machine.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 17 2025, 9:03 PM
This revision was automatically updated to reflect the committed changes.