Page MenuHomeFreeBSD

hid: Allow serial execution of HID_INTR_START method.
ClosedPublic

Authored by wulf on Jul 28 2025, 9:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 7, 12:56 PM
Unknown Object (File)
Tue, Nov 4, 4:20 AM
Unknown Object (File)
Thu, Oct 30, 3:59 AM
Unknown Object (File)
Wed, Oct 29, 5:47 AM
Unknown Object (File)
Wed, Oct 29, 5:46 AM
Unknown Object (File)
Wed, Oct 29, 5:44 AM
Unknown Object (File)
Sat, Oct 25, 10:00 AM
Unknown Object (File)
Fri, Oct 24, 6:54 PM
Subscribers

Details

Summary

It is required to implement HQ_NO_READAHEAD HID quirk.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

wulf requested review of this revision.Jul 28 2025, 9:30 PM
wulf retitled this revision from hid: Allow serial execution of HID_INTR_STOP method. to hid: Allow serial execution of HID_INTR_START method..Jul 30 2025, 6:22 PM

No major problem. Just some comments.

sys/dev/hid/hidbus.c
634

For a device is read_ahead based like u2f, I assume that the communication model is like a device will be opened and read a few times then close. In that case, should we stop interrupt frequently? Since drain all transfer is unneeded for sequential xfer and can save some time.

sys/dev/hid/hidbus.c
634

"interrupts" are stopped right in "interrupt" handler if any data have been received through avoiding of execution of usbd_transfer_submit(). That is enough to stop state machine.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 17 2025, 9:03 PM
This revision was automatically updated to reflect the committed changes.