hid: Allow serial execution of HID_INTR_START method.
ClosedPublic
Actions

Authored by wulf on Jul 28 2025, 9:30 PM.

Details

Reviewers

emaste
manu

Commits

rGdf6ae0577d2c: hid: Allow serial execution of HID_INTR_START method.

Summary

It is required to implement HQ_NO_READAHEAD HID quirk.

MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 65817
Build 62700: arc lint + arc unit

Event Timeline

wulf created this revision.Jul 28 2025, 9:30 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 28 2025, 9:30 PM

wulf requested review of this revision.Jul 28 2025, 9:30 PM

Harbormaster completed remote builds in B65817: Diff 159370.Jul 28 2025, 9:30 PM

wulf added a parent revision: D41639: Add u2f(4), a HID driver for FIDO/U2F security keys.Jul 28 2025, 9:30 PM

wulf retitled this revision from hid: Allow serial execution of HID_INTR_STOP method. to hid: Allow serial execution of HID_INTR_START method..Jul 30 2025, 6:22 PM

No major problem. Just some comments.

sys/dev/hid/hidbus.c
634	For a device is read_ahead based like u2f, I assume that the communication model is like a device will be opened and read a few times then close. In that case, should we stop interrupt frequently? Since drain all transfer is unneeded for sequential xfer and can save some time.

wulf added inline comments.Aug 12 2025, 10:45 PM

sys/dev/hid/hidbus.c
634	"interrupts" are stopped right in "interrupt" handler if any data have been received through avoiding of execution of usbd_transfer_submit(). That is enough to stop state machine.