Differential D51605

hid: Add HQ_NO_READAHEAD quirk and implement it in usbhid(4)
ClosedPublic
Actions

Authored by wulf on Jul 28 2025, 9:29 PM.

Tags

None

Referenced Files

	F144154389: D51605.diff
	Thu, Feb 5, 3:45 PM

	Unknown Object (File)
	Sun, Feb 1, 9:18 PM

	Unknown Object (File)
	Sun, Feb 1, 9:00 PM

	Unknown Object (File)
	Sun, Feb 1, 8:18 AM

	Unknown Object (File)
	Sun, Feb 1, 8:17 AM

	Unknown Object (File)
	Sat, Jan 31, 2:01 PM

	Unknown Object (File)
	Sat, Jan 31, 11:34 AM

	Unknown Object (File)
	Mon, Jan 26, 10:25 AM

View All 48 Files

Subscribers

Details

Reviewers

emaste
manu
aokblast

Commits

rG7699ec1558b7: hid: Add HQ_NO_READAHEAD quirk and implement it in usbhid(4)

Summary

It disables interrupt emulation on poll-driven buses like USB and
forces aquiring of only one USB frame per read(2) operation.
This avoids an FIDO/U2F issue where IN endpoint data received from
the device right before the file handle is closed, gets lost.

PR: 263995
MfC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wulf created this revision.Jul 28 2025, 9:29 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 28 2025, 9:29 PM

wulf requested review of this revision.Jul 28 2025, 9:29 PM

Harbormaster completed remote builds in B65816: Diff 159369.Jul 28 2025, 9:29 PM

wulf added a parent revision: D41639: Add u2f(4), a HID driver for FIDO/U2F security keys.Jul 28 2025, 9:29 PM

aokblast accepted this revision.Aug 8 2025, 8:07 AM

This revision is now accepted and ready to land.Aug 8 2025, 8:07 AM

Closed by commit rG7699ec1558b7: hid: Add HQ_NO_READAHEAD quirk and implement it in usbhid(4) (authored by wulf). · Explain WhyAug 17 2025, 9:03 PM

This revision was automatically updated to reflect the committed changes.

wulf added a commit: rG7699ec1558b7: hid: Add HQ_NO_READAHEAD quirk and implement it in usbhid(4).

Revision Contents
Changeset List

Path

Size

sys/

dev/

hid/

1 line

usb/

input/

4 lines

Diff 160512

sys/dev/hid/hidquirk.h

Loading...

sys/dev/usb/input/usbhid.c

Loading...