Page MenuHomeFreeBSD

Add u2f(4), a HID driver for FIDO/U2F security keys
AbandonedPublic

Authored by wulf on Aug 29 2023, 10:21 PM.
Tags
None
Referenced Files
F156618892: D41639.diff
Fri, May 15, 4:10 AM
Unknown Object (File)
Thu, May 14, 12:38 AM
Unknown Object (File)
Wed, May 13, 9:07 PM
Unknown Object (File)
Mon, May 11, 11:59 PM
Unknown Object (File)
Thu, Apr 30, 8:32 AM
Unknown Object (File)
Sun, Apr 26, 6:11 AM
Unknown Object (File)
Wed, Apr 22, 10:28 PM
Unknown Object (File)
Sun, Apr 19, 12:55 AM

Details

Summary

This driver is a stripped-down version of hidraw(4). It implements subset of commands required for FIDO/U2F keys only.

User-visible changes are:
It attaches to FIDO/U2F top level collection. So it can be automagically loaded with devd
It sets 660 root:u2f mode to device node. No need in special devd scripts
It emulates USB_GET_DEVICEINFO ioctl

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

wulf requested review of this revision.Aug 29 2023, 10:21 PM
manu requested changes to this revision.Nov 24 2023, 9:31 AM

I guess this review should be splitted in multiple ones.
There is the addition of u2f(4) yes but a lot of stuff is changed in the hid code too.

This revision now requires changes to proceed.Nov 24 2023, 9:31 AM
share/man/man4/u2f.4
90
sys/amd64/conf/GENERIC
397

We need a more descriptive description -- both HIDRAW_MAKE_UHID_ALIAS and U2F_MAKE_UHID_ALIAS have the description # install /dev/uhid alias right now

Are there some test plan to verify that this will not break both Yubikey and Nitrokey support ?

Like for instance, upgrading the firmware on Nitrokey will require having hidraw attaching to the device.
And of course is there a test plan for firefox and chromium derivative to see if that will still work without enabling new usbhid ?

Depending on which FIDO version we are talking about, does webauth test with both enabling and disabling new usbhid ?