Paths

Table of Contentst

Differential D55573

amd64: complete thunderbolt KERNCONF integration
ClosedPublic
Actions

Authored by ngie on Feb 27 2026, 8:46 PM.

Project Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

Commits

rG886164895f3f: amd64: complete thunderbolt KERNCONF integration

Summary

This completes the work so the driver can be integrated into KERNCONFs
properly on amd64.

MFC after: 1 month

Test Plan

This is one of the many changes that helps provide a more complete/functional Thunderbolt experience with my MacBookPro13,1.

My other Apple devices are pending..

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ngie created this revision.Feb 27 2026, 8:46 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 27 2026, 8:46 PM

ngie requested review of this revision.Feb 27 2026, 8:46 PM

Harbormaster completed remote builds in B71080: Diff 172891.Feb 27 2026, 8:46 PM

ngie retitled this revision from Complete thunderbolt KERNCONF integration to amd64: complete thunderbolt KERNCONF integration.Feb 27 2026, 8:50 PM

ngie edited the summary of this revision. (Show Details)

ngie edited the test plan for this revision. (Show Details)

ngie added a reviewer: imp.

ngie added a child revision: D55556: ARM64: add thunderbolt to `std.apple`.

ngie added subscribers: adrian, jhb, USB.

imp added inline comments.Feb 27 2026, 9:09 PM

sys/conf/files.amd64
440	So I'm wondering if all this shouldn't just be in files, even if it's just amd64 at the moment... And it's also misordered here if it actually belongs here.

ngie added inline comments.Feb 27 2026, 11:07 PM

sys/conf/files.amd64
440	Putting it in `sys/conf/files` might be a good idea, but what I am doing is matching the existing logic in `sys/modules/Makefile`. Where should these entries be? Should it be sorted by its driver name (in this case thunderbolt?)?

ngie added inline comments.Mar 20 2026, 12:43 AM

sys/conf/files.amd64
440	@imp: ping?

imp added inline comments.Mar 20 2026, 4:25 AM

sys/conf/files.amd64
440	they should be in alphabetical order with the other devices.

Sort by driver name.

Harbormaster completed remote builds in B71610: Diff 174062.Mar 21 2026, 3:12 AM

@imp : ping?

ngie mentioned this in D52861: thunderbolt: Support generic USB4 NHIs.May 16 2026, 1:07 AM

This revision was not accepted when it landed; it landed in state Needs Review.Jun 3 2026, 6:02 AM

Closed by commit rG886164895f3f: amd64: complete thunderbolt KERNCONF integration. · Explain Why

This revision was automatically updated to reflect the committed changes.

ngie added a commit: rG886164895f3f: amd64: complete thunderbolt KERNCONF integration.

obiwac subscribed.Jun 8 2026, 2:29 PM

obiwac added inline comments.

sys/amd64/conf/GENERIC
346	could we not have this built in the kernel by default? firstly and mainly because this is still very incomplete and I don't want anyone relying on this, and secondly because for S0i3 with pink sardine controllers to work we currently have to easily be able to unload/load this on resume (issue with hotplug events not being properly acknowledged and filling the rings).

ngie added inline comments.Jun 11 2026, 6:54 PM

sys/amd64/conf/GENERIC
346	I'll do that and add a comment/bug that notes why it's not in GENERIC. I'll hopefully have this started/completed by EOD.

obiwac added inline comments.Jun 11 2026, 8:32 PM

sys/amd64/conf/GENERIC
346	thanks, appreciate it :)

Revision Contents
Changeset List

Path

Size

sys/

amd64/

conf/

1 line

4 lines

conf/

10 lines

3 lines

Diff 179114

sys/amd64/conf/GENERIC

Loading...

sys/amd64/conf/NOTES

Loading...

sys/conf/files.amd64

Loading...

sys/conf/options.amd64

Loading...