Paths

Table of Contentst

Differential D55573

amd64: complete thunderbolt KERNCONF integration
Needs ReviewPublic
Actions

Authored by ngie on Fri, Feb 27, 8:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Mar 18, 9:31 PM

	Unknown Object (File)
	Sat, Mar 7, 1:08 AM

	Unknown Object (File)
	Thu, Mar 5, 8:56 AM

	Unknown Object (File)
	Thu, Mar 5, 2:56 AM

	Unknown Object (File)
	Wed, Mar 4, 2:37 PM

	Unknown Object (File)
	Tue, Mar 3, 5:35 AM

	Unknown Object (File)
	Tue, Mar 3, 5:12 AM

	Unknown Object (File)
	Sun, Mar 1, 9:39 AM

View All 14 Files

Subscribers

Details

Reviewers

Summary

This completes the work so the driver can be integrated into KERNCONFs
properly on amd64.

MFC after: 1 month

Test Plan

This is one of the many changes that helps provide a more complete/functional Thunderbolt experience with my MacBookPro13,1.

My other Apple devices are pending..

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71610
Build 68493: arc lint + arc unit

Event Timeline

ngie created this revision.Fri, Feb 27, 8:46 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Feb 27, 8:46 PM

ngie requested review of this revision.Fri, Feb 27, 8:46 PM

Harbormaster completed remote builds in B71080: Diff 172891.Fri, Feb 27, 8:46 PM

ngie retitled this revision from Complete thunderbolt KERNCONF integration to amd64: complete thunderbolt KERNCONF integration.Fri, Feb 27, 8:50 PM

ngie edited the summary of this revision. (Show Details)

ngie edited the test plan for this revision. (Show Details)

ngie added a reviewer: imp.

ngie added a child revision: D55556: ARM64: add thunderbolt to `std.apple`.

ngie added subscribers: adrian, jhb, USB.

imp added inline comments.Fri, Feb 27, 9:09 PM

sys/conf/files.amd64
439	So I'm wondering if all this shouldn't just be in files, even if it's just amd64 at the moment... And it's also misordered here if it actually belongs here.

ngie added inline comments.Fri, Feb 27, 11:07 PM

sys/conf/files.amd64
439	Putting it in `sys/conf/files` might be a good idea, but what I am doing is matching the existing logic in `sys/modules/Makefile`. Where should these entries be? Should it be sorted by its driver name (in this case thunderbolt?)?

ngie added inline comments.Fri, Mar 20, 12:43 AM

sys/conf/files.amd64
439	@imp: ping?

imp added inline comments.Fri, Mar 20, 4:25 AM

sys/conf/files.amd64
439	they should be in alphabetical order with the other devices.

Sort by driver name.

Harbormaster completed remote builds in B71610: Diff 174062.Sat, Mar 21, 3:12 AM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

conf/

1 line

4 lines

conf/

10 lines

3 lines

Diff 174062

sys/amd64/conf/GENERIC

Loading...

sys/amd64/conf/NOTES

Loading...

sys/conf/files.amd64

Loading...

sys/conf/options.amd64

Loading...