Add u2f(4), a HID driver for FIDO/U2F security keys
Needs RevisionPublic
Actions

Authored by wulf on Aug 29 2023, 10:21 PM.

Details

Reviewers

grembo
andrew
manu

Summary

This driver is a stripped-down version of hidraw(4). It implements subset of commands required for FIDO/U2F keys only.

User-visible changes are:
It attaches to FIDO/U2F top level collection. So it can be automagically loaded with devd
It sets 660 root:u2f mode to device node. No need in special devd scripts
It emulates USB_GET_DEVICEINFO ioctl

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

wulf created this revision.Aug 29 2023, 10:21 PM

Herald added a reviewer: andrew. · View Herald TranscriptAug 29 2023, 10:21 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: jhibbits, emaste, imp. · View Herald Transcript

wulf requested review of this revision.Aug 29 2023, 10:21 PM

lwhsu added a subscriber: lwhsu.Aug 30 2023, 3:36 AM

valdemar_erk.io added a subscriber: valdemar_erk.io.Nov 12 2023, 1:51 PM

I guess this review should be splitted in multiple ones.
There is the addition of u2f(4) yes but a lot of stuff is changed in the hid code too.

This revision now requires changes to proceed.Nov 24 2023, 9:31 AM

wulf mentioned this in D45659: Enable usbhid by default.Jun 21 2024, 4:17 PM

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

Makefile

1 line

u2f.4

93 lines

sys/

amd64/

conf/

GENERIC

1 line

arm/

conf/

GENERIC

1 line

RPI-B

1 line

arm64/

conf/

std.dev

1 line

conf/

NOTES

2 lines

files

1 line

options

1 line

dev/

hid/

4 lines

41 lines

1 line

51 lines

31 lines

589 lines

iicbus/

iichid.c

3 lines

usb/

input/

6 lines

8 lines

48 lines

37 lines

3 lines

i386/

conf/

GENERIC

1 line

modules/

hid/

Makefile

1 line

u2f/

Makefile

8 lines

powerpc/

conf/

GENERIC64

1 line

GENERIC64LE

1 line

riscv/

conf/

GENERIC

1 line

sys/

conf.h

1 line

Diff 126660

View Options

share/man/man4/Makefile

View Options

share/man/man4/u2f.4

View Options

sys/amd64/conf/GENERIC

View Options

sys/arm/conf/GENERIC

View Options

sys/arm/conf/RPI-B

View Options

sys/arm64/conf/std.dev

View Options

sys/conf/NOTES

View Options

sys/conf/files

View Options

sys/conf/options

View Options

sys/dev/hid/hid.h

View Options

sys/dev/hid/hidbus.c

View Options

sys/dev/hid/hidquirk.h

View Options

sys/dev/hid/hidraw.c

View Options

sys/dev/hid/ietp.c

View Options

sys/dev/hid/u2f.c

View Options

sys/dev/iicbus/iichid.c

View Options

sys/dev/usb/input/uhid.c

View Options

sys/dev/usb/input/usbhid.c

View Options

sys/dev/usb/usb_device.c

View Options

sys/dev/usb/usb_generic.c

View Options

sys/dev/usb/usbdi.h

View Options

sys/i386/conf/GENERIC

View Options

sys/modules/hid/Makefile

View Options

sys/modules/hid/u2f/Makefile

View Options

sys/powerpc/conf/GENERIC64

View Options

sys/powerpc/conf/GENERIC64LE

View Options

sys/riscv/conf/GENERIC

View Options

Add u2f(4), a HID driver for FIDO/U2F security keysNeeds RevisionPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 126660

share/man/man4/Makefile

share/man/man4/u2f.4

sys/amd64/conf/GENERIC

sys/arm/conf/GENERIC

sys/arm/conf/RPI-B

sys/arm64/conf/std.dev

sys/conf/NOTES

sys/conf/files

sys/conf/options

sys/dev/hid/hid.h

sys/dev/hid/hidbus.c

sys/dev/hid/hidquirk.h

sys/dev/hid/hidraw.c

sys/dev/hid/ietp.c

sys/dev/hid/u2f.c

sys/dev/iicbus/iichid.c

sys/dev/usb/input/uhid.c

sys/dev/usb/input/usbhid.c

sys/dev/usb/usb_device.c

sys/dev/usb/usb_generic.c

sys/dev/usb/usbdi.h

sys/i386/conf/GENERIC

sys/modules/hid/Makefile

sys/modules/hid/u2f/Makefile

sys/powerpc/conf/GENERIC64

sys/powerpc/conf/GENERIC64LE

sys/riscv/conf/GENERIC

sys/sys/conf.h

Add u2f(4), a HID driver for FIDO/U2F security keys
Needs RevisionPublic
Actions

Revision Contents
Changeset List