Page MenuHomeFreeBSD

emil_etsalapatis.com (Emil Tsalapatis)
User

Projects

User does not belong to any projects.

User Details

User Since
May 16 2024, 6:38 PM (8 w, 6 d)

Recent Activity

Jun 6 2024

emil_etsalapatis.com planned changes to D45370: add virtio single-machine testing framework.
Jun 6 2024, 9:27 PM
emil_etsalapatis.com added a comment to D45370: add virtio single-machine testing framework.

Will do, I have been building it as part of the kernel so that's probably why it didn't need a definition in sys/modules. I have been running this manually.

I've been thinking on how to get this code to be more reviewable. Should I maybe try to get it published as a port instead of submitting it as a patch to src/? Most of this code is self-contained, and its size means it will be next to impossible to review in its current state. If we go down the port route, only changes we would be applying to src/ would be non-functional - most would be about turning some static functions global.

Alternatively, I can break this diff apart, get the virtio-dbg transport reviewed since it is more reasonably sized, and either spin off the userspace device emulation component as a port or introduce it later. Which do you think is more reasonable?

Splitting it apart sounds good. Especially if there's some way to exercise the virtio-dbg transport without the userspace device emulation. Then splitting it apart would be a very good idea.

Jun 6 2024, 9:27 PM
emil_etsalapatis.com added a comment to D45370: add virtio single-machine testing framework.

I think you need to add a definition for the virtio_dbg module in sys/modules. Oh, and how do you use it? Eventually we want ATF tests, of course. But I assume for now you've been manually using it somehow?

Jun 6 2024, 8:53 PM

May 26 2024

emil_etsalapatis.com requested review of D45370: add virtio single-machine testing framework.
May 26 2024, 4:24 PM