Page MenuHomeFreeBSD

add virtio file system device support
Needs ReviewPublic

Authored by emil_etsalapatis.com on Aug 14 2024, 3:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 9, 4:31 AM
Unknown Object (File)
Tue, Jul 1, 4:23 AM
Unknown Object (File)
Mon, Jun 30, 9:58 AM
Unknown Object (File)
Mon, Jun 23, 9:06 PM
Unknown Object (File)
Mon, Jun 23, 12:59 AM
Unknown Object (File)
Wed, Jun 18, 3:26 AM
Unknown Object (File)
Wed, Jun 18, 12:31 AM
Unknown Object (File)
Tue, Jun 17, 11:21 PM

Details

Summary

Supporting the virtiofs requires a device driver for the virtio fs device. Add the virtio file system driver before introducing the file system itself.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 64544
Build 61428: arc lint + arc unit

Event Timeline

lwhsu added inline comments.
sys/dev/virtio/fs/virtio_fs.h
5

We need a copyright holder here, and may drop "all rights reserved."

asomers requested changes to this revision.Aug 21 2024, 7:30 PM
asomers added inline comments.
sys/dev/virtio/fs/virtio_fs.c
59

This line is redundant with the one in virtio_fs.h

297
551–552
sys/dev/virtio/fs/virtio_fs_internal.h
11

If these messages are just for debugging purposes, shouldn't there be a way to turn them off?

This revision now requires changes to proceed.Aug 21 2024, 7:30 PM
  • sys/dev/virtio/fs: drain virtqueues one at a time
sys/dev/virtio/fs/virtio_fs.h
3

BSD-2-Clause is fine, no need -FreeBSD suffix

  • sys/dev/virtio/fs: use regular BSD-2-Clause license