Page MenuHomeFreeBSD

crest_freebsd_rlwinm.de (Jan Bramkamp)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 27 2021, 7:29 PM (138 w, 3 d)

Recent Activity

Wed, Feb 7

crest_freebsd_rlwinm.de added inline comments to D41318: Add the "missing" WireGuard rc.d script.
Wed, Feb 7, 4:06 PM · manpages, rc, network

Fri, Feb 2

crest_freebsd_rlwinm.de added a comment to D43696: Jail descriptors.

The __specialfd() system call is good to know about, but on its own doesn't provide a way to atomically create a configured jail with its lifetime tied to the file descriptor unlike passing a negative integer as "desc" argument to jail_set. There would either be a window where the jail would exist without a file descriptor associated with it which would reintroduce races and resource leak or the file descriptor has to start out unattached to a jail and be passed to the jail_set(JAIL_CREATE) call. The later design choice would get rid of the awkwardness of (ab-)using negative file descriptor numbers to request a file descriptor via an in-out parameter.

Fri, Feb 2, 3:06 PM

Thu, Feb 1

crest_freebsd_rlwinm.de added a comment to D43696: Jail descriptors.
In D43696#996669, @dvl wrote:

I read the description, but I'm still not sure how a jail descriptor would be used. How about some pseudo-code, to illustrate the concept please?

Thu, Feb 1, 5:20 PM

Jan 15 2024

crest_freebsd_rlwinm.de added inline comments to D41318: Add the "missing" WireGuard rc.d script.
Jan 15 2024, 12:48 PM · manpages, rc, network
crest_freebsd_rlwinm.de added inline comments to D41318: Add the "missing" WireGuard rc.d script.
Jan 15 2024, 12:41 PM · manpages, rc, network
crest_freebsd_rlwinm.de added inline comments to D41318: Add the "missing" WireGuard rc.d script.
Jan 15 2024, 12:20 PM · manpages, rc, network

Dec 29 2023

crest_freebsd_rlwinm.de added a comment to D41318: Add the "missing" WireGuard rc.d script.

No manual page to review, yet manpages is a group reviewer. Did a file get accidentally left out?

Dec 29 2023, 9:49 PM · manpages, rc, network

Nov 6 2023

crest_freebsd_rlwinm.de added a comment to D42402: cam/ata: Postpone removal of two compat sysctl until 15.

Is there enough space in the message to help users by giving them a reference to the new interface to express the same configuration and what form of reference would work well for this?

Nov 6 2023, 10:31 AM

Oct 26 2023

crest_freebsd_rlwinm.de added a comment to D42366: bhyve: fix arguments to ioctl(VMIO_SIOCSIFFLAGS).

Good catch.

Oct 26 2023, 3:57 PM

Sep 7 2023

crest_freebsd_rlwinm.de awarded D41723: Fix ".include" section of jail.conf.5 a Like token.
Sep 7 2023, 1:19 PM

Aug 23 2023

crest_freebsd_rlwinm.de added a comment to D41318: Add the "missing" WireGuard rc.d script.

The interface name restriction function is a judgment call restricting users from creating problematic (for shell scripts) interface names. Applying the same restrictions to existing services like netif and routing could break (partly) working configurations.

Aug 23 2023, 6:46 PM · manpages, rc, network

Aug 18 2023

crest_freebsd_rlwinm.de added a reviewer for D41318: Add the "missing" WireGuard rc.d script: manpages.
Aug 18 2023, 11:21 AM · manpages, rc, network

Aug 4 2023

crest_freebsd_rlwinm.de requested review of D41318: Add the "missing" WireGuard rc.d script.
Aug 4 2023, 10:44 AM · manpages, rc, network

Jun 13 2023

crest_freebsd_rlwinm.de added a comment to D40377: Teach route(8) to run in jails.

The jail_name variable must be initialised to NULL. This should be done through an explicit char * jail_name = NULL; in line 101 of route.c.

Static storage are always initialized to 0/NULL by C standard.

Jun 13 2023, 1:15 PM · Jails

Jun 12 2023

crest_freebsd_rlwinm.de requested changes to D40377: Teach route(8) to run in jails.

The jail_name variable must be initialised to NULL. This should be done through an explicit char * jail_name = NULL; in line 101 of route.c.

Jun 12 2023, 2:53 PM · Jails
crest_freebsd_rlwinm.de accepted D40377: Teach route(8) to run in jails.
Jun 12 2023, 2:49 PM · Jails

Jun 2 2023

crest_freebsd_rlwinm.de added a comment to D40377: Teach route(8) to run in jails.

It reads to me like initialising jail_name to NULL and replacing if (usejail) with if (jail_name != NULL) would make the usejail variable superfluous. Splitting a pointer and its validity into two variables like this (jail_name and usejail) introduces the potential for contradiction if only one of the two is updated. If this split is required for something I would like to see them stored together in a struct { char *, bool } instead of destructured into two variables.

Jun 2 2023, 2:48 PM · Jails

Jun 1 2023

crest_freebsd_rlwinm.de added a comment to D40188: Add ".include" directive to jail.conf.

Just a small nitpick: I would prefer a macro #define MAX_INCLUDE_DEPTH 32 or constant static const unsigned int max_include_depth = 32; somewhere above the include_config() in config.c instead of the literal to improve readability.

Jun 1 2023, 11:49 AM · Jails

May 10 2023

crest_freebsd_rlwinm.de added a comment to D39011: Enable jail(8) to parse all config files.

The jail(8) man page needs to be updated to reflect the new -F flag.

May 10 2023, 5:42 PM
crest_freebsd_rlwinm.de added a watcher for Jails: crest_freebsd_rlwinm.de.
May 10 2023, 5:31 PM

May 8 2023

crest_freebsd_rlwinm.de added a comment to D39996: fork: do not exclude pid 1's children from creating reapsubtrees.

What is gained by having PID 1 acquire sub-reaper status given that it's the reaper? What are the expected semantics for proctl(PROC_REAP_ACQUIRE) in PID 1? Would it be enough to wrap the procctl(…) call with if ( getpid() != 1 ) { … } or is there more to this?

May 8 2023, 5:21 PM

Mar 31 2023

crest_freebsd_rlwinm.de added a comment to D38901: linsysfs(4): Make listnics use new if_foreach_sleep method.

This change has been blamed to cause kernel panics on the FreeBSD current mailing list: https://lists.freebsd.org/archives/freebsd-current/2023-March/003381.html. It's been reported that reverting commit 0b56641cfcda30d06243223f37781ccc18455bef allows starting jails without triggering the observed kernel panic.

Mar 31 2023, 11:41 AM · Linux Emulation

Jun 24 2022

crest_freebsd_rlwinm.de added a comment to D33693: Run softclock threads at a hardware ithread priority..
Jun 24 2022, 11:39 AM

Apr 28 2022

crest_freebsd_rlwinm.de added a watcher for bhyve: crest_freebsd_rlwinm.de.
Apr 28 2022, 4:16 PM

Dec 9 2021

crest_freebsd_rlwinm.de added a comment to D28199: bhyve(8): decouple unix domain socket from save/restore code.
In D28199#636696, @rew wrote:

bhyve/ipc: use SOCK_DGRAM

  • use SOCK_DGRAM instead of SOCK_STREAM
  • have bhyvectl(8) share ipc.h from bhyve(8)
  • fix naming semantics of MAX_SNAPSHOT_VMNAME, now called MAX_SNAPSHOT_FILENAME.

Previously, snapshot.h and bhyvectl.c each had their own
#define MAX_VMNAME 100, this is now shared at vmmapi.h - the
value has also been changed to 89. It's a limitation for the
unix domain socket path as constrained by SUNPATHLEN (104).
The prefix for the socket path is BHYVE_RUN_DIR, which by default
is '/var/run/bhyve/' (15). 104-15 = 89.

Dec 9 2021, 5:38 PM