Differential D53973

ix(4): Add support for firmware logging for E610 adapters
AcceptedPublic
Actions

Authored by Yogesh.Bhosale_intel.com on Fri, Nov 28, 6:19 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 19, 10:46 AM

	Unknown Object (File)
	Wed, Dec 17, 8:53 AM

	Unknown Object (File)
	Sun, Dec 14, 8:18 PM

	Unknown Object (File)
	Fri, Dec 5, 11:06 PM

	Unknown Object (File)
	Thu, Dec 4, 7:37 AM

	Unknown Object (File)
	Wed, Dec 3, 5:06 PM

	Unknown Object (File)
	Fri, Nov 28, 9:30 PM

	Unknown Object (File)
	Fri, Nov 28, 4:51 PM

Subscribers

Details

Reviewers

ziaee
kgalazka
kbowling
erj

Group Reviewers

Restricted Owners Package

(Owns No Changed Paths)

Summary

This is part 3 of the support for the new Intel Ethernet E610
family of devices

The ix driver now enables firmware logging on Intel E610 devices
for debugging with Customer Support. Logs are enabled by default
and generated in binary format that requires decoding by support
teams. The collected data is firmware and hardware related for
debugging purposes only.

When the driver loads, it creates a fw_log sysctl node under the
debug section. Events are organized into categories (modules) for
targeted logging, and users can adjust verbosity levels as needed.

This adds sysctl support for the firmware logging feature and
updates the ix(4) manual page with documentation.

Signed-off-by: Yogesh Bhosale <yogesh.bhosale@intel.com>
Co-developed-by: Krzysztof Galazka <krzysztof.galazka@intel.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 68914
Build 65797: arc lint + arc unit

Event Timeline

Yogesh.Bhosale_intel.com created this revision.Fri, Nov 28, 6:19 AM

Herald added subscribers: ziaee, ae, imp. · View Herald TranscriptFri, Nov 28, 6:19 AM

Yogesh.Bhosale_intel.com requested review of this revision.Fri, Nov 28, 6:19 AM

Harbormaster completed remote builds in B68914: Diff 167230.Fri, Nov 28, 6:19 AM

Yogesh.Bhosale_intel.com added reviewers: Restricted Owners Package, ziaee, kgalazka.Fri, Nov 28, 6:33 AM

Yogesh.Bhosale_intel.com added reviewers: kbowling, erj.

No comment on the implementation, but the manual looks good to me. Thanks Yogesh!

share/man/man4/ix.4
163–194	For alphabetization.

This revision is now accepted and ready to land.Mon, Dec 1, 9:58 PM

Oops, I forgot: Please make sure to wrap commit messages at 72 columns!

In D53973#1234193, @ziaee wrote:

No comment on the implementation, but the manual looks good to me. Thanks Yogesh!

Thanks!

In D53973#1234270, @ziaee wrote:

Oops, I forgot: Please make sure to wrap commit messages at 72 columns!

Done!

Just a cursory look on my end, approving for @kgalazka

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

34 lines

sys/

conf/

2 lines

dev/

ixgbe/

18 lines

5 lines

13 lines

486 lines

ixgbe_features.h

1 line

ixgbe_fw_logging.c

467 lines

3 lines

36 lines

modules/

ix/

1 line

ixv/

1 line

Diff 167230

share/man/man4/ix.4

Loading...

sys/conf/files

Loading...

sys/dev/ixgbe/if_ix.c

Loading...

sys/dev/ixgbe/ixgbe.h

Loading...

sys/dev/ixgbe/ixgbe_e610.h

Loading...

sys/dev/ixgbe/ixgbe_e610.c

Loading...

sys/dev/ixgbe/ixgbe_features.h

Loading...

sys/dev/ixgbe/ixgbe_fw_logging.c

Loading...

sys/dev/ixgbe/ixgbe_osdep.h

Loading...

sys/dev/ixgbe/ixgbe_osdep.c

Loading...

sys/modules/ix/Makefile

Loading...

sys/modules/ixv/Makefile

Loading...