I do not have a Freebsd email for the moment.

Sure i can close this diff.

• atrtc0 (ISA) attaches first during boot gets IRQ 8
• atrtc1 (ACPI) attaches second also registers as a TOD clock

In D54954#1260711, @jhb wrote:

You still haven't answered the question of how you get multiple atrtcX devices in the first place. That should Never Happen(tm) and probably points to some other bug elsewhere that we should handle instead of applying a band-aid to atrtc(4).

Your approach is much more elegant..

• intel/intel_pmc_core: Remove unnecessary NULL check in detach

Reverting to datasheet value (100us). Linux's 104us likely quirk on untested vendors.

Addressed feedback:

• SPDX first line, split copyright/description
• Alphabetized includes and build files
• Updated counter to 104us (empirical/Linux)
• Refactored with pmc_read_safe() helper
• Documented S0ix scope
• Removed slp_s0_step member

This looks like a breaking change. Not sure if the solution is to detect the cpu (since having both types in the same motherboard is not possible).

I have the full thunderbolt 1/2/3/4 work lined up... I'm trying to split them into smaller chuncks .

Wire into build; add PL2 enabled/lock bit; align sysctl names

Add files.x86 and modules entries; align slp_s0_residency sysctl name

Only add dev.asmc.*.wol when AUPO exists; add key constant

Prefer unit 0 using devclass check; remove global sentinel. Drop RF_SHAREABLE and document IRQ 8.

Make dev.asmc.*.raw.len read-only to prevent user overrides

Fix tab alignment in usbdevs

Address review feedback: keep warn variable, invert at assignment instead of double-negative

@manu thanks for the work here, do you plan to resume this driver effort ? I ran into the same hang on boot that @saper_saper.info reported, and on top of that I see a crash at runtime after a few minutes.

@ngie i prefered to keep this diff scoped to ACPI discovery only, but the switching is important too.

Updated the diff .

Adding dump_app in another diff.

Sorry, still using arc incorrectly. Need i need to learn git-arc.

speaker, clock: Replace Giant lock with fine-grained locking

We could wrap it with a sleep mutex, but concurrent fan control from multiple threads is not a realistic scenario.
The worst case is a lost update, not a crash.

oss@seuros.com (like the previous commits)

This module load only in apple hardware. Spparently the hardware is not build to have it driver hot reloaded.

Duplicate of D54439.

i got the patch from the wrong branch, the first time.

Honestly no.