Page MenuHomeFreeBSD

val_packett.cool (Val Packett (they/them))
User

Projects

User does not belong to any projects.

User Details

User Since
Dec 9 2017, 2:51 PM (330 w, 6 d)

Recent Activity

Jan 21 2024

val_packett.cool added a comment to D41844: Add an implementation of the 9P filesystem.

Can we land this without an aggressive MFC and test in CURRENT before the review goes stale?

Jan 21 2024, 12:41 AM

Dec 7 2023

val_packett.cool added a comment to D41844: Add an implementation of the 9P filesystem.

Playing with this again, a lot better now!

Dec 7 2023, 8:32 AM
val_packett.cool added inline comments to D41844: Add an implementation of the 9P filesystem.
Dec 7 2023, 5:44 AM

Oct 13 2023

val_packett.cool added a comment to D41844: Add an implementation of the 9P filesystem.

Ah no, the cache_enter_time thing seems to be unrelated. Maybe it was bad luck that I got it very quickly after porting the patches just doing some ls commands; with pkg fetching packages it has happened both with the patches as they are and without them at all; i.e. no matter what. Not sure what can be done, my attempts to "fix" it (with my nonexistent vfs knowledge) seem to only introduce new panics.

Oct 13 2023, 3:01 AM
val_packett.cool added a comment to D41844: Add an implementation of the 9P filesystem.

Interesting!! The excl->share thing I was getting seems to happen when I mount /home, but not when I mount /home/val only. (On the host /home/val is a mounted ZFS dataset if that matters… well /home is a dataset too but only has the mountpoint dir.)

Oct 13 2023, 2:20 AM
val_packett.cool created P611 For D41844: backport.
Oct 13 2023, 2:09 AM

Oct 12 2023

val_packett.cool added a comment to D41844: Add an implementation of the 9P filesystem.

Just logging in to a home directory shared with the Linux host, there's a lock order issue:

Oct 12 2023, 11:09 PM

Sep 23 2023

val_packett.cool accepted D41949: mailmap: Add pstef and val.
Sep 23 2023, 8:08 PM

Aug 24 2023

val_packett.cool abandoned D38351: [RFC/Proposal] Mechanism for in-kernel AT_FDCWD substitution with provided FD for oblivious sandboxing with Capsicum.

Thanks @trasz, I'll experiment with building on top of fchroot. I'll post new proposals as separate revisions and leave this closed as-is for historical reference :)

Aug 24 2023, 5:30 PM
val_packett.cool added a comment to D39996: fork: do not exclude pid 1's children from creating reapsubtrees.

ping!

Aug 24 2023, 5:27 PM

Aug 2 2023

val_packett.cool added a comment to D39863: Add atopcase, the Apple HID over SPI input driver [WIP: Someone w/ Hardware Needed].
In D39863#937356, @wulf wrote:

Finally, I got MacBook 14,1 for some time and tried to run this driver on it. It required some extra work and result can be found here: https://github.com/wulf7/freebsd/commits/atopcase

Aug 2 2023, 8:21 AM

Jul 27 2023

val_packett.cool retitled D39980: mk: fix unnecessary library relinking with incremental builds from mk: fix unnecessary library relinking WITH_META_MODE to mk: fix unnecessary library relinking with incremental builds.
Jul 27 2023, 7:24 PM
val_packett.cool added a comment to D39980: mk: fix unnecessary library relinking with incremental builds.

WITHOUT_CLEAN builds should benefit as well then.. (Not sure why people still use it when META_MODE exists but okay :D)

Jul 27 2023, 7:24 PM
val_packett.cool added a comment to D39980: mk: fix unnecessary library relinking with incremental builds.

Well, you wouldn't really save any time on a non-incremental build as all the libraries would be rebuilt anyway. The *problem* this solves is specific to META_MODE :)

Jul 27 2023, 7:17 PM

May 8 2023

val_packett.cool added a comment to D39996: fork: do not exclude pid 1's children from creating reapsubtrees.
In D39996#911105, @kib wrote:

IMO it is micro-overoptimization, not a fix for a bug. It is fine as far as init(8) does not use reaper API.
It if starts using it, then the check needs to go away.

May 8 2023, 11:05 PM

May 7 2023

val_packett.cool updated the test plan for D39996: fork: do not exclude pid 1's children from creating reapsubtrees.
May 7 2023, 7:56 PM
val_packett.cool requested review of D39996: fork: do not exclude pid 1's children from creating reapsubtrees.
May 7 2023, 7:54 PM

May 5 2023

val_packett.cool updated the test plan for D39980: mk: fix unnecessary library relinking with incremental builds.
May 5 2023, 8:12 PM
val_packett.cool requested review of D39980: mk: fix unnecessary library relinking with incremental builds.
May 5 2023, 8:10 PM

Apr 28 2023

val_packett.cool added a comment to D39863: Add atopcase, the Apple HID over SPI input driver [WIP: Someone w/ Hardware Needed].
In D39863#907564, @wulf wrote:

The sibling should be deleted and recreated as child of spibus to get proper ivars like iicbus does: https://github.com/freebsd/freebsd-src/blob/main/sys/dev/iicbus/acpi_iicbus.c#L459
And I wonder, how it produces interrupts as intel_spi misses some resource handling bus methods

Apr 28 2023, 7:40 PM
val_packett.cool updated the summary of D39863: Add atopcase, the Apple HID over SPI input driver [WIP: Someone w/ Hardware Needed].
Apr 28 2023, 5:04 AM
val_packett.cool requested review of D39863: Add atopcase, the Apple HID over SPI input driver [WIP: Someone w/ Hardware Needed].
Apr 28 2023, 4:29 AM

Apr 20 2023

val_packett.cool added a comment to D38459: timerfd: Add native support for Linux's timerfd.

Hey, couple random notes:

Apr 20 2023, 6:12 AM · linuxkpi, Linux Emulation

Apr 15 2023

val_packett.cool updated the diff for D39585: procctl: add state flags to PROC_REAP_GETPIDS reports.

Yeah, I guess it would make sense to only report "exiting" when not yet exited.

Apr 15 2023, 9:05 PM
val_packett.cool retitled D39585: procctl: add state flags to PROC_REAP_GETPIDS reports from procctl: add a REAPER_PIDINFO_ZOMBIE flag to PROC_REAP_GETPIDS reports to procctl: add state flags to PROC_REAP_GETPIDS reports.
Apr 15 2023, 8:07 PM
val_packett.cool updated the diff for D39585: procctl: add state flags to PROC_REAP_GETPIDS reports.

BTW, is the only difference between P_WEXIT and zombie state is that P_WEXIT gets set earlier in the process?

Apr 15 2023, 8:06 PM
val_packett.cool added reviewers for D39585: procctl: add state flags to PROC_REAP_GETPIDS reports: Contributor Reviews (src), kib.
Apr 15 2023, 6:05 PM
val_packett.cool requested review of D39585: procctl: add state flags to PROC_REAP_GETPIDS reports.
Apr 15 2023, 6:03 PM

Apr 13 2023

val_packett.cool added a comment to D38351: [RFC/Proposal] Mechanism for in-kernel AT_FDCWD substitution with provided FD for oblivious sandboxing with Capsicum.

I wonder if, instead of "fake root", you made it so that it uses the actual root vnode for the process, the one that's changed by chroot(2)? That would require implementing fchroot(2), like NetBSD did, and that's assuming you're ok with the NO_NEW_PRIVS flag set, ie the SUID bits being ignored, because otherwise chroot(2)/fchroot(2) would require root privileges. The cap_enter() would then have to set the process' root vp to NULL, or to some dead vnode, when called.

Apr 13 2023, 4:26 AM

Mar 30 2023

val_packett.cool added a comment to D39283: vt: add a vt_dummy driver.

Yeah, I solved the same problem in drm initially by writing a dummy driver too, but now it's been replaced by FB_FLAG_NOWRITE.
This is how we're doing it, it's a bit annoying that we have to check the driver and reach into its softc, ideally flags like that would be a more outer-level thing somehow (?)

Mar 30 2023, 12:44 AM

Mar 27 2023

val_packett.cool added a comment to D39270: Redefine CLOCK_BOOTTIME to alias CLOCK_MONOTONIC, not CLOCK_UPTIME.

Found some interesting discussion from almost a decade ago: https://lists.freebsd.org/pipermail/freebsd-arch/2013-August/014707.html confirming that MONOTONIC should include suspended time:

Mar 27 2023, 10:07 PM
val_packett.cool added a comment to D39270: Redefine CLOCK_BOOTTIME to alias CLOCK_MONOTONIC, not CLOCK_UPTIME.
In D39270#894574, @imp wrote:

How that aligns with Linux and other OSes is going to be messy, I fear.

Mar 27 2023, 8:29 PM

Mar 26 2023

val_packett.cool added a comment to D39270: Redefine CLOCK_BOOTTIME to alias CLOCK_MONOTONIC, not CLOCK_UPTIME.

Oh, what's also pretty neat about the "MONOTONIC includes suspend like OpenBSD" choice is that software doing some security timeouts like sudo does would default to the secure behavior (not prolonging timeouts across suspends) even without doing anything for suspend-awareness / while being just POSIX without any OS-specific code!! :)

Mar 26 2023, 6:21 PM
val_packett.cool added a comment to D39270: Redefine CLOCK_BOOTTIME to alias CLOCK_MONOTONIC, not CLOCK_UPTIME.
In D39270#894014, @imp wrote:

we specifically aligned with Linux here because more software is written for linux and we had a lot of patches in the ports tree to emulate the linux behavior prior to my changes.

Mar 26 2023, 6:14 PM

Mar 25 2023

val_packett.cool added reviewers for D39270: Redefine CLOCK_BOOTTIME to alias CLOCK_MONOTONIC, not CLOCK_UPTIME: Contributor Reviews (src), imp, dchagin, kib.
Mar 25 2023, 7:59 PM
val_packett.cool requested review of D39270: Redefine CLOCK_BOOTTIME to alias CLOCK_MONOTONIC, not CLOCK_UPTIME.
Mar 25 2023, 7:57 PM

Mar 2 2023

val_packett.cool added a comment to D21612: acpi_cros_tbmc: New driver for Chromebook Tablet Mode Switch.
Mar 2 2023, 4:34 PM
val_packett.cool added a comment to D21746: acpi_cros_kblt: New driver for Chromebook keyboard backlight control.

Can this driver generate org.freedesktop.UPower.KbdBacklight events ?

Mar 2 2023, 4:31 PM

Feb 22 2023

val_packett.cool added a comment to D28704: md: check uid when non-root users detach/resize the mds.

Oops… cr_cansee actually would only deny this with security.bsd.see_other_uids=0 btw. Is there a "fs write" style check anywhere in the common code?

Feb 22 2023, 6:56 AM
val_packett.cool added inline comments to D28704: md: check uid when non-root users detach/resize the mds.
Feb 22 2023, 6:01 AM

Feb 20 2023

val_packett.cool added a comment to D38675: open.2: describe O_RESOLVE_BENEATH errors correctly.

Though, hm, various AT_RESOLVE_BENEATH documentation does collapse it all into one item:

Feb 20 2023, 9:21 PM
val_packett.cool updated the diff for D38675: open.2: describe O_RESOLVE_BENEATH errors correctly.

Yeah, makes sense, let's try like this

Feb 20 2023, 8:57 PM

Feb 19 2023

val_packett.cool updated the diff for D38675: open.2: describe O_RESOLVE_BENEATH errors correctly.

Hopefully more clear this way?

Feb 19 2023, 9:05 PM
val_packett.cool added reviewers for D38675: open.2: describe O_RESOLVE_BENEATH errors correctly: manpages, Contributor Reviews (src), kib.
Feb 19 2023, 8:20 PM
val_packett.cool requested review of D38675: open.2: describe O_RESOLVE_BENEATH errors correctly.
Feb 19 2023, 8:18 PM
val_packett.cool added inline comments to D38351: [RFC/Proposal] Mechanism for in-kernel AT_FDCWD substitution with provided FD for oblivious sandboxing with Capsicum.
Feb 19 2023, 8:03 PM

Feb 12 2023

val_packett.cool added inline comments to D26836: linsysfs: add drm render node.
Feb 12 2023, 12:59 AM

Feb 10 2023

val_packett.cool accepted D38497: specialfd: Extend interface to support many fds.
Feb 10 2023, 9:49 PM
val_packett.cool added a comment to D38497: specialfd: Extend interface to support many fds.

I couldn't figure out a good way to generalize the falloc_noinstall/finstall/fdrop calls since the finstall needs fflags that are unique per special fd. I could move falloc_noinstall and fdrop into sys___specialfd(), I believe.

Feb 10 2023, 9:48 PM
val_packett.cool added a comment to D38497: specialfd: Extend interface to support many fds.

Wait wait wait… if we decided not to put gettime/settime here, to keep it as an interface only for creating various kinds of descriptors, why are we still going to duplicate the falloc_noinstall/finstall/fdrop dance across the individual functions for each descriptor kind?

Feb 10 2023, 9:37 PM
val_packett.cool added a comment to D38459: timerfd: Add native support for Linux's timerfd.
In D38459#875880, @kib wrote:

I suggest to add ioctl's to perform the ops on the descriptor, instead of filling the syscall table with more one-purpose entries.

Feb 10 2023, 5:15 PM · linuxkpi, Linux Emulation

Feb 9 2023

val_packett.cool added a comment to D38459: timerfd: Add native support for Linux's timerfd.

One wrinkle that I can see is that timerfd lets you specify a clock ID, but this implementation doesn't really do anything with it...

Feb 9 2023, 8:16 PM · linuxkpi, Linux Emulation
val_packett.cool added a comment to D38459: timerfd: Add native support for Linux's timerfd.

just implement these to as syscalls leaving __specialfd for descriptor creation

Feb 9 2023, 7:09 PM · linuxkpi, Linux Emulation
val_packett.cool added inline comments to D38445: tzcode: Resurrect tzsetwall(3) with a deprecation warning..
Feb 9 2023, 6:12 AM
val_packett.cool abandoned D38409: tzcode: garbage collect references to tzsetwall.

sure, D38445 LGTM

Feb 9 2023, 6:09 AM

Feb 7 2023

val_packett.cool abandoned D38389: Fix building the ia32 vDSO with --no-undefined-version.

ok, let's go with D38392

Feb 7 2023, 1:35 AM
val_packett.cool accepted D38392: amd64 ia32 vdso: always define some __vdso_ symbols.
Feb 7 2023, 1:34 AM

Feb 6 2023

val_packett.cool updated the diff for D32879: ext2fs: extract crc16 into sys/crc16.h.

Remove $FreeBSD$ tags, add header include to the .c file to fix missing-prototype

Feb 6 2023, 9:23 PM
val_packett.cool updated the summary of D38409: tzcode: garbage collect references to tzsetwall.
Feb 6 2023, 8:14 PM
val_packett.cool requested review of D38409: tzcode: garbage collect references to tzsetwall.
Feb 6 2023, 8:13 PM
val_packett.cool updated the summary of D38408: xlocale: garbage collect references to strtoq_l/strtouq_l.
Feb 6 2023, 7:48 PM
val_packett.cool requested review of D38408: xlocale: garbage collect references to strtoq_l/strtouq_l.
Feb 6 2023, 7:47 PM
val_packett.cool added inline comments to D38407: arpa: garbage collect ns_newmsg/ns_rdata decls.
Feb 6 2023, 7:16 PM
val_packett.cool updated the summary of D38407: arpa: garbage collect ns_newmsg/ns_rdata decls.
Feb 6 2023, 7:14 PM
val_packett.cool requested review of D38407: arpa: garbage collect ns_newmsg/ns_rdata decls.
Feb 6 2023, 7:13 PM
val_packett.cool added a comment to D28703: Allow sysctl hw.machine/hw.machine_arch in capability mode.

Do you have a public Git branch somewhere that I can fetch your changes from?

Feb 6 2023, 6:50 PM
val_packett.cool added inline comments to D26836: linsysfs: add drm render node.
Feb 6 2023, 6:26 PM
val_packett.cool retitled D38389: Fix building the ia32 vDSO with --no-undefined-version from Fix building the ia32 vDSO with LLVM binutils to Fix building the ia32 vDSO with --no-undefined-version.
Feb 6 2023, 6:49 AM
val_packett.cool added a comment to D38389: Fix building the ia32 vDSO with --no-undefined-version.

btw, what toggles the error is --(no-)undefined-version, no became the default. It seems difficult to make *everything* work with --no-undefined-version, but this was the only thing in the kernel.

Feb 6 2023, 6:49 AM
val_packett.cool updated the diff for D34248: LinuxKPI: return an address string in pci_name.

Rebase after D38222

Feb 6 2023, 3:19 AM · linuxkpi
val_packett.cool added a comment to D38389: Fix building the ia32 vDSO with --no-undefined-version.

Yes, it has failed. I wouldn't be that bothered with a little warning :)

Feb 6 2023, 3:12 AM

Feb 5 2023

val_packett.cool updated the diff for D34248: LinuxKPI: return an address string in pci_name.

Rebased. Ping!

Feb 5 2023, 9:08 PM · linuxkpi
val_packett.cool updated the summary of D34248: LinuxKPI: return an address string in pci_name.
Feb 5 2023, 9:05 PM · linuxkpi
val_packett.cool edited P538 D34248 format-patch.
Feb 5 2023, 9:01 PM
val_packett.cool updated the summary of D32879: ext2fs: extract crc16 into sys/crc16.h.
Feb 5 2023, 9:00 PM
val_packett.cool updated the diff for D32879: ext2fs: extract crc16 into sys/crc16.h.

rebased / author name changed / etc. (dang it's been a year)

Feb 5 2023, 8:59 PM
val_packett.cool updated the diff for D28703: Allow sysctl hw.machine/hw.machine_arch in capability mode.

rebased (bye bye MIPS \o/). ping!

Feb 5 2023, 8:54 PM
val_packett.cool updated the summary of D26836: linsysfs: add drm render node.
Feb 5 2023, 8:50 PM
val_packett.cool updated the diff for D26836: linsysfs: add drm render node.

rebased patch, no functional changes. ping!

Feb 5 2023, 8:50 PM
val_packett.cool updated the summary of D28704: md: check uid when non-root users detach/resize the mds.
Feb 5 2023, 8:48 PM
val_packett.cool updated the diff for D28704: md: check uid when non-root users detach/resize the mds.

rebased patch, no changes

Feb 5 2023, 8:48 PM
val_packett.cool updated the summary of D38389: Fix building the ia32 vDSO with --no-undefined-version.
Feb 5 2023, 5:00 PM
val_packett.cool requested review of D38389: Fix building the ia32 vDSO with --no-undefined-version.
Feb 5 2023, 4:53 PM

Feb 4 2023

val_packett.cool abandoned D23043: rtld-elf: Fix loading libraries with ORIGIN flag (like LLVM) via LD_LIBRARY_PATH_FDS.
Feb 4 2023, 8:32 PM · capsicum
val_packett.cool updated the summary of D21746: acpi_cros_kblt: New driver for Chromebook keyboard backlight control.
Feb 4 2023, 7:13 AM
val_packett.cool updated the diff for D21746: acpi_cros_kblt: New driver for Chromebook keyboard backlight control.

Add man page and sys/conf/files entry

Feb 4 2023, 7:13 AM
val_packett.cool updated the summary of D21612: acpi_cros_tbmc: New driver for Chromebook Tablet Mode Switch.
Feb 4 2023, 7:06 AM
val_packett.cool updated the diff for D21612: acpi_cros_tbmc: New driver for Chromebook Tablet Mode Switch.

update via git-arc

Feb 4 2023, 7:04 AM
val_packett.cool updated the diff for D21612: acpi_cros_tbmc: New driver for Chromebook Tablet Mode Switch.
Feb 4 2023, 6:49 AM
val_packett.cool updated the diff for D21612: acpi_cros_tbmc: New driver for Chromebook Tablet Mode Switch.

oops, also don't add $FreeBSD$ to new files

Feb 4 2023, 6:43 AM
val_packett.cool updated the diff for D21612: acpi_cros_tbmc: New driver for Chromebook Tablet Mode Switch.

Added a manpage and a files entry for building into the kernel

Feb 4 2023, 6:22 AM

Feb 3 2023

val_packett.cool added a comment to D38351: [RFC/Proposal] Mechanism for in-kernel AT_FDCWD substitution with provided FD for oblivious sandboxing with Capsicum.

Are you sure this patch is correctly generated?
I know that you said you want the review of the general idea, but still..

Feb 3 2023, 5:21 PM

Feb 2 2023

val_packett.cool updated the diff for D38351: [RFC/Proposal] Mechanism for in-kernel AT_FDCWD substitution with provided FD for oblivious sandboxing with Capsicum.

added patch context

Feb 2 2023, 7:28 AM
val_packett.cool requested review of D38351: [RFC/Proposal] Mechanism for in-kernel AT_FDCWD substitution with provided FD for oblivious sandboxing with Capsicum.
Feb 2 2023, 7:27 AM
val_packett.cool updated val_packett.cool.
Feb 2 2023, 7:12 AM

Jan 14 2023

val_packett.cool updated val_packett.cool.
Jan 14 2023, 10:55 PM
bofh renamed val_packett.cool from greg_unrelenting.technology to val_packett.cool.
Jan 14 2023, 5:44 PM
val_packett.cool updated val_packett.cool.
Jan 14 2023, 5:37 PM

Jan 4 2023

val_packett.cool requested review of D37945: copyright: chase my name and email change.
Jan 4 2023, 8:10 PM

Oct 8 2022

val_packett.cool updated val_packett.cool.
Oct 8 2022, 2:31 PM