jonathan (Jonathan Anderson)
User

Projects

User Details

User Since
May 9 2014, 10:57 PM (150 w, 6 d)

Recent Activity

Wed, Mar 29

jonathan accepted D10149: DTrace Audit Provider Prototype.

LGTM

Wed, Mar 29, 7:51 PM
jonathan added a comment to D10149: DTrace Audit Provider Prototype.

Some of these questions may not make sense to those thoroughly versed in DTrace, but I'm new in this corner of the world. :)

Wed, Mar 29, 1:56 AM

Fri, Mar 17

jonathan updated the diff for D9030: First attempt at a new fexecve() variant that allows the interpreter to be specified explicitly with a file descriptor..
  • Fix MLINKS for fldexec.
Fri, Mar 17, 6:13 PM
jonathan updated the diff for D9030: First attempt at a new fexecve() variant that allows the interpreter to be specified explicitly with a file descriptor..

Rebase onto -CURRENT

Fri, Mar 17, 5:04 PM
jonathan updated the diff for D9030: First attempt at a new fexecve() variant that allows the interpreter to be specified explicitly with a file descriptor..
  • Remove auto-generated files from diff.
Fri, Mar 17, 4:57 PM

Sat, Mar 11

jonathan added inline comments to D9853: Exclude assembly files from LLVM IR Builds.
Sat, Mar 11, 3:12 AM

Jan 3 2017

jonathan retitled D9030: First attempt at a new fexecve() variant that allows the interpreter to be specified explicitly with a file descriptor. from to First attempt at a new fexecve() variant that allows the interpreter to be specified explicitly with a file descriptor..
Jan 3 2017, 2:34 PM

Nov 22 2016

jonathan added a comment to D8397: Add devd rule for Elantech touchscreens..

usbconfig output is here: http://pastebin.com/iqJix3h2

Nov 22 2016, 3:14 PM
jonathan added a reviewer for D8397: Add devd rule for Elantech touchscreens.: hselasky.
Nov 22 2016, 2:41 PM
jonathan added a comment to D8439: New port: devel/llbuild.

I think this might address all of the comments properly now?

Nov 22 2016, 2:32 PM
jonathan updated the diff for D8439: New port: devel/llbuild.
  • New port: devel/llbuild
  • Change post-stage to post-install for docs.
  • Fix typo: "swift-llbuild", not "switch-llbuild"!
  • Add the llbuild binary to the build and plist.
  • Fix licensing: use ports' multi-license support.
Nov 22 2016, 2:31 PM

Nov 10 2016

jonathan added inline comments to D8439: New port: devel/llbuild.
Nov 10 2016, 5:33 PM

Nov 5 2016

jonathan updated the diff for D8439: New port: devel/llbuild.
  • Fix typo: "swift-llbuild", not "switch-llbuild"!
Nov 5 2016, 6:39 AM
jonathan added inline comments to D8439: New port: devel/llbuild.
Nov 5 2016, 6:37 AM
jonathan updated the diff for D8439: New port: devel/llbuild.
  • Change post-stage to post-install for docs.
Nov 5 2016, 6:37 AM

Nov 4 2016

jonathan retitled D8439: New port: devel/llbuild from to New port: devel/llbuild.
Nov 4 2016, 12:34 AM

Nov 1 2016

jonathan committed rS308181: Add rules to build LLVM IR binaries and libraries..
Add rules to build LLVM IR binaries and libraries.
Nov 1 2016, 9:28 PM
jonathan closed D8388: Add rules to build LLVM IR binaries and libraries. by committing rS308181: Add rules to build LLVM IR binaries and libraries..
Nov 1 2016, 9:28 PM
jonathan added a comment to D8388: Add rules to build LLVM IR binaries and libraries..

Thanks for the comments: I think I've managed to address them.

Nov 1 2016, 12:28 AM
jonathan updated the diff for D8388: Add rules to build LLVM IR binaries and libraries..
  • Add {BC,LL}OBJS to bsd.lib.mk's CLEANFILES.
  • Remove redundant C++/non-C++ logic.
  • Improve whitespace consistency.
Nov 1 2016, 12:27 AM

Oct 31 2016

jonathan retitled D8397: Add devd rule for Elantech touchscreens. from to Add devd rule for Elantech touchscreens..
Oct 31 2016, 12:35 PM
jonathan retitled D8388: Add rules to build LLVM IR binaries and libraries. from to Add rules to build LLVM IR binaries and libraries..
Oct 31 2016, 1:42 AM

Oct 24 2016

jonathan added a comment to D8326: Use upstream suffixes for LLVM IR.

The distinction between .bc and .bco was actually purposeful. The next step in the process is to add IR build rules for whole programs, and then we might end up with conflicts between the IR file that's analogous to cp.o and the IR file that's analogous to the cp binary (i.e., the result of llvm-link). So, we used .bco as the bitcode suffix that's analogous to .o (much like .pico is the PIC suffix for .o files).

Oct 24 2016, 1:56 AM

Oct 20 2016

jonathan closed D4339: Add suffix rules for LLVM IR and bitcode. by committing rS307676: Add make rules to build LLVM IR from C/C++ sources..
Oct 20 2016, 3:14 PM
jonathan committed rS307676: Add make rules to build LLVM IR from C/C++ sources..
Add make rules to build LLVM IR from C/C++ sources.
Oct 20 2016, 3:14 PM

Oct 19 2016

jonathan added a comment to D4339: Add suffix rules for LLVM IR and bitcode..

This is a much simpler change after rS307075. How does it look to everyone now?

Oct 19 2016, 11:51 PM

Oct 12 2016

jonathan accepted D8133: abort in srandomdev if kern.arandom sysctl fails.

Looks like a good idea to me. Perhaps it's worthy of a comment explaining why we use abort() within a library? It could contain the same text as at the top of this review, but it might be a slightly surprising thing to discover if you haven't been party to the review.

Oct 12 2016, 1:27 AM
jonathan updated the diff for D4339: Add suffix rules for LLVM IR and bitcode..

Rework this change based on rS307075 (suffix rule files).

Oct 12 2016, 1:22 AM
jonathan committed rS307075: Extract suffix rules into bsd.suffixes[-posix].mk..
Extract suffix rules into bsd.suffixes[-posix].mk.
Oct 12 2016, 12:43 AM
jonathan closed D6805: Extract suffix rules into bsd.suffixes[-posix].mk. by committing rS307075: Extract suffix rules into bsd.suffixes[-posix].mk..
Oct 12 2016, 12:43 AM

Oct 11 2016

jonathan updated the diff for D6805: Extract suffix rules into bsd.suffixes[-posix].mk..
  • Merge 'origin/master' into arcpatch-D6805
Oct 11 2016, 7:34 PM

Oct 7 2016

jonathan added a comment to D8110: Allow some dotdot lookups in capability mode..

A fairly cursory look didn't turn up any obvious problems for me, but I would like to take a deeper look over the next few days.

Oct 7 2016, 1:23 AM · capsicum
jonathan abandoned D8127: Build with GUI enabled by default..

Thanks for responding... sounds like a tough problem until we make the leap to Python 3.

Oct 7 2016, 1:06 AM

Oct 6 2016

jonathan added a comment to D6805: Extract suffix rules into bsd.suffixes[-posix].mk..

Indeed, I did have that exp-run done:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210331

Oct 6 2016, 1:41 AM
jonathan added a comment to D6805: Extract suffix rules into bsd.suffixes[-posix].mk..

Not that we're well clear of code freezes on -CURRENT (and I think that I've addressed @bdrewery's comments), are folks ok with me committing this?

Oct 6 2016, 12:37 AM

Oct 3 2016

jonathan accepted D8077: libc arc4_stir: use only kern.arandom sysctl.

Very nice.

Oct 3 2016, 1:05 PM
jonathan added a watcher for DTrace: jonathan.
Oct 3 2016, 12:54 AM
jonathan added a watcher for chromium: jonathan.
Oct 3 2016, 12:53 AM
jonathan accepted D1345: Capsicum support for jot(1).

LGTM

Oct 3 2016, 12:52 AM
jonathan accepted D8076: Capsicum-ize lam(1).

Looks good to me in principle; see inline comment above.

Oct 3 2016, 12:48 AM
jonathan retitled D8127: Build with GUI enabled by default. from to Build with GUI enabled by default..
Oct 3 2016, 12:37 AM

Sep 30 2016

jonathan added a reviewer for D8013: Capsicum helpers: jonathan.
Sep 30 2016, 2:19 PM

Sep 27 2016

jonathan retitled D8043: Patch vimdot to use /usr/local from to Patch vimdot to use /usr/local.
Sep 27 2016, 12:27 AM

Sep 26 2016

jonathan added a reviewer for D8015: Make kern.hostname and friends readable in capability mode: rwatson.
Sep 26 2016, 5:21 PM
jonathan accepted D8015: Make kern.hostname and friends readable in capability mode.

I think that these are all fine to make readable, for the same reason that the hostname is ok: allowing information to "leak" in a way that enables more software to use Capsicum sandboxing is a net win. If we wanted to obscure the host UUID then we should also be hiding anything that could be used to identify the machine, which seems distinctly unhelpful in our overall goal of World Domination (tm).

Sep 26 2016, 5:21 PM
jonathan accepted D8000: kern_mib: Allow kern.hostname in Capsicum capability sandbox.

I'm fine with exposing the hostname here -- the goal of Capsicum has always been to be pragmatic about getting software running where it doesn't violate isolation properties. You could argue that this is an information leak and/or might cause problems for deterministic replay-style applications of Capsicum -- but I'd rather we had more code working in a sandboxing. :-)

Sep 26 2016, 5:14 PM

Sep 22 2016

jonathan closed D7879: Switch libpololu-avr port to GitHub sources. by committing rP422600: Switch libpololu-avr port to GitHub sources..
Sep 22 2016, 11:19 AM
jonathan committed rP422600: Switch libpololu-avr port to GitHub sources..
Switch libpololu-avr port to GitHub sources.
Sep 22 2016, 11:19 AM
jonathan committed rP422599: New port: devel/libgrading Library for grading C/C++ assignments.
New port: devel/libgrading Library for grading C/C++ assignments
Sep 22 2016, 11:15 AM
jonathan closed D7956: Add a new port devel/libgrading. by committing rP422599: New port: devel/libgrading Library for grading C/C++ assignments.
Sep 22 2016, 11:15 AM

Sep 21 2016

jonathan accepted D7724: Copy capabilities to new fd after accept(2)..

Agreed: this change makes perfect sense to me after rS305756.

Sep 21 2016, 7:27 PM
jonathan updated the diff for D7879: Switch libpololu-avr port to GitHub sources..
  • Simplify {BUILD,RUN}_DEPENDS.
Sep 21 2016, 7:21 PM
jonathan added inline comments to D7956: Add a new port devel/libgrading..
Sep 21 2016, 7:11 PM
jonathan updated the diff for D7956: Add a new port devel/libgrading..
  • Remove superfluous GH_PROJECT variable.
  • Move GitHub details to below LIB_DEPENDS.
  • Clean up COMMENT to satisfy portlint -A.
  • Change pkg-plist to PLIST_FILES.
Sep 21 2016, 7:10 PM

Sep 19 2016

jonathan added a comment to D7734: First pass at capsicumizing file(1).

I think I'd be more comfortable if the bug fixes were committed separately from the Capsicum changes (making everything easier to upstream?) and if the Capsicum-specific stuff could be refactored out as much as possible to reduce the in-line #ifdef content. In particular, it would be nice if there could be struct sandbox or the like to capture all of the additional state required by Capsicum, and the contents of that structure could be different on FreeBSD, OpenBSD, etc. If there were a function called start_sandbox(struct sandbox *sbp) or the like, possibly together with a set_flags(int fd, struct sandbox *) or something, it would allow a nice, fair comparison between the Capsicum and Pledge LoC.

Sep 19 2016, 9:37 PM
jonathan added a comment to D7773: Capsicum-ize brandelf.
In D7773#164148, @cem wrote:

I'm not a fan of introducing additional forks into otherwise straightforward programs. I think we might introduce more bugs that way than we mitigate with capsicum. I'd rather just allocate a list or array and preopen all inputs.

Sep 19 2016, 9:29 PM
jonathan retitled D7956: Add a new port devel/libgrading. from to Add a new port devel/libgrading..
Sep 19 2016, 7:02 PM
jonathan added a comment to D7879: Switch libpololu-avr port to GitHub sources..

Updated port to Fix All The Things (TM)

Sep 19 2016, 4:54 PM
jonathan updated the diff for D7879: Switch libpololu-avr port to GitHub sources..
  • Remove PREFIX hack from libpolou-avr.
  • Add RUN_DEPENDS to libpololu-avr.
Sep 19 2016, 4:53 PM

Sep 13 2016

jonathan added inline comments to D7879: Switch libpololu-avr port to GitHub sources..
Sep 13 2016, 4:49 PM
jonathan added inline comments to D7879: Switch libpololu-avr port to GitHub sources..
Sep 13 2016, 4:42 PM
jonathan added a reviewer for D7879: Switch libpololu-avr port to GitHub sources.: portmgr.
Sep 13 2016, 2:19 PM
jonathan retitled D7879: Switch libpololu-avr port to GitHub sources. from to Switch libpololu-avr port to GitHub sources..
Sep 13 2016, 2:16 PM

Sep 1 2016

jonathan edited this Badge.
Sep 1 2016, 3:02 PM
jonathan accepted D7723: x11/nvidia-driver: Update to 367.44 (PR #212287).

Works for me.

Sep 1 2016, 3:01 PM

Aug 26 2016

jonathan added a comment to D7569: x11/nvidia-driver: Update to 367.35.

Works for me with a variant of 11-STABLE when I use nvidia-modeset. If I just try to use kldload nvidia by itself, however, I get strange artifacts and no visible X.

Aug 26 2016, 1:25 PM

Jul 28 2016

jonathan added a comment to D2808: Implement O_BENEATH flag for openat(2)..

Address @mjg 's point about EPERM.

Jul 28 2016, 2:26 PM
jonathan updated the diff for D2808: Implement O_BENEATH flag for openat(2)..
  • MFC r303406
  • Treat EPERM slightly less specially.
Jul 28 2016, 2:22 PM

Jul 27 2016

jonathan closed D6339: Update to v151002. by committing rP419184: Update to v151002..
Jul 27 2016, 4:11 PM
jonathan committed rP419184: Update to v151002..
Update to v151002.
Jul 27 2016, 4:11 PM
jonathan committed rP419183: Remove `Requires.private: zlib` on FreeBSD <10..
Remove `Requires.private: zlib` on FreeBSD <10.
Jul 27 2016, 4:08 PM
jonathan closed D4359: Patch tcl pkgconf file: remove zlib Requirement. by committing rP419183: Remove `Requires.private: zlib` on FreeBSD <10..
Jul 27 2016, 4:08 PM
jonathan added a reviewer for D6339: Update to v151002.: portmgr.
Jul 27 2016, 3:01 PM
jonathan abandoned D7291: Allow suppression of --no-fatal-warnings..

This seems to have been obviated by rS303274.

Jul 27 2016, 3:00 PM

Jul 22 2016

jonathan added a comment to D7291: Allow suppression of --no-fatal-warnings..

Of course, if we wanted to ignore the --no-fatal-warnings flag altogether, we could just do:

Jul 22 2016, 10:03 PM
jonathan retitled D7291: Allow suppression of --no-fatal-warnings. from to Allow suppression of --no-fatal-warnings..
Jul 22 2016, 9:59 PM

Jul 19 2016

jonathan updated the diff for D4359: Patch tcl pkgconf file: remove zlib Requirement..
  • switch to Makefile-based patching with OSVERSION
Jul 19 2016, 6:01 PM

Jun 17 2016

jonathan retitled D6883: Add x11 and xcb to redshift's USE_XORG. from to Add x11 and xcb to redshift's USE_XORG..
Jun 17 2016, 5:45 PM
jonathan updated the diff for D6805: Extract suffix rules into bsd.suffixes[-posix].mk..
  • Extract suffix rules into bsd.suffixes[-posix].mk.
  • Add bsd.suffixes[-posix].mk to share/mk/Makefile.
  • Don't clear suffix rules in bsd.lib.mk.
Jun 17 2016, 12:40 AM

Jun 16 2016

jonathan updated the diff for D6805: Extract suffix rules into bsd.suffixes[-posix].mk..
  • Move .SUFFIXES definitions into suffix rule files, too.
Jun 16 2016, 11:09 PM
jonathan added a comment to D6805: Extract suffix rules into bsd.suffixes[-posix].mk..

Thanks, I've added those to share/mk/Makefile and will request an exp-run.

Jun 16 2016, 6:14 PM
jonathan updated the diff for D6805: Extract suffix rules into bsd.suffixes[-posix].mk..
  • Add bsd.suffixes[-posix].mk to share/mk/Makefile.
Jun 16 2016, 6:14 PM

Jun 11 2016

jonathan added inline comments to D6805: Extract suffix rules into bsd.suffixes[-posix].mk..
Jun 11 2016, 2:18 AM
jonathan retitled D6805: Extract suffix rules into bsd.suffixes[-posix].mk. from to Extract suffix rules into bsd.suffixes[-posix].mk..
Jun 11 2016, 1:28 AM

Jun 8 2016

jonathan updated the diff for D6616: Add script to parse makefile include graph..
  • Generalize the metadata we can look for.
  • Don't output None attributes.
  • Normalize paths.
  • Give re-definitions a different shape from definitions.
  • Add more filename sanitizing.
  • Add flags to filter singletons and unconnected components.
  • Print the total number of files being parsed.
Jun 8 2016, 9:11 PM

May 31 2016

jonathan retitled D6664: Allow rc.initdiskless to find configuration in subdirectories. from to Allow rc.initdiskless to find configuration in subdirectories..
May 31 2016, 7:16 PM

May 28 2016

jonathan abandoned D5547: Fix shebang lines in DTrace Toolkit scripts. Perl, on FreeBSD, is no longer found at /usr/bin/perl. This commit fixes three shebang lines from the DTrace Toolkit to use /usr/bin/env instead..

Obviated by rS300226.

May 28 2016, 1:23 AM
jonathan retitled D6616: Add script to parse makefile include graph. from to Add script to parse makefile include graph..
May 28 2016, 1:22 AM

May 15 2016

jonathan closed D6340: Update to v2.6. by committing rP415268: Update to v2.6 and fix RUN_DEPENDS..
May 15 2016, 5:17 PM
jonathan committed rP415268: Update to v2.6 and fix RUN_DEPENDS..
Update to v2.6 and fix RUN_DEPENDS.
May 15 2016, 5:17 PM

May 14 2016

jonathan added a comment to D4359: Patch tcl pkgconf file: remove zlib Requirement..

Sorry, I slightly let the ball drop here. How do I create a patch that only applies on one major version?

May 14 2016, 4:10 PM
jonathan added a comment to D5547: Fix shebang lines in DTrace Toolkit scripts. Perl, on FreeBSD, is no longer found at /usr/bin/perl. This commit fixes three shebang lines from the DTrace Toolkit to use /usr/bin/env instead..

Ping?

May 14 2016, 3:51 PM
jonathan abandoned D4361: Add MAKE_JOBS_UNSAFE to devel/libdistance..

This was done independently by @gahr in rP412743.

May 14 2016, 3:50 PM
jonathan accepted D5522: Chain-loading loader or re-loading loader.conf.

So, I can't not approve... :)

May 14 2016, 3:43 PM
jonathan updated the diff for D6340: Update to v2.6..
  • Update to v2.6.
  • Add PyQt RUN_DEPENDS
May 14 2016, 3:32 PM

May 13 2016

jonathan added a comment to D6340: Update to v2.6..

I will now! :)

May 13 2016, 8:54 PM
jonathan committed rP415154: Fix "need root" logic for PORT_DBDIR..
Fix "need root" logic for PORT_DBDIR.
May 13 2016, 8:53 PM
jonathan closed D6349: Fix "need root" logic for PORT_DBDIR. by committing rP415154: Fix "need root" logic for PORT_DBDIR..
May 13 2016, 8:53 PM
jonathan committed rP415151: Update to 0.6.1.
Update to 0.6.1
May 13 2016, 8:33 PM
jonathan closed D6350: Update to 0.6.1 by committing rP415151: Update to 0.6.1.
May 13 2016, 8:33 PM