jonathan (Jonathan Anderson)
User

Projects

User Details

User Since
May 9 2014, 10:57 PM (223 w, 1 d)

Recent Activity

Jun 18 2018

jonathan added a comment to D15762: Add an NSFW option to x11/xscreensaver.

Thanks very much!

Jun 18 2018, 2:22 PM
jonathan committed rP472691: Add devd rule for Elantech touchscreens..
Add devd rule for Elantech touchscreens.
Jun 18 2018, 1:26 PM
jonathan closed D8397: Add devd rule for Elantech touchscreens..
Jun 18 2018, 1:26 PM

Jun 11 2018

jonathan added a comment to D7734: First pass at capsicumizing file(1).

So... should this revision be abandoned in favour of an approach that uses the new enable_sandbox_{basic,full}() functions?

Jun 11 2018, 7:22 PM
jonathan added a comment to D8397: Add devd rule for Elantech touchscreens..

Ping?

Jun 11 2018, 7:17 PM
jonathan created D15762: Add an NSFW option to x11/xscreensaver.
Jun 11 2018, 7:08 PM

Jun 6 2018

jonathan added inline comments to D14407: Introduce cap_fileargs..
Jun 6 2018, 10:47 PM

Feb 28 2018

jonathan abandoned D12733: New port: devel/capnproto.

Figuring out the 10.x compatibility isn't worth it for me any more, as the project I was thinking of using Cap'n Proto for has moved on.

Feb 28 2018, 6:41 PM
jonathan abandoned D14275: Add pkg_bootstrap firstboot script..

So, @cperciva , do you mind if I pull your firstboot-pkgs work into the base system? This would help tidy up a VM-building workflow that I'm using in which I can't run pkg(8) on the VM-building host.

Feb 28 2018, 6:40 PM

Feb 9 2018

jonathan added a comment to D14275: Add pkg_bootstrap firstboot script..

I wasn't aware of that port, no... thanks for pointing it out! I'll definitely take a look at that and see if it might make more sense to pull that into base than to duplicate the work.

Feb 9 2018, 1:14 PM
jonathan committed rP461285: Update neo4j to v3.3.2..
Update neo4j to v3.3.2.
Feb 9 2018, 2:40 AM
jonathan closed D14260: Update neo4j to v3.3.2..
Feb 9 2018, 2:40 AM
jonathan added a comment to D14260: Update neo4j to v3.3.2..

Thanks!

Feb 9 2018, 2:40 AM
jonathan added reviewers for D14275: Add pkg_bootstrap firstboot script.: bapt, jmg, cperciva.
Feb 9 2018, 2:37 AM
jonathan created D14275: Add pkg_bootstrap firstboot script..
Feb 9 2018, 2:32 AM

Feb 8 2018

jonathan added a reviewer for D14260: Update neo4j to v3.3.2.: crees.
Feb 8 2018, 2:44 PM

Feb 7 2018

jonathan added a reviewer for D14260: Update neo4j to v3.3.2.: Contributor Reviewers (ports).
Feb 7 2018, 11:35 PM
jonathan created D14260: Update neo4j to v3.3.2..
Feb 7 2018, 11:34 PM

Feb 2 2018

jonathan committed rP460660: New port: x11-themes/arc-gruvbox-theme.
New port: x11-themes/arc-gruvbox-theme
Feb 2 2018, 1:04 AM
jonathan closed D14134: New port: x11-themes/arc-gruvbox-theme.
Feb 2 2018, 1:04 AM

Jan 31 2018

jonathan updated the diff for D14134: New port: x11-themes/arc-gruvbox-theme.
  • Clean up as per review comments.
Jan 31 2018, 2:02 PM

Jan 30 2018

jonathan added a reviewer for D14134: New port: x11-themes/arc-gruvbox-theme: Contributor Reviewers (ports).
Jan 30 2018, 6:29 PM
jonathan created D14134: New port: x11-themes/arc-gruvbox-theme.
Jan 30 2018, 6:29 PM

Jan 25 2018

jonathan accepted D14051: Remove K&R stuff: never use it in new code..
Jan 25 2018, 4:13 PM

Dec 12 2017

jonathan committed rP456130: Update devel/llbuild to SNAPSHOT-2017-12-10..
Update devel/llbuild to SNAPSHOT-2017-12-10.
Dec 12 2017, 1:16 PM
jonathan closed D13451: Update devel/llbuild to SNAPSHOT-2017-12-10..
Dec 12 2017, 1:16 PM

Dec 11 2017

jonathan added a comment to D12719: Add WITH_LLVM_BITCODE option..

Ping?

Dec 11 2017, 7:01 PM
jonathan created D13451: Update devel/llbuild to SNAPSHOT-2017-12-10..
Dec 11 2017, 7:01 PM

Oct 26 2017

jonathan committed rP452958: New port: devel/llbuild.
New port: devel/llbuild
Oct 26 2017, 10:35 PM
jonathan closed D8439: New port: devel/llbuild.
Oct 26 2017, 10:34 PM

Oct 21 2017

jonathan added a comment to D12733: New port: devel/capnproto.

Builded fine in 11-[amd64|i386] and CURRENT-[amd64|i386].
Problem here in 10-[amd64|i386].

Logs are here:
10-amd64
10-i386

Oct 21 2017, 3:47 AM

Oct 20 2017

jonathan added a comment to D12733: New port: devel/capnproto.

[...] Have you done a test build in Poudriere?

Oct 20 2017, 3:39 PM
jonathan updated the summary of D12733: New port: devel/capnproto.
Oct 20 2017, 3:38 PM
jonathan committed rP452495: New port: devel/py-cdg.
New port: devel/py-cdg
Oct 20 2017, 12:01 AM
jonathan closed D11677: New port: devel/py-cdg.
Oct 20 2017, 12:01 AM

Oct 19 2017

jonathan updated the diff for D12733: New port: devel/capnproto.
  • Break out version prefix.
Oct 19 2017, 11:57 PM
jonathan added a comment to D12733: New port: devel/capnproto.

Where's the pkg-plist?

Oct 19 2017, 11:54 PM
jonathan updated the diff for D12733: New port: devel/capnproto.
  • Commit missing pkg-plist
  • Remove MASTER_SITES.
  • Replace USES+= with USES=.
Oct 19 2017, 11:52 PM
jonathan added a reviewer for D12733: New port: devel/capnproto: Contributor Reviewers (ports).
Oct 19 2017, 10:40 PM
jonathan created D12733: New port: devel/capnproto.
Oct 19 2017, 10:39 PM
jonathan added inline comments to D8439: New port: devel/llbuild.
Oct 19 2017, 10:18 PM
jonathan updated the diff for D8439: New port: devel/llbuild.
  • De-uglify version number using DISTVERSIONPREFIX.
Oct 19 2017, 10:16 PM

Oct 18 2017

jonathan added a comment to D9853: Exclude assembly files from LLVM IR Builds.

I think this may now be redundant in light of https://reviews.freebsd.org/D12701?

Oct 18 2017, 10:07 PM
jonathan updated the diff for D12719: Add WITH_LLVM_BITCODE option..
  • Add missing LLVM_IR_TYPE
Oct 18 2017, 3:02 PM
jonathan created D12719: Add WITH_LLVM_BITCODE option..
Oct 18 2017, 2:31 PM
jonathan closed D12701: Improve computation of {BC,LL}OBJS..
Oct 18 2017, 12:33 AM
jonathan committed rS324712: Improve computation of {BC,LL}OBJS..
Improve computation of {BC,LL}OBJS.
Oct 18 2017, 12:33 AM
jonathan committed rS324711: Improve logic of CLEANFILES+=${PROG_FULL}.{bc,ll}..
Improve logic of CLEANFILES+=${PROG_FULL}.{bc,ll}.
Oct 18 2017, 12:30 AM
jonathan closed D12703: Improve logic of CLEANFILES+=${PROG_FULL}.{bc,ll}..
Oct 18 2017, 12:30 AM
jonathan added a comment to D12701: Improve computation of {BC,LL}OBJS..
In D12701#263694, @sjg wrote:

Ok so apart from moving the definitions, the key improvement is suppressing .bco etc. for .asm ?

Oct 18 2017, 12:23 AM

Oct 17 2017

jonathan created D12703: Improve logic of CLEANFILES+=${PROG_FULL}.{bc,ll}..
Oct 17 2017, 4:41 PM
jonathan committed rS324695: Add LLVM IR libraries to CLEANFILES..
Add LLVM IR libraries to CLEANFILES.
Oct 17 2017, 4:30 PM
jonathan updated the diff for D12701: Improve computation of {BC,LL}OBJS..
  • Prefer += to = when computing {BC,LL}OBJS.
Oct 17 2017, 4:18 PM
jonathan created D12701: Improve computation of {BC,LL}OBJS..
Oct 17 2017, 4:09 PM

Sep 15 2017

jonathan added a comment to D12339: rename(2): document capability mode errors.
In D12339#255993, @cem wrote:

Er, why is rename / renameat with AT_FDCWD not allowed in capability mode?

Sep 15 2017, 2:23 PM

Sep 9 2017

jonathan added a comment to D11677: New port: devel/py-cdg.

Ok, I think that addresses the last of the reviewer comments?

Sep 9 2017, 5:15 PM
jonathan updated the test plan for D11677: New port: devel/py-cdg.
Sep 9 2017, 5:14 PM
jonathan added a comment to D8439: New port: devel/llbuild.

Ok, I think that's everything now?

Sep 9 2017, 5:09 PM
jonathan updated the diff for D8439: New port: devel/llbuild.
  • Move USES above USE_GITHUB.
  • Merge 'origin/master' into llbuild
Sep 9 2017, 1:51 PM
jonathan committed rS323365: Remove redundant source and object files..
Remove redundant source and object files.
Sep 9 2017, 1:18 PM
jonathan closed D12208: Remove redundant source, object files..
Sep 9 2017, 1:18 PM

Sep 1 2017

jonathan updated the diff for D8439: New port: devel/llbuild.
  • New port: devel/llbuild
  • Change post-stage to post-install for docs.
  • Fix typo: "swift-llbuild", not "switch-llbuild"!
  • Add the llbuild binary to the build and plist.
  • Fix licensing: use ports' multi-license support.
  • Fix license: ports tree calls "LLVM" "NCSA".
  • Update to use lit from llvm-devel
Sep 1 2017, 7:15 PM
jonathan added a comment to D8439: New port: devel/llbuild.

In this case, LICENSE_FILE describes the Apache license but it also describes which bits of the sources fall under different licenses. Under those conditions, does it make sense to keep?

Sep 1 2017, 7:15 PM
jonathan added a comment to D8397: Add devd rule for Elantech touchscreens..

No, sometimes the device use 0xff for some ID fields which means propritary driver. It might be better to match that than vendor/product.

Sep 1 2017, 6:44 PM
jonathan abandoned D6616: Add script to parse makefile include graph..
Sep 1 2017, 6:40 PM
jonathan updated the test plan for D11677: New port: devel/py-cdg.
Sep 1 2017, 6:27 PM
jonathan updated the diff for D11677: New port: devel/py-cdg.
  • Change an unnecessary '?=' to '='.
  • Uncomment PKGNAMEPREFIX as requested by sunpoet.
  • Update py-cdg to HEAD
Sep 1 2017, 6:26 PM
jonathan added reviewers for D12208: Remove redundant source, object files.: ngie, bdrewery, dim, peter.

Add reviewers who have touched these makefiles recently

Sep 1 2017, 6:11 PM
jonathan created D12208: Remove redundant source, object files..
Sep 1 2017, 6:08 PM

Aug 11 2017

jonathan added a comment to D11446: Update to neo4j v3.2.1..

Thanks very much: I've committed the patch as approved/accepted, but would certainly be happy to discuss the relative merits of moving things around (perhaps as a separate action?). I think there will be a tension between the "FreeBSD way" and the "Neo4j way", but... well, perhaps that's a conversation for another day/diff/review. :)

Aug 11 2017, 10:30 AM
jonathan committed rP447753: Update neo4j to v3.2.1..
Update neo4j to v3.2.1.
Aug 11 2017, 10:29 AM
jonathan closed D11446: Update to neo4j v3.2.1. by committing rP447753: Update neo4j to v3.2.1..
Aug 11 2017, 10:29 AM
jonathan updated the diff for D11677: New port: devel/py-cdg.
  • New port: devel/py-cdg
  • Address comments in Phab review
Aug 11 2017, 10:02 AM
jonathan added a comment to D11677: New port: devel/py-cdg.

Thanks very much for the feedback: I learned a lot about Python packaging!

Aug 11 2017, 9:30 AM

Aug 9 2017

jonathan committed rS322314: Add birthday information for jonathan@..
Add birthday information for jonathan@.
Aug 9 2017, 1:25 PM

Jul 20 2017

jonathan created D11677: New port: devel/py-cdg.
Jul 20 2017, 7:29 PM

Jul 5 2017

jonathan updated the diff for D11446: Update to neo4j v3.2.1..
  • Align neo4j.conf patch with previous patch.
  • Put databases in /var/db instead of $PREFIX/share.
Jul 5 2017, 12:05 PM

Jul 4 2017

jonathan updated the diff for D11446: Update to neo4j v3.2.1..
  • Update to use ${PREFIX}/etc as requested.
Jul 4 2017, 2:35 AM
jonathan added a comment to D11446: Update to neo4j v3.2.1..

Ok, that's fair enough: I'll check to make sure that this will work with config files in ${PREFIX}/etc. What is your view on the weird ${PREFIX}/libexec/bin/neo4j-* path with symlinks to /usr/local/bin? My patch (or at least my local version that I've since hacked up some more!) puts cypher-shell, neo4j-admin, etc., into ${PREFIX}/bin and avoids the symlinks entirely. I think this sounds compatible with your view?

Jul 4 2017, 2:05 AM

Jul 2 2017

jonathan added a comment to D11446: Update to neo4j v3.2.1..

Actually, we can simplify a lot of this patching if we follow the Neo4j convention of putting config stuff in somewhere like /usr/local/neo4j/conf instead of /usr/local/etc... thoughts?

Jul 2 2017, 11:36 AM
jonathan created D11446: Update to neo4j v3.2.1..
Jul 2 2017, 10:57 AM

Jun 7 2017

jonathan added inline comments to D10413: FreeBSD Project Associates.
Jun 7 2017, 4:11 PM

May 29 2017

jonathan added inline comments to D10826: Document direct execution mode for ld.so..
May 29 2017, 1:41 PM

May 28 2017

jonathan accepted D10826: Document direct execution mode for ld.so..

Some very small nits on which I would happily defer (well, except for the spelling one). Otherwise LGTM.

May 28 2017, 11:40 PM

May 18 2017

jonathan committed rS318432: Fix some nroff syntax in rtld.1..
Fix some nroff syntax in rtld.1.
May 18 2017, 12:32 AM

May 17 2017

jonathan committed rS318431: Allow rtld direct-exec to take a file descriptor..
Allow rtld direct-exec to take a file descriptor.
May 17 2017, 10:51 PM
jonathan closed D10751: Allow rtld direct-exec to take a file descriptor. by committing rS318431: Allow rtld direct-exec to take a file descriptor..
May 17 2017, 10:51 PM
jonathan updated the diff for D10751: Allow rtld direct-exec to take a file descriptor..
  • Restore tabs to print_args().
May 17 2017, 10:35 PM
jonathan added a comment to D10751: Allow rtld direct-exec to take a file descriptor..
In D10751#223329, @kib wrote:

For new functions in rtld, I use normal style(9), so rtld slowly migrates to proper indentation. For smaller changes to existing functions I do follow existing style of 4 spaces indent/2 spaces continuation.

May 17 2017, 10:31 PM
jonathan updated the diff for D10751: Allow rtld direct-exec to take a file descriptor..
  • Add a missing rtld_strerror()
  • Convert some _rtld_error() calls to rtld_printf().
  • Use four spaces for second-level indent.
  • Be clear about user- vs path-derived descriptor.
May 17 2017, 9:28 PM
jonathan added inline comments to D10751: Allow rtld direct-exec to take a file descriptor..
May 17 2017, 9:23 PM
jonathan added inline comments to D10751: Allow rtld direct-exec to take a file descriptor..
May 17 2017, 9:02 PM
jonathan updated the diff for D10751: Allow rtld direct-exec to take a file descriptor..
  • Remove some superfluous parentheses.
  • Remove redundant fstat(2) call.
May 17 2017, 9:02 PM
jonathan accepted D10775: Fix shebangs in devel/tesla.

LGTM. I'm also happy to fix this upstream: what should the Python shebang line be instead of #!/usr/bin/env python?

May 17 2017, 5:21 PM
jonathan added a comment to D10751: Allow rtld direct-exec to take a file descriptor..

Ok, I think I've addressed all of these points now. I suppose that my use of strncmp comes from... my fingers just don't want to type functions that start with strc? :) Anyhow, I've changed all of the strncmp to strcmp and strnlen to strlen as you've asked.

May 17 2017, 4:36 PM
jonathan updated the diff for D10751: Allow rtld direct-exec to take a file descriptor..
  • Address comments in kib's review.
May 17 2017, 4:32 PM
jonathan updated the diff for D10751: Allow rtld direct-exec to take a file descriptor..
  • Fix argv/environ/aux shift calculations.
May 17 2017, 12:02 AM

May 16 2017

jonathan updated the diff for D10751: Allow rtld direct-exec to take a file descriptor..
  • Drop unnecessary defensive braces.
May 16 2017, 10:58 PM
jonathan added a comment to D10751: Allow rtld direct-exec to take a file descriptor..
  • Merge 'origin/master' into arcpatch-D10751
May 16 2017, 10:56 PM
jonathan updated the diff for D10751: Allow rtld direct-exec to take a file descriptor..
  • Merge 'origin/master' into arcpatch-D10751
May 16 2017, 10:55 PM