Page MenuHomeFreeBSD

jonathan (Jonathan Anderson)
User

Projects

User Details

User Since
May 9 2014, 10:57 PM (523 w, 3 d)

Recent Activity

Yesterday

jonathan added a comment to D44373: Capsicum vs the Pathnames, a PoC.

@trasz : thanks for sending this review request. My general feeling is that I'm leery of relaxing the in-kernel security model, not just because of the potential for opening things we don't mean to open, but also because it complicates the model for those who are trying to understand it. "No global namespaces", while limiting, is a clearer rule than "no global namespaces unless you or your ancestor has previously called fchroot(2), unless-unless something has also called cap_enter(2) again to clear that magic vnode".

Mon, May 20, 10:46 PM

Fri, May 17

jonathan added a comment to D44372: Allow subset of wait4(2) functionality in Capsicum mode.

Hey folks,

Fri, May 17, 3:32 PM

Jul 21 2022

jonathan abandoned D35824: Update to GitHub-hosted version from 2020..

Never mind... attempting to use this in 2022 leads to all sorts of safety violations. Not worth updating without major surgery on the codebase itself.

Jul 21 2022, 5:20 PM

Jul 14 2022

jonathan requested review of D35824: Update to GitHub-hosted version from 2020..
Jul 14 2022, 10:12 PM

Dec 13 2020

jonathan committed R9:61415811a12f: jonathan@ is a src committer. (authored by jonathan).
jonathan@ is a src committer.
Dec 13 2020, 5:35 PM
jonathan committed R9:75296098cfbf: Add myself (jonathan@) to the list of src committers. (authored by jonathan).
Add myself (jonathan@) to the list of src committers.
Dec 13 2020, 5:27 PM
jonathan committed R9:101d5b7eb1b0: Added news item: jonathan@ is a new committer! (authored by jonathan).
Added news item: jonathan@ is a new committer!
Dec 13 2020, 5:27 PM

Jun 10 2019

jonathan closed D20551: devel/libgrading: update v0.1.7 -> v0.1.8..
Jun 10 2019, 4:43 PM
jonathan committed rP503908: devel/libgrading: update v0.1.7 -> v0.1.8..
devel/libgrading: update v0.1.7 -> v0.1.8.
Jun 10 2019, 4:43 PM
jonathan added a comment to D20460: devel/git-cola: revive port and use qt5.

Very happy to see this port getting updated for Qt5! And yes, entirely happy to relinquish maintainership... I only know enough about the ports tree to be dangerous. :)

Jun 10 2019, 4:37 PM

Jun 7 2019

jonathan created D20551: devel/libgrading: update v0.1.7 -> v0.1.8..
Jun 7 2019, 4:05 PM

May 30 2019

jonathan added a comment to D8397: Add devd rule for Elantech touchscreens..
In D8397#337061, @greg_unrelenting.technology wrote:

Is this one not supported by wmt(4)? The elan touchscreen on my Thinkpad X240 (0x04f3 : 0x0140) works great with wmt(4), but webcamd used to lose touch-end events...

May 30 2019, 2:00 PM

Feb 17 2019

jonathan committed rP493150: devel/libgrading: update v0.1.2 -> v0.1.7..
devel/libgrading: update v0.1.2 -> v0.1.7.
Feb 17 2019, 3:04 AM
jonathan closed D19112: devel/libgrading: update v0.1.2 -> v0.1.6.
Feb 17 2019, 3:04 AM

Feb 8 2019

jonathan added a comment to D19112: devel/libgrading: update v0.1.2 -> v0.1.6.

Just for good measure, I also updated the upstream code to incorporate the __FreeBSD_version_ patch; I'm now looking to update the port to v0.1.7.

Feb 8 2019, 7:05 PM
jonathan updated the diff for D19112: devel/libgrading: update v0.1.2 -> v0.1.6.
  • Update to v0.1.7 (w/upstream patch adoption).
Feb 8 2019, 6:55 PM
jonathan added a comment to D19112: devel/libgrading: update v0.1.2 -> v0.1.6.

Thanks for the feedback: I've added the missing file and done a little extra tidy-up that portlint -A suggested while I'm at it.

Feb 8 2019, 5:27 PM
jonathan updated the diff for D19112: devel/libgrading: update v0.1.2 -> v0.1.6.
  • Add new library to plist
  • Fix library version.
  • Fix a portlint warning.
  • Update patch file (new line numbers, etc.).
Feb 8 2019, 5:26 PM

Feb 7 2019

jonathan added a reviewer for D19112: devel/libgrading: update v0.1.2 -> v0.1.6: Contributor Reviewers (ports).
Feb 7 2019, 11:04 PM
jonathan created D19112: devel/libgrading: update v0.1.2 -> v0.1.6.
Feb 7 2019, 11:04 PM

Nov 16 2018

jonathan abandoned D2808: Implement O_BENEATH flag for openat(2)..

Closing revision: this functionality was implemented in D17547.

Nov 16 2018, 10:10 PM

Nov 5 2018

jonathan added inline comments to D17714: Allow absolute paths for O_BENEATH..
Nov 5 2018, 2:22 PM

Oct 29 2018

jonathan added a comment to D17714: Allow absolute paths for O_BENEATH..

Just to be clear: this change only affects the use of O_BENEATH when not in capability mode, right? We wouldn't want to allow absolute path information (e.g., "is FD X somewhere under the path /foo/bar/baz/wibble?") to leak when a process is in capability mode...

Oct 29 2018, 12:57 PM

Oct 20 2018

jonathan added a comment to D17547: Implement O_BENEATH and AT_BENEATH.

I've made a few minor suggestions about man page wording (which might reasonably apply to all of the man pages in the review). I've also made a minor suggestion about deriving LCF_STRICTRELATIVE from BENEATH rather than including lots of if (... STRICTRELATIVE || ... BENEATH).

Oct 20 2018, 9:44 PM

Jun 18 2018

jonathan added a comment to D15762: Add an NSFW option to x11/xscreensaver.

Thanks very much!

Jun 18 2018, 2:22 PM
jonathan committed rP472691: Add devd rule for Elantech touchscreens..
Add devd rule for Elantech touchscreens.
Jun 18 2018, 1:26 PM
jonathan closed D8397: Add devd rule for Elantech touchscreens..
Jun 18 2018, 1:26 PM

Jun 11 2018

jonathan added a comment to D7734: First pass at capsicumizing file(1).

So... should this revision be abandoned in favour of an approach that uses the new enable_sandbox_{basic,full}() functions?

Jun 11 2018, 7:22 PM
jonathan added a comment to D8397: Add devd rule for Elantech touchscreens..

Ping?

Jun 11 2018, 7:17 PM
jonathan created D15762: Add an NSFW option to x11/xscreensaver.
Jun 11 2018, 7:08 PM

Jun 6 2018

jonathan added inline comments to D14407: Introduce cap_fileargs..
Jun 6 2018, 10:47 PM

Feb 28 2018

jonathan abandoned D12733: New port: devel/capnproto.

Figuring out the 10.x compatibility isn't worth it for me any more, as the project I was thinking of using Cap'n Proto for has moved on.

Feb 28 2018, 6:41 PM
jonathan abandoned D14275: Add pkg_bootstrap firstboot script..

So, @cperciva , do you mind if I pull your firstboot-pkgs work into the base system? This would help tidy up a VM-building workflow that I'm using in which I can't run pkg(8) on the VM-building host.

Feb 28 2018, 6:40 PM

Feb 9 2018

jonathan added a comment to D14275: Add pkg_bootstrap firstboot script..

I wasn't aware of that port, no... thanks for pointing it out! I'll definitely take a look at that and see if it might make more sense to pull that into base than to duplicate the work.

Feb 9 2018, 1:14 PM
jonathan committed rP461285: Update neo4j to v3.3.2..
Update neo4j to v3.3.2.
Feb 9 2018, 2:40 AM
jonathan closed D14260: Update neo4j to v3.3.2..
Feb 9 2018, 2:40 AM
jonathan added a comment to D14260: Update neo4j to v3.3.2..

Thanks!

Feb 9 2018, 2:40 AM
jonathan added reviewers for D14275: Add pkg_bootstrap firstboot script.: bapt, jmg, cperciva.
Feb 9 2018, 2:37 AM
jonathan created D14275: Add pkg_bootstrap firstboot script..
Feb 9 2018, 2:32 AM

Feb 8 2018

jonathan added a reviewer for D14260: Update neo4j to v3.3.2.: crees.
Feb 8 2018, 2:44 PM

Feb 7 2018

jonathan added a reviewer for D14260: Update neo4j to v3.3.2.: Contributor Reviewers (ports).
Feb 7 2018, 11:35 PM
jonathan created D14260: Update neo4j to v3.3.2..
Feb 7 2018, 11:34 PM

Feb 2 2018

jonathan committed rP460660: New port: x11-themes/arc-gruvbox-theme.
New port: x11-themes/arc-gruvbox-theme
Feb 2 2018, 1:04 AM
jonathan closed D14134: New port: x11-themes/arc-gruvbox-theme.
Feb 2 2018, 1:04 AM

Jan 31 2018

jonathan updated the diff for D14134: New port: x11-themes/arc-gruvbox-theme.
  • Clean up as per review comments.
Jan 31 2018, 2:02 PM

Jan 30 2018

jonathan added a reviewer for D14134: New port: x11-themes/arc-gruvbox-theme: Contributor Reviewers (ports).
Jan 30 2018, 6:29 PM
jonathan created D14134: New port: x11-themes/arc-gruvbox-theme.
Jan 30 2018, 6:29 PM

Jan 25 2018

jonathan accepted D14051: Remove K&R stuff: never use it in new code..
Jan 25 2018, 4:13 PM

Dec 12 2017

jonathan committed rP456130: Update devel/llbuild to SNAPSHOT-2017-12-10..
Update devel/llbuild to SNAPSHOT-2017-12-10.
Dec 12 2017, 1:16 PM
jonathan closed D13451: Update devel/llbuild to SNAPSHOT-2017-12-10..
Dec 12 2017, 1:16 PM

Dec 11 2017

jonathan added a comment to D12719: Add WITH_LLVM_BITCODE option..

Ping?

Dec 11 2017, 7:01 PM
jonathan created D13451: Update devel/llbuild to SNAPSHOT-2017-12-10..
Dec 11 2017, 7:01 PM

Oct 26 2017

jonathan committed rP452958: New port: devel/llbuild.
New port: devel/llbuild
Oct 26 2017, 10:35 PM
jonathan closed D8439: New port: devel/llbuild.
Oct 26 2017, 10:34 PM

Oct 21 2017

jonathan added a comment to D12733: New port: devel/capnproto.

Builded fine in 11-[amd64|i386] and CURRENT-[amd64|i386].
Problem here in 10-[amd64|i386].

Logs are here:
10-amd64
10-i386

Oct 21 2017, 3:47 AM

Oct 20 2017

jonathan added a comment to D12733: New port: devel/capnproto.

[...] Have you done a test build in Poudriere?

Oct 20 2017, 3:39 PM
jonathan updated the summary of D12733: New port: devel/capnproto.
Oct 20 2017, 3:38 PM
jonathan committed rP452495: New port: devel/py-cdg.
New port: devel/py-cdg
Oct 20 2017, 12:01 AM
jonathan closed D11677: New port: devel/py-cdg.
Oct 20 2017, 12:01 AM

Oct 19 2017

jonathan updated the diff for D12733: New port: devel/capnproto.
  • Break out version prefix.
Oct 19 2017, 11:57 PM
jonathan added a comment to D12733: New port: devel/capnproto.

Where's the pkg-plist?

Oct 19 2017, 11:54 PM
jonathan updated the diff for D12733: New port: devel/capnproto.
  • Commit missing pkg-plist
  • Remove MASTER_SITES.
  • Replace USES+= with USES=.
Oct 19 2017, 11:52 PM
jonathan added a reviewer for D12733: New port: devel/capnproto: Contributor Reviewers (ports).
Oct 19 2017, 10:40 PM
jonathan created D12733: New port: devel/capnproto.
Oct 19 2017, 10:39 PM
jonathan added inline comments to D8439: New port: devel/llbuild.
Oct 19 2017, 10:18 PM
jonathan updated the diff for D8439: New port: devel/llbuild.
  • De-uglify version number using DISTVERSIONPREFIX.
Oct 19 2017, 10:16 PM

Oct 18 2017

jonathan added a comment to D9853: Exclude assembly files from LLVM IR Builds.

I think this may now be redundant in light of https://reviews.freebsd.org/D12701?

Oct 18 2017, 10:07 PM
jonathan updated the diff for D12719: Add WITH_LLVM_BITCODE option..
  • Add missing LLVM_IR_TYPE
Oct 18 2017, 3:02 PM
jonathan created D12719: Add WITH_LLVM_BITCODE option..
Oct 18 2017, 2:31 PM
jonathan closed D12701: Improve computation of {BC,LL}OBJS..
Oct 18 2017, 12:33 AM
jonathan committed rS324712: Improve computation of {BC,LL}OBJS..
Improve computation of {BC,LL}OBJS.
Oct 18 2017, 12:33 AM
jonathan committed rS324711: Improve logic of CLEANFILES+=${PROG_FULL}.{bc,ll}..
Improve logic of CLEANFILES+=${PROG_FULL}.{bc,ll}.
Oct 18 2017, 12:30 AM
jonathan closed D12703: Improve logic of CLEANFILES+=${PROG_FULL}.{bc,ll}..
Oct 18 2017, 12:30 AM
jonathan added a comment to D12701: Improve computation of {BC,LL}OBJS..
In D12701#263694, @sjg wrote:

Ok so apart from moving the definitions, the key improvement is suppressing .bco etc. for .asm ?

Oct 18 2017, 12:23 AM

Oct 17 2017

jonathan created D12703: Improve logic of CLEANFILES+=${PROG_FULL}.{bc,ll}..
Oct 17 2017, 4:41 PM
jonathan committed rS324695: Add LLVM IR libraries to CLEANFILES..
Add LLVM IR libraries to CLEANFILES.
Oct 17 2017, 4:30 PM
jonathan updated the diff for D12701: Improve computation of {BC,LL}OBJS..
  • Prefer += to = when computing {BC,LL}OBJS.
Oct 17 2017, 4:18 PM
jonathan created D12701: Improve computation of {BC,LL}OBJS..
Oct 17 2017, 4:09 PM

Sep 15 2017

jonathan added a comment to D12339: rename(2): document capability mode errors.
In D12339#255993, @cem wrote:

Er, why is rename / renameat with AT_FDCWD not allowed in capability mode?

Sep 15 2017, 2:23 PM

Sep 9 2017

jonathan added a comment to D11677: New port: devel/py-cdg.

Ok, I think that addresses the last of the reviewer comments?

Sep 9 2017, 5:15 PM
jonathan updated the test plan for D11677: New port: devel/py-cdg.
Sep 9 2017, 5:14 PM
jonathan added a comment to D8439: New port: devel/llbuild.

Ok, I think that's everything now?

Sep 9 2017, 5:09 PM
jonathan updated the diff for D8439: New port: devel/llbuild.
  • Move USES above USE_GITHUB.
  • Merge 'origin/master' into llbuild
Sep 9 2017, 1:51 PM
jonathan committed rS323365: Remove redundant source and object files..
Remove redundant source and object files.
Sep 9 2017, 1:18 PM
jonathan closed D12208: Remove redundant source, object files..
Sep 9 2017, 1:18 PM

Sep 1 2017

jonathan updated the diff for D8439: New port: devel/llbuild.
  • New port: devel/llbuild
  • Change post-stage to post-install for docs.
  • Fix typo: "swift-llbuild", not "switch-llbuild"!
  • Add the llbuild binary to the build and plist.
  • Fix licensing: use ports' multi-license support.
  • Fix license: ports tree calls "LLVM" "NCSA".
  • Update to use lit from llvm-devel
Sep 1 2017, 7:15 PM
jonathan added a comment to D8439: New port: devel/llbuild.

In this case, LICENSE_FILE describes the Apache license but it also describes which bits of the sources fall under different licenses. Under those conditions, does it make sense to keep?

Sep 1 2017, 7:15 PM
jonathan added a comment to D8397: Add devd rule for Elantech touchscreens..

No, sometimes the device use 0xff for some ID fields which means propritary driver. It might be better to match that than vendor/product.

Sep 1 2017, 6:44 PM
jonathan abandoned D6616: Add script to parse makefile include graph..
Sep 1 2017, 6:40 PM
jonathan updated the test plan for D11677: New port: devel/py-cdg.
Sep 1 2017, 6:27 PM
jonathan updated the diff for D11677: New port: devel/py-cdg.
  • Change an unnecessary '?=' to '='.
  • Uncomment PKGNAMEPREFIX as requested by sunpoet.
  • Update py-cdg to HEAD
Sep 1 2017, 6:26 PM
jonathan added reviewers for D12208: Remove redundant source, object files.: ngie, bdrewery, dim, peter.

Add reviewers who have touched these makefiles recently

Sep 1 2017, 6:11 PM
jonathan created D12208: Remove redundant source, object files..
Sep 1 2017, 6:08 PM

Aug 11 2017

jonathan added a comment to D11446: Update to neo4j v3.2.1..

Thanks very much: I've committed the patch as approved/accepted, but would certainly be happy to discuss the relative merits of moving things around (perhaps as a separate action?). I think there will be a tension between the "FreeBSD way" and the "Neo4j way", but... well, perhaps that's a conversation for another day/diff/review. :)

Aug 11 2017, 10:30 AM
jonathan committed rP447753: Update neo4j to v3.2.1..
Update neo4j to v3.2.1.
Aug 11 2017, 10:29 AM
jonathan closed D11446: Update to neo4j v3.2.1. by committing rP447753: Update neo4j to v3.2.1..
Aug 11 2017, 10:29 AM
jonathan updated the diff for D11677: New port: devel/py-cdg.
  • New port: devel/py-cdg
  • Address comments in Phab review
Aug 11 2017, 10:02 AM
jonathan added a comment to D11677: New port: devel/py-cdg.

Thanks very much for the feedback: I learned a lot about Python packaging!

Aug 11 2017, 9:30 AM

Aug 9 2017

jonathan committed rS322314: Add birthday information for jonathan@..
Add birthday information for jonathan@.
Aug 9 2017, 1:25 PM

Jul 20 2017

jonathan created D11677: New port: devel/py-cdg.
Jul 20 2017, 7:29 PM