jonathan (Jonathan Anderson)
User

Projects

User Details

User Since
May 9 2014, 10:57 PM (185 w, 3 h)

Recent Activity

Thu, Oct 26

jonathan committed rP452958: New port: devel/llbuild.
New port: devel/llbuild
Thu, Oct 26, 10:35 PM
jonathan closed D8439: New port: devel/llbuild.
Thu, Oct 26, 10:34 PM

Oct 21 2017

jonathan added a comment to D12733: New port: devel/capnproto.

Builded fine in 11-[amd64|i386] and CURRENT-[amd64|i386].
Problem here in 10-[amd64|i386].

Logs are here:
10-amd64
10-i386

Oct 21 2017, 3:47 AM

Oct 20 2017

jonathan added a comment to D12733: New port: devel/capnproto.

[...] Have you done a test build in Poudriere?

Oct 20 2017, 3:39 PM
jonathan updated the summary of D12733: New port: devel/capnproto.
Oct 20 2017, 3:38 PM
jonathan committed rP452495: New port: devel/py-cdg.
New port: devel/py-cdg
Oct 20 2017, 12:01 AM
jonathan closed D11677: New port: devel/py-cdg.
Oct 20 2017, 12:01 AM

Oct 19 2017

jonathan updated the diff for D12733: New port: devel/capnproto.
  • Break out version prefix.
Oct 19 2017, 11:57 PM
jonathan added a comment to D12733: New port: devel/capnproto.

Where's the pkg-plist?

Oct 19 2017, 11:54 PM
jonathan updated the diff for D12733: New port: devel/capnproto.
  • Commit missing pkg-plist
  • Remove MASTER_SITES.
  • Replace USES+= with USES=.
Oct 19 2017, 11:52 PM
jonathan added a reviewer for D12733: New port: devel/capnproto: Contributor Reviewers (ports).
Oct 19 2017, 10:40 PM
jonathan created D12733: New port: devel/capnproto.
Oct 19 2017, 10:39 PM
jonathan added inline comments to D8439: New port: devel/llbuild.
Oct 19 2017, 10:18 PM
jonathan updated the diff for D8439: New port: devel/llbuild.
  • De-uglify version number using DISTVERSIONPREFIX.
Oct 19 2017, 10:16 PM

Oct 18 2017

jonathan added a comment to D9853: Exclude assembly files from LLVM IR Builds.

I think this may now be redundant in light of https://reviews.freebsd.org/D12701?

Oct 18 2017, 10:07 PM
jonathan updated the diff for D12719: Add WITH_LLVM_BITCODE option..
  • Add missing LLVM_IR_TYPE
Oct 18 2017, 3:02 PM
jonathan created D12719: Add WITH_LLVM_BITCODE option..
Oct 18 2017, 2:31 PM
jonathan closed D12701: Improve computation of {BC,LL}OBJS..
Oct 18 2017, 12:33 AM
jonathan committed rS324712: Improve computation of {BC,LL}OBJS..
Improve computation of {BC,LL}OBJS.
Oct 18 2017, 12:33 AM
jonathan committed rS324711: Improve logic of CLEANFILES+=${PROG_FULL}.{bc,ll}..
Improve logic of CLEANFILES+=${PROG_FULL}.{bc,ll}.
Oct 18 2017, 12:30 AM
jonathan closed D12703: Improve logic of CLEANFILES+=${PROG_FULL}.{bc,ll}..
Oct 18 2017, 12:30 AM
jonathan added a comment to D12701: Improve computation of {BC,LL}OBJS..
In D12701#263694, @sjg wrote:

Ok so apart from moving the definitions, the key improvement is suppressing .bco etc. for .asm ?

Oct 18 2017, 12:23 AM

Oct 17 2017

jonathan created D12703: Improve logic of CLEANFILES+=${PROG_FULL}.{bc,ll}..
Oct 17 2017, 4:41 PM
jonathan committed rS324695: Add LLVM IR libraries to CLEANFILES..
Add LLVM IR libraries to CLEANFILES.
Oct 17 2017, 4:30 PM
jonathan updated the diff for D12701: Improve computation of {BC,LL}OBJS..
  • Prefer += to = when computing {BC,LL}OBJS.
Oct 17 2017, 4:18 PM
jonathan created D12701: Improve computation of {BC,LL}OBJS..
Oct 17 2017, 4:09 PM

Sep 15 2017

jonathan added a comment to D12339: rename(2): document capability mode errors.
In D12339#255993, @cem wrote:

Er, why is rename / renameat with AT_FDCWD not allowed in capability mode?

Sep 15 2017, 2:23 PM

Sep 9 2017

jonathan added a comment to D11677: New port: devel/py-cdg.

Ok, I think that addresses the last of the reviewer comments?

Sep 9 2017, 5:15 PM
jonathan updated the test plan for D11677: New port: devel/py-cdg.
Sep 9 2017, 5:14 PM
jonathan added a comment to D8439: New port: devel/llbuild.

Ok, I think that's everything now?

Sep 9 2017, 5:09 PM
jonathan updated the diff for D8439: New port: devel/llbuild.
  • Move USES above USE_GITHUB.
  • Merge 'origin/master' into llbuild
Sep 9 2017, 1:51 PM
jonathan committed rS323365: Remove redundant source and object files..
Remove redundant source and object files.
Sep 9 2017, 1:18 PM
jonathan closed D12208: Remove redundant source, object files..
Sep 9 2017, 1:18 PM

Sep 1 2017

jonathan updated the diff for D8439: New port: devel/llbuild.
  • New port: devel/llbuild
  • Change post-stage to post-install for docs.
  • Fix typo: "swift-llbuild", not "switch-llbuild"!
  • Add the llbuild binary to the build and plist.
  • Fix licensing: use ports' multi-license support.
  • Fix license: ports tree calls "LLVM" "NCSA".
  • Update to use lit from llvm-devel
Sep 1 2017, 7:15 PM
jonathan added a comment to D8439: New port: devel/llbuild.

In this case, LICENSE_FILE describes the Apache license but it also describes which bits of the sources fall under different licenses. Under those conditions, does it make sense to keep?

Sep 1 2017, 7:15 PM
jonathan added a comment to D8397: Add devd rule for Elantech touchscreens..

No, sometimes the device use 0xff for some ID fields which means propritary driver. It might be better to match that than vendor/product.

Sep 1 2017, 6:44 PM
jonathan abandoned D6616: Add script to parse makefile include graph..
Sep 1 2017, 6:40 PM
jonathan updated the test plan for D11677: New port: devel/py-cdg.
Sep 1 2017, 6:27 PM
jonathan updated the diff for D11677: New port: devel/py-cdg.
  • Change an unnecessary '?=' to '='.
  • Uncomment PKGNAMEPREFIX as requested by sunpoet.
  • Update py-cdg to HEAD
Sep 1 2017, 6:26 PM
jonathan added reviewers for D12208: Remove redundant source, object files.: ngie, bdrewery, dim, peter.

Add reviewers who have touched these makefiles recently

Sep 1 2017, 6:11 PM
jonathan created D12208: Remove redundant source, object files..
Sep 1 2017, 6:08 PM

Aug 11 2017

jonathan added a comment to D11446: Update to neo4j v3.2.1..

Thanks very much: I've committed the patch as approved/accepted, but would certainly be happy to discuss the relative merits of moving things around (perhaps as a separate action?). I think there will be a tension between the "FreeBSD way" and the "Neo4j way", but... well, perhaps that's a conversation for another day/diff/review. :)

Aug 11 2017, 10:30 AM
jonathan committed rP447753: Update neo4j to v3.2.1..
Update neo4j to v3.2.1.
Aug 11 2017, 10:29 AM
jonathan closed D11446: Update to neo4j v3.2.1. by committing rP447753: Update neo4j to v3.2.1..
Aug 11 2017, 10:29 AM
jonathan updated the diff for D11677: New port: devel/py-cdg.
  • New port: devel/py-cdg
  • Address comments in Phab review
Aug 11 2017, 10:02 AM
jonathan added a comment to D11677: New port: devel/py-cdg.

Thanks very much for the feedback: I learned a lot about Python packaging!

Aug 11 2017, 9:30 AM

Aug 9 2017

jonathan committed rS322314: Add birthday information for jonathan@..
Add birthday information for jonathan@.
Aug 9 2017, 1:25 PM

Jul 20 2017

jonathan created D11677: New port: devel/py-cdg.
Jul 20 2017, 7:29 PM

Jul 5 2017

jonathan updated the diff for D11446: Update to neo4j v3.2.1..
  • Align neo4j.conf patch with previous patch.
  • Put databases in /var/db instead of $PREFIX/share.
Jul 5 2017, 12:05 PM

Jul 4 2017

jonathan updated the diff for D11446: Update to neo4j v3.2.1..
  • Update to use ${PREFIX}/etc as requested.
Jul 4 2017, 2:35 AM
jonathan added a comment to D11446: Update to neo4j v3.2.1..

Ok, that's fair enough: I'll check to make sure that this will work with config files in ${PREFIX}/etc. What is your view on the weird ${PREFIX}/libexec/bin/neo4j-* path with symlinks to /usr/local/bin? My patch (or at least my local version that I've since hacked up some more!) puts cypher-shell, neo4j-admin, etc., into ${PREFIX}/bin and avoids the symlinks entirely. I think this sounds compatible with your view?

Jul 4 2017, 2:05 AM

Jul 2 2017

jonathan added a comment to D11446: Update to neo4j v3.2.1..

Actually, we can simplify a lot of this patching if we follow the Neo4j convention of putting config stuff in somewhere like /usr/local/neo4j/conf instead of /usr/local/etc... thoughts?

Jul 2 2017, 11:36 AM
jonathan created D11446: Update to neo4j v3.2.1..
Jul 2 2017, 10:57 AM

Jun 7 2017

jonathan added inline comments to D10413: FreeBSD Project Associates.
Jun 7 2017, 4:11 PM

May 29 2017

jonathan added inline comments to D10826: Document direct execution mode for ld.so..
May 29 2017, 1:41 PM

May 28 2017

jonathan accepted D10826: Document direct execution mode for ld.so..

Some very small nits on which I would happily defer (well, except for the spelling one). Otherwise LGTM.

May 28 2017, 11:40 PM

May 18 2017

jonathan committed rS318432: Fix some nroff syntax in rtld.1..
Fix some nroff syntax in rtld.1.
May 18 2017, 12:32 AM

May 17 2017

jonathan committed rS318431: Allow rtld direct-exec to take a file descriptor..
Allow rtld direct-exec to take a file descriptor.
May 17 2017, 10:51 PM
jonathan closed D10751: Allow rtld direct-exec to take a file descriptor. by committing rS318431: Allow rtld direct-exec to take a file descriptor..
May 17 2017, 10:51 PM
jonathan updated the diff for D10751: Allow rtld direct-exec to take a file descriptor..
  • Restore tabs to print_args().
May 17 2017, 10:35 PM
jonathan added a comment to D10751: Allow rtld direct-exec to take a file descriptor..
In D10751#223329, @kib wrote:

For new functions in rtld, I use normal style(9), so rtld slowly migrates to proper indentation. For smaller changes to existing functions I do follow existing style of 4 spaces indent/2 spaces continuation.

May 17 2017, 10:31 PM
jonathan updated the diff for D10751: Allow rtld direct-exec to take a file descriptor..
  • Add a missing rtld_strerror()
  • Convert some _rtld_error() calls to rtld_printf().
  • Use four spaces for second-level indent.
  • Be clear about user- vs path-derived descriptor.
May 17 2017, 9:28 PM
jonathan added inline comments to D10751: Allow rtld direct-exec to take a file descriptor..
May 17 2017, 9:23 PM
jonathan added inline comments to D10751: Allow rtld direct-exec to take a file descriptor..
May 17 2017, 9:02 PM
jonathan updated the diff for D10751: Allow rtld direct-exec to take a file descriptor..
  • Remove some superfluous parentheses.
  • Remove redundant fstat(2) call.
May 17 2017, 9:02 PM
jonathan accepted D10775: Fix shebangs in devel/tesla.

LGTM. I'm also happy to fix this upstream: what should the Python shebang line be instead of #!/usr/bin/env python?

May 17 2017, 5:21 PM
jonathan added a comment to D10751: Allow rtld direct-exec to take a file descriptor..

Ok, I think I've addressed all of these points now. I suppose that my use of strncmp comes from... my fingers just don't want to type functions that start with strc? :) Anyhow, I've changed all of the strncmp to strcmp and strnlen to strlen as you've asked.

May 17 2017, 4:36 PM
jonathan updated the diff for D10751: Allow rtld direct-exec to take a file descriptor..
  • Address comments in kib's review.
May 17 2017, 4:32 PM
jonathan updated the diff for D10751: Allow rtld direct-exec to take a file descriptor..
  • Fix argv/environ/aux shift calculations.
May 17 2017, 12:02 AM

May 16 2017

jonathan updated the diff for D10751: Allow rtld direct-exec to take a file descriptor..
  • Drop unnecessary defensive braces.
May 16 2017, 10:58 PM
jonathan added a comment to D10751: Allow rtld direct-exec to take a file descriptor..
  • Merge 'origin/master' into arcpatch-D10751
May 16 2017, 10:56 PM
jonathan updated the diff for D10751: Allow rtld direct-exec to take a file descriptor..
  • Merge 'origin/master' into arcpatch-D10751
May 16 2017, 10:55 PM
jonathan updated the diff for D10751: Allow rtld direct-exec to take a file descriptor..
  • Apply a style(9) fix.
May 16 2017, 1:49 PM
jonathan updated the diff for D10751: Allow rtld direct-exec to take a file descriptor..
  • Remove a stray (debug) utrace(2) invocation.
May 16 2017, 1:47 PM
jonathan updated the diff for D10751: Allow rtld direct-exec to take a file descriptor..
  • Add more explicit argument parsing to rtld.
  • Merge remote-tracking branch 'origin/master' into arcpatch-D10751
May 16 2017, 1:46 PM
jonathan committed rS318352: Rename rtld's parse_libdir to parse_integer..
Rename rtld's parse_libdir to parse_integer.
May 16 2017, 1:28 PM
jonathan added a comment to D10751: Allow rtld direct-exec to take a file descriptor..
In D10751#222729, @kib wrote:

I do not like these argv0 tricks, I intend to implement normal options parsing for the direct mode. One of the options would take the file descriptor number and do what your trick does. I think that this is better than the trick since it allows to easily invoke and test the functionality from the shell.

May 16 2017, 12:33 PM

May 15 2017

jonathan abandoned D9030: Create new fexecve() variant with explicit interpreter.

I've just opened D10751 as a more rtld-centric way of achieving (hopefully) the same effect, now that D10701 has landed and ld-elf.so.1 is directly executable.

May 15 2017, 11:38 PM
jonathan updated subscribers of D10751: Allow rtld direct-exec to take a file descriptor..
May 15 2017, 11:34 PM
jonathan created D10751: Allow rtld direct-exec to take a file descriptor..
May 15 2017, 11:31 PM
jonathan added a comment to D9030: Create new fexecve() variant with explicit interpreter.
In D9030#222200, @kib wrote:

But important point is that new syscall extends kernel ABI, and by its nature, this change is with us forever. If we start consider the approach wrong and better approach emerges, we still must maintain the syscall, due to the backward compatibility guarantees.

May 15 2017, 1:16 AM

May 13 2017

jonathan added a comment to D9030: Create new fexecve() variant with explicit interpreter.
In D9030#221824, @kib wrote:

What is slightly less obvious is how to pass the binary to ld.so, but: ELF format specified a way to run binaries by filedescriptor for long time. Look at the AT_EXECFD aux vector, we still have this code in rtld.c (it might somewhat rotten, but this is easily fixable). Then the standalone-runnable ld.so only needs to grow an option to specify which fd points to the binary, in addition to AT_EXECFD.

May 13 2017, 5:36 PM
jonathan updated the diff for D9030: Create new fexecve() variant with explicit interpreter.
  • Don't honour setuid/setgid with custom interpreter.
May 13 2017, 1:40 AM
jonathan updated the diff for D9030: Create new fexecve() variant with explicit interpreter.
  • Don't honour setuid/setgid with custom interpreter.
May 13 2017, 1:35 AM
jonathan added a comment to D9030: Create new fexecve() variant with explicit interpreter.
In D9030#221740, @kib wrote:

Let's split two things. I thought that your issue at hand was the conflict between the nature of capability mode disallowing implicit root and absolute lookups, badly interfering with the typical absolute path specification for ELF interpreters.

May 13 2017, 1:28 AM

May 12 2017

jonathan added a comment to D9030: Create new fexecve() variant with explicit interpreter.
In D9030#221707, @kib wrote:

As is, the thing is unbelievable security hole. Unprivileged user can execute suid binary with arbitrary code injected instead of official interpreter. Even for the static suid binary, it seems. Please correct me.

May 12 2017, 7:38 PM
jonathan added a comment to D9030: Create new fexecve() variant with explicit interpreter.

FWIW, I'm not a fan of the NULL terminated argv and envv arguments as they make argument validation in CheriABI harder, but I mostly think that ship has sailed. If I were to fix it I'd make the syscall a into a __ffexecve() that takes lengths and have ffexecve() be a user space wrapper that counts the lengths of the vectors and passes them down.

May 12 2017, 7:24 PM

May 11 2017

jonathan updated the diff for D9030: Create new fexecve() variant with explicit interpreter.
  • Disable ffexecve(2) with non-ELF image activators.
May 11 2017, 11:51 PM
jonathan retitled D9030: Create new fexecve() variant with explicit interpreter from First attempt at a new fexecve() variant that allows the interpreter to be specified explicitly with a file descriptor. to Create new fexecve() variant with explicit interpreter.
May 11 2017, 11:50 PM
jonathan updated the diff for D9030: Create new fexecve() variant with explicit interpreter.
  • Merge 'origin/master' into arcpatch-D9030
  • Add !have_interp for consistency.
  • Rename fldexec to ffexecve.
  • Add ffexecve to execve(2) man page.
May 11 2017, 1:54 PM

Mar 29 2017

jonathan accepted D10149: DTrace Audit Provider Prototype.

LGTM

Mar 29 2017, 7:51 PM
jonathan added a comment to D10149: DTrace Audit Provider Prototype.

Some of these questions may not make sense to those thoroughly versed in DTrace, but I'm new in this corner of the world. :)

Mar 29 2017, 1:56 AM

Mar 17 2017

jonathan updated the diff for D9030: Create new fexecve() variant with explicit interpreter.
  • Fix MLINKS for fldexec.
Mar 17 2017, 6:13 PM
jonathan updated the diff for D9030: Create new fexecve() variant with explicit interpreter.

Rebase onto -CURRENT

Mar 17 2017, 5:04 PM
jonathan updated the diff for D9030: Create new fexecve() variant with explicit interpreter.
  • Remove auto-generated files from diff.
Mar 17 2017, 4:57 PM

Mar 11 2017

jonathan added inline comments to D9853: Exclude assembly files from LLVM IR Builds.
Mar 11 2017, 3:12 AM

Jan 3 2017

jonathan retitled D9030: Create new fexecve() variant with explicit interpreter from to First attempt at a new fexecve() variant that allows the interpreter to be specified explicitly with a file descriptor..
Jan 3 2017, 2:34 PM

Nov 22 2016

jonathan added a comment to D8397: Add devd rule for Elantech touchscreens..

usbconfig output is here: http://pastebin.com/iqJix3h2

Nov 22 2016, 3:14 PM
jonathan added a reviewer for D8397: Add devd rule for Elantech touchscreens.: hselasky.
Nov 22 2016, 2:41 PM
jonathan added a comment to D8439: New port: devel/llbuild.

I think this might address all of the comments properly now?

Nov 22 2016, 2:32 PM