Page MenuHomeFreeBSD

devel/libgrading: update v0.1.2 -> v0.1.6
ClosedPublic

Authored by jonathan on Thu, Feb 7, 11:04 PM.

Details

Summary
  • Add support for Gradescope
  • Fix SOVERSION
  • Various minor fixups

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jonathan created this revision.Thu, Feb 7, 11:04 PM
tobik requested changes to this revision.Fri, Feb 8, 7:58 AM
tobik added a subscriber: tobik.

This fails check-plist:

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/libgrading.so.0.1.4
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1
This revision now requires changes to proceed.Fri, Feb 8, 7:58 AM
matthew accepted this revision.Fri, Feb 8, 7:58 AM
matthew added a subscriber: matthew.
This comment was removed by matthew.
matthew requested changes to this revision.Fri, Feb 8, 8:00 AM

Ooops. I was too quick to accept there. Needs pkg-plist updating as @tobik has shown

jonathan updated this revision to Diff 53691.Fri, Feb 8, 5:26 PM
  • Add new library to plist
  • Fix library version.
  • Fix a portlint warning.
  • Update patch file (new line numbers, etc.).

Thanks for the feedback: I've added the missing file and done a little extra tidy-up that portlint -A suggested while I'm at it.

jonathan updated this revision to Diff 53700.Fri, Feb 8, 6:55 PM
  • Update to v0.1.7 (w/upstream patch adoption).

Just for good measure, I also updated the upstream code to incorporate the __FreeBSD_version_ patch; I'm now looking to update the port to v0.1.7.

matthew accepted this revision.Fri, Feb 8, 7:42 PM

LGTM

tobik accepted this revision.Fri, Feb 8, 8:30 PM
This revision is now accepted and ready to land.Fri, Feb 8, 8:30 PM
This revision was automatically updated to reflect the committed changes.