Page MenuHomeFreeBSD

Improve computation of {BC,LL}OBJS.
ClosedPublic

Authored by jonathan on Oct 17 2017, 4:09 PM.
Tags
None
Referenced Files
F86756296: D12701.id.diff
Tue, Jun 25, 2:31 AM
Unknown Object (File)
Fri, Jun 21, 7:30 PM
Unknown Object (File)
Mon, Jun 3, 10:56 PM
Unknown Object (File)
May 24 2024, 12:10 AM
Unknown Object (File)
May 21 2024, 9:27 AM
Unknown Object (File)
May 7 2024, 3:32 PM
Unknown Object (File)
May 6 2024, 9:11 PM
Unknown Object (File)
May 6 2024, 8:31 PM
Subscribers

Details

Summary

Now that OBJS has grown an OBJS_SRCS_FILTER variable, use this variable
in the computation of BCOBJS and LLOBJS too. Also move BCOBJS and LLOBJS
computation to be next to the OBJS computation: this should both make
the parallel structure clearer and serve to remind people changing OBJS
that parallel changes are required in BCOBJS and LLOBJS.

A side effect of this change is that BCOBJS and LLOBJS will be available
even when LLVM_LINK has not been defined, but that seems like a positive
change: there's no reason we can't ask "what bitcode files would you
generate" just because we can't link those files together into a
complete bitcode representation of a binary or library.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Prefer += to = when computing {BC,LL}OBJS.

Ok so apart from moving the definitions, the key improvement is suppressing .bco etc. for .asm ?

This revision is now accepted and ready to land.Oct 17 2017, 6:47 PM
In D12701#263694, @sjg wrote:

Ok so apart from moving the definitions, the key improvement is suppressing .bco etc. for .asm ?

Yup, that's right.

This revision was automatically updated to reflect the committed changes.