Page MenuHomeFreeBSD

sjg (Simon Gerraty)
User

Projects

User Details

User Since
Apr 9 2015, 9:27 PM (476 w, 4 d)

Recent Activity

Today

sjg committed rG2b7c1402f96b: src.sys.obj.mk: Export OBJTOP (authored by sjg).
src.sys.obj.mk: Export OBJTOP
Tue, May 28, 6:53 PM

Thu, May 23

sjg committed rG9d3df31ec06f: Merge bmake-20240520 (authored by sjg).
Merge bmake-20240520
Thu, May 23, 8:14 PM
sjg committed rG29efb3dcaedd: Import bmake-20240520 (authored by sjg).
Import bmake-20240520
Thu, May 23, 8:11 PM

Wed, May 22

sjg committed rGdc501a9ec093: Allow DEBUG_SH=rc:all to debug all rc.d (authored by sjg).
Allow DEBUG_SH=rc:all to debug all rc.d
Wed, May 22, 2:46 AM

Sun, May 19

sjg added inline comments to D44271: bsd.lib.mk: add targets to detect symbol changes.
Sun, May 19, 5:12 PM

Tue, May 14

sjg committed rGc9f4001f81c4: Merge bmake-20240508 (authored by sjg).
Merge bmake-20240508
Tue, May 14, 5:23 AM
sjg committed rG3c2ab5fddc57: Import bmake-20240508 (authored by sjg).
Import bmake-20240508
Tue, May 14, 4:17 AM

Fri, May 10

sjg committed rGdd4d206cad0c: kmod.mk use ${XARGS} (authored by sjg).
kmod.mk use ${XARGS}
Fri, May 10, 7:06 PM
sjg closed D45146: kmod.mk use ${XARGS}.
Fri, May 10, 7:06 PM
sjg requested review of D45146: kmod.mk use ${XARGS}.
Fri, May 10, 1:38 AM
sjg committed rGf77b5b295da3: Allow -DNO_STRICT_REGEX to restore historic regex behavior (authored by sjg).
Allow -DNO_STRICT_REGEX to restore historic regex behavior
Fri, May 10, 1:31 AM
sjg closed D45134: Allow -DNO_STRICT_ERE to restore historic regex behavior.
Fri, May 10, 1:31 AM

Wed, May 8

sjg updated the diff for D45134: Allow -DNO_STRICT_ERE to restore historic regex behavior.

Rename knob to NO_STRICT_REGEX

Wed, May 8, 11:13 PM
sjg requested review of D45134: Allow -DNO_STRICT_ERE to restore historic regex behavior.
Wed, May 8, 10:15 PM

Fri, May 3

sjg committed rG548bfc56eb0b: Merge bmake-20240430 (authored by sjg).
Merge bmake-20240430
Fri, May 3, 10:50 PM
sjg committed rG507951f55039: Import bmake-20240430 (authored by sjg).
Import bmake-20240430
Fri, May 3, 10:45 PM

Thu, May 2

sjg added inline comments to D44271: bsd.lib.mk: add targets to detect symbol changes.
Thu, May 2, 7:38 PM

Apr 27 2024

sjg added inline comments to D44271: bsd.lib.mk: add targets to detect symbol changes.
Apr 27 2024, 4:09 PM

Apr 24 2024

sjg committed rG0135101e23f9: meta.autodep.mk do not override start_utc (authored by sjg).
meta.autodep.mk do not override start_utc
Apr 24 2024, 7:27 PM

Apr 18 2024

sjg committed rGf697b9d03d99: Update sys.dirdeps.mk set default DEP_* (authored by sjg).
Update sys.dirdeps.mk set default DEP_*
Apr 18 2024, 9:08 PM

Apr 13 2024

sjg added inline comments to D44765: maketab: Add build rules to use HOST_CC.
Apr 13 2024, 4:02 PM

Mar 27 2024

sjg accepted D44540: include: Allow SDESTDIR to be overridden.
Mar 27 2024, 11:07 PM
sjg accepted D44539: libmagic: Use HOST_CC when compiling hostprog used by build.

*might* be worth a comment to the effect of in the non-DIRDEPS_BUILD HOST_CC is just CC

Mar 27 2024, 11:06 PM
sjg accepted D44537: csh: Use HOST_CC when compiling hostprog used by csh build.
Mar 27 2024, 9:48 PM
sjg accepted D44536: sys.mk: Define HOST_CC as CC by default..
Mar 27 2024, 9:48 PM

Mar 21 2024

sjg committed rG139d114acc7b: libsysdecode use MKTABLES_INCLUDEDIR (authored by sjg).
libsysdecode use MKTABLES_INCLUDEDIR
Mar 21 2024, 6:57 PM
sjg closed D44415: libsysdecode use MKTABLES_INCLUDEDIR.
Mar 21 2024, 6:56 PM

Mar 18 2024

sjg committed rGa8eb3b365eb6: loader.4th dictthreshold too small (authored by sjg).
loader.4th dictthreshold too small
Mar 18 2024, 11:17 PM
sjg closed D44414: loader.4th dictthreshold too small.
Mar 18 2024, 11:17 PM
sjg committed rG01f3abbfcd59: uboot/Makefile move BINDIR (authored by sjg).
uboot/Makefile move BINDIR
Mar 18 2024, 11:16 PM
sjg closed D44413: uboot/Makefile move BINDIR.
Mar 18 2024, 11:15 PM
sjg requested review of D44415: libsysdecode use MKTABLES_INCLUDEDIR.
Mar 18 2024, 6:40 PM
sjg requested review of D44414: loader.4th dictthreshold too small.
Mar 18 2024, 6:32 PM
sjg requested review of D44413: uboot/Makefile move BINDIR.
Mar 18 2024, 6:27 PM

Mar 14 2024

sjg committed rGf974ced38a4a: Update dirdeps.mk et al (authored by sjg).
Update dirdeps.mk et al
Mar 14 2024, 5:52 AM
sjg committed rG3ff501040ba7: bmake Makefile.config (authored by sjg).
bmake Makefile.config
Mar 14 2024, 5:09 AM
sjg committed rG51ca8a7a7da7: bmake updated config.h (authored by sjg).
bmake updated config.h
Mar 14 2024, 5:04 AM
sjg committed rGc59c3bf34db3: Merge bmake-20240309 (authored by sjg).
Merge bmake-20240309
Mar 14 2024, 4:58 AM
sjg committed rG368b06ce6b01: Need a blank line after brief summary (authored by sjg).
Need a blank line after brief summary
Mar 14 2024, 2:17 AM
sjg committed rGa6b892e1c76a: Import bmake-20240309 (authored by sjg).
Import bmake-20240309
Mar 14 2024, 2:17 AM

Mar 8 2024

sjg added a comment to D44271: bsd.lib.mk: add targets to detect symbol changes.

FWIW we have sym and abi checkers in junos build, they are each in a separate makefile included by bsd.lib.mk if the appropriate knob is enabled
The sym checker does BSS and TLS symbol checks, not directly useful here, but just a thought

Mar 8 2024, 4:52 PM

Mar 1 2024

sjg accepted D44166: tarfs: Improve validation of numeric fields..
Mar 1 2024, 9:53 PM
sjg accepted D44161: tarfs: Fix two input validation issues..
Mar 1 2024, 9:49 PM

Feb 27 2024

sjg committed rG8aea77bc3bf4: Add share/mk/local.dirdeps-targets.mk (authored by sjg).
Add share/mk/local.dirdeps-targets.mk
Feb 27 2024, 9:39 PM

Feb 21 2024

sjg accepted D43982: bearssl: Make shared library link.
Feb 21 2024, 3:32 AM

Feb 12 2024

sjg closed D43826: rc.subr add Exists so we can find sed.
Feb 12 2024, 10:41 PM
sjg committed rGb75bb99621fb: rc.subr add Exists so we can find sed (authored by sjg).
rc.subr add Exists so we can find sed
Feb 12 2024, 10:41 PM
sjg committed rGf616d61ab6b0: libsecureboot do not report expected unverified files (authored by sjg).
libsecureboot do not report expected unverified files
Feb 12 2024, 10:37 PM
sjg closed D43810: libsecureboot do not report expected unverified files.
Feb 12 2024, 10:36 PM
sjg added a comment to D43810: libsecureboot do not report expected unverified files.

No comment on the veriexec bits (they seem generally sane, but that's your area of course :-)), but the motivation described here:

When verifying a compressed module (.ko.gz or .ko.bz2)
stat() reports the size as -1 (unknown).
vectx_lseek needs to spot this during closing - and just read until
EOF is hit.

and the relevant hunk of the diff look OK to me.

Feb 12 2024, 10:35 PM
sjg updated the diff for D43810: libsecureboot do not report expected unverified files.

clean up local.trust.mk more

Feb 12 2024, 5:15 PM

Feb 11 2024

sjg updated the diff for D43826: rc.subr add Exists so we can find sed.

Use $() rather than backticks, and only look once.

Feb 11 2024, 8:56 PM
sjg added a comment to D43826: rc.subr add Exists so we can find sed.

This looks good. It makes an extra effort to find sed.
I just wonder if it is possible to define SED=${SED:-$(Exists -x /usr/bin/sed /rescue/sed)} only once in rc.subr, maybe at the beginning?

Feb 11 2024, 8:52 PM
sjg requested review of D43826: rc.subr add Exists so we can find sed.
Feb 11 2024, 1:01 AM

Feb 10 2024

sjg committed rG41f9823eda94: rc.subr.8 note when DebugOn will be called (authored by sjg).
rc.subr.8 note when DebugOn will be called
Feb 10 2024, 8:31 PM
sjg committed rG15483f96207d: rc.subr avoid noise if /usr not mounted (authored by sjg).
rc.subr avoid noise if /usr not mounted
Feb 10 2024, 6:15 PM
sjg updated the diff for D43810: libsecureboot do not report expected unverified files.

Update version.veriexec for SMBIOS 3 support

Feb 10 2024, 2:42 AM

Feb 9 2024

sjg updated the diff for D43810: libsecureboot do not report expected unverified files.

Put _TA_*_USE after _SIGN_*_USE

Feb 9 2024, 9:39 PM
sjg updated the diff for D43810: libsecureboot do not report expected unverified files.

Use version.veriexec when LOADER_VERIEXEC is enabled

Feb 9 2024, 9:35 PM
sjg requested review of D43810: libsecureboot do not report expected unverified files.
Feb 9 2024, 9:21 PM
sjg closed D43671: /etc/rc add trace debug and verify.
Feb 9 2024, 5:18 PM · rc
sjg committed rGaa3b7a2fbc46: /etc/rc add trace debug and verify (authored by sjg).
/etc/rc add trace debug and verify
Feb 9 2024, 5:18 PM
sjg updated the diff for D43671: /etc/rc add trace debug and verify.

Add SPDX BSD-2-Clause to safe_eval.sh

Feb 9 2024, 3:14 AM · rc

Feb 7 2024

sjg updated the diff for D43671: /etc/rc add trace debug and verify.

Use local.rc.subr rather than rc.subr.local

Feb 7 2024, 9:19 PM · rc
sjg updated the diff for D43671: /etc/rc add trace debug and verify.

Validate load_rc_config_reader

Feb 7 2024, 12:01 AM · rc

Feb 6 2024

sjg added inline comments to D43671: /etc/rc add trace debug and verify.
Feb 6 2024, 11:56 PM · rc
sjg updated the diff for D43671: /etc/rc add trace debug and verify.

Implement some feedback

Feb 6 2024, 11:51 PM · rc
sjg added inline comments to D43671: /etc/rc add trace debug and verify.
Feb 6 2024, 11:44 PM · rc

Feb 3 2024

sjg updated the diff for D43671: /etc/rc add trace debug and verify.

Update doc in debug.sh

Feb 3 2024, 7:09 PM · rc

Feb 2 2024

sjg updated the diff for D43671: /etc/rc add trace debug and verify.

rc.subr add comment explaining the no-op Debug{On,Off} and safe_dot
at the end - in case the real ones could not be found.

Feb 2 2024, 6:17 PM · rc
sjg updated the diff for D43671: /etc/rc add trace debug and verify.

Tweak debug.sh.8, use .Fn when refering to functions called.

Feb 2 2024, 6:09 PM · rc

Feb 1 2024

sjg added inline comments to D43701: loader: Document the lua loader table..
Feb 1 2024, 6:23 PM
sjg updated the diff for D43671: /etc/rc add trace debug and verify.

Man page tweaks

Feb 1 2024, 4:15 AM · rc
sjg updated the diff for D43671: /etc/rc add trace debug and verify.

Add man page for debug.sh

Feb 1 2024, 2:47 AM · rc

Jan 31 2024

sjg added inline comments to D43671: /etc/rc add trace debug and verify.
Jan 31 2024, 8:42 PM · rc
sjg updated the diff for D43671: /etc/rc add trace debug and verify.

Further man page tweaks

Jan 31 2024, 7:56 PM · rc
sjg updated the diff for D43671: /etc/rc add trace debug and verify.

Make a start on man pages

Jan 31 2024, 7:33 PM · rc
sjg added inline comments to D43671: /etc/rc add trace debug and verify.
Jan 31 2024, 8:09 AM · rc
sjg updated the diff for D43671: /etc/rc add trace debug and verify.

Fix some style issues in rc.subr

Jan 31 2024, 8:05 AM · rc
sjg added a comment to D43671: /etc/rc add trace debug and verify.

Will have a go at the style issues.

Jan 31 2024, 7:40 AM · rc

Jan 30 2024

sjg updated the diff for D43671: /etc/rc add trace debug and verify.

Check for -f as well as -s

Jan 30 2024, 11:47 PM · rc
sjg added a comment to D39624: veriexec: Add support in rc.d script processing..

This is overcome by D43671

Jan 30 2024, 8:15 PM · rc
sjg added a project to D43671: /etc/rc add trace debug and verify: rc.

Note: If the format of rc_log is deemed undesirable we could move it (and rc_trace) to rc.subr.local and just put a place holder in rc.subr

Jan 30 2024, 7:30 PM · rc
sjg requested review of D43671: /etc/rc add trace debug and verify.
Jan 30 2024, 7:27 PM · rc
sjg added a comment to D39624: veriexec: Add support in rc.d script processing..

I know a few folk are interested in using mac_veriexec, but we could push the guts of vdot etc into rc.subr.local (I've moved it to the end of the file) and just put a place holder here like vdot() { dot "$@"; }. It is the callouts in run_rc_* etc which are most important.

Jan 30 2024, 6:02 PM · rc

Jan 14 2024

sjg committed rGd5e0a182cf15: Update to bmake-20240108 (authored by sjg).
Update to bmake-20240108
Jan 14 2024, 1:32 AM
sjg committed rG7a05a7153af6: Import bmake-20240108 (authored by sjg).
Import bmake-20240108
Jan 14 2024, 1:18 AM

Jan 13 2024

sjg added inline comments to D43009: kerberos: Fix numerous segfaults when using weak crypto.
Jan 13 2024, 5:19 PM

Dec 30 2023

sjg committed rG4d08b569a01e: bsd.man.mk allow staging compressed pages (authored by sjg).
bsd.man.mk allow staging compressed pages
Dec 30 2023, 5:13 PM
sjg closed D43238: bsd.man.mk allow staging compressed pages.
Dec 30 2023, 5:12 PM
sjg requested review of D43238: bsd.man.mk allow staging compressed pages.
Dec 30 2023, 12:24 AM

Dec 7 2023

sjg committed rG5c8b07fe8449: bsdinstall: add include to SUBDIR (authored by sjg).
bsdinstall: add include to SUBDIR
Dec 7 2023, 6:18 AM
sjg committed rG83d0b8c089d8: bsdinstall generate opt_osname.h in include (authored by sjg).
bsdinstall generate opt_osname.h in include
Dec 7 2023, 2:36 AM
sjg closed D42947: bsdinstall generate opt_osname.h in osname.
Dec 7 2023, 2:36 AM
sjg added a comment to D42947: bsdinstall generate opt_osname.h in osname.

One nit, and I assume you've verified that opt_osname.h does now have the right contents?

Dec 7 2023, 2:32 AM
sjg updated the diff for D42947: bsdinstall generate opt_osname.h in osname.

missed SUBDIR_DEPEND_

Dec 7 2023, 1:45 AM
sjg updated the diff for D42947: bsdinstall generate opt_osname.h in osname.

Rename osname to include

Dec 7 2023, 1:43 AM
sjg requested review of D42947: bsdinstall generate opt_osname.h in osname.
Dec 7 2023, 1:19 AM

Nov 20 2023

sjg committed rG0a45a7e99fc3: Fix share/zoneinfo for DIRDEPS_BUILD (authored by sjg).
Fix share/zoneinfo for DIRDEPS_BUILD
Nov 20 2023, 8:54 PM
sjg closed D42624: Fix share/zoneinfo for DIRDEPS_BUILD.
Nov 20 2023, 8:54 PM