Page MenuHomeFreeBSD

sjg (Simon Gerraty)
User

Projects

User Details

User Since
Apr 9 2015, 9:27 PM (293 w, 4 d)

Recent Activity

Sat, Nov 21

sjg updated the diff for D27300: Update dirdeps.mk et al to latest.

Revert extra blank lines

Sat, Nov 21, 2:40 AM
sjg updated the diff for D27300: Update dirdeps.mk et al to latest.

Grab LEVEL0_TARGETS from init.mk

Sat, Nov 21, 2:38 AM
sjg added inline comments to D27300: Update dirdeps.mk et al to latest.
Sat, Nov 21, 12:48 AM
sjg updated the diff for D27300: Update dirdeps.mk et al to latest.

remove refs to BUILD_AT_LEVEL0

Sat, Nov 21, 12:44 AM

Fri, Nov 20

sjg added inline comments to D27299: legacy: Use -isystem for system header overrides..
Fri, Nov 20, 9:47 PM
sjg added a reviewer for D27300: Update dirdeps.mk et al to latest: bdrewery.
Fri, Nov 20, 9:40 PM
sjg requested review of D27300: Update dirdeps.mk et al to latest.
Fri, Nov 20, 9:38 PM
sjg committed rS367863: Merge bmake-20201117.
Merge bmake-20201117
Fri, Nov 20, 6:03 AM
sjg committed rS367861: tag bmake-20201117.
tag bmake-20201117
Fri, Nov 20, 3:56 AM

Wed, Nov 18

sjg committed rS367808: Retain missing/sys/cdefs.h to support build on non-FreeBSD.
Retain missing/sys/cdefs.h to support build on non-FreeBSD
Wed, Nov 18, 5:50 PM

Mon, Nov 16

sjg added a comment to D27234: Attempt to unbreak bmake bootstrap on Linux.

The ksh issue is already fixed in bmake-20201114
can you try http://www.crufty.net:/ftp/pub/sjg/beta/bmake-20201114.tar.gz to confirm the other issue is also fixed

Mon, Nov 16, 8:15 PM

Tue, Nov 10

sjg accepted D27134: makeman: Don't require filemon with MK_DIRDEPS_BUILD..
Tue, Nov 10, 4:43 AM

Sun, Nov 8

sjg added inline comments to D27134: makeman: Don't require filemon with MK_DIRDEPS_BUILD..
Sun, Nov 8, 2:27 AM

Sat, Nov 7

sjg committed rS367465: Update to bmake-20201101.
Update to bmake-20201101
Sat, Nov 7, 9:47 PM
sjg committed rS367461: tag bmake-20201101.
tag bmake-20201101
Sat, Nov 7, 7:42 PM
sjg committed rS367460: Import bmake-20201101.
Import bmake-20201101
Sat, Nov 7, 7:39 PM

Oct 9 2020

sjg added a comment to D26576: Skip two bmake tests when using a strict POSIX shell.

Should I wait for an upstream resolution? Or should I fix this revision and commit the workaround?

Oct 9 2020, 4:12 PM

Oct 3 2020

sjg added a comment to D26576: Skip two bmake tests when using a strict POSIX shell.
In D26576#593624, @sjg wrote:

Which version of Ubuntu are you talking about? I build all version of bmake on ubuntu without problem, and
the expected result for export.mk does not include any variable that does not consist of only [_A-Za-z0-9]

make-exported should be fixed - upstream

FYI later versions of bmake use -r for all tests to avoid contamination from your local makefiles.

export.exp contains the line &=ampersand which will not be printed by dash since it filters out that variable (& is not allowed in env vars by dash).

Oct 3 2020, 6:16 PM

Oct 2 2020

sjg added a comment to D26576: Skip two bmake tests when using a strict POSIX shell.

Which version of Ubuntu are you talking about? I build all version of bmake on ubuntu without problem, and
the expected result for export.mk does not include any variable that does not consist of only [_A-Za-z0-9]

Oct 2 2020, 11:51 PM

Sep 5 2020

sjg committed rS365366: Update to bmake-20200902.
Update to bmake-20200902
Sep 5 2020, 7:30 PM
sjg committed rS365363: tag bmake-20200902.
tag bmake-20200902
Sep 5 2020, 4:45 PM
sjg committed rS365361: Import bmake-20200902.
Import bmake-20200902
Sep 5 2020, 4:11 PM

Sep 4 2020

sjg accepted D26321: Avoid collisions with function names in openssl headers..
Sep 4 2020, 2:52 AM

Aug 29 2020

sjg closed D26235: zalloc_malloc:Free hexdump preceeding buffer when we detect overflow.
Aug 29 2020, 9:06 PM
sjg committed rS364965: zalloc_malloc:Free hexdump preceeding buffer when we detect overflow.
zalloc_malloc:Free hexdump preceeding buffer when we detect overflow
Aug 29 2020, 9:06 PM
sjg added inline comments to D26235: zalloc_malloc:Free hexdump preceeding buffer when we detect overflow.
Aug 29 2020, 8:59 PM
sjg updated the diff for D26235: zalloc_malloc:Free hexdump preceeding buffer when we detect overflow.

fix typo

Aug 29 2020, 8:57 PM
sjg updated the diff for D26235: zalloc_malloc:Free hexdump preceeding buffer when we detect overflow.

fix typo

Aug 29 2020, 8:49 PM
sjg updated the diff for D26235: zalloc_malloc:Free hexdump preceeding buffer when we detect overflow.

fix typo

Aug 29 2020, 8:05 PM
sjg added reviewers for D26235: zalloc_malloc:Free hexdump preceeding buffer when we detect overflow: imp, kevans, stevek.

Added the HEXDUMP_PAGER #ifdef, since otherwise pager (which we do not need in this case) causes linking issue for boot1

Aug 29 2020, 7:54 PM
sjg requested review of D26235: zalloc_malloc:Free hexdump preceeding buffer when we detect overflow.
Aug 29 2020, 7:51 PM
sjg committed rS364962: mac_veriexec_fingerprint_check_vnode: v_writecount > 0 means active writers.
mac_veriexec_fingerprint_check_vnode: v_writecount > 0 means active writers
Aug 29 2020, 4:27 PM
sjg committed rS364961: MFC loader fixes.
MFC loader fixes
Aug 29 2020, 4:23 PM

Aug 25 2020

sjg added a comment to D26169: Move libsqlite3 to the top of the SUBDIR list.
In D26169#581544, @sjg wrote:

Best way to get parallelism is to avoid tree walks.
Once system is pkg based, there should be a path to enabling that.

Does that mean this change is fine for now?

Aug 25 2020, 11:55 PM
sjg added a comment to D26169: Move libsqlite3 to the top of the SUBDIR list.

Best way to get parallelism is to avoid tree walks.
Once system is pkg based, there should be a path to enabling that.

Aug 25 2020, 4:53 AM

Aug 21 2020

sjg committed rS364443: veloader: insist on verifying .4th .lua etc.
veloader: insist on verifying .4th .lua etc
Aug 21 2020, 12:27 AM

Aug 2 2020

sjg committed rP543927: Add sjg.
Add sjg
Aug 2 2020, 1:08 AM

Jul 20 2020

sjg committed rS363352: Update to bmake-20200710.
Update to bmake-20200710
Jul 20 2020, 12:17 AM

Jul 19 2020

sjg committed rS363351: Revert that!.
Revert that!
Jul 19 2020, 11:56 PM
sjg committed rS363350: Oops missed Makefile.config.
Oops missed Makefile.config
Jul 19 2020, 11:54 PM

Jul 12 2020

sjg committed rS363117: Update to bmake-20200710.
Update to bmake-20200710
Jul 12 2020, 1:12 AM

Jul 11 2020

sjg committed rS363116: tag bmake-20200710.
tag bmake-20200710
Jul 11 2020, 10:46 PM
sjg committed rS363115: Import bmake-20200710.
Import bmake-20200710
Jul 11 2020, 10:45 PM

Jul 9 2020

sjg committed rS363035: Revert r363031.
Revert r363031
Jul 9 2020, 3:46 AM

Jul 8 2020

sjg committed rS363031: Update to bmake-20200704.
Update to bmake-20200704
Jul 8 2020, 9:20 PM
sjg committed rS363019: tag bmake-20200704.
tag bmake-20200704
Jul 8 2020, 6:33 PM
sjg committed rS363018: Import bmake-20200704.
Import bmake-20200704
Jul 8 2020, 6:32 PM

Jul 1 2020

sjg committed rS362822: tag bmake-20200629.
tag bmake-20200629
Jul 1 2020, 2:13 AM
sjg committed rS362821: Import bmake-20200629.
Import bmake-20200629
Jul 1 2020, 2:13 AM

Jun 27 2020

sjg accepted D25477: Kernel build changes for openzfs vendor import.

There is always room for improvement, but this seems generally ok.
FWIW the "how to write makefiles" doc I provide to devs at Juniper includes
"""

  1. Do not put anything in your makefile that you don't need
  2. Do not put anything in your makefile that you cannot explain the need for. Ie. if you cannot explain it, you don't need it, remove it.
  3. Do not cut/paste anything from your friend's makefile (see #1).
Jun 27 2020, 6:08 PM

Jun 26 2020

sjg added inline comments to D25477: Kernel build changes for openzfs vendor import.
Jun 26 2020, 11:02 PM
sjg added inline comments to D25477: Kernel build changes for openzfs vendor import.
Jun 26 2020, 9:43 PM

Jun 19 2020

sjg added a comment to D25346: bmake: Hide noisy spam behind debug options.

I think the following is sufficient:

Jun 19 2020, 4:41 AM

Jun 18 2020

sjg added a comment to D25346: bmake: Hide noisy spam behind debug options.

All in all the approach here looks wrong.
Let me ponder/poke...

Jun 18 2020, 11:45 PM
sjg added a comment to D25346: bmake: Hide noisy spam behind debug options.

This is nice. I'm not sure if using -s would make things harder when we need to check flags, but can get rid of 'make[N]: stopped in /foo/bar' is really helpful.

Jun 18 2020, 11:37 PM
sjg added a comment to D25346: bmake: Hide noisy spam behind debug options.

If the build log is 6Gb (because the build took 10hrs before it failed), the extra noise at the end is the least of your problems.
Needing to redo that job to have any clue as to when and why it failed is not an option.
So again, if make is exiting due to an error token, by all means keep quiet, but otherwise noise is better than silence.

Jun 18 2020, 11:32 PM
sjg added a comment to D25346: bmake: Hide noisy spam behind debug options.

Do you have an example of resulting output?

Jun 18 2020, 11:20 PM

Jun 16 2020

sjg committed rS362231: Make KENV_MVALLEN tunable.
Make KENV_MVALLEN tunable
Jun 16 2020, 5:03 PM

Jun 13 2020

sjg added reviewers for D25259: Make KENV_MVALLEN tunable: stevek, kevans.
Jun 13 2020, 5:28 PM
sjg requested review of D25259: Make KENV_MVALLEN tunable.
Jun 13 2020, 5:18 PM

Jun 12 2020

sjg committed rS362127: verify_pcr_export: bump kenv_mvallen if needed.
verify_pcr_export: bump kenv_mvallen if needed
Jun 12 2020, 9:55 PM
sjg committed rS362125: mac_veriexec_fingerprint_check_vnode: v_writecount > 0 means active writers.
mac_veriexec_fingerprint_check_vnode: v_writecount > 0 means active writers
Jun 12 2020, 9:51 PM
sjg committed rS362124: Minor cleanup of initialized variables.
Minor cleanup of initialized variables
Jun 12 2020, 9:49 PM

Jun 9 2020

sjg committed rS361986: Merge bmake-20200606.
Merge bmake-20200606
Jun 9 2020, 8:53 PM
sjg committed rS361955: tag bmake-20200606.
tag bmake-20200606
Jun 9 2020, 2:08 AM
sjg committed rS361954: Import bmake-20200606.
Import bmake-20200606
Jun 9 2020, 2:07 AM

Jun 8 2020

sjg committed rS361933: loader: install allow for more complete device spec in url.
loader: install allow for more complete device spec in url
Jun 8 2020, 6:14 PM

Jun 5 2020

sjg updated the diff for D25134: loader: install allow for more complete device spec in url.

Avoid comparison errors

Jun 5 2020, 5:52 PM

Jun 4 2020

sjg added reviewers for D25134: loader: install allow for more complete device spec in url: stevek, imp, kevans.

Simplify code and allow for control of devname and fstype

Jun 4 2020, 8:52 PM
sjg requested review of D25134: loader: install allow for more complete device spec in url.
Jun 4 2020, 8:50 PM

Jun 1 2020

sjg committed rS361710: stand/uboot: fix setting of gateip.s_addr.
stand/uboot: fix setting of gateip.s_addr
Jun 1 2020, 11:44 PM

May 31 2020

sjg committed rS361674: Update to bmake-20200517.
Update to bmake-20200517
May 31 2020, 9:44 PM

May 20 2020

sjg committed rS361307: Merge bmake-20200517.
Merge bmake-20200517
May 20 2020, 10:26 PM
sjg committed rS361289: tag bmake-20200517.
tag bmake-20200517
May 20 2020, 7:36 PM
sjg committed rS361288: Import bmake-20200517.
Import bmake-20200517
May 20 2020, 7:35 PM

Apr 30 2020

sjg committed rS360481: Define enum for so_qstate outside of struct..
Define enum for so_qstate outside of struct.
Apr 30 2020, 12:20 AM

Apr 18 2020

sjg committed rS360059: Define enum for so_qstate outside of struct..
Define enum for so_qstate outside of struct.
Apr 18 2020, 1:22 AM

Apr 17 2020

sjg added a comment to D24477: llvm9 wont allow enum definition inside anon-struct.

Of the 100 .meta files, this is the one I didn't save. The error with clang++ was "cannot declare types inside an anonymous struct."

Apr 17 2020, 9:40 PM
sjg added reviewers for D24477: llvm9 wont allow enum definition inside anon-struct: jtl, jhb.
Apr 17 2020, 7:14 PM
sjg created D24477: llvm9 wont allow enum definition inside anon-struct.
Apr 17 2020, 7:05 PM

Apr 14 2020

sjg committed rS359913: Do not claim libbearssl et al are INTERNALLIB.
Do not claim libbearssl et al are INTERNALLIB
Apr 14 2020, 1:08 AM
sjg committed rS359912: Include ${.CURDIR}/local.init.mk if it exists.
Include ${.CURDIR}/local.init.mk if it exists
Apr 14 2020, 1:05 AM
sjg committed rS359911: Improve interaction of vectx and tftp.
Improve interaction of vectx and tftp
Apr 14 2020, 12:58 AM

Apr 10 2020

sjg committed rS359769: veloader use vectx API for kernel and modules.
veloader use vectx API for kernel and modules
Apr 10 2020, 5:13 AM

Apr 9 2020

sjg committed rS359735: veloader use vectx API for kernel and modules.
veloader use vectx API for kernel and modules
Apr 9 2020, 4:50 AM

Apr 7 2020

sjg committed rS359700: Improve interaction of vectx and tftp.
Improve interaction of vectx and tftp
Apr 7 2020, 4:56 PM
sjg closed D24287: Improve interaction of vectx and tftp.
Apr 7 2020, 4:56 PM
sjg updated the diff for D24287: Improve interaction of vectx and tftp.

fix cachesz checks for sure

Apr 7 2020, 4:54 PM
sjg updated the diff for D24287: Improve interaction of vectx and tftp.

fix cachesz checks

Apr 7 2020, 4:52 PM

Apr 4 2020

sjg added a comment to D24270: bsd.{files,conf}.mk: remove some complicated logic.

These files became far more complicated recently I think perhaps as a consequence of moving etc/ files all over the place, and then needing to make them install to the right place.
Since that need is? going away, perhaps the complexity can too.

Apr 4 2020, 2:21 AM
sjg updated the diff for D24287: Improve interaction of vectx and tftp.

skip reset tries

Apr 4 2020, 2:12 AM
sjg added reviewers for D24287: Improve interaction of vectx and tftp: stevek, imp.
Apr 4 2020, 12:24 AM
sjg created D24287: Improve interaction of vectx and tftp.
Apr 4 2020, 12:21 AM

Apr 1 2020

sjg committed rS359502: Do not claim libbearssl et al are INTERNALLIB.
Do not claim libbearssl et al are INTERNALLIB
Apr 1 2020, 5:45 AM

Mar 31 2020

sjg committed rS359488: Include ${.CURDIR}/local.init.mk if it exists.
Include ${.CURDIR}/local.init.mk if it exists
Mar 31 2020, 3:59 PM
sjg added a reviewer for D24233: Do not claim libbearssl et al are INTERNALLIB: emaste.
Mar 31 2020, 3:54 AM
sjg created D24233: Do not claim libbearssl et al are INTERNALLIB.
Mar 31 2020, 1:18 AM
sjg updated the diff for D24101: Allow for per directory local.init.mk.

Guard against multiple inclusion

Mar 31 2020, 12:11 AM

Mar 25 2020

sjg committed rS359307: Fix pkgfs stat so it satisfies libsecureboot.
Fix pkgfs stat so it satisfies libsecureboot
Mar 25 2020, 7:12 PM

Mar 17 2020

sjg added reviewers for D24101: Allow for per directory local.init.mk: bdrewery, imp, emaste.
Mar 17 2020, 5:41 PM