Page MenuHomeFreeBSD

sjg (Simon Gerraty)
User

Projects

User Details

User Since
Apr 9 2015, 9:27 PM (274 w, 2 d)

Recent Activity

Thu, Jul 9

sjg committed rS363035: Revert r363031.
Revert r363031
Thu, Jul 9, 3:46 AM

Wed, Jul 8

sjg committed rS363031: Update to bmake-20200704.
Update to bmake-20200704
Wed, Jul 8, 9:20 PM
sjg committed rS363019: tag bmake-20200704.
tag bmake-20200704
Wed, Jul 8, 6:33 PM
sjg committed rS363018: Import bmake-20200704.
Import bmake-20200704
Wed, Jul 8, 6:32 PM

Wed, Jul 1

sjg committed rS362822: tag bmake-20200629.
tag bmake-20200629
Wed, Jul 1, 2:13 AM
sjg committed rS362821: Import bmake-20200629.
Import bmake-20200629
Wed, Jul 1, 2:13 AM

Sat, Jun 27

sjg accepted D25477: Kernel build changes for openzfs vendor import.

There is always room for improvement, but this seems generally ok.
FWIW the "how to write makefiles" doc I provide to devs at Juniper includes
"""

  1. Do not put anything in your makefile that you don't need
  2. Do not put anything in your makefile that you cannot explain the need for. Ie. if you cannot explain it, you don't need it, remove it.
  3. Do not cut/paste anything from your friend's makefile (see #1).
Sat, Jun 27, 6:08 PM

Fri, Jun 26

sjg added inline comments to D25477: Kernel build changes for openzfs vendor import.
Fri, Jun 26, 11:02 PM
sjg added inline comments to D25477: Kernel build changes for openzfs vendor import.
Fri, Jun 26, 9:43 PM

Fri, Jun 19

sjg added a comment to D25346: bmake: Hide noisy spam behind debug options.

I think the following is sufficient:

Fri, Jun 19, 4:41 AM

Thu, Jun 18

sjg added a comment to D25346: bmake: Hide noisy spam behind debug options.

All in all the approach here looks wrong.
Let me ponder/poke...

Thu, Jun 18, 11:45 PM
sjg added a comment to D25346: bmake: Hide noisy spam behind debug options.

This is nice. I'm not sure if using -s would make things harder when we need to check flags, but can get rid of 'make[N]: stopped in /foo/bar' is really helpful.

Thu, Jun 18, 11:37 PM
sjg added a comment to D25346: bmake: Hide noisy spam behind debug options.

If the build log is 6Gb (because the build took 10hrs before it failed), the extra noise at the end is the least of your problems.
Needing to redo that job to have any clue as to when and why it failed is not an option.
So again, if make is exiting due to an error token, by all means keep quiet, but otherwise noise is better than silence.

Thu, Jun 18, 11:32 PM
sjg added a comment to D25346: bmake: Hide noisy spam behind debug options.

Do you have an example of resulting output?

Thu, Jun 18, 11:20 PM

Tue, Jun 16

sjg committed rS362231: Make KENV_MVALLEN tunable.
Make KENV_MVALLEN tunable
Tue, Jun 16, 5:03 PM

Sat, Jun 13

sjg added reviewers for D25259: Make KENV_MVALLEN tunable: stevek, kevans.
Sat, Jun 13, 5:28 PM
sjg requested review of D25259: Make KENV_MVALLEN tunable.
Sat, Jun 13, 5:18 PM

Fri, Jun 12

sjg committed rS362127: verify_pcr_export: bump kenv_mvallen if needed.
verify_pcr_export: bump kenv_mvallen if needed
Fri, Jun 12, 9:55 PM
sjg committed rS362125: mac_veriexec_fingerprint_check_vnode: v_writecount > 0 means active writers.
mac_veriexec_fingerprint_check_vnode: v_writecount > 0 means active writers
Fri, Jun 12, 9:51 PM
sjg committed rS362124: Minor cleanup of initialized variables.
Minor cleanup of initialized variables
Fri, Jun 12, 9:49 PM

Jun 9 2020

sjg committed rS361986: Merge bmake-20200606.
Merge bmake-20200606
Jun 9 2020, 8:53 PM
sjg committed rS361955: tag bmake-20200606.
tag bmake-20200606
Jun 9 2020, 2:08 AM
sjg committed rS361954: Import bmake-20200606.
Import bmake-20200606
Jun 9 2020, 2:07 AM

Jun 8 2020

sjg committed rS361933: loader: install allow for more complete device spec in url.
loader: install allow for more complete device spec in url
Jun 8 2020, 6:14 PM

Jun 5 2020

sjg updated the diff for D25134: loader: install allow for more complete device spec in url.

Avoid comparison errors

Jun 5 2020, 5:52 PM

Jun 4 2020

sjg added reviewers for D25134: loader: install allow for more complete device spec in url: stevek, imp, kevans.

Simplify code and allow for control of devname and fstype

Jun 4 2020, 8:52 PM
sjg requested review of D25134: loader: install allow for more complete device spec in url.
Jun 4 2020, 8:50 PM

Jun 1 2020

sjg committed rS361710: stand/uboot: fix setting of gateip.s_addr.
stand/uboot: fix setting of gateip.s_addr
Jun 1 2020, 11:44 PM

May 31 2020

sjg committed rS361674: Update to bmake-20200517.
Update to bmake-20200517
May 31 2020, 9:44 PM

May 20 2020

sjg committed rS361307: Merge bmake-20200517.
Merge bmake-20200517
May 20 2020, 10:26 PM
sjg committed rS361289: tag bmake-20200517.
tag bmake-20200517
May 20 2020, 7:36 PM
sjg committed rS361288: Import bmake-20200517.
Import bmake-20200517
May 20 2020, 7:35 PM

Apr 30 2020

sjg committed rS360481: Define enum for so_qstate outside of struct..
Define enum for so_qstate outside of struct.
Apr 30 2020, 12:20 AM

Apr 18 2020

sjg committed rS360059: Define enum for so_qstate outside of struct..
Define enum for so_qstate outside of struct.
Apr 18 2020, 1:22 AM

Apr 17 2020

sjg added a comment to D24477: llvm9 wont allow enum definition inside anon-struct.

Of the 100 .meta files, this is the one I didn't save. The error with clang++ was "cannot declare types inside an anonymous struct."

Apr 17 2020, 9:40 PM
sjg added reviewers for D24477: llvm9 wont allow enum definition inside anon-struct: jtl, jhb.
Apr 17 2020, 7:14 PM
sjg created D24477: llvm9 wont allow enum definition inside anon-struct.
Apr 17 2020, 7:05 PM

Apr 14 2020

sjg committed rS359913: Do not claim libbearssl et al are INTERNALLIB.
Do not claim libbearssl et al are INTERNALLIB
Apr 14 2020, 1:08 AM
sjg committed rS359912: Include ${.CURDIR}/local.init.mk if it exists.
Include ${.CURDIR}/local.init.mk if it exists
Apr 14 2020, 1:05 AM
sjg committed rS359911: Improve interaction of vectx and tftp.
Improve interaction of vectx and tftp
Apr 14 2020, 12:58 AM

Apr 10 2020

sjg committed rS359769: veloader use vectx API for kernel and modules.
veloader use vectx API for kernel and modules
Apr 10 2020, 5:13 AM

Apr 9 2020

sjg committed rS359735: veloader use vectx API for kernel and modules.
veloader use vectx API for kernel and modules
Apr 9 2020, 4:50 AM

Apr 7 2020

sjg committed rS359700: Improve interaction of vectx and tftp.
Improve interaction of vectx and tftp
Apr 7 2020, 4:56 PM
sjg closed D24287: Improve interaction of vectx and tftp.
Apr 7 2020, 4:56 PM
sjg updated the diff for D24287: Improve interaction of vectx and tftp.

fix cachesz checks for sure

Apr 7 2020, 4:54 PM
sjg updated the diff for D24287: Improve interaction of vectx and tftp.

fix cachesz checks

Apr 7 2020, 4:52 PM

Apr 4 2020

sjg added a comment to D24270: bsd.{files,conf}.mk: remove some complicated logic.

These files became far more complicated recently I think perhaps as a consequence of moving etc/ files all over the place, and then needing to make them install to the right place.
Since that need is? going away, perhaps the complexity can too.

Apr 4 2020, 2:21 AM
sjg updated the diff for D24287: Improve interaction of vectx and tftp.

skip reset tries

Apr 4 2020, 2:12 AM
sjg added reviewers for D24287: Improve interaction of vectx and tftp: stevek, imp.
Apr 4 2020, 12:24 AM
sjg created D24287: Improve interaction of vectx and tftp.
Apr 4 2020, 12:21 AM

Apr 1 2020

sjg committed rS359502: Do not claim libbearssl et al are INTERNALLIB.
Do not claim libbearssl et al are INTERNALLIB
Apr 1 2020, 5:45 AM

Mar 31 2020

sjg committed rS359488: Include ${.CURDIR}/local.init.mk if it exists.
Include ${.CURDIR}/local.init.mk if it exists
Mar 31 2020, 3:59 PM
sjg added a reviewer for D24233: Do not claim libbearssl et al are INTERNALLIB: emaste.
Mar 31 2020, 3:54 AM
sjg created D24233: Do not claim libbearssl et al are INTERNALLIB.
Mar 31 2020, 1:18 AM
sjg updated the diff for D24101: Allow for per directory local.init.mk.

Guard against multiple inclusion

Mar 31 2020, 12:11 AM

Mar 25 2020

sjg committed rS359307: Fix pkgfs stat so it satisfies libsecureboot.
Fix pkgfs stat so it satisfies libsecureboot
Mar 25 2020, 7:12 PM

Mar 17 2020

sjg added reviewers for D24101: Allow for per directory local.init.mk: bdrewery, imp, emaste.
Mar 17 2020, 5:41 PM
sjg created D24101: Allow for per directory local.init.mk.
Mar 17 2020, 5:39 PM

Mar 15 2020

sjg added inline comments to D24027: Fix pkgfs stat so it satisfies libsecureboot.
Mar 15 2020, 8:12 PM
sjg updated the diff for D24027: Fix pkgfs stat so it satisfies libsecureboot.

ve_pcr_update: check malloc failure

Mar 15 2020, 8:08 PM

Mar 13 2020

sjg updated the diff for D24027: Fix pkgfs stat so it satisfies libsecureboot.

vectx_close: ensure we have hashed whole file

Mar 13 2020, 4:51 AM

Mar 12 2020

sjg updated the diff for D24027: Fix pkgfs stat so it satisfies libsecureboot.

Fix pkg_seek - can rewind within cache limit

Mar 12 2020, 7:03 AM

Mar 11 2020

sjg added reviewers for D24027: Fix pkgfs stat so it satisfies libsecureboot: imp, tsoome, stevek.
Mar 11 2020, 8:24 PM
sjg created D24027: Fix pkgfs stat so it satisfies libsecureboot.
Mar 11 2020, 8:20 PM

Mar 9 2020

sjg committed rS358813: veloader use vectx API for kernel and modules.
veloader use vectx API for kernel and modules
Mar 9 2020, 4:03 PM
sjg committed rS358811: veloader use vectx API for kernel and modules.
veloader use vectx API for kernel and modules
Mar 9 2020, 3:49 PM

Mar 8 2020

sjg committed rS358767: veloader use vectx API for kernel and modules.
veloader use vectx API for kernel and modules
Mar 8 2020, 6:48 PM
sjg committed rS358744: veloader use vectx API for kernel and modules.
veloader use vectx API for kernel and modules
Mar 8 2020, 5:43 PM

Mar 3 2020

sjg updated the diff for D23827: veloader use vectx API for kernel and modules.

Use typedef for readin_handle_t

Mar 3 2020, 11:39 PM
sjg added inline comments to D23827: veloader use vectx API for kernel and modules.
Mar 3 2020, 11:35 PM

Mar 1 2020

sjg added a reviewer for D23827: veloader use vectx API for kernel and modules: tsoome.
Mar 1 2020, 6:55 PM

Feb 28 2020

sjg added a reviewer for D23827: veloader use vectx API for kernel and modules: stevek.
Feb 28 2020, 10:50 PM
sjg updated the diff for D23827: veloader use vectx API for kernel and modules.

Add readin.h to define READIN_HANDLE_T

Feb 28 2020, 10:29 PM
sjg updated the diff for D23827: veloader use vectx API for kernel and modules.

Add readin.h to define READIN_HANDLE_T

Feb 28 2020, 10:29 PM

Feb 25 2020

sjg updated the diff for D23827: veloader use vectx API for kernel and modules.

update test app

Feb 25 2020, 7:46 PM
sjg added a reviewer for D23827: veloader use vectx API for kernel and modules: imp.
Feb 25 2020, 1:04 AM
sjg created D23827: veloader use vectx API for kernel and modules.
Feb 25 2020, 1:04 AM

Jan 30 2020

sjg accepted D23411: stand: properly declare build dependencies or .WAIT, start building in parallel.

For tree walks .WAIT is a legit solution

Jan 30 2020, 1:38 AM

Jan 10 2020

sjg added a comment to D23122: retire BSD_CRTBEGIN option.

There should not be any active depends mentioning gnu/lib/csu - that's the point of the filters,
any stale entries will be ignored - if the directory is gone.

Jan 10 2020, 5:19 PM

Dec 20 2019

sjg committed rS355962: Avoid unused vars when VE_ECDSA_HASH_AGAIN undefined.
Avoid unused vars when VE_ECDSA_HASH_AGAIN undefined
Dec 20 2019, 9:56 PM

Dec 19 2019

sjg committed rS355906: Add Makefile.depend.options.
Add Makefile.depend.options
Dec 19 2019, 4:59 AM
sjg committed rS355905: Update dirdeps.mk and gendirdeps.mk.
Update dirdeps.mk and gendirdeps.mk
Dec 19 2019, 4:49 AM
sjg committed rS355904: Tweaks for DIRDEPS_BUILD.
Tweaks for DIRDEPS_BUILD
Dec 19 2019, 2:40 AM
sjg closed D22872: Tweaks for DIRDEPS_BUILD.
Dec 19 2019, 2:40 AM
sjg added a reviewer for D22872: Tweaks for DIRDEPS_BUILD: bdrewery.
Dec 19 2019, 2:30 AM
sjg created D22872: Tweaks for DIRDEPS_BUILD.
Dec 19 2019, 2:28 AM

Dec 13 2019

sjg added inline comments to D21800: fix emulation name passed to linker when cross compiling.
Dec 13 2019, 7:46 PM · PowerPC

Dec 11 2019

sjg committed rS355618: Update dirdeps.mk and gendirdeps.mk.
Update dirdeps.mk and gendirdeps.mk
Dec 11 2019, 5:38 PM
sjg closed D22495: Update dirdeps.mk and gendirdeps.mk.
Dec 11 2019, 5:38 PM
sjg committed rS355617: Update Makefile.depend files.
Update Makefile.depend files
Dec 11 2019, 5:38 PM
sjg closed D22494: Update depends.
Dec 11 2019, 5:38 PM
sjg committed rS355616: Add Makefile.depend.options.
Add Makefile.depend.options
Dec 11 2019, 5:38 PM
sjg closed D22469: Add Makefile.depend.options.
Dec 11 2019, 5:37 PM

Nov 22 2019

sjg retitled D22494: Update depends from Update dirdeps.mk and depends to Update depends.
Nov 22 2019, 12:31 AM
sjg added a reviewer for D22495: Update dirdeps.mk and gendirdeps.mk: bdrewery.
Nov 22 2019, 12:30 AM
sjg created D22495: Update dirdeps.mk and gendirdeps.mk.
Nov 22 2019, 12:29 AM
sjg updated the diff for D22494: Update depends.

just depends

Nov 22 2019, 12:27 AM
sjg added a reviewer for D22494: Update depends: bdrewery.
Nov 22 2019, 12:18 AM
sjg created D22494: Update depends.
Nov 22 2019, 12:17 AM

Nov 21 2019

sjg updated the diff for D22469: Add Makefile.depend.options.

Add warning about not autogen

Nov 21 2019, 10:34 PM