Page MenuHomeFreeBSD
Differential D56795

Add test cases for safe_eval.sh
ClosedPublic
Actions

Authored by sjg on Mon, May 4, 6:33 PM.
Tags
None
Referenced Files
F157156126: D56795.diff
Mon, May 18, 8:45 PM
Unknown Object (File)
Fri, May 15, 4:46 AM
Unknown Object (File)
Thu, May 14, 2:28 PM
Unknown Object (File)
Thu, May 14, 10:46 AM
Unknown Object (File)
Thu, May 14, 10:37 AM
Unknown Object (File)
Thu, May 14, 10:15 AM
Unknown Object (File)
Thu, May 14, 7:39 AM
Unknown Object (File)
Thu, May 14, 3:56 AM
View All 21 Files
Subscribers
None

Details

Reviewers
des
imp
stevek
Commits
rG701d7be6e4a9: Add test cases for safe_eval.sh
Summary

safe_set is the routine that does all the work.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sjg requested review of this revision.Mon, May 4, 6:33 PM
sjg created this revision.
Harbormaster completed remote builds in B72780: Diff 177183.Mon, May 4, 6:33 PM
sjg updated this revision to Diff 177217.Tue, May 5, 4:32 AM

Add $() example

Harbormaster completed remote builds in B72806: Diff 177217.Tue, May 5, 4:32 AM
sjg updated this revision to Diff 177218.Tue, May 5, 5:59 AM

Add quotes around result if we see _ followed by space.

Harbormaster completed remote builds in B72807: Diff 177218.Tue, May 5, 5:59 AM
sjg updated this revision to Diff 177219.Tue, May 5, 6:01 AM

Fix comment to match the expected result.

Harbormaster completed remote builds in B72808: Diff 177219.Tue, May 5, 6:01 AM
sjg updated this revision to Diff 177264.Tue, May 5, 6:15 PM

delete lines containing backtics or $()

Harbormaster completed remote builds in B72832: Diff 177264.Tue, May 5, 6:15 PM
stevek accepted this revision.Mon, May 18, 4:31 PM

LGTM

This revision is now accepted and ready to land.Mon, May 18, 4:31 PM
Closed by commit rG701d7be6e4a9: Add test cases for safe_eval.sh (authored by sjg). · Explain WhyMon, May 18, 5:52 PM
This revision was automatically updated to reflect the committed changes.
sjg added a commit: rG701d7be6e4a9: Add test cases for safe_eval.sh.

Revision Contents
Changeset List

PathSize
libexec/
rc/
7 lines
tests/
8 lines
65 lines

Diff 178025

View Options

libexec/rc/safe_eval.sh

Loading...
View Options

libexec/rc/tests/Makefile

Loading...
View Options

libexec/rc/tests/safe_eval_test.sh

Loading...