Page MenuHomeFreeBSD
Differential D56795

Add test cases for safe_eval.sh
ClosedPublic
Actions

Authored by sjg on May 4 2026, 6:33 PM.
Tags
None
Referenced Files
F175656499: D56795.diff
Mon, Oct 12, 7:57 AM
F175571153: D56795.id178025.diff
Sun, Oct 11, 6:55 PM
F175570987: D56795.id177217.diff
Sun, Oct 11, 6:54 PM
F175570894: D56795.id177218.diff
Sun, Oct 11, 6:53 PM
F175570832: D56795.id177219.diff
Sun, Oct 11, 6:53 PM
F175570813: D56795.id177264.diff
Sun, Oct 11, 6:53 PM
F175569240: D56795.diff
Sun, Oct 11, 6:41 PM
Unknown Object (File)
Thu, Oct 8, 3:22 PM
View All Files
Subscribers
None

Details

Reviewers
des
imp
stevek
Commits
rG701d7be6e4a9: Add test cases for safe_eval.sh
Summary

safe_set is the routine that does all the work.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 72832
Build 69715: arc lint + arc unit

Event Timeline

sjg requested review of this revision.May 4 2026, 6:33 PM
sjg created this revision.
Harbormaster completed remote builds in B72780: Diff 177183.May 4 2026, 6:33 PM
sjg updated this revision to Diff 177217.May 5 2026, 4:32 AM

Add $() example

Harbormaster completed remote builds in B72806: Diff 177217.May 5 2026, 4:32 AM
sjg updated this revision to Diff 177218.May 5 2026, 5:59 AM

Add quotes around result if we see _ followed by space.

Harbormaster completed remote builds in B72807: Diff 177218.May 5 2026, 5:59 AM
sjg updated this revision to Diff 177219.May 5 2026, 6:01 AM

Fix comment to match the expected result.

Harbormaster completed remote builds in B72808: Diff 177219.May 5 2026, 6:01 AM
sjg updated this revision to Diff 177264.May 5 2026, 6:15 PM

delete lines containing backtics or $()

Harbormaster completed remote builds in B72832: Diff 177264.May 5 2026, 6:15 PM
stevek accepted this revision.May 18 2026, 4:31 PM

LGTM

This revision is now accepted and ready to land.May 18 2026, 4:31 PM
Closed by commit rG701d7be6e4a9: Add test cases for safe_eval.sh (authored by sjg). · Explain WhyMay 18 2026, 5:52 PM
This revision was automatically updated to reflect the committed changes.
sjg added a commit: rG701d7be6e4a9: Add test cases for safe_eval.sh.

Revision Contents
Changeset List

PathSize
libexec/
rc/
7 lines
tests/
8 lines
65 lines

Diff 177264

View Options

libexec/rc/safe_eval.sh

Loading...
View Options

libexec/rc/tests/Makefile

Loading...
View Options

libexec/rc/tests/safe_eval_test.sh

Loading...